Download
(33 Kb)
Download
Updated: 10/21/23 06:34 AM
Pictures
File Info
Compatibility:
Endless Archive (9.2.5)
base-game patch (9.1.5)
Necrom (9.0.0)
Scribes of Fate (8.3.5)
Firesong (8.2.5)
Lost Depths (8.1.5)
High Isle (8.0.0)
Updated:10/21/23 06:34 AM
Created:05/11/15 01:10 PM
Monthly downloads:8,741
Total downloads:829,476
Favorites:520
MD5:
Categories:Combat Mods, Bags, Bank, Inventory, Casting Bars, Cooldowns, PvP
Auto Recharge (and repair)  Popular! (More than 5000 hits)
Version: 2.77
by: XanDDemoX, Baertram
Auto Recharge
Needed dependencies: LibAddonMenu-2.0

Recharges and repairs your equipped weapons and amour automatically upon entering and leaving combat.

A single soul gem will be consumed per weapon recharged in the order of worst to best (e.g lesser soul gems will be used before common).

A single repair kit will be consumed per piece of armour recharged in the order of worst to best (e.g common repair kits will be used before greater). A single crown repair kit will be used to repair all of your equipped armor.

Features
-Recharge weapons if the charge drops below a threshold (at combat start, in combat, and after combat, optionally: As weapon pair changes)
-Repair equipment if they drop below a threshold (at combat start, in combat, and after combat, optionally: No crown repair kits will be used)
-Remind me after login/as fight ends if my soul gems drop below a threshold
-Remind me after login/as fight ends if my repair kits drop below a threshold
-Show my number of repair kits left at a vendor
-Show info about what happened in the chat
-Suppress chat messages if nothing was done etc.
-Multi language support was added

Usage
You are able to setup everything in the LAM settings menu.

Automatic Charging
/arc Attempts to recharge the currently equipped primary and secondary weapons.
/arc + Enable automatic equipped weapons recharging (you can also use the localized value on, an, на).
/arc - Disable automatic equipped weapons recharging (you can also use the localized value off, aus, от).
/arc 0-99 Set the minimum charge percentage

Automatic Repair
/arp Attempts to repair the currently equipped armour.
/arp + Enable automatic amour repairing (you can also use the localized value on, an, на).
/arp - Disable automatic armour repairing (you can also use the localized value off, aus, от).
/arp 0-99 Set the minimum condition percentage


Languages supported
DE
EN
FR
IT - L'addon è perfettamente compatibile con la traduzione italiana degli Italian Scrolls Online. Disponibile qui ItalianScrollsOnline
RU

Many thanks to XanDDemoX for the base of this great helper!
And many thanks to Scootworks for helping me test and translate the addon!
IMPORTANT: With version 2.67: The SavedVariables changed to server dependent ones.
You need to setup your SavedVariables new! LOGOUT and BACKUP your SavedVariables before updating from version 2.66


Version 2.77 - 2023-10-21
-Finally fixed center screen messages for soulgems and repair kits missing/near empty:
--Added new settings to "Only alert on login/reloadui/zone change (with loading screen) for repair kits soon empty, and soulgems soon empty
--Added new settings to "Only alert at vendor" for repair kits soon empty
-Rearranged the other settings about repair kits and soul gems to properly be "in relating blocks" (empty warning vs. soon empty warning)


Version 2.76 - 2023-07-10
-Added settings (settings menu added) to "Prefer crown soul gems" and "Prefer crown repai kits"
-Working on fix for "Only 1 item equipped -> does not get repaired". Caused by always checking the "head" item's "is slotted" and not the correct actual slot e.g. legs
-Fixed center screen messages for soulgems and repair kits missing/near empty

Version 2.75 - 2022-12-05
Fixed default settings variables not loading in some situations, which lead to errors with the minPercent sliders

Version 2.74 - 2022-10-30
-Updated API and version
-Fixed account wide settigs not loading/saving it's data properly (was still saved per character sometimes)

Version 2.73 - 2022-08-21
-Re-uploaded correct version where the settings menu does not throw an error upon changing percentage sliders

Version 2.72 - 2022-08-13
-Updated API
-Added upon request: setting to show the repair kits empty reminder as you interact with a vendor
-Fixed: More "are we dead" checks to overcome ZOs API which does not recognize we are dead fast enough. This hopefully should fix the disconnects
Many thanks to Busygeezus for all the feedback and testing!
-Fixed: Delayed charge/repair should work properly now, allthough a delay of 0 should be working fine


Version 2.71 - 2022-02-01
-Updated API
-Added more "IsPlayerDeath" checks
-Added more "IsCrownRepairKit" checks
-Fixed typo in en.lua, thanks to all mentioning it

Version 2.70
Added Italian translations, thanks to Dusty82
L'addon è perfettamente compatibile con la traduzione italiana degli Italian Scrolls Online.
Disponibile qui https://www.esoui.com/downloads/info2854-ItalianScrollsOnline-TraduzioneItaliana.html

Version 2.69
-Updated API version
-Updated French translation (thanks to @jakez31)

Version 2.68
-Fixed LAM settings checkbox for account wide settings to be saved server dependent
-> Please check your settings after updating to version 2.68 as this checkbox might be disabled!
-Fixed Cannot create LAM ... error message
-Fixed "this item is fully repaired" multiple messages


Version 2.67
-Tested on Markarth & Stonethorn
-Updated API and files
-Updated Russian translation (thanks to ivann339)
-Added speed up variables for settings
-Fixed slash commands and keybindings trying to access the non-loaded settings
-Fixed in combat repair/recharge
-Fixed event filters for recharge and repair not overwriting each other
-Added setting for "No crown store repair kits"
-Fixed: Crown store repair kits usage on 1 equipped item (will repair all then) instead of trying to use it as normal repair kit + checking other equipped items afterwards unnecessarily
-Fixed non-slotted items (2hd backup slot e.g.) -> No repair start anymore
-Fixed settings
-Added event filter on BAG_WORN for charge and repair checks
-Added setting to check weapon charge on weapon pair change + setting for only in combat

Version 2.66
-Updated API to Stonethorn
-Updated needed versions of dependencies
-Updated French translations (thanks to jakez31)

Version 2.65
-Removed LibStub hybrid call
-Added LibAddonMenu-2.0 Verison 28 or newer as dependency
-Fixed typo in event filter for charge change -> In combat charging did not work due to this

Version 2.64
-Removed additional debug messages

Version 2.63
-Updated API
-Removed debug messages

Version 2.62
-Updated API
-Added option: Recharge weapon during combat
-Added option: Repair armor during combat

Version 2.61
-Fixed chat commands /arc on and /arc off
-Fixed chat commands /arp on and /arp off
-Added the values an/aus and на/от to support German and Russian languages for the chat commands

Version 2.60
Removed: The needed libraries were removed from this addon and need to be installed seperately as standalone version: LibAddonMenu-2.0
Added: Chat output will not be shown anymore for empty soulgem/repair kits messages if you got 0 soulgems/repair kits and the setting to suppress the "nothing repaired/charged" is enabled.


Version 2.54
Fixed: The repair kits left icon was shown too far to the right when using the quickslot vendor from the crown store.
Updated: libAddonMenu r25
Updated: API

Version 2.51
Added single keybinds for "Repair" and "Recharge"

Version 2.41
Fixed typo

Version 2.4
-Api raise to Homestead
-Updated library LAM

Version 2.3
- Fixed lua error message
Version 2.2
- Added setting to switch to account wide settings (Thanks to Scootworks!)
- Added setting to show icon + repair kits left amount at a vendor's top-left corner
- Fixed bug where soul gems / repair kits amount was calculated false (always the total available sum was used
for single stacks of items, even if they were the same item like another stack)

Version 2.1
- New addon co-author: Baertram
- Updated Api version
- Updated libraries
- Added multi language support
- Added new settings (chat output, reminders for low repair kits/soul gems)
- Fixed some bugs
- Improved code where possible

Version 2.0.5

- Updated Api version to 100012

Version 2.0.4

- Added settings menu implementation by Baertram.

Version 2.0.3

- Fixed Off Hand slots not being checked for repair.

Version 2.0.2

- Renamed Readme.txt to README to prevent ESO detecting it as an addon

Version 2.0.1

- Fixed error attempting to enable / disable using slash commands.

Version 2.0.0

- Implemented Automatic amour repair
- Fixed potentially not searching all bag slots for items.

Version 1.0.7

- Fixed missing local definition in master weapon exclusion.

Version 1.0.6

- Added check of whether the player is dead before attempting to recharge.
- Added fixed Master weapon exclusion.

Version 1.0.5

- Increased settings version

Version 1.0.4

- Restored original settings variable name

Version 1.0.3

- Moved Readme and Licence into Recharge folder within zip for users who use Minion.

Version 1.0.2

- Disabled master weapons exclusion.

Version 1.0.1

- Added master weapons exclusion.

Version 0.0.6

- Added string trim to input to remove whitespace before attempting to parse a potentially numeric input

Version 0.0.5

- Enabled setting of a minimum charge percentage.

Version 0.0.4

- Initial Release
Optional Files (0)


Archived Files (37)
File Name
Version
Size
Uploader
Date
2.76
32kB
Baertram
07/10/23 09:37 AM
2.75
31kB
Baertram
12/04/22 05:27 PM
2.74
31kB
Baertram
10/30/22 12:05 PM
2.73
30kB
Baertram
08/21/22 05:34 AM
2.72
30kB
Baertram
08/13/22 09:15 AM
2.71
26kB
Baertram
02/01/22 05:10 AM
2.70
26kB
Baertram
03/30/21 09:08 AM
2.69
23kB
Baertram
03/28/21 01:05 PM
2.68
23kB
Baertram
11/23/20 05:48 AM
2.67
23kB
Baertram
10/17/20 01:04 PM
2.66
19kB
Baertram
09/19/20 09:04 AM
2.65
17kB
Baertram
03/21/20 08:41 PM
2.64
17kB
Baertram
02/26/20 04:08 AM
2.63
17kB
Baertram
02/24/20 05:14 PM
2.62
17kB
Baertram
02/23/20 07:12 PM
2.61
16kB
Baertram
06/18/19 06:55 AM
2.60
16kB
Baertram
05/31/19 10:39 AM
2.54
59kB
Baertram
01/27/18 08:23 PM
2.51
58kB
Baertram
09/07/17 02:28 PM
2.41
56kB
Baertram
07/04/17 01:49 PM
2.4
57kB
Baertram
02/06/17 02:34 PM
2.3
54kB
Baertram
11/21/16 03:46 PM
2.2
54kB
Baertram
11/20/16 01:56 PM
2.1
52kB
Baertram
11/12/16 02:52 PM
2.0.5
42kB
XanDDemoX
09/08/15 02:08 PM
2.0.4
42kB
XanDDemoX
08/12/15 03:04 PM
2.0.3
7kB
XanDDemoX
08/11/15 01:25 PM
2.0.2
6kB
XanDDemoX
05/23/15 01:07 AM
2.0.1
6kB
XanDDemoX
05/22/15 09:58 PM
1.0.7
5kB
XanDDemoX
05/20/15 09:41 PM
1.0.6
4kB
XanDDemoX
05/20/15 09:16 PM
1.0.5
4kB
XanDDemoX
05/18/15 10:41 PM
1.0.4
4kB
XanDDemoX
05/18/15 10:00 PM
1.0.3
4kB
XanDDemoX
05/18/15 08:10 PM
1.0.2
4kB
XanDDemoX
05/18/15 04:28 PM
0.0.6
4kB
XanDDemoX
05/18/15 02:12 PM
0.0.5
3kB
XanDDemoX
05/17/15 07:36 PM


Post A Reply Comment Options
Unread 10/14/23, 05:05 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Originally Posted by Neverlands
Hello,
is it possible to show the running out of repair kits screen warning ONLY after login, reload ui or at the merchant?
I disabled the general warning notifications but I still get the on screen warning all of the time, especially when in combat.



Hi Neverlands,

I'll have a look, and I think it should be possible to add a setting for that.

Edit:
Added some settings, could you please dl and test this version:
https://github.com/Baertram/Recharge.../heads/PTS.zip
PAy attention at the extarction of the zip file, only extact the sub-sbfolder "Recharge" (and check if you need to rename it, sometimes it's name e.g. is "Recharge-PTS" so rename to "Recharge" then. In the end it must be live/AddOns/Recharge/Recharge.lua and .txt etc.)

Many thanks!
Last edited by Baertram : 10/14/23 at 05:35 AM.
Report comment to moderator  
Reply With Quote
Unread 10/14/23, 02:11 AM  
Neverlands
 
Neverlands's Avatar

Forum posts: 7
File comments: 559
Uploads: 0
Hello,
is it possible to show the running out of repair kits screen warning ONLY after login, reload ui or at the merchant?
I disabled the general warning notifications but I still get the on screen warning all of the time, especially when in combat.



Report comment to moderator  
Reply With Quote
Unread 08/02/23, 03:02 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Re: No Auto Repair on Shoulder

Originally Posted by NoOneOfImportance
I'm using Version 2.76 - 2023-07-10 and I'm not getting auto repair on the shoulder slot.
Hi, I need some more details please:
Does the same not work if you disable ALL other addons? Only Auo Recharge + dependencies enabled.
What are your settings for repair in detail, each setting?
In combat or out of combat too?
What reair kits to use?
etc.

What repair kits do you own at that time it is not reparing? Crown only or normal ones only, or mixed?
Other slots are repaired properly?
Are you playing in keyboard mode?

Could you enable the debug mode just before the repair should happen (test it somewhere) and send me the complete debug output from chat then via copy&paste?
At best use LibDebugLogger, and DebugLogViewer (in the settings of DebugLogViewer change the LibDebugLogger trace depth to "Debug" please!!!) then /reloadui.

Tehn do your fight where it should repair the shoulder and after the fight was done and nothing was repaired do a /reloadui and then go to live/SavedVariables/LibDebugLogger.lua and upload it here for me:
https://sir.insidi.at/or/logviewer/

After upload click on "Share" at the top right and send me the link please so I can have a look.
Report comment to moderator  
Reply With Quote
Unread 08/01/23, 08:18 PM  
NoOneOfImportance

Forum posts: 0
File comments: 18
Uploads: 0
No Auto Repair on Shoulder

I'm using Version 2.76 - 2023-07-10 and I'm not getting auto repair on the shoulder slot.
Report comment to moderator  
Reply With Quote
Unread 07/10/23, 09:28 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Alright, thanks for your feedback.
I'll release it to the public then.

Originally Posted by hanspeter123
i think this hotfix works

i just randomly noticed i didnt get any repair and checked my equipped gear to find out i hadn't equippd any monster set, so i did some experimenting with the "current" setup, then with ONLY the broken gear, and then with fully equipped setup
then i looked into the lua and noticed the ordered check but as i didnt have a lot of time to fix it myself i just posted here and made sure i had every slot equipped
Report comment to moderator  
Reply With Quote
Unread 07/10/23, 09:23 AM  
hanspeter123

Forum posts: 0
File comments: 6
Uploads: 0
i think this hotfix works

i just randomly noticed i didnt get any repair and checked my equipped gear to find out i hadn't equippd any monster set, so i did some experimenting with the "current" setup, then with ONLY the broken gear, and then with fully equipped setup
then i looked into the lua and noticed the ordered check but as i didnt have a lot of time to fix it myself i just posted here and made sure i had every slot equipped
Report comment to moderator  
Reply With Quote
Unread 07/07/23, 04:49 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Please try if this beta version works for you:
https://github.com/Baertram/Recharge.../heads/PTS.zip
-> Extract ONLY the Recharge folder in the Recharge-PTS folder please!

Fixed and added:
Code:
-Added settings to "Prefer crown soul gems" and "Prefer crown repai kits"
-Fix for "Only 1 item equipped -> does not get repaired". Caused by always checking the "head" item's "is slotted" and not the correct actual slot e.g. legs
-Fixed center screen messages for soulgems and repair kits missing/near empty
Report comment to moderator  
Reply With Quote
Unread 07/07/23, 04:31 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Did some further tests and added more debug messages.
Only legs are equipped:


In combat repair is off, threshold set to 99%, ver small repair kits used on cp160 items so it does repiar but does not really reapair that way

Debug log says:

Code:
2023-07-08 00:19:23.614 - I/UI - =========================================================
2023-07-08 00:19:23.614 - I/UI - [ARC]CombatStateChanged inCombat: false
2023-07-08 00:19:23.614 - I/UI - [ARC]ARC_IsPlayerDead: false, playerHealth: 24051, wasDead: false
2023-07-08 00:19:23.614 - I/UI - [ARC]ARC_IsPlayerDead: false, playerHealth: 24051, wasDead: false
2023-07-08 00:19:23.614 - I/UI - [ARC]ARC_IsPlayerDead: false, playerHealth: 24051, wasDead: false
2023-07-08 00:19:23.614 - I/UI - [ARC]ARC_IsPlayerDead: false, playerHealth: 24051, wasDead: false
2023-07-08 00:19:23.614 - I/UI - [ARC]ARC_IsPlayerDead: false, playerHealth: 24051, wasDead: false
2023-07-08 00:19:23.614 - I/UI - [Recharge]RepairEquipped - isDead: false, repairActive: false, inCombat: false, slotIndex: nil, chatOutput: true
2023-07-08 00:19:23.614 - I/UI - >> 00000000000000000000000000000
2023-07-08 00:19:23.615 - I/UI - >>Non equipped item, slot: 5(Nebenhand)
2023-07-08 00:19:23.615 - I/UI - >> 00000000000000000000000000000
2023-07-08 00:19:23.615 - I/UI - >>Non equipped item, slot: 21(Nebenhand (Reserve))
2023-07-08 00:19:23.615 - I/UI - >> 00000000000000000000000000000
2023-07-08 00:19:23.615 - I/UI - >>Non equipped item, slot: 0(Kopf)
2023-07-08 00:19:23.615 - I/UI - >> 00000000000000000000000000000
2023-07-08 00:19:23.615 - I/UI - >>Non equipped item, slot: 3(Schultern)
2023-07-08 00:19:23.615 - I/UI - >> 00000000000000000000000000000
2023-07-08 00:19:23.615 - I/UI - >>Non equipped item, slot: 2(Torso)
2023-07-08 00:19:23.615 - I/UI - >> 00000000000000000000000000000
2023-07-08 00:19:23.615 - I/UI - >>Non equipped item, slot: 6(Taille)
2023-07-08 00:19:23.615 - I/UI - >> ???????????????????????????????????????
2023-07-08 00:19:23.615 - I/UI - >>Repair check, no delay, slot: 8(Beine)-|H0:item:171988:363:50:0:0:0:0:0:0:0:0:0:0:0:1:121:0:1:0:9900:0|h|h
2023-07-08 00:19:23.615 - I/UI - [Recharge]RepairItem - slotIndex: 8
2023-07-08 00:19:23.615 - I/UI - [ARC]ARC_IsPlayerDead: false, playerHealth: 24051, wasDead: false
2023-07-08 00:19:23.615 - I/UI - [IsItemAboveConditionThreshold]|H0:item:171988:363:50:0:0:0:0:0:0:0:0:0:0:0:1:121:0:1:0:9900:0|h|h, isAbove: false, threshold: 0.99, condition: 99
2023-07-08 00:19:23.615 - I/UI - << ???????????????????????????????????????
2023-07-08 00:19:23.616 - I/UI - >> 00000000000000000000000000000
2023-07-08 00:19:23.616 - I/UI - >>Non equipped item, slot: 16(H\u00e4nde)
2023-07-08 00:19:23.616 - I/UI - >> 00000000000000000000000000000
2023-07-08 00:19:23.616 - I/UI - >>Non equipped item, slot: 9(F\u00fc\u00dfe)
2023-07-08 00:19:23.616 - I/UI - >total delay: 500
2023-07-08 00:19:23.641 - I/UI - >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
2023-07-08 00:19:23.641 - I/UI - [ARC_Durability_Changed]|H0:item:171988:363:50:0:0:0:0:0:0:0:0:0:0:0:1:121:0:1:0:9900:0|h|h
2023-07-08 00:19:23.641 - I/UI - [ARC]ARC_IsPlayerDead: false, playerHealth: 24051, wasDead: false
2023-07-08 00:19:23.641 - I/UI - <<<<noWornNoDeadNoDuringCombatCheck - allowed
2023-07-08 00:19:23.641 - I/UI - [ARC]ARC_IsPlayerDead: false, playerHealth: 24051, wasDead: false
2023-07-08 00:19:23.641 - I/UI - [Recharge]RepairEquipped - isDead: false, repairActive: true, inCombat: true, slotIndex: 8, chatOutput: true
2023-07-08 00:19:23.641 - I/UI - <<ABORT - Repair run is active
2023-07-08 00:19:23.641 - I/UI - <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
2023-07-08 00:19:24.150 - I/UI - >>0000000000 Delayed chatOutput 0000000000000
2023-07-08 00:19:24.150 - I/UI - <<0000000000 Delayed chatOutput 0000000000000
2023-07-08 00:19:24.158 - I/UI - >>delayed call 3 - repair kits left output
2023-07-08 00:19:24.158 - I/UI - [ARC_checkThresholdOrEmpty]checkType: repairKits, emptyOrThreshold: false, amount: 16
2023-07-08 00:19:24.158 - I/UI - >threshold repair kits: 5
2023-07-08 00:19:24.174 - I/UI - >>delayed call 4 - reset the repair prevention variable
ESO Debug Log link: https://sir.insidi.at/or/logviewer/Ee7LWu
Log, Range filter -> UI reload 00:09:35




The function IsItemAboveConditionThreshold is checking the slot 8 here (legs) and somehow the API function:
local _, slotHasItem = GetEquippedItemInfo(BAG_WORN, 8)
returns false as 2nd param slotHasItem and thus the further checks are aborted then!

I'll have a look.

Edit2:
If you equip ALL items the function returns correct values:


I found out what is wrong and will fix it. I always checked the head item and not the actual slot!

btw: Why do you only wear 1 item?
Last edited by Baertram : 07/07/23 at 04:47 PM.
Report comment to moderator  
Reply With Quote
Unread 07/07/23, 01:31 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Okay, thanks for the details.
Yes it's checking in a loop from 0 head to max equipId but baiscally it should not stop if any is not equipped.
I'll have a look how this is happending as I find the time, maybe Sunday.

Edit:
Had a brief look and I'm using
for _, slot in ipairs(_repairSlots) do
if HasItemInSlot(BAG_WORN, slot) then
--repair checks
end
end

So it SHOULD check each of the slots in _repairSlots properly.
-> It just does NOT output debug messages if HasItemInSlot was not true!

Are you sure it actually is NOT checking for repair or is this just a "guess" because of the debug messages?
If so you can edit file AutoRecharge.lua at lines 447 (end of the if HasItemInSlot(BAG_WORN, slot) then)
and add before that end:

Code:
else
  if isDebugEnabled then d(">> 00000000000000000000000000000")
	d(">>Non equipped item, slot: " ..tostring(slot)) 
  end
 
end ---old line 447's end, if HasItemInSlot(BAG_WORN, slot) then
As you said the breeches were not repaired I need to find time to check it with 0%
-> What is your threshold to repair items set to? 0%?
It looks like it starts the RepairItem function, then checks the item condition and then aborts as condition is still high enough.

Or it does not find your repair kits?
Did you enable "Do not use crown repair kits" and only got crown repair kits left?
Or did you enable to use level appropriate repair kits and got none?

Originally Posted by hanspeter123
Originally Posted by Baertram
Originally Posted by hanspeter123
i've noticed this addon won't repair if not every armor piece is equipped

see debug output:
Hi, okay. Some more info please then:
Which equipment slots were equipped and which were not equipped as thas happened, as the debug log does only show me it was trying to repair your breeches, and nothing else
i had nothing equipped except the breeches and the addon was unable to automatically repair them.

this behaviour is not limited to leg armor tho, the same happened with following combinations:
-only feet equipped and nothing else
-only feet and legs, nothing else, both 0%
-all armor pieces equipped except head and shoulders, some 0% some around 50%

as i understood the addon checks in order and maybe if a "previous" item is missing the repair won't work (so basically if head piece is missing the repair will fail all the time, if head is equipped and broken but other pieces are missing, it might still repair, someone would have to test it or analyze the code more in-depth)

it's pretty easy to recreate actually, you can get to a wayshrine with a ledge and jump to your death repeatedly until some armor pieces are broken and check if it will auto-repair
Last edited by Baertram : 07/07/23 at 12:43 PM.
Report comment to moderator  
Reply With Quote
Unread 07/07/23, 12:09 AM  
hanspeter123

Forum posts: 0
File comments: 6
Uploads: 0
Originally Posted by Baertram
Originally Posted by hanspeter123
i've noticed this addon won't repair if not every armor piece is equipped

see debug output:
Hi, okay. Some more info please then:
Which equipment slots were equipped and which were not equipped as thas happened, as the debug log does only show me it was trying to repair your breeches, and nothing else
i had nothing equipped except the breeches and the addon was unable to automatically repair them.

this behaviour is not limited to leg armor tho, the same happened with following combinations:
-only feet equipped and nothing else
-only feet and legs, nothing else, both 0%
-all armor pieces equipped except head and shoulders, some 0% some around 50%

as i understood the addon checks in order and maybe if a "previous" item is missing the repair won't work (so basically if head piece is missing the repair will fail all the time, if head is equipped and broken but other pieces are missing, it might still repair, someone would have to test it or analyze the code more in-depth)

it's pretty easy to recreate actually, you can get to a wayshrine with a ledge and jump to your death repeatedly until some armor pieces are broken and check if it will auto-repair
Report comment to moderator  
Reply With Quote
Unread 07/06/23, 05:58 AM  
NullunVoyd

Forum posts: 0
File comments: 10
Uploads: 0
Re: 2 improvements

Thank you for this bit-o-code. Solved a nagging issue for me.

Originally Posted by 2eCBqy3YdX6c
I found myself wanting this add-on to use up the crown versions before the non-crown versions of soul gems and repair kits. (i.e. Crown Repair Kits before Grand Repair Kits and Crown Soul Gems before Soul Gems)

I discovered that Crown Soul Gems have a tier value of 0 while Soul Gems have a tier value of 1. This means the official version will use up Crown Soul Gems before Soul Gems but will use up Grand Repair Kits before Crown Repair Kits.

The patch below does two things (and achieves my goal):
- Documents the Soul Gem tiers
- Reverses the sort order of Repair Kits

Maybe this will be useful to someone else...

Code:
diff --git a/Bag.lua b/Bag.lua
index dbace06..3f6fa1f 100644
--- a/Bag.lua
+++ b/Bag.lua
@@ -21,6 +21,9 @@ local function getItemStackSize(bagId, slotIndex)
 end

 local function GetSoulGems(bagId)
+       --Soul gem tiers
+       --0 = Crown soul gem
+       --1 = Soul gem
        local tbl = GetBagItems(bagId,function(i)
                if IsItemSoulGem(SOUL_GEM_TYPE_FILLED,bagId,i) == true then
                        return {
@@ -33,6 +36,7 @@ local function GetSoulGems(bagId)
        end)

        table.sort(tbl,function(x,y)
+               -- use up crown before regular
                return x.tier > y.tier
        end)

@@ -67,7 +71,8 @@ local function GetRepairKits(bagId)
        end)

        table.sort(tbl,function(x,y)
-               return x.tier > y.tier
+               -- use up crown before grand
+               return x.tier < y.tier
        end)

        return tbl
Report comment to moderator  
Reply With Quote
Unread 07/06/23, 04:51 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Originally Posted by hanspeter123
i've noticed this addon won't repair if not every armor piece is equipped

see debug output:
Hi, okay. Some more info please then:
Which equipment slots were equipped and which were not equipped as thas happened, as the debug log does only show me it was trying to repair your breeches, and nothing else
Last edited by Baertram : 07/06/23 at 04:51 AM.
Report comment to moderator  
Reply With Quote
Unread 07/05/23, 10:03 PM  
hanspeter123

Forum posts: 0
File comments: 6
Uploads: 0
i've noticed this addon won't repair if not every armor piece is equipped

see debug output:
Report comment to moderator  
Reply With Quote
Unread 01/16/23, 06:17 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4913
File comments: 5990
Uploads: 78
Re: 2 improvements

Tahnks for the patch and the info!
But isn't there a "use crown items" settings entry already which sets the addon to do so (or similar).
I need to check that again as I'm not the original addon developer.

Originally Posted by 2eCBqy3YdX6c
I found myself wanting this add-on to use up the crown versions before the non-crown versions of soul gems and repair kits. (i.e. Crown Repair Kits before Grand Repair Kits and Crown Soul Gems before Soul Gems)

I discovered that Crown Soul Gems have a tier value of 0 while Soul Gems have a tier value of 1. This means the official version will use up Crown Soul Gems before Soul Gems but will use up Grand Repair Kits before Crown Repair Kits.

The patch below does two things (and achieves my goal):
- Documents the Soul Gem tiers
- Reverses the sort order of Repair Kits

Maybe this will be useful to someone else...

Code:
diff --git a/Bag.lua b/Bag.lua
index dbace06..3f6fa1f 100644
--- a/Bag.lua
+++ b/Bag.lua
@@ -21,6 +21,9 @@ local function getItemStackSize(bagId, slotIndex)
 end

 local function GetSoulGems(bagId)
+       --Soul gem tiers
+       --0 = Crown soul gem
+       --1 = Soul gem
        local tbl = GetBagItems(bagId,function(i)
                if IsItemSoulGem(SOUL_GEM_TYPE_FILLED,bagId,i) == true then
                        return {
@@ -33,6 +36,7 @@ local function GetSoulGems(bagId)
        end)

        table.sort(tbl,function(x,y)
+               -- use up crown before regular
                return x.tier > y.tier
        end)

@@ -67,7 +71,8 @@ local function GetRepairKits(bagId)
        end)

        table.sort(tbl,function(x,y)
-               return x.tier > y.tier
+               -- use up crown before grand
+               return x.tier < y.tier
        end)

        return tbl
Report comment to moderator  
Reply With Quote
Unread 01/15/23, 04:56 PM  
2eCBqy3YdX6c

Forum posts: 0
File comments: 13
Uploads: 0
2 improvements

I found myself wanting this add-on to use up the crown versions before the non-crown versions of soul gems and repair kits. (i.e. Crown Repair Kits before Grand Repair Kits and Crown Soul Gems before Soul Gems)

I discovered that Crown Soul Gems have a tier value of 0 while Soul Gems have a tier value of 1. This means the official version will use up Crown Soul Gems before Soul Gems but will use up Grand Repair Kits before Crown Repair Kits.

The patch below does two things (and achieves my goal):
- Documents the Soul Gem tiers
- Reverses the sort order of Repair Kits

Maybe this will be useful to someone else...

Code:
diff --git a/Bag.lua b/Bag.lua
index dbace06..3f6fa1f 100644
--- a/Bag.lua
+++ b/Bag.lua
@@ -21,6 +21,9 @@ local function getItemStackSize(bagId, slotIndex)
 end

 local function GetSoulGems(bagId)
+       --Soul gem tiers
+       --0 = Crown soul gem
+       --1 = Soul gem
        local tbl = GetBagItems(bagId,function(i)
                if IsItemSoulGem(SOUL_GEM_TYPE_FILLED,bagId,i) == true then
                        return {
@@ -33,6 +36,7 @@ local function GetSoulGems(bagId)
        end)

        table.sort(tbl,function(x,y)
+               -- use up crown before regular
                return x.tier > y.tier
        end)

@@ -67,7 +71,8 @@ local function GetRepairKits(bagId)
        end)

        table.sort(tbl,function(x,y)
-               return x.tier > y.tier
+               -- use up crown before grand
+               return x.tier < y.tier
        end)

        return tbl
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.