ZAM's Minion, currently in open beta, is a new AddOn manager optimized for use with ESO. Install, update & manage AddOns... Learn more!
Download
(106 Kb)
Download
Updated: 11/28/14 01:00 PM
Pictures
File Info
Compatibility:
Update 5 (1.5.2)
Updated:11/28/14 01:00 PM
Created:04/06/14 04:35 PM
Downloads:414,289
Favorites:836
MD5:
1.5.2
Lootdrop, Continued (All in One)  Popular! (More than 5000 hits)
Version: 2.0.1
by: Flagrick, Pawkette
[Update] Flagrick has stepped up and volunteered to take over maintaining LootDrop. Thanks Flagrick!

[Please note] Pawkette has discontinued working on her addons. She has graciously allowed them to be put back up on the site with the MIT license. We are actively working on figuring out if we can maintain them ourselves, or if someone else would like to take them over. Sorry for the confusion created by it disappearing and then reappearing. ~ Cairenn

------------------------------------------------------------------

Personally, I think LootDrop is a very useful addon for TESO, and thank Pawkette for all she has done on this addon.

This version is based on the 1.5.4 original one.

Purpose

when you check the auto-loot option in Teso menu, drops go directly into your bag. But you do not know what you looted. Lootdrop graphically displays this informations (icon, quantity, rarity and text) on the screen by stacking it in a specific and transparent window (when it is locked).

Modifications
  • Added veteran XP support from Fyrakin.
  • The lootDrop frame is now movable (menu -> lock/unlock). Then the Frame is visible. Move it at the desired place, and lock it. Then the frame becomes transparent.
  • You can choose Xp icon style from menu (older one by default, Pawkette style or Rushmik style)
  • The quantity appears before the name, not after.
  • Rarity color on border of the LootDrop frame is now configurable in menu (on/off)
  • Loots could be stack up (default) or stack down
  • Show craft xp
  • Show guild reputation points (fighter, mage and undaunted/other Xp)
  • Show Library book Xp
  • Key binding for Autoloot on/off and lootdrop frame lock/unlock
  • Show detailed loot in chat if debug log is checked
  • Show items looted from mail

Bugs
please use the portal tool : Bugs
Addon version, Menu configuration and Screenshots are appreciated (You can use Imgur to host your images)

New Features
please use the portal tool : New features

Note
I'm not really Lua programmer or designer for TESO addon, I do my best.
I do it for myself and you are free to use it.

Teso addon
  • 2.0.1:
    • more options for Loot frames (Text, inventory stack, style, mail)
    • Font size settings added in Dimension and style settings
    • Bug Fix : attempt to correct Xp gain when you have reached max veteran rank with more than max Xp (ie 1 000 000).
  • 1.10.1:
    • more options for Debug log
    • Style info in Debug Log for all items that have one (if option is enabled)
  • 1.9.10a:
    • Debug info from mail Loot removed
  • 1.9.10:
    • Loot from Mail is optional (could be enabled only if Loot option is enabled)
    • Loot from Mail : workaround to avoid crash (not sure it works : never reproduce it)
  • 1.9.9:
    • Debug log Fix: no more 'rh' between icon and skill xp value
    • Quest item loot Fix : the '?' icon was back, Now, I hope he is returned home
    • Added loot from mail
    • Debug Log section has been created and moved at the end of settings menu
    • debug log time info is now optional
  • 1.9.8:
  • 1.9.7:
    • Debug log : added item number you have in inventory after loot
    • Teso addon API version compliance (100008 --> 100009)
  • 1.9.6:
    • Bug : Sometimes, instead of quest item tools, the addon showing the last item Drop in inventory
  • 1.9.5:
    • Fixed Guild reputation Xp (Fighter, Mage and Undaunted/other). In english and German, all Xp was for Undaunted (since teso 1.3.3 ? no report before ;-) )
  • 1.9.4:
  • 1.9.3:
  • 1.9.2:
    • Craft Library book Xp : now it take the good format of Library book Xp (number and skillname).
    • Craft Library book Xp : is no more visible if Library book Xp is disabled even if craft xp is activated.
    • Updated to LibAddonMenu-2.0 r10
  • 1.9.1.a:
    • removed the debug info that remained (GuildType)
  • 1.9.1:
    • Craft Xp : Could be stacked or not. Changes craft text name to Craft icon. Added current % reached.
    • Guild reputation Xp : New ! (fighter, mage and undaunted/other Xp). Could be stacked or not. Added icons, reputation points and current % reached.
    • Library book Xp : New ! Added skill points and SkillName. Could not be stacked.
    • Updated to LibAddonMenu-2.0 r9
  • 1.8.9:
    • Thousand separator is dependant of your client langage
  • 1.8.8:
    • Menu: extended info on XP and gold are now optional
    • Bug : fixed an error with accumulated numbers, thx to Garkin
  • 1.8.7a:
    • Bug: fixed an error on formatted string for loot items
  • 1.8.7:
    • Bug: fixed "EXP and Money gains don't seem to accumulate correctly".
    • Added thousand separator (1000000 => 1 000 000)
    • Look of XP/money gains: added little modifications
  • 1.8.6:
    • Modifications to show icon and color from quest's rewards
    • Quest's itemtools icons could not be shown since 1.2.3 teso patch (need text from itemlinks). So i have added a new icon for this items.
    • Updated to LibAddonMenu-2.0 r8
    • money: show income and total. format: x -> y
    • Xp: show xp in number, in percent of the current level, , and percent reached of the level; format: x ( a.b% -> y%)
  • 1.8.5 beta 2:
    • Add Zenimax manifest in lootdrop.txt
    • fixed a bug when itemlinks contains no text, may have other bugs since i can test it :(
  • 1.8.5 beta :
    • Quick patch to make LootDrop works, but some features could not work perfectly. Can't test it now.
    • Thx to Garkin for his help.
    • Teso addon API version compliance (100004 --> 100007)
  • 1.8.4 :
  • 1.8.3 :
    • Updated to LibAddonMenu-2.0 r6
  • 1.8.2 :
    • Added key binding for Autoloot on/off and lootdrop frame lock/unlock
  • 1.8.1 :
    • Loot animation : improvement.
  • 1.8.0 :
    • Alliance points could be stacked or not
    • Loot animation: if staked up, the loots come from the top. Otherwise, they come from the bottom.
  • 1.7.6 :
    • show gold spent (feature re-added - lost since 1.7.1)
  • 1.7.5 :
    • Show craft xp
  • 1.7.4 :
    • Teso addon API version compliance (100003 --> 100004)
  • 1.7.3 :
  • 1.7.2 :
    • Enhancement for icon items of Quests
    • Debug log added to my personal needs (you can use it, but i will do nothing on it, except for my debug ;-) )
  • 1.7.1 :
    • Most of icons of Quest Items should be shown. (always "?" icon if it's not in the quest part of the bag)
    • New Rushmik style added (more info there). (i had to reset savevars for that - the frame should be at the bottom right of the screen. Sorry for the inconvenience)
    • added an option to set junk items in the junk part of the inventory bag
  • 1.6.1 :
    • LootDrop main frame autofit to drop item frame size (could help to find the right position on global UI)
    • More friendly user for lock and move LootDrop main frame (no more 2nd menu)
    • Autosave LootDrop main frame position after move
    • Xp Icons are a bit more coloured for AP and BT points
  • 1.6.0.a : Bug Fix for crash on Xp update (Only Veteran ?). Can't test it. Wait for Feedbacks and/or screenshots.
  • 1.6.0 :
    • mod - Add a new little movable frame menu to lock/unlock LootDrop to prevent TESO menu interaction
    • mod - Xp Veteran points will be tracked in a different way as before (using EVENT_VETERAN_POINTS_UPDATE). I'm not veteran so it could not work. Please, i'm awaiting feedback.
    • bug - Xp. When level up, LootDrop didn't show the exact amount of Xp received
    • bug - Blank loot notifications. Expecting to have fixed it. Awaiting Feedback
  • 1.5.9 : Loots could be stack up (default) or stack down. Correction Ap icon glitch in Pawkette style
  • 1.5.8 : configuration of rarity color on border of the LootDrop frame, icon xp dds in separate files (prevent glitch icon if switching in live)
  • 1.5.7 : Correction : LootDrop Frame overlays the inventory/store windows.
  • 1.5.6 : initial release from Flagrick : Movable LootDrop frame, icon style for Xp from menu
Archived Files (38)
File Name
Version
Size
Author
Date
1.10.1
106kB
Flagrick
11/22/14 04:35 AM
1.9.10a
105kB
Flagrick
11/16/14 08:59 AM
1.9.10
105kB
Flagrick
11/16/14 07:53 AM
1.9.9
105kB
Flagrick
11/12/14 09:07 AM
1.9.8
104kB
Flagrick
11/05/14 06:16 AM
1.9.7
104kB
Flagrick
09/17/14 04:15 AM
1.9.6
103kB
Flagrick
09/07/14 07:08 AM
1.9.5
105kB
Flagrick
08/09/14 03:53 AM
1.9.4
114kB
Flagrick
08/05/14 12:15 PM
1.9.3
114kB
Flagrick
07/21/14 01:37 PM
1.9.2
113kB
Flagrick
07/17/14 11:19 AM
1.9.1.a
113kB
Flagrick
07/09/14 07:17 AM
1.9.1
113kB
Flagrick
07/09/14 04:43 AM
1.8.9
101kB
Flagrick
07/02/14 01:07 PM
1.8.8
101kB
Flagrick
07/01/14 02:10 PM
1.8.7a
101kB
Flagrick
07/01/14 02:07 AM
1.8.7
101kB
Flagrick
06/30/14 04:39 PM
1.8.6
101kB
Flagrick
06/29/14 12:59 PM
1.8.5 beta 2
101kB
Flagrick
06/25/14 10:25 AM
1.8.5 beta
101kB
Flagrick
06/25/14 09:29 AM
1.8.4
101kB
Flagrick
06/22/14 07:25 AM
1.8.3
100kB
Flagrick
06/15/14 03:37 AM
1.8.2
83kB
Flagrick
06/08/14 10:01 AM
1.8.1
82kB
Flagrick
06/03/14 11:14 AM
1.8.0
82kB
Flagrick
06/01/14 10:45 AM
1.7.6
81kB
Flagrick
05/31/14 09:50 AM
1.7.5
81kB
Flagrick
05/29/14 08:15 AM
1.7.4
74kB
Flagrick
05/24/14 03:12 AM
1.7.3
74kB
Flagrick
05/19/14 12:44 PM
1.7.2
111kB
Flagrick
05/17/14 07:41 AM
1.7.1
73kB
Flagrick
05/10/14 08:09 AM
1.6.1
45kB
Flagrick
04/30/14 02:38 PM
1.6.0.a
46kB
Flagrick
04/25/14 02:45 AM
1.6.0
45kB
Flagrick
04/24/14 01:53 PM
1.5.9
45kB
Flagrick
04/17/14 02:38 PM
1.5.8
44kB
Flagrick
04/16/14 03:26 AM
1.5.4
37kB
Flagrick
04/06/14 05:03 PM
1.5.0
36kB
Cairenn
04/06/14 04:41 PM


Post A Reply Comment Options
Unread 12/04/14, 10:25 AM  
QuadroTony
 
QuadroTony's Avatar

Forum posts: 175
File comments: 1068
Uploads: 0
great! i like new style option
one question, not really related to the addon

how i can calculate all inspiration points i need for 12,32,40 and 50 lvl of the craft branch?
mby some1 know?
QuadroTony is online now Report comment to moderator  
Reply With Quote
Unread 11/28/14, 01:33 PM  
Flagrick
 
Flagrick's Avatar
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 122
Uploads: 2
Originally Posted by QuadroTony
Originally Posted by Flagrick
Originally Posted by QuadroTony
if you not planning to make more comfortable way with loot drop rame+style
can you delete style notification for glyphs+style materials? at least it will decrease this spam in chat
i have done something to incorporate info of style in frame loot.
(mainly,
more options for frame:

, and text size options)
I'm testing it for now.


for glyph, I did not know what to do because it bothers me too.
But I wanted to be sure that you do not want it.
for style material it is sometimes usefull and perhaps i will let it as it.
ok i will w8 for your new update

for now im trying smthing like this
http://www.esoui.com/forums/showthread.php?p=13499
Done in 2.0.1
Flagrick is offline Report comment to moderator  
Reply With Quote
Unread 11/27/14, 04:06 AM  
QuadroTony
 
QuadroTony's Avatar

Forum posts: 175
File comments: 1068
Uploads: 0
Originally Posted by Flagrick
Originally Posted by QuadroTony
if you not planning to make more comfortable way with loot drop rame+style
can you delete style notification for glyphs+style materials? at least it will decrease this spam in chat
i have done something to incorporate info of style in frame loot.
(mainly,
more options for frame:

, and text size options)
I'm testing it for now.


for glyph, I did not know what to do because it bothers me too.
But I wanted to be sure that you do not want it.
for style material it is sometimes usefull and perhaps i will let it as it.
ok i will w8 for your new update

for now im trying smthing like this
http://www.esoui.com/forums/showthread.php?p=13499
QuadroTony is online now Report comment to moderator  
Reply With Quote
Unread 11/27/14, 03:46 AM  
Flagrick
 
Flagrick's Avatar
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 122
Uploads: 2
Originally Posted by Ayantir
tested, no more errors
Thx Ayantir for your feedbacks

Originally Posted by Ayantir
(nothing displayed, btw).
I do not know which is better:
Xp not see when we reached the max rank as it was in LootDrop before Teso Patch 1.5, or ever see it?

Btw, to see Vet Xp when Vet max rank is reached, I think we have to change this code
Lua Code:
  1. -------------------------------------------------------------------------------
  2. function LootDrop:OnXPVetUpdated( tag, exp, maxExp, reason )
  3.     if ( tag ~= 'player' ) then
  4.         return
  5.     end
  6.  
  7.     local xp = exp
  8. -- max vet rank could be reached and then no more level up
  9.     if (( maxExp > 0 ) and ( not (GetUnitVeteranRank(tag) > 13) )) then
  10.         xp = zo_min( exp, maxExp )
  11.     end
  12. ....

I will do an LootDrop update this evening
Last edited by Flagrick : 11/27/14 at 05:12 AM.
Flagrick is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 04:53 PM  
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view AddOns

Forum posts: 64
File comments: 102
Uploads: 7
tested, no more errors (nothing displayed, btw).
Ayantir is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 04:48 PM  
Flagrick
 
Flagrick's Avatar
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 122
Uploads: 2
ok, i think i found the solution.
Replace the complete code of these 2 functions by this and let me know if it works.

Lua Code:
  1. -------------------------------------------------------------------------------
  2. function LootDrop:OnXPUpdated( tag, exp, maxExp, reason )
  3.     if ( tag ~= 'player' ) then
  4.         return
  5.     end
  6.  
  7.     local xp = exp
  8.     if (maxExp > 0) then
  9.         xp = zo_min( exp, maxExp )
  10.     end
  11.  
  12.     --if maxExp == 0 then max standard rank is reached
  13.     if ( self.current_xp == xp ) or (maxExp == 0) then
  14.         return
  15.     end
  16.  
  17.     local gain = xp - self.current_xp
  18.  
  19.     if (exp < maxExp) then
  20.         self.current_xp = xp
  21.     else
  22.         self.current_xp= 0
  23.     end
  24.  
  25.     if ( gain <= 0 ) then
  26.         return
  27.     end
  28.  
  29.     local RealDiff=gain
  30.  
  31.     local pop = false
  32.  
  33.     local newDrop = nil
  34.     if ( self._xpId ) then
  35.         newDrop = self:Get( self._xpId )
  36.  
  37.         if ( newDrop ) then
  38.             pop = true
  39.             gain = gain + self._xpLastVal
  40.         end
  41.     end
  42.  
  43.     if ( not newDrop ) then
  44.         newDrop, self._xpId = self:Acquire()
  45.     end
  46.  
  47.     self._xpLastVal = gain
  48.  
  49.     local c = 'FFFFFF'
  50.     if (self.db.sListStyle==LootDrop_sDefPawkette) then
  51.         c = '00FF00'
  52.     end
  53.  
  54.  
  55.     newDrop:SetTimestamp( GetFrameTimeSeconds() )
  56.     newDrop:SetBackground()
  57.     newDrop:SetLabelSize( self.db.FontSize )
  58.     newDrop:SetRarity( ZO_ColorDef:New( c ), self.db.rarity )
  59.     newDrop:SetIcon( LootDrop_sXpIcon )
  60.  
  61.     if (self.db.experience == LootDrop_sListBoxExtended) then
  62.         local pcgain = 0
  63.         local pccurrent=100
  64.    
  65.         if (maxExp>0) then
  66.             pccurrent = math.floor(100*(xp/maxExp))
  67.             pcgain = (math.floor(100000 * (gain/maxExp)) / 1000)
  68.         end
  69.         local pctexts = zo_strformat( '|c736F6E(+<<1>>% -> <<2>>%)|r', pcgain, pccurrent )
  70.         newDrop:SetLabel( zo_strformat('<<1>> <<2>>', self:FormatAmount(gain), pctexts))
  71.     else
  72.         newDrop:SetLabel( self:FormatAmount(gain) )
  73.     end
  74.  
  75.     if (self.db.DbgLogXp) then
  76.         local text=zo_strformat('<<1>>  |c736F6E-> <<2>> / <<3>>|r', self:FormatAmount(RealDiff), self:FormatAmount(xp), self:FormatAmount(maxExp))
  77.         self:dbgDrop(LootDrop_sXpIcon, c, 1, text, 'Xp')
  78.     end
  79.  
  80.     if ( pop ) then
  81.         local anim = self._pop:Apply( newDrop.control )
  82.         anim:Forward()
  83.     end
  84. end
  85.  
  86. -------------------------------------------------------------------------------
  87. function LootDrop:OnXPVetUpdated( tag, exp, maxExp, reason )
  88.     if ( tag ~= 'player' ) then
  89.         return
  90.     end
  91.  
  92.     local xp = exp
  93.     if (maxExp > 0) then
  94.         xp = zo_min( exp, maxExp )
  95.     end
  96.  
  97.     if ( self.current_Vetxp == xp ) then
  98.         return
  99.     end
  100.  
  101.     local gain = xp - self.current_Vetxp
  102.  
  103.     --if max rank reached no more level up (for the moment ;-)
  104.     if (exp < maxExp) or (GetUnitVeteranRank(tag) > 13) then
  105.         self.current_Vetxp = xp
  106.     else
  107.         self.current_Vetxp= 0
  108.     end
  109.  
  110.     if ( gain <= 0 ) then
  111.         return
  112.     end
  113.  
  114.     local RealDiff=gain
  115.     local pop = false
  116.     local newDrop = nil
  117.  
  118.     if ( self._xpVetId ) then
  119.         newDrop = self:Get( self._xpVetId )
  120.  
  121.         if ( newDrop ) then
  122.             pop = true
  123.             gain = gain + self._xpVetLastVal
  124.         end
  125.     end
  126.  
  127.     if ( not newDrop ) then
  128.         newDrop, self._xpVetId = self:Acquire()
  129.     end
  130.  
  131.     self._xpVetLastVal= gain
  132.  
  133.     local c = 'FFFFFF'
  134.     if (self.db.sListStyle==LootDrop_sDefPawkette) then
  135.         c = '00FF00'
  136.     end
  137.  
  138.  
  139.     newDrop:SetTimestamp( GetFrameTimeSeconds() )
  140.     newDrop:SetBackground()
  141.     newDrop:SetLabelSize( self.db.FontSize )
  142.     newDrop:SetRarity( ZO_ColorDef:New( c ), self.db.rarity )
  143.     newDrop:SetIcon( LootDrop_sXpIcon )
  144.    
  145.     if (self.db.experience == LootDrop_sListBoxExtended) then
  146.         local pcgain = 0
  147.         local pccurrent=100
  148.    
  149.         if (maxExp>0) then
  150.             pccurrent = math.floor(100*(xp/maxExp))
  151.             pcgain = (math.floor(100000 * (gain/maxExp)) / 1000)
  152.         end
  153.         local pctexts = zo_strformat( '|c736F6E(+<<1>>% -> <<2>>%)|r', pcgain, pccurrent )
  154.  
  155.         newDrop:SetLabel( zo_strformat('<<1>> <<2>>', self:FormatAmount(gain), pctexts ) )
  156.     else
  157.         newDrop:SetLabel(self:FormatAmount(gain) )
  158.     end
  159.  
  160.     if (self.db.DbgLogXp) then
  161.         local text = zo_strformat('<<1>> |c736F6E -> <<2>> / <<3>>|r', self:FormatAmount(RealDiff), self:FormatAmount(xp), self:FormatAmount(maxExp))
  162.         self:dbgDrop(LootDrop_sXpIcon, c, 1, text, 'XpVet')
  163.     end
  164.  
  165.     if ( pop ) then
  166.         local anim = self._pop:Apply( newDrop.control )
  167.         anim:Forward()
  168.     end
  169. end
  170. -------------------------------------------------------------------------------
Flagrick is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 04:39 PM  
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view AddOns

Forum posts: 64
File comments: 102
Uploads: 7
tested last update, everything is fine for xp. vp stll problematic

BTW, for veterans, XP bar (on top side of screen) is based on VP points (in API), I think you should display VP points gained no ?
Last edited by Ayantir : 11/26/14 at 04:49 PM.
Ayantir is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 04:19 PM  
Flagrick
 
Flagrick's Avatar
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 122
Uploads: 2
Originally Posted by Ayantir
So,

With both modifs on OnXPUpdated and OnXPVetUpdated (from your both comments) : Same issue.

With only OnXPUpdated modified :

- Works well for the 1st kill, but all other kills (events) are buggy.

Please also notice that XPVet triggers only on 1 kill ( instead of 2 )

Look :



in normal rank or veteran rank, when you level up you 've got 2 xp event :
OnXPVetUpdated( tag, maxExp+diff, maxExp, reason )
and
OnXPVetUpdated( tag, diff, NewmaxExp, reason )

and that why LootDrop is bugging here, there is no level up but MaxExp is reached.

I think The bug is there :
Lua Code:
  1. if (exp < maxExp) then
  2.         self.current_Vetxp = xp
  3.     else
  4.         self.current_Vetxp= 0
  5.     end
with full Vet 14, we are always in the second case.
so then gain = xp - self.current_Vetxp, ie 1 000 000 - 0 = 1 000 000

for normal xp it should be corrected with
Lua Code:
  1. -------------------------------------------------------------------------------
  2. function LootDrop:OnXPUpdated( tag, exp, maxExp, reason )
  3.     if ( tag ~= 'player' ) then
  4.         return
  5.     end
  6.  
  7.     local xp = exp
  8.     if (maxExp > 0) then
  9.         xp = zo_min( exp, maxExp )
  10.     end
  11.  
  12.     if ( self.current_xp == xp ) then
  13.         return
  14.     end
  15.  
  16.     local gain = xp - self.current_xp
  17.  
  18.     if (exp < maxExp) or ( maxExp==0 )then
  19.         self.current_xp = xp
  20.     else
  21.         self.current_xp= 0
  22.     end
For veteran xp, i have to find how to know max level is reached, or perhaps vet Xp update is no more necessary ?
I have to test it.
Flagrick is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 02:46 PM  
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view AddOns

Forum posts: 64
File comments: 102
Uploads: 7
So,

With both modifs on OnXPUpdated and OnXPVetUpdated (from your both comments) : Same issue.

With only OnXPUpdated modified :

- Works well for the 1st kill, but all other kills (events) are buggy.

Please also notice that XPVet triggers only on 1 kill ( instead of 2 )

Look :



Last edited by Ayantir : 11/26/14 at 02:49 PM.
Ayantir is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 01:58 PM  
Flagrick
 
Flagrick's Avatar
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 122
Uploads: 2
Originally Posted by Ayantir
Also, please note that Lootdrop won't "trigger" each time I get some "points"

Here, I killled 2 mobs : 1st, Lootdrop didn't show anything, on 2nd, it showed the (false) xp gained.



PS : I reloadui twice ^^
PPS: I'm still gaining some VP and XP too..
ok, please could you activate tags on your debug log.
I think there is normal Xp update with maxExp=0 and Vet Update with maxExp=1 000 000.
should do the correction in OnXPUpdated

Lua Code:
  1. -------------------------------------------------------------------------------
  2. function LootDrop:OnXPUpdated( tag, exp, maxExp, reason )
  3.     if ( tag ~= 'player' ) then
  4.         return
  5.     end
  6.  
  7.     local xp = exp
  8.     if (maxExp > 0) then
  9.         xp = zo_min( exp, maxExp )
  10.     end
  11.  
  12.     if ( self.current_xp == xp ) then
  13.         return
  14.     end

then LootDrop should show nothing about vet Xp because you have reached the max Xp like it was in LootDrop previous version before V1.5 teso patch. Perhaps only normal Xp.

Originally Posted by Ayantir
I think if I am > maxPoints, you need to memorize how many XP i got (when addon_loads) then on each xp/vp event, make diff to know how many points I'm gaining on each event
it already works like this:
self.current_Vetxp memorize the last Vet Xp level before xp Vet udate
Last edited by Flagrick : 11/26/14 at 02:01 PM.
Flagrick is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 01:35 PM  
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view AddOns

Forum posts: 64
File comments: 102
Uploads: 7
Also, please note that Lootdrop won't "trigger" each time I get some "points"

Here, I killled 2 mobs : 1st, Lootdrop didn't show anything, on 2nd, it showed the (false) xp gained.



PS : I reloadui twice ^^
PPS: I'm still gaining some VP and XP too..

I think if I am > maxPoints, you need to memorize how many XP i got (when addon_loads) then on each xp/vp event, make diff to know how many points I'm gaining on each event
Ayantir is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 01:24 PM  
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view AddOns

Forum posts: 64
File comments: 102
Uploads: 7
Hey, you was right, I've hitted maxpoints

So, last version of lootdrop, deleted my savedvars.

First, without fix :




Then, with your fix and reloadui : (I removed lines from 1162 to 1176)

Lua Code:
  1. -------------------------------------------------------------------------------
  2. function LootDrop:OnXPVetUpdated( tag, exp, maxExp, reason )
  3.     if ( tag ~= 'player' ) then
  4.         return
  5.     end
  6.  
  7.     local xp = exp
  8.  
  9.     if (maxExp~=0) then
  10.       xp  =  zo_min( exp, maxExp )
  11.     end
  12.  
  13.     if ( self.current_Vetxp == xp ) then
  14.         return
  15.     end
  16.    
  17.     local gain = xp - self.current_Vetxp
  18.  
  19.     if (exp < maxExp) then
  20.         self.current_Vetxp = xp
  21.     else
  22.         self.current_Vetxp= 0
  23.     end
  24.  
  25.     if ( gain <= 0 ) then
  26.         return
  27.     end
  28.  
  29. .....


But your fix didn't worked : Also please note that my VP still rise (I was 1,153,172 on 1st kill, and 1,153,187 on 2nd).

Ayantir is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 12:49 PM  
Flagrick
 
Flagrick's Avatar
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 122
Uploads: 2
Originally Posted by Ayantir
I think i found something :
==> maxExp=0

Are you VR 14 with 1 000 000/1 000 000 VetXp ?
Because maxExp should be 1 000 000 and it is 0.

Ayantir could you test this code for me (in LootDrop.lua)?

Lua Code:
  1. -------------------------------------------------------------------------------
  2. function LootDrop:OnXPVetUpdated( tag, exp, maxExp, reason )
  3.     if ( tag ~= 'player' ) then
  4.         return
  5.     end
  6.  
  7.     local xp = exp
  8.     if (maxExp > 0) then
  9.         xp = zo_min( exp, maxExp )
  10.     end
  11.  
  12.     if ( self.current_Vetxp == xp ) then
  13.         return
  14.     end
Last edited by Flagrick : 11/26/14 at 01:23 PM.
Flagrick is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 12:02 PM  
Flagrick
 
Flagrick's Avatar
AddOn Author - Click to view AddOns

Forum posts: 22
File comments: 122
Uploads: 2
Originally Posted by Embolism
since they removed Vet XP (Veteran leveling now uses normal XP)
they are using veteran Xp (I have to use an event API for veteran to get Xp). In debug log, Xp is taged XpVet in this case.

Originally Posted by Ayantir
Yeah same problem here, since patch 1.5.4, 1 mob = 1 000 000 xp, same for quests, chests, everything.
(was working fine before and gaining ~ 377 / 600 xp per mob when 1.5 was released).

It's XP I think. I'm V14 since ages.
I can't reproduce it and I have done no change on this code part.
i have done tests with level 36, VR 4 and VR 14.
For VR 14, the tests was also in Deutsch, English and French.



Please first try a clean install of the last version (V1.10.1).
then if the bug is always here, could you deactivate other addons one by one and the see if you always got the bug, perhaps is there a compatibility problem.
Then, if we found nothing, as i can't reproduce it, it will be nice to Ayantir to try to debug it.

(@Ayantir)
I'm using EVENT_EXPERIENCE_UPDATE for standard ranks and EVENT_VETERAN_POINTS_UPDATE for Veteran ranks
Last edited by Flagrick : 11/26/14 at 12:27 PM.
Flagrick is offline Report comment to moderator  
Reply With Quote
Unread 11/26/14, 10:27 AM  
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view AddOns

Forum posts: 64
File comments: 102
Uploads: 7
Yeah same problem here, since patch 1.5.4, 1 mob = 1 000 000 xp, same for quests, chests, everything.
(was working fine before and gaining ~ 377 / 600 xp per mob when 1.5 was released).

It's XP I think. I'm V14 since ages.

Will do a screenshot in 5 min and edit





I get values with EVENT_EXPERIENCE_UPDATED.

I can debug more if needed..
Last edited by Ayantir : 11/26/14 at 11:25 AM.
Ayantir is offline Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: