Download
(21 Kb)
Download
Updated: 07/01/14 11:12 AM
Patch for:
ins:JunkYard.
Pictures
File Info
Compatibility:
Veteran Crypt of Hearts (1.2.3)
Updated:07/01/14 11:12 AM
Created:06/08/14 07:06 PM
Monthly downloads:20
Total downloads:3,983
Favorites:10
MD5:
insjunkyard update for ESO 1.2.3
Version: 1.01
by: YelloDello [More]
This is an update to insjunkyard (http://www.esoui.com/downloads/fileinfo.php?id=63#info):

- fixes bugs introduced by ESO 1.2.3

See the Change.log file for more info.
insJunkyard change Log
========================
v1.01 - 2014-06-30 (updated by YelloDello)
[Bugfix]
Contains fixes in response to unfriendly changes introduced by ESO 1.2.3, mainly a result of the item link format changing completely. I've attempted to remain backward compatible with old ESO 1.1.2 item link types, so you don't have to start your junklist over from scratch.
* Fixes item links displayed when typing "/junkyard list mark" so that clicking them does not cause UI errors (bug introduced by ESO 1.2.3).
* Fixes item comparisons so all items don't look the same to the add-on (bug introduced by ESO 1.2.3).

[NOTE]
There appears to be a bug where ESO uses your SavedVariables incorrectly now, putting them under "" (empty string) instead of your account name. To continue using your old settings, see http://www.esoui.com/forums/showthread.php?t=1843

v1.0a1-yd1 - 2014-06-02 (updated by YelloDello)
[Added]
* Cleanup function to remove duplicates in saved junk list, caused by old version of insjunkyard
being used with ESO 1.1.2 or later (/jy cleanup)

[Bugfix]
* Some optimizing of functions related to bugs.
* Fixed crash when selling all junk at vendor (partly caused by ESO 1.1.2 change, it seems; but also, code redundantly executing some functions 2 or 3 times).
* No more confusing/conflicting messages when moving item to junk list.
* Items from saved mark list are autojunked again (ESO 1.1.2 broke this).
* Duplicate items no longer added to saved junk list (ESO 1.1.2 broke this).
Archived Files (1)
File Name
Version
Size
Uploader
Date
1.0a1-yd1
20kB
06/08/14 07:06 PM


Post A Reply Comment Options
Unread 08/05/14, 11:06 AM  
Augmenti-DeMontia

Forum posts: 32
File comments: 213
Uploads: 0
Hoping to get an update of your work on this mod, thanks!
Report comment to moderator  
Reply With Quote
Unread 08/04/14, 04:20 PM  
logan9a

Forum posts: 3
File comments: 13
Uploads: 0
Should I be here instead of http://www.esoui.com/downloads/filei...id=63#comments ?

I am curious, is this mod still supported? (Will the download I already have on my computer get the updates or do I need to reinstall?)


If so -

Is it possible to have more than one type of 'junk'?

In other words, you want some junk to go into the junk bag. Other addons (personal assistant) can automatically sell junk when you click on any merchant.

But there is some junk you just want destroyed as soon as you pick it up. I'm thinking about the new useless armor and weapons added to trunks etc.
Report comment to moderator  
Reply With Quote
Unread 07/22/14, 08:40 AM  
QuadroTony
Banned
 
QuadroTony's Avatar
AddOn Author - Click to view AddOns

Forum posts: 828
File comments: 3866
Uploads: 3
ty for your work!

i will install this, and turn off the checkbox, will use it when you will fix major issues listed below =)
Report comment to moderator  
Reply With Quote
Unread 07/08/14, 08:21 PM  
YelloDello
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 11
Uploads: 1
Re: Re: Re: Re: CTD when using Cleanup

After further investigation, it looks like the link parsing function hasn't changed that much, but that ESO is for some reason slower/more crash-prone when dealing with large numbers of script instructions.

In one case, I have a method which used to call the link parser around 200000 times without crashing (previous to 1.2.3). But since 1.2.3, when doing around 1/40th the number of calls (5000) it now causes momentary lag or crashes.

Originally Posted by Augmenti-DeMontia
Thanks again for your work on this, hopefully there is a way to fix the link processing issue.
You're welcome! I hope so too.

Originally Posted by Augmenti-DeMontia
What's a Mark List?
The mark list refers to the user's personal list of items which are marked for autojunking.
Report comment to moderator  
Reply With Quote
Unread 07/08/14, 07:45 AM  
Augmenti-DeMontia

Forum posts: 32
File comments: 213
Uploads: 0
Re: Re: Re: CTD when using Cleanup

Originally Posted by YelloDello
Originally Posted by genadine
Tonight I attempted to clean my junk file using /jy cleanup and immediately suffered a CTD
Note: it looks like there isn't a quick fix for this.

The problem is ESO 1.2.3 again: they seem to have changed item link parsing in such a way that parsing a lot of links at once causes a crash. I will look for a workaround (perhaps a better sorting algorithm that will lessen the load) but for now, avoid using /jy cleanup. Sorry!
This sounds like the cause of my issue. When in group and showing all looted items, there is a lag created when anyone loots. The more the looted items the more the lag, i.e. everyone trying to loot a dungeon boss. It took me awhile to isolate, but now going to try just showing my own loot.


Thanks again for your work on this, hopefully there is a way to fix the link processing issue.


I strongly recommend not using a mark list, or turning off the mod altogether.
What's a Mark List?

Edited:
Last edited by Augmenti-DeMontia : 07/08/14 at 07:59 AM.
Report comment to moderator  
Reply With Quote
Unread 07/06/14, 06:17 PM  
YelloDello
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 11
Uploads: 1
Re: Re: CTD when using Cleanup

Originally Posted by genadine
Tonight I attempted to clean my junk file using /jy cleanup and immediately suffered a CTD
Note: it looks like there isn't a quick fix for this.

The problem is ESO 1.2.3 again: they seem to have changed item link parsing in such a way that parsing a lot of links at once causes a crash. I will look for a workaround (perhaps a better sorting algorithm that will lessen the load) but for now, avoid using /jy cleanup. Sorry!
Report comment to moderator  
Reply With Quote
Unread 07/06/14, 10:55 AM  
YelloDello
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 11
Uploads: 1
Re: CTD when using Cleanup

Originally Posted by genadine
Tonight I attempted to clean my junk file using /jy cleanup and immediately suffered a CTD
Thanks! Hadn't thought to retest cleanup. I'll look into it and hopefully put out a fix soon.
Report comment to moderator  
Reply With Quote
Unread 07/05/14, 01:48 PM  
genadine
Premium Member

Forum posts: 1
File comments: 10
Uploads: 0
CTD when using Cleanup

Tonight I attempted to clean my junk file using /jy cleanup and immediately suffered a CTD
Report comment to moderator  
Reply With Quote
Unread 06/30/14, 07:21 PM  
Enigma

Forum posts: 0
File comments: 65
Uploads: 0
Re: Note: 1.2.3 breaks it

Originally Posted by YelloDello
Once again, ESO changes in the latest patch (1.2.3) have broken the mod. I'm going to try to fix it. Stay tuned.

In the meantime... I strongly recommend not using a mark list, or turning off the mod altogether. I'm seeing some very wacky behaviour, including all kinds of random items ending up as junk.
Yes thank you very much.
Report comment to moderator  
Reply With Quote
Unread 06/29/14, 10:43 PM  
YelloDello
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 11
Uploads: 1
Note: 1.2.3 breaks it

Once again, ESO changes in the latest patch (1.2.3) have broken the mod. I'm going to try to fix it. Stay tuned.

In the meantime... I strongly recommend not using a mark list, or turning off the mod altogether. I'm seeing some very wacky behaviour, including all kinds of random items ending up as junk.
Report comment to moderator  
Reply With Quote
Unread 06/29/14, 10:38 PM  
YelloDello
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 11
Uploads: 1
Re: Original vs this version

Originally Posted by nasrudin
Do I need to have the original plugin installed for this to work, ie.: is it a modification or remake ?
You do not need the original plugin for this to work. This mod is standalone.
Report comment to moderator  
Reply With Quote
Unread 06/24/14, 07:19 PM  
Augmenti-DeMontia

Forum posts: 32
File comments: 213
Uploads: 0
Thanks for your work on this mod !
Report comment to moderator  
Reply With Quote
Unread 06/21/14, 12:54 PM  
nasrudin

Forum posts: 0
File comments: 1
Uploads: 0
Original vs this version

Do I need to have the original plugin installed for this to work, ie.: is it a modification or remake ?
Report comment to moderator  
Reply With Quote
Unread 06/10/14, 08:31 AM  
YelloDello
AddOn Author - Click to view AddOns

Forum posts: 8
File comments: 11
Uploads: 1
Re: Re: If still crashing

Originally Posted by Tonyleila
I don't think its a slow system problem this is my setup:
CPU: i7-4770k @ 4,2ghz
GPU: GeForce GTX 780 Ti
RAM: 32 gb
-----
I guess you PC is not better
You guess right... we have pretty much the same machine.

Originally Posted by Tonyleila
However its a problem with too many addons trying to get info from the server and then when you push too many things out of your bags it will lag and then error. Maybe this coud be solved like in Bank Manager where the progess of pushing and pulling items is slowed down and split into max 5 items a once or so.
I already do this, except even more drastically. As far as I can tell from testing, insjunkyard now does way fewer transactions than Bank Manager. The only fix along these lines that would help is if I stopped using "Sell All Junk" altogether, and programatically sold all junk a few items at a time. The problem is that it wouldn't stop the game from crashing when players press "X" to sell all junk manually using the ESO UI.

Did you try the test I gave you? Did the game crash with ONLY insjunkyard running?
Report comment to moderator  
Reply With Quote
Unread 06/09/14, 11:36 PM  
Tonyleila
 
Tonyleila's Avatar
AddOn Author - Click to view AddOns

Forum posts: 288
File comments: 763
Uploads: 7
Re: If still crashing

Originally Posted by YelloDello
It's possible the game would still crash with my fix, since the problem is somewhat dependent on the power of your computer, and I haven't tested slower systems than mine.
I don't think its a slow system problem this is my setup:
CPU: i7-4770k @ 4,2ghz
GPU: GeForce GTX 780 Ti
RAM: 32 gb
-----
I guess you PC is not better However its a problem with too many addons trying to get info from the server and then when you push too many things out of your bags it will lag and then error. Maybe this coud be solved like in Bank Manager where the progess of pushing and pulling items is slowed down and split into max 5 items a once or so.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.