insjunkyard update for ESO 1.2.3 : Discontinued & Outdated : Elder Scrolls Online AddOns

insJunkyard change Log
========================
v1.01 - 2014-06-30 (updated by YelloDello)
[Bugfix]
Contains fixes in response to unfriendly changes introduced by ESO 1.2.3, mainly a result of the item link format changing completely. I've attempted to remain backward compatible with old ESO 1.1.2 item link types, so you don't have to start your junklist over from scratch.
* Fixes item links displayed when typing "/junkyard list mark" so that clicking them does not cause UI errors (bug introduced by ESO 1.2.3).
* Fixes item comparisons so all items don't look the same to the add-on (bug introduced by ESO 1.2.3).

[NOTE]
There appears to be a bug where ESO uses your SavedVariables incorrectly now, putting them under "" (empty string) instead of your account name. To continue using your old settings, see http://www.esoui.com/forums/showthread.php?t=1843

v1.0a1-yd1 - 2014-06-02 (updated by YelloDello)
[Added]
* Cleanup function to remove duplicates in saved junk list, caused by old version of insjunkyard
being used with ESO 1.1.2 or later (/jy cleanup)

[Bugfix]
* Some optimizing of functions related to bugs.
* Fixed crash when selling all junk at vendor (partly caused by ESO 1.1.2 change, it seems; but also, code redundantly executing some functions 2 or 3 times).
* No more confusing/conflicting messages when moving item to junk list.
* Items from saved mark list are autojunked again (ESO 1.1.2 broke this).
* Duplicate items no longer added to saved junk list (ESO 1.1.2 broke this).

Archived Files (1)

File Name	Version	Size	Uploader	Date
insjunkyard update for ESO 1.1.2	1.0a1-yd1	20kB		06/08/14 07:06 PM

Comment Options

Page 1 of 2

1

2

>

06/08/14, 08:55 PM
Tonyleila Forum posts: 288 File comments: 763 Uploads: 7	Thanks for updating!

06/09/14, 04:38 PM
rolfbier Forum posts: 0 File comments: 1 Uploads: 0	Wenn ich sterbe und habe dabei eine Rüstung an dann stürzt mein Spiel ab! Hab dies gerade eben mehrmals getestet, kann mir aber auch nicht erklären warum das so ist. Ich spiele auf dem deutschen Client. Dieser Fehler trat auch erst mit diesem Fix auf. Googletranslate: When I die and I have a suit of armor then crashes my game! Did this just now tested several times, but I can not explain why this is so also. I play on the German client. This error also occurred only with this fix.

06/09/14, 10:21 PM

YelloDello

Forum posts: 8

File comments: 11

Uploads: 1

Originally Posted by rolfbier

Googletranslate:

When I die and I have a suit of armor then crashes my game!
Did this just now tested several times, but I can not explain why this is so also. I play on the German client.
This error also occurred only with this fix.

Thanks for the info. I won't be able to fix this in the near future. I recommend using the unfixed version for now, or not using junkyard at all if you want to avoid that bug. I say this because I played for a full week and died many times in various suits of armor, and never had a problem. And if I can't reproduce it, then I can't debug/fix it anytime soon (unless I get really involved and have you debug, send chat logs, and communicate back and forth with me... which, I'm sad to say, I don't have time to do).

Last edited by YelloDello : 06/09/14 at 10:23 PM.

06/09/14, 10:39 PM

YelloDello

Forum posts: 8

File comments: 11

Uploads: 1

If still crashing

I'm posting a PM and my response here:

Originally Posted by Tonyleila

... but the Auto Sell still gives me disconnects and ESO errors....

It's possible the game would still crash with my fix, since the problem is somewhat dependent on the power of your computer, and I haven't tested slower systems than mine.

That said... it's also fairly likely that other add-ons are the problem. The latest version of ESO can cause a particular event to be triggered hundreds of times when you "Sell All Junk", and the more add ons that respond to that event, the more likely you are to crash.

I suggest this test:

1. Turn off all addons but insjunkyard, then reload ui.
2. Go to a vendor with a bunch of junk items (you can buy back from the vendor first if you don't have any) and click on the "Store" option to cause the autosell to happen.

If it still crashes with only insjunkyard running, then it's indeed the problem. Please let me know either way. (I may not be able to fix it immediately, but it helps to have the info in case I have time to troubleshoot.)

06/09/14, 11:36 PM

Tonyleila

Forum posts: 288

File comments: 763

Uploads: 7

Re: If still crashing

Originally Posted by YelloDello

It's possible the game would still crash with my fix, since the problem is somewhat dependent on the power of your computer, and I haven't tested slower systems than mine.

I don't think its a slow system problem this is my setup:
CPU: i7-4770k @ 4,2ghz
GPU: GeForce GTX 780 Ti
RAM: 32 gb
-----
I guess you PC is not better

However its a problem with too many addons trying to get info from the server and then when you push too many things out of your bags it will lag and then error. Maybe this coud be solved like in Bank Manager where the progess of pushing and pulling items is slowed down and split into max 5 items a once or so.

06/10/14, 08:31 AM

YelloDello

Forum posts: 8

File comments: 11

Uploads: 1

Re: Re: If still crashing

Originally Posted by Tonyleila

I don't think its a slow system problem this is my setup:
CPU: i7-4770k @ 4,2ghz
GPU: GeForce GTX 780 Ti
RAM: 32 gb
-----
I guess you PC is not better

You guess right... we have pretty much the same machine.

Originally Posted by Tonyleila

However its a problem with too many addons trying to get info from the server and then when you push too many things out of your bags it will lag and then error. Maybe this coud be solved like in Bank Manager where the progess of pushing and pulling items is slowed down and split into max 5 items a once or so.

I already do this, except even more drastically. As far as I can tell from testing, insjunkyard now does way fewer transactions than Bank Manager. The only fix along these lines that would help is if I stopped using "Sell All Junk" altogether, and programatically sold all junk a few items at a time. The problem is that it wouldn't stop the game from crashing when players press "X" to sell all junk manually using the ESO UI.

Did you try the test I gave you? Did the game crash with ONLY insjunkyard running?

06/21/14, 12:54 PM
nasrudin Forum posts: 0 File comments: 1 Uploads: 0	Original vs this version Do I need to have the original plugin installed for this to work, ie.: is it a modification or remake ?

06/24/14, 07:19 PM
Augmenti-DeMontia Forum posts: 32 File comments: 213 Uploads: 0	Thanks for your work on this mod !

06/29/14, 10:38 PM

YelloDello

Forum posts: 8

File comments: 11

Uploads: 1

Re: Original vs this version

Originally Posted by nasrudin

Do I need to have the original plugin installed for this to work, ie.: is it a modification or remake ?

You do not need the original plugin for this to work. This mod is standalone.

06/29/14, 10:43 PM
YelloDello Forum posts: 8 File comments: 11 Uploads: 1	Note: 1.2.3 breaks it Once again, ESO changes in the latest patch (1.2.3) have broken the mod. I'm going to try to fix it. Stay tuned. In the meantime... I strongly recommend not using a mark list, or turning off the mod altogether. I'm seeing some very wacky behaviour, including all kinds of random items ending up as junk.

06/30/14, 07:21 PM

Enigma

Forum posts: 0

File comments: 65

Uploads: 0

Re: Note: 1.2.3 breaks it

Originally Posted by YelloDello

Once again, ESO changes in the latest patch (1.2.3) have broken the mod. I'm going to try to fix it. Stay tuned.

In the meantime... I strongly recommend not using a mark list, or turning off the mod altogether. I'm seeing some very wacky behaviour, including all kinds of random items ending up as junk.

Yes thank you very much.

07/05/14, 01:48 PM
genadine Forum posts: 1 File comments: 10 Uploads: 0	CTD when using Cleanup Tonight I attempted to clean my junk file using /jy cleanup and immediately suffered a CTD

07/06/14, 10:55 AM

YelloDello

Forum posts: 8

File comments: 11

Uploads: 1

Re: CTD when using Cleanup

Originally Posted by genadine

Tonight I attempted to clean my junk file using /jy cleanup and immediately suffered a CTD

Thanks! Hadn't thought to retest cleanup. I'll look into it and hopefully put out a fix soon.

07/06/14, 06:17 PM

YelloDello

Forum posts: 8

File comments: 11

Uploads: 1

Re: Re: CTD when using Cleanup

Originally Posted by genadine

Tonight I attempted to clean my junk file using /jy cleanup and immediately suffered a CTD

Note: it looks like there isn't a quick fix for this.

The problem is ESO 1.2.3 again: they seem to have changed item link parsing in such a way that parsing a lot of links at once causes a crash. I will look for a workaround (perhaps a better sorting algorithm that will lessen the load) but for now, avoid using /jy cleanup. Sorry!

07/08/14, 07:45 AM

Augmenti-DeMontia

Forum posts: 32

File comments: 213

Uploads: 0

Re: Re: Re: CTD when using Cleanup

Originally Posted by YelloDello

Originally Posted by genadine

Tonight I attempted to clean my junk file using /jy cleanup and immediately suffered a CTD

Note: it looks like there isn't a quick fix for this.

The problem is ESO 1.2.3 again: they seem to have changed item link parsing in such a way that parsing a lot of links at once causes a crash. I will look for a workaround (perhaps a better sorting algorithm that will lessen the load) but for now, avoid using /jy cleanup. Sorry!

This sounds like the cause of my issue. When in group and showing all looted items, there is a lag created when anyone loots. The more the looted items the more the lag, i.e. everyone trying to loot a dungeon boss. It took me awhile to isolate, but now going to try just showing my own loot.

Thanks again for your work on this, hopefully there is a way to fix the link processing issue.

I strongly recommend not using a mark list, or turning off the mod altogether.

What's a Mark List?

Edited:

Last edited by Augmenti-DeMontia : 07/08/14 at 07:59 AM.

Page 1 of 2

1

2

>

Donate to YelloDello via PayPal

Compatibility:	Veteran Crypt of Hearts (1.2.3)
Updated:	07/01/14 11:12 AM
Created:	06/08/14 07:06 PM
Monthly downloads:	18
Total downloads:	3,991
Favorites:	10
MD5:

Support AddOn Development!