Shopkeeper (Improved, Fixed and Updated) : Plug-Ins & Patches : Elder Scrolls Online AddOns

(223 Kb)

Download

Updated: 03/03/15 04:06 PM

Patch for:
Shopkeeper - Sales History and Alerts.

Add Favorite

Install Help

Pictures

File Info

Compatibility:	Update 6 (1.6.5)
Updated:	03/03/15 04:06 PM
Created:	12/09/14 08:36 PM
Monthly downloads:	52
Total downloads:	17,239
Favorites:	18
MD5:

Shopkeeper (Improved, Fixed and Updated) Popular! (More than 5000 hits)

Version: 1.0 (dOpiate Fix).7b

by: dopiate, Garkin

I've found people are avoiding this addon thinking it's the OLDER version when in truth it's as current as can be. Plus, it is THE more stable option and if you read the forums you will see NO ERRORS OR ISSUES. So that's why I dropped the "Classic" name because ....

THIS IS SHOPKEEPER

While this addon will still exist it's development has halted.

I suggest you migrate to Master Merchant

That truly is the New Shopkeeper Continued!

New Version? Always check the Change Log

--------------------News-----------------------

The tool tip value.

After quite a bit of investigating I was able to determine that the PPU (“Price Per Unit”) shown in the tool tip is not wrong. In fact, I believe it’s the most accurate representation of the true PPU that I am aware of in the game!

How does it work?

What Khaibit did was implement a formula that took into account the time in which each sale took place. So, if there were two sales, one ten days ago and one yesterday, his formula gave more weight (“importance”) to the more recent sale. Therefore the PPU is generated by using the value of gold over time and its relevance is based on sale date.

In his code were these comments:

If all sales data covers less than a day, we'll just do a plain average, nothing to weight.

For a weighted average, the latest data gets a weighting of X, where X is the number of days the data covers, thus making newest data worth more.

My guess is that his formula is based on “The Time Value of Money” – which took me by surprise.
I don’t even remember him saying that he was doing that. It’s really an impressive way to look at generating a more accurate PPU. If you look in the forums you can see I first tried to generate his tool tip PPU using multiple basic methods and every time I could not match his number. When I looked at the code I realized why. If you read that post and then see his value v. all the equations I tried you will see his is MUCH more accurate than mine were. More realistic to NOW. The game is not static and so the PPU would not be either and he addressed that issues.

This puts to rest the idea that Shopkeeper 1.0 tool tips were wrong or broken. They were neither. They were more advanced then he let us know.

-d

12.10.2014 - I changed the errors into not errors
12.11.2014 - I found and fixed an error with the font replacement
------------- please note this error was not reported but found by me reviewing my changes
------------- I am at work and can not test this fix but it should be fine
12.12.2014 - A conflict was discovered between Shopkeeper and CraftCompare
------------- Garkin was kind enough to just PM the code fix so I didn't have to wait until after work before I could
------------- test/fix it. If you don't use CraftCompare then this isn't an essential update.
12.17.2014 - Two actual bugs were fixed. The tool tip not showing in inventory or bank was fixed.
------------- dragging items to sell or mail was also fixed (all credit to Garkin for that one)
12.18.2014 - Garkin found what spoqster had suspected. There was a stack size issue.
------------- This issue only happened for items with sales in a 24 hour window.
------------- That issue was fixed and the missing font code was updated.
12.21.2014 - Somehow (I used the wrong version to zip up I guess) the Shopkeeper and CraftCompare
------------- bug fix was GONE! 100% my screw up! I hang my head in shame.
------------- Garkin provided me the code the first time he pointed it out again today.
------------- it was fixed - unfixed - now re-fixed - sorry :-(
01.24.2015 - small fixes in the offline file report
02.06.2015 - fixed issue with regular items going BOA (bind on account) but still in your sales history.
03.03.2015 - Update 6 version
03.03.2015 - Updated to correct LibAddonMenu-2.0

Archived Files (9)

File Name	Version	Size	Uploader	Date
Shopkeeper (Improved, Fixed and Updated)	1.0 (dOpiate Fi	222kB	dopiate	03/03/15 12:59 PM
Shopkeeper (Improved, Fixed and Updated)	1.0 (dOpiate Fi	219kB	dopiate	02/06/15 02:12 PM
Shopkeeper (Improved, Fixed and Updated)	1.0 (dOpiate Fi	219kB	dopiate	01/24/15 01:48 PM
Shopkeeper (Improved, Fixed and Updated)	1.0 (dOpiate Fi	219kB	dopiate	12/21/14 01:10 PM
Shopkeeper 1.0 (Classic)	1.0 (dOpiate Fi	219kB	dopiate	12/18/14 10:40 AM
Shopkeeper 1.0 (Classic)	1.0 (dOpiate Fi	218kB	dopiate	12/17/14 08:46 AM
Shopkeeper 1.0 (Classic)	1.0 (dOpiate Fi	218kB	dopiate	12/12/14 09:21 AM
Shopkeeper 1.0 (Classic)	1.0 (dOpiate Fi	218kB	dopiate	12/10/14 09:13 AM
Shopkeeper 1.0 (Classic)	1.0 (dOpiate Fi	218kB	dopiate	12/09/14 08:36 PM

Comment Options

Page 1 of 4

Last »

09/01/15, 05:18 AM
dopiate Forum posts: 142 File comments: 677 Uploads: 11	Update? Has anyone tested this with the new patch? If it still works and you still want to us it, I will update it. -d

02/06/15, 02:38 PM
Migoda Forum posts: 18 File comments: 79 Uploads: 1	You're welcome . Glad i could help to kill that little bug! Tested your fix and the errors are gone now. Cheers!

02/06/15, 02:08 PM
dopiate Forum posts: 142 File comments: 677 Uploads: 11	Regular Items going BOA! Migoda, Thanks to your hard work and Garkins quick thinking this has been fixed. Fixed in this version and fixed in the version that will go up when Update 6 is released. That bug was introduced every time they patched and made a regular item (that you were previously able to sell) now boa (bind on account) and impossible to sell and be listed - in your case the item was now listed as type "Costume". At one time you used to be able to sell that item, You still can in live but in PTS it's boa. I used to sell quest disguises a lot then one patch and they were boa - so this is a common practice for them. There is now a check in the current shopkeeper and the one to be released in Update 6 to prevent this error. Thanks for your investigative work on this! Much appreciated. Puzzle solved! -d . Last edited by dopiate : 02/06/15 at 05:36 PM.

02/05/15, 01:55 PM

dopiate

Forum posts: 142

File comments: 677

Uploads: 11

Originally Posted by Migoda

Originally Posted by Garkin

I'm not really sure what's going on because I do not have a single error from modified version of Shopkeeper on PTS. Do you use any other addons which scans guild sales history?

Nope, just Shopkeeper running for that purpose.

Here is my saved variables file, using your modified SK version:
Shopkeeper-test.zip

I logged out after the error appeared for the first time to stop the scan. You will see a lot of dupes in there already.

OH I have seen this -- I had no clear solution.

Can you on the PTS quit this guild "Bund der freien Händler"

check this link: http://forums.elderscrollsonline.com...and-available#

I'm sorry for some reason (and I haven't the slightest idea why) some guilds do this - well to be fair this is only the 2nd time I've seen it but it's the same symptoms.

The link explains is much better but I currently have no solution or clue as to why it happens,

-d

02/05/15, 01:36 PM

Migoda

Forum posts: 18

File comments: 79

Uploads: 1

Originally Posted by Garkin

I'm not really sure what's going on because I do not have a single error from modified version of Shopkeeper on PTS. Do you use any other addons which scans guild sales history?

02/05/15, 01:30 PM
dopiate Forum posts: 142 File comments: 677 Uploads: 11	Ok I'm on the confused bandwagon also I didn't just try Shopkeeper but I ported Garkin's changes over to GSA and it's flawless. not one error He did an amazing job. I do not know why you are having issues. I tried now both Shopkeeper from Garkin and his changes in GSA and both worked 100%. -d ps yes I should be working - but I had to figure this out.

02/05/15, 12:52 PM

dopiate

Forum posts: 142

File comments: 677

Uploads: 11

Originally Posted by Garkin

Originally Posted by Migoda

Thanks! Thats awesome, Garkin. I tried your modified version, the old data stays fine and is displayed with no errors now.

So its only the scanning of new sales that still needs a fix. Right now it runs infinite and keeps filling the saved file with dupes. This error keeps popping up all the time:

I'm not really sure what's going on because I do not have a single error from modified version of Shopkeeper on PTS. Do you use any other addons which scans guild sales history?

Here is my saved variables file (without character specific data):
https://www.dropbox.com/s/03bcaxz8ug...-test.zip?dl=0

Garkin,

I'll connected to my home pc now via VPN and I'm downloading PTS.

I will be able to also confirm tonight.

-d

02/05/15, 12:49 PM

Garkin

Forum posts: 832

File comments: 1097

Uploads: 33

Originally Posted by Migoda

02/05/15, 12:28 PM

dopiate

Forum posts: 142

File comments: 677

Uploads: 11

Originally Posted by Migoda

I tried it and got the same result and error i mentioned in my previous post.

Ok thanks for trying - can you post a part of the lua file here so we can see whats repeating over and over?

I'm going to remote to home and get PTS ready so I can try it tonight.

-d

.

Last edited by dopiate : 02/05/15 at 12:30 PM.

02/05/15, 12:23 PM
Migoda Forum posts: 18 File comments: 79 Uploads: 1	I tried it and got the same result and error i mentioned in my previous post.

02/05/15, 12:15 PM

dopiate

Forum posts: 142

File comments: 677

Uploads: 11

Originally Posted by Migoda

Just as a test.

go to the old version (temporarily)

delete your saved variables (rename/backup)

let it rebuild from scratch

let me know the results.

my guess is it will be bug free but you will only be able to go back 10 days.

-d

Last edited by dopiate : 02/05/15 at 12:16 PM.

02/05/15, 11:48 AM

Migoda

Forum posts: 18

File comments: 79

Uploads: 1

Lua Error: user:/AddOns/Shopkeeper/Shopkeeper_Util.lua:94: table index is nil
stack traceback:
user:/AddOns/Shopkeeper/Shopkeeper_Util.lua:94: in function 'Shopkeeper:addToHistoryTables'
user:/AddOns/Shopkeeper/Shopkeeper.lua:581: in function 'Shopkeeper:InsertEvent'
user:/AddOns/Shopkeeper/Shopkeeper.lua:661: in function 'Shopkeeper:DoScan'
user:/AddOns/Shopkeeper/Shopkeeper.lua:719: in function 'func'
EsoUI/Libraries/Globals/globalapi.lua:181: in function '(anonymous)'

Last edited by Migoda : 02/05/15 at 11:50 AM.

02/05/15, 11:23 AM

dopiate

Forum posts: 142

File comments: 677

Uploads: 11

Originally Posted by Garkin

I have slightly modified Shopkeeper to automatically update links to the new format:
Shopkeeper-1.0r7-Update6_beta.zip

I don't know if it is the best solution, but at least it works and you can keep your old data.

WARNING: Works only on PTS server, patch 1.6.1.

Thanks Garkin -- thats a great solution

Would you have any issue with me using the same code to keep GSA working without an issue?

Thanks,

-d

02/05/15, 11:02 AM
Garkin Forum posts: 832 File comments: 1097 Uploads: 33	I have slightly modified Shopkeeper to automatically update links to the new format: Shopkeeper-1.0r7-Update6_beta.zip I don't know if it is the best solution, but at least it works and you can keep your old data. WARNING: Works only on PTS server, patch 1.6.1.

02/05/15, 09:43 AM

dopiate

Forum posts: 142

File comments: 677

Uploads: 11

Originally Posted by Garkin

Originally Posted by Migoda

Hey dop,

any chance for a fix to make SK work with Update 6? On PTS the tooltips and item links / names are broken.

There is just this error message popping up all the time:

Thanks in advance and for keeping this great addon alive!

Item links in Update 6 have an additional flag for stolen items.

Old Link:

Code:

"|H1:item:33252:30:1:0:0:0:0:0:0:0:0:0:0:0:0:7:0:0:0:0|h|h"

New link (new flag is in red):

Code:

"|H1:item:33252:30:1:0:0:0:0:0:0:0:0:0:0:0:0:7:0:0:0:0:0|h|h"

You will have to either clear saved variables and let Shopkeeper to do full update (and I'm not really sure if it will work as last time when links were changed, server did not update links in sales history) or make function which will iterate over all items in saved variables and convert old links to new ones.

Hey Garkin,

Thanks for jumping in and helping -- I have yet to be on Update 6

I believe you are right - the old saved variables history will error out and just deleting the saved variables should set everyone straight. They will have to start with 10 days and work up to 30 again but that's hardly a burden.

If the fix is to delete the saved variables and let it re-scan - that would be a nice easy fix for Shopkeeper ... but as you questioned what will it return for the previous 10 days of history? old item links or new item links?

If this is the fix for Shopkeeper this will make a HUGE mess of GSA because when you let Shopkeeper (or the GSA engine based on Shopkeeper) re-create the history the epoch time-stamp is almost never the same (why I have no freaking idea) and GSA uses the epoch date as BIG part of keeping the database duplicate free.

Based on what you show for the items link - the offline GSA will just adapt because it uses the location in the string for this pattern "h|h" -- it could be any number and it will not flinch - the power or parsing based on pattern matching and not using static numbers!

Could you send me a copy of your Shopkeeper.lua from Update 6 (Garkin or anyone who would like to help?)

Migoda,

Could you give this a try and let us know how it works out. Just (before you login to the game) - delete your PTS\SavedVariables\Shopkeeper.lua -- then Shopkeeper will recreate it.

I would also LOVE a copy of the re-created Shopkeeper.lua :-) pretty please!

Thanks,
-d

.

Last edited by dopiate : 02/05/15 at 10:12 AM.

Page 1 of 4

Last »

http://www.esoui.com/downloads/info822-GSA.html#donate

Report this File