Quantcast
Download
(5 Kb)
Download
Updated: 02/12/18 11:16 AM
Pictures
File Info
Compatibility:
Dragon Bones (3.3)
Clockwork City (3.2)
Horns of the Reach (3.1)
Morrowind (3.0)
Homestead (2.7)
One Tamriel (2.6)
Shadows of the Hist (2.5)
Dark Brotherhood (2.4)
Thieves Guild (2.3)
Orsinium (2.2.4)
Updated:02/12/18 11:16 AM
Created:10/06/17 03:30 PM
Monthly downloads:186
Total downloads:3,951
Favorites:17
MD5:
CritDamage
Version: 1.3
by: SamwellTarly [More]
This simple addon will extend your character windows stats to include, in addition to your penetration, your critical damage.
1.3 -- Update for dragonbones

1.1.2-- Changed a line of code which might have been causing people to get a ui error when using a certain combination of gear, the shadow stone, and poisons.


1.1. Swapped sides of the buffs and made the stat react when having the shadow stone and changing the amount of divines gear instantly instead of after a reload UI.
Optional Files (0)


Archived Files (5)
File Name
Version
Size
Author
Date
1.2.1
5kB
SamwellTarly
10/24/17 03:14 PM
1.1.2
4kB
SamwellTarly
10/12/17 12:42 PM
1.1.1
4kB
SamwellTarly
10/07/17 07:13 AM
1.2
3kB
SamwellTarly
10/07/17 05:43 AM
1.0
3kB
SamwellTarly
10/06/17 03:30 PM


Post A Reply Comment Options
Unread 03/11/18, 04:18 AM  
HolKann

Forum posts: 0
File comments: 2
Uploads: 0
Refactored the code a bit

Fixed the bug from this thread, made the color consistent with ZOS color scheme, shields are correctly taken into account as well, general refactoring. See lua code.
Last edited by HolKann : 03/11/18 at 04:18 AM.
Report comment to moderator  
Reply With Quote
Unread 02/22/18, 03:49 AM  
HolKann

Forum posts: 0
File comments: 2
Uploads: 0
Originally Posted by SamwellTarly
Originally Posted by SamwellTarly
Originally Posted by RealReeth
Good AddOn Idea, but I get following message at opening char-overview.

Code:
user:/AddOns/CritDamage/CritDamage.lua:55: operator + is not supported for number + string
stack traceback:
	user:/AddOns/CritDamage/CritDamage.lua:55: in function 'CritD:Ggdivines'
	user:/AddOns/CritDamage/CritDamage.lua:66: in function 'CritD:TheShadowBeWithYou'
	user:/AddOns/CritDamage/CritDamage.lua:129: in function 'CritD:CritDamage'
	user:/AddOns/CritDamage/CritDamage.lua:160: in function '(anonymous)'
	(tail call): ?
	EsoUI/Ingame/Stats/Keyboard/ZO_StatEntry_Keyboard.lua:59: in function 'ZO_StatEntry_Keyboard:UpdateStatValue'
	EsoUI/Ingame/Stats/Keyboard/ZO_StatEntry_Keyboard.lua:19: in function 'UpdateStatValue'
Crit-Damages are not shown and if I close the error windows, it re-appears instantly.
Hmm, I will try to recreate your errors. So far you're the first one I've seen with this.
Did you have the shadow stone at the time? Were you max level? Lastly what trait and quality was your gear?
I had the same problem, but I fixed it with the following code:
Code:
function CritD.Gear(i)  
    return GetItemLinkTraitInfo(GetItemLink(BAG_WORN,i) )    -- Get(,1) = trait id (18 is div) Get(_,2) is the text of the trait 
end

function CritD.Quality(i)  
    return GetItemLinkQuality(GetItemLink(BAG_WORN,i) ) -- Value between 1-5, depending on the quality of the gear
end 
    
function CritD:Ggdivines()
    local flag=0
    local x, y=0
    local T= {0,2,3,6,7,8,9,12,29}    -- T enumerates the only slots which can have worn gear (other than weapons)
    for _,i in pairs(T) do 	x, y=self.Gear(i)
        if x==18   -- 18 means divines
			then flag=flag + 2.5 + self.Quality(i)
        end
    end
    return flag/100 
end
It has something to do with parsing the divines percentage out of the info string, which returned a null pointer in my game client (maybe because I use the French client?). So instead, I extract the quality and use that to return the right divines percentage.

Also, it's possible that a shield has the divines trait, which now is taken into account. Hmm, now that I think of it, you can't have two shields active at the same time...

Is my first eso addon programming experience, but I really wanted to know my crit damage and spell penetration
Last edited by HolKann : 02/22/18 at 03:51 AM.
Report comment to moderator  
Reply With Quote
Unread 11/20/17, 07:16 PM  
SamwellTarly
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 11
Uploads: 4
Originally Posted by Dingodan
I'm wondering if there is any localisation needed for this addon?
There is, but I'm trying to develop my next addon while still learning the ins and outs of addon development, so it's going to be a while.
Report comment to moderator  
Reply With Quote
Unread 11/17/17, 06:19 PM  
Dingodan
 
Dingodan's Avatar

Forum posts: 46
File comments: 226
Uploads: 0
I'm wondering if there is any localisation needed for this addon?
Report comment to moderator  
Reply With Quote
Unread 10/11/17, 03:28 PM  
SamwellTarly
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 11
Uploads: 4
Originally Posted by SamwellTarly
Originally Posted by RealReeth
Good AddOn Idea, but I get following message at opening char-overview.

Code:
user:/AddOns/CritDamage/CritDamage.lua:55: operator + is not supported for number + string
stack traceback:
	user:/AddOns/CritDamage/CritDamage.lua:55: in function 'CritD:Ggdivines'
	user:/AddOns/CritDamage/CritDamage.lua:66: in function 'CritD:TheShadowBeWithYou'
	user:/AddOns/CritDamage/CritDamage.lua:129: in function 'CritD:CritDamage'
	user:/AddOns/CritDamage/CritDamage.lua:160: in function '(anonymous)'
	(tail call): ?
	EsoUI/Ingame/Stats/Keyboard/ZO_StatEntry_Keyboard.lua:59: in function 'ZO_StatEntry_Keyboard:UpdateStatValue'
	EsoUI/Ingame/Stats/Keyboard/ZO_StatEntry_Keyboard.lua:19: in function 'UpdateStatValue'
Crit-Damages are not shown and if I close the error windows, it re-appears instantly.
Hmm, I will try to recreate your errors. So far you're the first one I've seen with this.
Did you have the shadow stone at the time? Were you max level? Lastly what trait and quality was your gear?
Report comment to moderator  
Reply With Quote
Unread 10/10/17, 01:19 PM  
SamwellTarly
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 11
Uploads: 4
Originally Posted by RealReeth
Good AddOn Idea, but I get following message at opening char-overview.

Code:
user:/AddOns/CritDamage/CritDamage.lua:55: operator + is not supported for number + string
stack traceback:
	user:/AddOns/CritDamage/CritDamage.lua:55: in function 'CritD:Ggdivines'
	user:/AddOns/CritDamage/CritDamage.lua:66: in function 'CritD:TheShadowBeWithYou'
	user:/AddOns/CritDamage/CritDamage.lua:129: in function 'CritD:CritDamage'
	user:/AddOns/CritDamage/CritDamage.lua:160: in function '(anonymous)'
	(tail call): ?
	EsoUI/Ingame/Stats/Keyboard/ZO_StatEntry_Keyboard.lua:59: in function 'ZO_StatEntry_Keyboard:UpdateStatValue'
	EsoUI/Ingame/Stats/Keyboard/ZO_StatEntry_Keyboard.lua:19: in function 'UpdateStatValue'
Crit-Damages are not shown and if I close the error windows, it re-appears instantly.
Hmm, I will try to recreate your errors. So far you're the first one I've seen with this.
Report comment to moderator  
Reply With Quote
Unread 10/09/17, 12:28 PM  
RealReeth

Forum posts: 1
File comments: 13
Uploads: 0
Good AddOn Idea, but I get following message at opening char-overview.

Code:
user:/AddOns/CritDamage/CritDamage.lua:55: operator + is not supported for number + string
stack traceback:
	user:/AddOns/CritDamage/CritDamage.lua:55: in function 'CritD:Ggdivines'
	user:/AddOns/CritDamage/CritDamage.lua:66: in function 'CritD:TheShadowBeWithYou'
	user:/AddOns/CritDamage/CritDamage.lua:129: in function 'CritD:CritDamage'
	user:/AddOns/CritDamage/CritDamage.lua:160: in function '(anonymous)'
	(tail call): ?
	EsoUI/Ingame/Stats/Keyboard/ZO_StatEntry_Keyboard.lua:59: in function 'ZO_StatEntry_Keyboard:UpdateStatValue'
	EsoUI/Ingame/Stats/Keyboard/ZO_StatEntry_Keyboard.lua:19: in function 'UpdateStatValue'
Crit-Damages are not shown and if I close the error windows, it re-appears instantly.
Report comment to moderator  
Reply With Quote
Unread 10/07/17, 07:19 AM  
SamwellTarly
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 11
Uploads: 4
Originally Posted by Darkkeira
I'm only getting Spell and Physical Penetration. No Weapon or Spell Crit

Sorry, messed up with the uploading of the update since I had not done it before. Should be set now.
Report comment to moderator  
Reply With Quote
Unread 10/07/17, 05:31 AM  
Darkkeira

Forum posts: 2
File comments: 7
Uploads: 0
I'm only getting Spell and Physical Penetration. No Weapon or Spell Crit
Report comment to moderator  
Reply With Quote
Unread 10/07/17, 04:42 AM  
lexo1000
 
lexo1000's Avatar

Forum posts: 3
File comments: 84
Uploads: 0
Great addition thank you
Two things :
- could you make the addon translatable?
- could you let the default color for text?
Report comment to moderator  
Reply With Quote
Unread 10/07/17, 04:10 AM  
Dingodan
 
Dingodan's Avatar

Forum posts: 46
File comments: 226
Uploads: 0
Is it possible to change the sides?

Weapon Damage Info under Weapon Damage and Spell Damage Info under Spell Damage.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.