Quantcast
Download
(4 Kb)
Download
Updated: 08/05/14 04:12 AM
Pictures
File Info
Compatibility:
Update 3 (1.3.3)
Updated:08/05/14 04:12 AM
Created:04/21/14 08:44 AM
Monthly downloads:120
Total downloads:4,101
Favorites:26
MD5:
Junkee
Version: 0.9
by: Thenedus [More]

My subscription has run out, so I will not be able to update this addon anymore.
If anyone wants to take over development, please let me know (preferably via PM)


Junkee

Provides a keybinding to quickly mark an item as junk and an additional keybinding to delete an item.

Installation and Setup
  • Copy complete folder to
    %USERPROFILE%\Documents\Elder Scrolls Online\<megaserver>\AddOns
    where <megaserver> is "live" for North America and "liveeu" for Europe
    (or use Minion)
  • Go to Controls/User Interface Shortcuts/Junkee and bind a key to "Junk current item"
  • Optionally, also bind a key do "Delete current item"
## 0.9
- [MOD] Adjusted APIVersion to the current API
## 0.8
- [MOD] Adjusted APIVersion to the current one, added ZeniMax disclaimer
- [FIX] Pressing the key bound to delete in another view (e.g. map) destroyed the
helmet (Thanks Karmik)
## 0.7
- [FIX] Pressing either bound key in another view (e.g. map) junked/destroyed the
last item the mouse was over (Thanks McGuffin)
## 0.6
- [FIX] Inventory slots that were not present on login were missing the Junk action
- [FIX] Destroy action was missing completely
- [FIX] Actions were missing from bank
## 0.5 (Thanks Iyanga)
- [MOD] Plays sound when junking or unjunking an item
- [FIX] Adding the junk keybind is more robust, should fix the "unsecure code" error
## 0.4
- [MOD] Adjusted APIVersion to the current one.
## 0.3
- [NEW] Second action to delete an item.
- [MOD] Only show actions when they are bound to a key.
- [NEW] Localization for German and French.
## 0.2a
- [FIX] Error when interacting with a vendor (Thanks ThadOptimus)
## 0.2
- [MOD] Removed dependency on Wykkyd's Framework.
- [NEW] Toggle junk, i.e. unjunk a junked item.
- [NEW] Only display action for backpack and bank.
- [FIX] Renamed readme.txt to read.me (Thanks Tonyleila)
## 0.1
- Initial release with basic functionality.
Optional Files (0)


Archived Files (8)
File Name
Version
Size
Author
Date
0.8
4kB
Thenedus
07/15/14 08:34 PM
0.7
4kB
Thenedus
06/02/14 01:12 PM
0.6
3kB
Thenedus
05/31/14 04:56 AM
0.5
3kB
Thenedus
05/30/14 05:08 PM
0.4
4kB
Thenedus
05/23/14 04:06 PM
0.3
3kB
Thenedus
04/27/14 06:16 AM
0.2a
2kB
Thenedus
04/23/14 03:22 PM
0.1
2kB
Thenedus
04/21/14 08:44 AM


Post A Reply Comment Options
Unread 12/20/15, 01:28 PM  
Denidil
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 23
Uploads: 3
I'm maintaining this addon now as Junkee Returns http://www.esoui.com/downloads/info1...eeReturns.html
Report comment to moderator  
Reply With Quote
Unread 07/21/14, 04:22 PM  
heyguyslol
AddOn Author - Click to view AddOns

Forum posts: 24
File comments: 53
Uploads: 1
Ok I tested the new updated Junkee with an alt using crap gear and crap inventory. It appears that the addon is working perfectly (fingers crossed). I also tried to use the junk and delete commands by hovering over equipped gear to see if it would junk or delete the gear, it did not junk or delete anything.

So I think we are in the clear to use this addon safely now.
Report comment to moderator  
Reply With Quote
Unread 07/21/14, 12:20 AM  
heyguyslol
AddOn Author - Click to view AddOns

Forum posts: 24
File comments: 53
Uploads: 1
Going to test this add on for a few days on a alt with sh!t gear just to make sure I dont run into any other problems before I let it touch my main. I really need this addon as it saves so much time for loot.
Last edited by heyguyslol : 07/21/14 at 12:21 AM.
Report comment to moderator  
Reply With Quote
Unread 07/15/14, 08:37 PM  
Thenedus
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 21
Uploads: 3
Updated to version 0.8 to fix the deletion bug.
I sincerely apologize to everyone who had their helmet deleted, I really should have caught this.
Report comment to moderator  
Reply With Quote
Unread 06/29/14, 11:12 PM  
Karmik

Forum posts: 0
File comments: 2
Uploads: 0
I believe I fixed the helmit deletion problem

IF YOU DON"T KNOW HOW TO PROPERLY EDIT A TEXT FILE DON"T DO THIS. Disable the addon as heyguyslil said in a previous comment. I make no guarantees in any case

Add the highlighted line to Junkee.lua file and save it. Reload the ui or better, restart the game.

Junkee.DeleteIt = function()
if Junkee.bagId == nil then return end
DestroyItem(Junkee.bagId, Junkee.slotId)
end

After having lost like 5 helmets I noticed that if you hit the bound delete key with nothing selected it deletes the helmet. But the patch notes said:
"## 0.7
- [FIX] Pressing either bound key in another view (e.g. map) junked/destroyed the
last item the mouse was over (Thanks McGuffin)"

I realized the developer must have fixed the Junked path but not the delete path. Looking at the LUA file I could see that is what he did. Not checking for nil is the most basic mistake you can make and is incredibly common. The game code is also poorly written. It obviously defaults to the helmet if nil is passed to DestroyItem(). It should reject the call.
Last edited by Karmik : 06/29/14 at 11:17 PM.
Report comment to moderator  
Reply With Quote
Unread 06/21/14, 01:14 AM  
heyguyslol
AddOn Author - Click to view AddOns

Forum posts: 24
File comments: 53
Uploads: 1
DO NOT USE THIS ADDON.

Version 0.7

I have lost 4 head pieces of equipped gear because of this addon using the latest version. It took me a while to isolate the problem but now I know that using this addon will delete gear that is equipped specifically the head piece. I've lost about 100k in head pieces because of this addon. I wont blame the author completely as any addon used is use at your own risk but be warned you may loose gear using his addon.

I was able to back track this bug from my live stream I did and created a highlight of the bug in action.

http://www.twitch.tv/heyguyslol_1975/c/4506208

So apparently what happens is when u use the marked junk option and start deleting junked items the last item you destroy from the junked items will also auto destroy your currently equipped helm.

Like I said I've lost about 100k in gear because of this addon 3 warlock vr1 helms and now a lvl 23 helm all legendary quality.

It's a shame because I really wanted an add on like this to work but I can't afford to risk using this or an updated version for the chance that it's going to destroy my gear.
Last edited by heyguyslol : 06/21/14 at 05:38 AM.
Report comment to moderator  
Reply With Quote
Unread 06/02/14, 01:17 PM  
Thenedus
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 21
Uploads: 3
Re: Re: Bug

Originally Posted by Minceraft
Well, I've been having the same problem with right-clicking to use/eat an item...I get that same lua error message about insecure actions....and could you look into any add-on problems between Junkee and, specifically, Ingeniousclown's ItemSaver, Bank Manager by Todo, and Garkin's Dustman?
Does the error still occur in 0.6?
I still cannot reproduce it, even with the addons you listed. I went back to Junkee 0.4 and installed the three addons. Did not receive an error when right-clicking on an item and choosing Use. I even disabled all other addons to ensure that no other addon "consumed" the error.

Originally Posted by Minceraft
And, was wondering if the random deletion thing had been fixed, because I'm missing a few things....could've been a rollback, but would like to be sure!!
I just fixed this issue in version 0.7; it was introduced in version 0.5. So if you had a key bound to the Delete action and pressed with key somewhere outside of the inventory, you could have lost items. Sorry about that.
Last edited by Thenedus : 06/02/14 at 01:18 PM.
Report comment to moderator  
Reply With Quote
Unread 06/02/14, 01:14 PM  
Thenedus
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 21
Uploads: 3
Originally Posted by McGuffin
open any UI windows (quest, map etc...) Hit the junk key: a random item is actually junked (i guess its the last hovered item in inventory)
Damn... Fixed in version 0.7.
And you're right, it was the last hovered item.
Report comment to moderator  
Reply With Quote
Unread 06/01/14, 01:07 PM  
Minceraft
 
Minceraft's Avatar
AddOn Author - Click to view AddOns

Forum posts: 51
File comments: 36
Uploads: 4
Re: Bug

Originally Posted by Tonyleila
Hey Thenedus im 99% shure now that the bug is from this addon. I sometimes can't rightklick items in my inventory to use/eat them. There is an lua error but not for a special addon. But since I disabled Junkee I did not get it again yet.

Well, I've been having the same problem with right-clicking to use/eat an item...I get that same lua error message about insecure actions....and could you look into any add-on problems between Junkee and, specifically, Ingeniousclown's ItemSaver, Bank Manager by Todo, and Garkin's Dustman? And, was wondering if the random deletion thing had been fixed, because I'm missing a few things....could've been a rollback, but would like to be sure!! And, THANKS for the awesome Add-ons!!!
Report comment to moderator  
Reply With Quote
Unread 06/01/14, 09:36 AM  
McGuffin

Forum posts: 5
File comments: 35
Uploads: 0
hi

There is issue in the last version that can be a big problem.

open any UI windows (quest, map etc...) Hit the junk key: a random item is actually junked (i guess its the last hovered item in inventory)
Report comment to moderator  
Reply With Quote
Unread 05/31/14, 04:59 AM  
Thenedus
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 21
Uploads: 3
Re: Re: Re: Bug

Originally Posted by Iyanga
I see this error, too and can pinpoint it to the addon.
Do you have a way to reliably reproduce this error? I have never seen it myself and with the changes I did to your patch, I may have reintroduced the error again.
Report comment to moderator  
Reply With Quote
Unread 05/31/14, 04:58 AM  
Thenedus
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 21
Uploads: 3
Originally Posted by Thenedus
The new version breaks compatibility with Inventory Grid View and probably other addons that modify the inventory.
The problem was not connected to Inventory Grid View, it was just easier visible there:
The Junk action was only added to inventory slots that were present on login. For example, if your inventory was very empty and you later added an item, this item would not have the action.
Report comment to moderator  
Reply With Quote
Unread 05/30/14, 05:42 PM  
Thenedus
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 21
Uploads: 3
Originally Posted by Thenedus
This should be the final change to this addon. Pending any new bug reports or API changes, I'm done.
Maybe I was be little bit too optimistic... The new version breaks compatibility with Inventory Grid View and probably other addons that modify the inventory.
I'll look into this tomorrow. In the meantime, if you are using Inventory Grid View, please stay on version 0.4!
Last edited by Thenedus : 05/30/14 at 05:42 PM.
Report comment to moderator  
Reply With Quote
Unread 05/30/14, 05:16 PM  
Thenedus
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 21
Uploads: 3
Originally Posted by Iyanga
You can hook directly into the OnMouseEnter and OnMouseExit handlers of the individual rows:

ZO_PlayerInventoryBackpack1RowX

This has the neat side effects that the event handler gets the control as parameter, too, so you don't need to verify whether it is an inventory tooltip and can get the bagId and slotId straight from the event.
Thank you very much, Iyanga. That is what I always wanted to do but was too lazy to figure out

This should be the final change to this addon. Pending any new bug reports or API changes, I'm done.
Report comment to moderator  
Reply With Quote
Unread 05/27/14, 02:02 PM  
Iyanga
AddOn Author - Click to view AddOns

Forum posts: 185
File comments: 48
Uploads: 9
Re: Re: Bug

Originally Posted by Thenedus
From the error message, I don't think that this is related to Junkee. Junkee does nothing with the menu or the InventoryItem itself, it just hooks the tooltip. It could be something strange happening in combination with another addon. If you would give me a list of the addons you are using, I'll look into it.
I see this error, too and can pinpoint it to the addon.

I think I even know what happens:

You rewrite the existing handler function like this:
- Call default function.
- Call my function.

But the old handler runs in an environment where it is allowed to call private functions. Now it runs in your environment, the default function is called from the addon, where it is NOT allowed to call private functions. So whenever the old handler requires a secure environment, like putting stuff in the bank, it will fail.
Last edited by Iyanga : 05/27/14 at 02:05 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: