ESOUI

ESOUI (https://www.esoui.com/forums/index.php)
-   Wish List (https://www.esoui.com/forums/forumdisplay.php?f=177)
-   -   [implemented] Don't make PreviewCraftItem private! D: (https://www.esoui.com/forums/showthread.php?t=7018)

manavortex 05/05/17 10:30 AM

[implemented] Don't make PreviewCraftItem private! D:
 
So, I just was on PTS, and...

Code:

user:/AddOns/CraftingPreview/CraftingPreview.lua:43: Attempt to access a private function 'PreviewCraftItem' from insecure code. The callstack became untrusted 9 stack frame(s) from the top.
stack traceback:
        user:/AddOns/CraftingPreview/CraftingPreview.lua:43: in function 'ZO_ItemPreviewType_Crafting:Apply'
        EsoUI/IngameShared/ItemPreview/ItemPreview_Shared.lua:358: in function 'ZO_ItemPreview_Shared:Apply'
        EsoUI/IngameShared/ItemPreview/Keyboard/ItemPreview_Keyboard.lua:97: in function 'ZO_ItemPreview_Keyboard:Apply'
        EsoUI/IngameShared/ItemPreview/ItemPreview_Shared.lua:352: in function 'ZO_ItemPreview_Shared:ApplyOrBuffer'
        EsoUI/IngameShared/ItemPreview/ItemPreview_Shared.lua:301: in function 'ZO_ItemPreview_Shared:SharedPreviewSetup'
        user:/AddOns/CraftingPreview/CraftingPreview.lua:47: in function 'ZO_ItemPreview_Shared:PreviewCraftItem'
        user:/AddOns/CraftingPreview/CraftingPreview.lua:109: in function 'ZO_Smithing:EnablePreview'
        user:/AddOns/CraftingPreview/CraftingPreview.lua:167: in function 'hookFunction'
        EsoUI/Libraries/Utility/ZO_Hook.lua:19: in function '(anonymous)'
        (tail call): ?
        user:/AddOns/MultiCraft/MultiCraft.lua:514: in function 'SetMode'
        EsoUI/Ingame/Crafting/Keyboard/Smithing_Keyboard.lua:208: in function 'callback'
        EsoUI/Libraries/ZO_MenuBar/ZO_MenuBar.lua:280: in function 'MenuBarButton:Release'
        EsoUI/Libraries/ZO_MenuBar/ZO_MenuBar.lua:628: in function 'ZO_MenuBarButtonTemplate_OnMouseUp'
        ZO_MainMenuCategoryBarButton1_MouseUp:3: in function '(main chunk)'


Rhyono 05/05/17 11:19 AM

I was too lazy to ever ask this, but it's relevant now: why are the preview functions listed twice on the API wiki; once as private, once as not.

ZOS_ChipHilseberg 05/05/17 01:44 PM

http://www.esoui.com/forums/showthread.php?t=7015

manavortex 05/08/17 12:55 AM

@ZOS_ChipHilseberg: You seriously rock, sir.


All times are GMT -6. The time now is 03:17 AM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2014 - 2022 MMOUI