ESOUI

ESOUI (https://www.esoui.com/forums/index.php)
-   General Authoring Discussion (https://www.esoui.com/forums/forumdisplay.php?f=174)
-   -   Fixes to someone else add-on (https://www.esoui.com/forums/showthread.php?t=7084)

darkbyte 05/28/17 07:57 AM

Fixes to someone else add-on
 
Hi Everyone,

I'm kinda new here and i was wondering what the rules were for sharing a fix to an addon while the author is seemingly absent or not available.

The reason i ask is i did fix some issues with a addon and would like to make it known to the author so he saves time to fix it when he gets back.

The other reason is that i would like players with that issue to benefit from the fix i did.

Can i attach the updated file in a forum post and direct players to that forum post for updating their files locally?

Regards,
DarkByte

Ayantir 05/28/17 08:02 AM

Why bother ? people fix my adons at day +1 while I'm posting .

Ayantir, verry happy.

darkbyte 05/28/17 09:06 AM

Well,

I did mention that this is a add-on where the author is not currently updating it. I usually wait a few days before doing any kind of attempt to fix and only if this addon is really a big benefit.

Still don't know if i'm allowed to attach the updated script file to a forum post here, and if so, in which forum section.

Edit: Also, i want others to benefit from this fix.

Rhyono 05/28/17 09:07 AM

Typically, you can post it as a patch for that addon, so people will more easily see there's a fixed version.

darkbyte 05/28/17 10:00 AM

1 Attachment(s)
So, the fix is for CraftStoreFixedAndImproved addon, the attachment is the updated Lua file that needs to replace the old one.

Is it ok that i do it this way ?

Atlan 05/28/17 10:08 AM

Good question
 
Quote:

Originally Posted by darkbyte (Post 31172)
I'm kinda new here and i was wondering what the rules were for sharing a fix to an addon while the author is seemingly absent or not available

That is indeed an interesting question. Destinations has not seen an update in six month and produces several nil errors.

So I was wondering about that as well. Since we have GIT it should be possible to fork abandoned add-ons.

Rhyono 05/28/17 10:13 AM

Or you could use the massively updated CraftStore Morrowind.

darkbyte 05/28/17 01:01 PM

After having a talk with my guild about the fix, i was told the addon had changed name and i felt a little dumb, lol.

At least it got me to learn new stuff. :)

Tyx 05/28/17 01:46 PM

Depends on the licence I would say.
If it has a open source licence: Feel free to fork it and fix it. If not you need the permission of the author to post a fix/patch if you use part of his code in it (if the author did not explicitly allow it somewhere).
This is from a legal standpoint (of my understanding, not a lawyer and can differ from country to country), but in reality, I don't think any author has something against a patch. At least I wouldn't :D

iwontsay 05/28/17 10:05 PM

Quote:

Originally Posted by Tyx (Post 31187)
Depends on the licence I would say.
If it has a open source licence: Feel free to fork it and fix it. If not you need the permission of the author to post a fix/patch if you use part of his code in it (if the author did not explicitly allow it somewhere).
This is from a legal standpoint (of my understanding, not a lawyer and can differ from country to country), but in reality, I don't think any author has something against a patch. At least I wouldn't :D

Well, some authors do have their misgivings on people modifiying and redistributing their addons, so buyers beware. It's not always wounded pride as someone might think, there are some valid concerns like that it would end up with too many versions floating around, with one fixing bug A, another fixing bug B, and a third one fixing neither of them but adding another feature, and so on and so forth. See Android distributions for example. (Nope, this isn't Android bashing, just a statement of fact)

If you see an open source license which allows you to adapt and share, you're usually on the safe side because that means the author of the addon has given his permission in advance, given that you comply to the terms of the license, with the most likely terms to leave the license text itself intact as well as the original author names.

Atlan 06/05/17 06:16 AM

Quote:

Originally Posted by iwontsay (Post 31197)
there are some valid concerns like that it would end up with too many versions floating around

True. But we are talking about abandoned add-ons. The only two alternatives are patching or creating a new add-on with the same functionality.

Randactyl 06/05/17 09:40 AM

Quote:

Originally Posted by iwontsay (Post 31197)
If you see an open source license which allows you to adapt and share, you're usually on the safe side because that means the author of the addon has given his permission in advance, given that you comply to the terms of the license, with the most likely terms to leave the license text itself intact as well as the original author names.

Also, ESOUI policy is that if there is no explicit license, the site treats it as all rights reserved.

http://www.esoui.com/forums/showthread.php?t=2365


All times are GMT -6. The time now is 04:07 AM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2014 - 2022 MMOUI