ESOUI - ODD behaviour of rightclick menu

ESOUI (https://www.esoui.com/forums/index.php)

- General Authoring Discussion (https://www.esoui.com/forums/forumdisplay.php?f=174)

- - ODD behaviour of rightclick menu (https://www.esoui.com/forums/showthread.php?t=6583)

ODD behaviour of rightclick menu

as you can see on the video it started from
0:38
and few times later too

the rightclick menu immediatly dissapear if MY WEAPONS BLINKING

the blinking of weapons at hero doll is random, and i cannot figure out why it happening
i think it can be easy to repro as you can see
at least on my end lol

i dont think blinking is connected with addons, more likely its Zenimax thing.. or?
PS - only at crafting stations
PSS - same without any addon ON

way to repro
- open station
- rightclick on an item at ANY tab of it
- just wait, menu will dissapear when blink of weapons will happened

Quote:

Originally Posted by QuadroTony (Post 28636)

as you can see on the video it started from
0:38
and few times later too

the rightclick menu immediatly dissapear if MY WEAPONS BLINKING

the blinking of weapons at hero doll is random, and i cannot figure out why it happening
i think it can be easy to repro as you can see
at least on my end lol

i dont think blinking is connected with addons, more likely its Zenimax thing.. or?
PS - only at crafting stations

way to repro
- open station
- rightclick on an item at ANY tab of it
- just wait, menu will dissapear when blink of weapons will happened

Have you tried it with all addons disabled?

yes, ofcourse
its the same

blink = menu dissapear

The blink of the equipment is something that happens since the release of the game afaik.
It's connexted to an event if I remember right but I can't remember the exact event name.

Could be something like

Code:

EVENT_INVENTORY_SINGLE_SLOT_UPDATE

EVENT_ITEM_SLOT_CHANGED

Register a callback function to this even Toni, or some others about inventory items, and just do a debug message output like
d("Executed event EVENT_INVENTORY_SINGLE_SLOT_UPDATE")
and you might find out which one it is and report it to ZOs.

The disappearing context menu should be because of a usage of function "ClearMenu()" somewhere in the event's callback function (or functions used inside the callback function)

ok i will try
so you think it can be fixed by .lua way?
if its so, its good news

I think you need to contact ZOS about it.
I had the same wrong behaviour right now at a crafting station.
It looks like the shown items at the crafting station (for me it was a deconstruction panel -> all items shown there that i could deconstruct) were updted every x seconds by something.

And with every update the contxt menu was disapperaing, and the character items were blinking.

ok i reproted also on the official forum but im not sure it will be noticed

UPd
its not because of other players' buffs
i got it in locations without anyone nearby

Internal ZOs bug got raised.

Rawl'kha woodworking station is definitive special somehow. It happens really fast there.
I was at other stations for 30min without any issue and there it sometimes happens in a few seconds serveral times. Very crowded, vendor nearby.

It is caused by HandleInventoryChanged() line 23 in sharedcraftinginventory.lua due to an EVENT_INVENTORY_SINGLE_SLOT_UPDATE with reason INVENTORY_UPDATE_REASON_ITEM_CHARGE.

You may have to add a filter to INVENTORY_UPDATE_REASON_DEFAULT.

Code:

ZO_SmithingTopLevelDeconstructionPanelInventory:AddFilterForEvent(EVENT_INVENTORY_SINGLE_SLOT_UPDATE, REGISTER_FILTER_INVENTORY_UPDATE_REASON, INVENTORY_UPDATE_REASON_DEFAULT)

ZO_SmithingTopLevelImprovementPanelInventory:AddFilterForEvent(EVENT_INVENTORY_SINGLE_SLOT_UPDATE, REGISTER_FILTER_INVENTORY_UPDATE_REASON, INVENTORY_UPDATE_REASON_DEFAULT)

/edit: Of course this is done better in the init-code directly:

Code:

function ZO_SharedCraftingInventory:Initialize(control, slotType, connectInfoFn, connectInfoControl)

...



    local function HandleInventoryChanged()

        self:HandleDirtyEvent()

    end



    control:RegisterForEvent(EVENT_INVENTORY_FULL_UPDATE, HandleInventoryChanged)

    control:RegisterForEvent(EVENT_INVENTORY_SINGLE_SLOT_UPDATE, HandleInventoryChanged)

    control:AddFilterForEvent(EVENT_INVENTORY_SINGLE_SLOT_UPDATE, REGISTER_FILTER_INVENTORY_UPDATE_REASON, INVENTORY_UPDATE_REASON_DEFAULT)



...



end

Now the question is: Where do we have more EVENT_INVENTORY_SINGLE_SLOT_UPDATE handlers, which would benefit from a filter?

So this comes down to the fact that we were sending slot updates when any player's item charge changed, not just you. We'll be changing that to only send an event when your item charges change.

Quote:

Originally Posted by ZOS_ChipHilseberg (Post 28723)

So this comes down to the fact that we were sending slot updates when any player's item charge changed, not just you. We'll be changing that to only send an event when your item charges change.

This will fix so many issues I have seen since launch. :D

Quote:

Originally Posted by sirinsidiator (Post 28724)

This will fix so many issues I have seen since launch. :D

for example? just curious

Blinking character equipment borders, events called and firing without reason (and event_inventory_single_slot_update is called in 100 of addons!)