ESOUI - Update 2.5

Page 3 of 4

Show 60 post(s) from this thread on one page

ESOUI (https://www.esoui.com/forums/index.php)

- Tutorials & Other Helpful Info (https://www.esoui.com/forums/forumdisplay.php?f=172)

- - Update 2.5 (https://www.esoui.com/forums/showthread.php?t=6384)

sirinsidiator

08/01/16 01:40 PM

Quote:

Originally Posted by ZOS_ChipHilseberg (Post 27767)

Here's the updated docs for the next PTS update.

Any chance we can get an updated file for live? ;)

Weolo

08/01/16 02:40 PM

I just got in to the game and my addon is broken.
Something has changed with GetCharacterInfo(). It is not working the same way it was on PTS.

Lua Code:

local found = false
d("DEBUG currentId: "..GetCurrentCharacterId())
d("DEBUG num characters: "..tostring(GetNumCharacters()))
for i = 1, GetNumCharacters() do
  local name, gender, level, championRank, classId, raceId, alliance, id, locationId = GetCharacterInfo(i)
  d("DEBUG id="..tostring(id).." name="..zo_strformat("<<1>>",name))
  if id == GetCurrentCharacterId() then
    found = true
  end
end
d("DEBUG Found id="..tostring(found))

The above code is generating this. The ids are way too short and some of the ids are duplicated

Screenshot

I am investigating to see if I can fix it myself :(

Ayantir

08/01/16 02:43 PM

Just don't rush on maybe broken new things :)

Weolo

08/01/16 02:54 PM

Quote:

Originally Posted by Ayantir (Post 27908)

Just don't rush on maybe broken new things :)

I tested the hell out of it on PTS and even submitted bug reports. They changed it for go live.

This:

Lua Code:

local name, gender, level, championRank, classId, raceId, alliance, id, locationId = GetCharacterInfo(i)

Seems to now be this:

Lua Code:

local name, gender, level, classId, raceId, alliance, id, locationId = GetCharacterInfo(i)

championRank has gone.
I will adapt my addon but it will have properly broken it for anyone who patched and tried to use it :(

ZOS_ChipHilseberg

08/01/16 03:03 PM

Sorry about that, the fix made it impossible to populate champion rank and it didn't particularly make sense in the returns anyway so we ripped it out.

Weolo

08/01/16 03:10 PM

No problem.
I fixed my addon and because it now tidies itself up its all good.
Keep up the good work, love the game, love the API, loving your work ;)

Sounomi

08/01/16 04:27 PM

Just a heads up, it seems that calling "GetItemBoPTradeableDisplayNamesString" on an item that's not BoP Tradable will crash the client, even if you override it with your code. Discovered it while testing things on the PTS during maint and sent in a description about it with the crash report. Its bugged on live as well.

ZOS_ChipHilseberg

08/01/16 04:31 PM

Quote:

Originally Posted by Sounomi (Post 27912)

Thanks for the info.

Ayantir

08/02/16 09:16 AM

I randomly have this error on live for my char

Lua Code:

EsoUI/Ingame/HousingEditor/SharedFurnitureManager.lua:74: attempt to index a nil value
stack traceback:
    EsoUI/Ingame/HousingEditor/SharedFurnitureManager.lua:74: in function 'ZO_SharedFurnitureManager:CreateOrUpdateItemDataEntry'
    EsoUI/Ingame/HousingEditor/SharedFurnitureManager.lua:29: in function 'ZO_SharedFurnitureManager:OnSingleSlotInventoryUpdate'
    EsoUI/Ingame/HousingEditor/SharedFurnitureManager.lua:13: in function 'callback'
    EsoUI/Libraries/Utility/ZO_CallbackObject.lua:111: in function 'ZO_CallbackObject:FireCallbacks'
    EsoUI/Ingame/Inventory/SharedInventory.lua:109: in function 'OnInventorySlotUpdated'

You should disable the housing editor while it's still unfinished :)

Baertram

08/02/16 11:35 AM

Yep, makes sense :)
Got this error message as well after a reloadui. I was standing at the bank and was doing nothing. No new items in my bag or others removed.
So it seems to be randomly.

Quote:

Originally Posted by Ayantir (Post 27919)

I randomly have this error on live for my char

Lua Code:

EsoUI/Ingame/HousingEditor/SharedFurnitureManager.lua:74: attempt to index a nil value
stack traceback:
    EsoUI/Ingame/HousingEditor/SharedFurnitureManager.lua:74: in function 'ZO_SharedFurnitureManager:CreateOrUpdateItemDataEntry'
    EsoUI/Ingame/HousingEditor/SharedFurnitureManager.lua:29: in function 'ZO_SharedFurnitureManager:OnSingleSlotInventoryUpdate'
    EsoUI/Ingame/HousingEditor/SharedFurnitureManager.lua:13: in function 'callback'
    EsoUI/Libraries/Utility/ZO_CallbackObject.lua:111: in function 'ZO_CallbackObject:FireCallbacks'
    EsoUI/Ingame/Inventory/SharedInventory.lua:109: in function 'OnInventorySlotUpdated'

You should disable the housing editor while it's still unfinished :)

ZOS_ChipHilseberg

08/03/16 08:03 AM

We haven't been able to reproduce the housing error internally. Does anyone have insight on possible triggers or know roughly how often it occurs?

Ayantir

08/03/16 08:58 AM

It only happens after a reloadui.

It should be really in first ms of a reload.
I had this 10 times while standing in wayrest yesterday before hotfix while doing tests on addons.
I didn't changed anything in my inventory to have this (no item creation, update or durability, nothing).

Baertram

08/03/16 09:21 AM

Yes, the same here.

Just standing around testing my addons and doing a reloadui here and there.
The error message appeared 3/5 times then just directly after the reloadui.
No items were changed,no new items created, no items were mailed or destroyed.

It did not depend on the city where I was standing or if I was inside a bank or outside as it seems.

Quote:

Originally Posted by Ayantir (Post 27937)

sirinsidiator

08/03/16 11:09 AM

I don't have the error, but I also haven't reloaded my UI much.
Maybe you can just comment out line 12 and 13 in sharedfurnituremanager.lua for now and call it a day?

Sounomi

08/03/16 09:18 PM

Same here, pretty much only get it after I've reloaded the UI when working on add-ons.

Code:

local itemCache = self.furnitureCache[ZO_PLACEABLE_TYPE_ITEM]

local bag = itemCache[bagId]

Looking at the code, my guess is that its being executed before the self.furnitureCache is fully initialized. Perhaps a simple fix would simply be to check that variable to make sure its not nil before trying to do stuff with it.

Weolo

08/06/16 10:34 AM

Weird bug with GetNumCharacters()

I logged in to ESO
Started playing with one of my characters
GetNumCharacters() was returning 8
Grouped up with a friend and did some Thieves guild heists
Did a couple of /reloadui during this time
GetNumCharacters() ended up only ever returning 1

I had to log out to the character selection screen for it to start returning 8 again

Sounomi

08/06/16 07:15 PM

I've run into that problem too. After a UI reload, it'll just randomly start saying there's only one character. Using "GetCharacterInfo" at this point with any index except for "1" returns empty values as well.

votan

08/07/16 05:25 AM

Quote:

Originally Posted by Weolo (Post 28011)

I logged in to ESO
Started playing with one of my characters
GetNumCharacters() was returning 8
Grouped up with a friend and did some Thieves guild heists
Did a couple of /reloadui during this time
GetNumCharacters() ended up only ever returning 1

I had to log out to the character selection screen for it to start returning 8 again

The information is lost at the second "Player Activated". In both cases: Due to travel or reloadui.

And there is a little mistake in the ESOUIDocumentation.txt.
GetCharacterInfo does not return championRank anymore. The return value has been removed, but is still in the doc file.

Weolo

08/07/16 06:55 AM

Quote:

Originally Posted by votan (Post 28018)

And there is a little mistake in the ESOUIDocumentation.txt.
GetCharacterInfo does not return championRank anymore. The return value has been removed, but is still in the doc file.

Yeah I raised that in post #44 above in this thead.
championRank was remove when Shodow of the Hist hit live.
ESOUIDocumentation.txt was given to us prior to go live so it is a little out.

I think I will have to build my own workaround. Capture all of the GetCharacterInfo() data that I want on first load and then re-use that from then on.

ZOS_ChipHilseberg

08/08/16 12:00 PM

Quote:

Originally Posted by Weolo (Post 28021)

This is fixed, but won't be in until the next update.

All times are GMT -6. The time now is 05:10 AM.

Page 3 of 4

Show 60 post(s) from this thread on one page