ESOUI

ESOUI (https://www.esoui.com/forums/index.php)
-   Minion (https://www.esoui.com/forums/forumdisplay.php?f=183)
-   -   Minion resets settings and unable to update some addons (https://www.esoui.com/forums/showthread.php?t=6488)

ettavolt 08/28/16 03:40 AM

Minion resets settings and unable to update some addons
 
1 Attachment(s)
Thanks for Minion.jar!
Though I still want source code, because:
  • it always resets settings found in ${user.home} (you can see different ga_user_id) in attached archive. For me it looks like I always have to choose what and where to scan.
  • Always proposes to update same set of addons after if I click 'update' for them. You can see this in r1.log and r2.log for 'Guild Events Improved' and 'Sous chef fix…'.
Attachment 770
Of course I tried to destroy settings manually and launch again, but this doesn't help.

ettavolt 08/28/16 09:33 AM

Ok, after several hours of decompiling and debugging I found that:

gg.minion.util.ConfigurationManager#xmlConfig lacks encoding set. Thus it writes configuration in windows-125X encoding and if system's locale is not en last-data-refresh value will not conform to UTF-8 when read back on next start. Just configure it xmlConfig.setEncoding("UTF-8"); and it's ok. I guess this affects all languages were months names use non-ASCII characters.
Though I'd prefer to see a JAXB-based implementation. ;)

AddOns Librarian, SlightlyImprovedExperienceBar, SousChef, wykkydsOutfitter have version set on site, but not in TOC. Minion has no idea about version so it assumes last. It would be better to indicate something like 'no info' to hint user to manually reinstall.

AddOns SousChef and GuildEventsImproved have version mismatch between site and TOC. Minion autoupdates them, but TOC isn't change and on next data refresh Minion proposes update again.

Dolby 08/29/16 08:27 AM

Hi ettavolt,

Thank you for the detailed information. We are currently working on redoing the config management and even switching to json as well. I'll make sure our java programmer see's what you have uncovered with the encoding.

If there is a mis-match in toc/saved in config vs api Minion should update the AddOn. It doesn't re-check toc vs saved in config unless the detection data is reset though.

The last issue you brought up with the toc version vs api version, when Minion updates the AddOn it should update the version in the minion.conf and then it shouldn't re-updated it. I'm guessing because Minion is having trouble writing to your config its not doing that so then its re-downloading the addon again because the minion config wasn't updated with the latest version and file hash. So I would bet if we fixed the config issue this would be fixed for you.

ettavolt 08/30/16 11:29 AM

Quote:

Originally Posted by Dolby (Post 28213)
The last issue you brought up with the toc version vs api version, when Minion updates the AddOn it should update the version in the minion.conf and then it shouldn't re-updated it. I'm guessing because Minion is having trouble writing to your config its not doing that so then its re-downloading the addon again because the minion config wasn't updated with the latest version and file hash. So I would bet if we fixed the config issue this would be fixed for you.

Actually yes, when I manually 'fix' minion.xml it uses saved versions from config file and doesn't check TOCs.
So the real problem is encoding. Could you make a patch release for this before you refactor DOM-based configuration to POJO-based?

Dolby 09/05/16 10:07 AM

Hi


We have gone ahead and fixed the encoding issue with the xml config (I hope). Testing it here seems to be ok but I was hoping you could test it before we release it live?

You can download a snapshot of the new client (3.0.5) here: https://cdn.mmoui.com/minion/v3/Mini...configtest.exe . You'll want to remove the invalid date line from the minion.xml config if you haven't already. Start up Minion and you'll be prompted to go back to Minion 3.0.4, just skip that 'Update Later' and continue on.

ettavolt 09/05/16 09:35 PM

Works for ru_RU at least. Obviously it can't read badly encoded configuration of previous version, but doesn't break when writes new.

Dolby 09/06/16 09:37 AM

Thanks ettavolt,

I'll work on getting 3.0.5 released this week.


All times are GMT -6. The time now is 08:48 AM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2014 - 2022 MMOUI