ESOUI - 'wait()' for Elder Scrolls Online?

ESOUI (https://www.esoui.com/forums/index.php)

- Lua/XML Help (https://www.esoui.com/forums/forumdisplay.php?f=175)

- - 'wait()' for Elder Scrolls Online? (https://www.esoui.com/forums/showthread.php?t=6827)

'wait()' for Elder Scrolls Online?

How would I prevent a while loop from crashing the client?

I broke my gigantic loops into smaller pieces and then called them at intervals like this:

EVENT_MANAGER:RegisterForUpdate(addon.name, milliseconds, function() loop() end)

You get an (infinite) loop : You break the loop.

99.9% of loops crashing the client are bad codes and can be avoided by refactoring it, no need wait(), pause() or other sleep() you may know.

Quote:

Originally Posted by Ayantir (Post 29865)

You get an (infinite) loop : You break the loop.

99.9% of loops crashing the client are bad codes and can be avoided by refactoring it, no need wait(), pause() or other sleep() you may know.

Infinite loop just fixes the client. Crashing is done by for example creating/changing too many strings within one frame. The x86 client does not crash for that. And the keyword is not wait, but yield.
And he is not talking about infinite loop, but huge loop.

ESO can at least handle a loop of 500,000 iterations without being noticed by users if there's no output.. I know it, I did it.

I'd like to see the kind of loop requiring a pause in order to do this without the complaints of users having so many addons and after months of investigation by the author..

Here we have :

Quote:

Originally Posted by BrizonTG

How would I prevent a while loop from crashing the client?

No example, no code snippet, no addon mentionned and a user with a post count of #1.

It can be nothing and anything, and for me the best answer to "how to prevent a while loop from crashing the client" asked by a newbie is "BETTER CODING" , not

Lua Code:

EVENT_MANAGER:RegisterForUpdate(ADDON_NAME, 1, zo_callLater(control:SetHandler("OnUpdate", function() DoSomethingWeird() end, 1)))

It's disclose bad practices.

It's like when your grand'ma ask how to change a registry setting when she just bought Win10. The answer should be adapted. So Yes, the first answer can be accepted, but it's not (for my point of view) the best to give.

Quote:

Infinite loop just fixes the client

If Lua become unresponsive, C++ crash.

control:RegisterForUpdate and zo_callLater can be interesting but in the long list of things a addon author should use when writing their first addon .. they comes at the very end.

In some cases when I have an infinite loop (somehow) that shouldn't be there I"ll add a counter and break it if the counter is too high. That's just for debugging purposes though, and once I figure it out I remove it.

Lua Code:

-- First addon, just mess around and figuring out the API.
 
-- NOTICE: PLEASE SEE 'README.TXT' FOR INFORMATION REGARDING THIS ADDON, COMPLIANT TO
-- [url]https://account.elderscrollsonline.com/add-on-terms[/url]
 
local Addon = 
{
    name,
    inCombat,   
};
 
Addon.name = "test"
 
-----------------------------------------------------------------------------
-- Boilerplate Lua...
-- Here's  our hack to get the 'connect line' back...
 
local AddonManager = {};
function AddonManager:connect(f)
    EVENT_MANAGER:RegisterForEvent(Addon.name, EVENT_ADD_ON_LOADED, f);
end
 
function AddonManager:disconnect()
    EVENT_MANAGER:UnregisterForEvent(Addon.name, EVENT_ADD_ON_LOADED);
end
 
local CombatManager = {};
function CombatManager:connect(f)
    EVENT_MANAGER:RegisterForEvent(Addon.name, EVENT_PLAYER_COMBAT_STATE, f);
end
 
function warn(string)
    d(string);
end
 
function wait(time)
    local init = os.clock() / 100;
    repeat until (os.clock() / 100) > init + time;
end
 
local clock = os.clock
function sleep(n)  -- seconds
  local t0 = clock();
  while clock() - t0 <= n do end --os.clock isn't available, and this crashes anyway if we use GetTimeFromMilliseconds()
end
 
-----------------------------------------------------------------------------
local timer = 0;
local tldgui;   -- Make us our thing...
local lblcntr;
 
function OnPlayerCombatState(event, inCombat)
    if (inCombat ~= Addon.inCombat)
    then
        Addon.inCombat = inCombat;
        tldgui:SetHidden(not inCombat);
    end
    if (inCombat)
        then
            warn("Entering Combat...");
            while (inCombat) do
                timer = timer + 1;
                --if (timer > 0)
                --then
                    lblCounter:SetText("Counter: " .. timer);
                --else
                --  lblCounter:SetText("Entering Combat!");
                --end
                --wait(1); --???? Why is this invalid?
                --sleep();
            end
        else
            warn("Leaving Combat...");
            timer = 0;
    end
end
 
-- Borrowed from the tutorial, hate XML, rather do this.
function Addon:CreateGui()
    tldgui = GetWindowManager():CreateTopLevelWindow("tldgui");
    tldgui:SetDimensions(200, 100);
    tldgui:SetResizeToFitDescendents(true);
    tldgui:SetAnchor(CENTER, GuiRoot, CENTER, 0,0);
    tldgui:SetMovable(true);
    tldgui:SetMouseEnabled(true);
    
    local bdBackdrop = GetWindowManager():CreateControl("bdBackDrop", tldgui, CT_BACKDROP);
    bdBackDrop:SetEdgeColor(0.4,0.4,0.4);
    bdBackDrop:SetCenterColor(0.1,0.1,0.1);
    bdBackDrop:SetAnchor(TOPLEFT, tldgui, TOPLEFT, 0, 0);
    bdBackDrop:SetDimensions(200,100);
    bdBackDrop:SetAlpha(1);
    bdBackDrop:SetDrawLayer(0);
    
    lblCounter = GetWindowManager():CreateControl("lblCounter", tldgui, CT_LABEL)
    lblCounter:SetColor(0.8, 0.8, 0.8, 1);
    lblCounter:SetFont("ZoFontAlert");
    lblCounter:SetScale(1);
    lblCounter:SetWrapMode(TEX_MODE_CLAMP);
    lblCounter:SetDrawLayer(1);
    lblCounter:SetText("Click Counts: 0");
    lblCounter:SetAnchor(CENTER, GuiRoot, CENTER, 0,0);
    lblCounter:SetDimensions(100,25);
end
 
function Addon:Init()
    Addon:CreateGui();
    tldgui:SetHidden(true);
    Addon.inCombat = IsUnitInCombat("player");
    CombatManager:connect(OnPlayerCombatState);
    AddonManager:disconnect();
end
 
AddonManager:connect(Addon.Init);

There's a lot more problems than just wait() here, and I'm still figuring out the differences between ESO's Lua and the implementation of Lua I know.

Because there are events for entering and exiting combat. So trying to tie up the thread with sleeping is a bad idea.

there is no os library, and please use the BBCode to help .. you don't need to end your lines with ";" .. creating GUI should be done in XML not lua

When you don't know how to do.. a good thing is to look at others does.

Hi BrizonTG.
Did you read the getting started guide or followed any of the tutorials we have on our wiki? They should clear up some of your questions.

As for differences between ESO Lua and "normal" Lua, ESO uses a variation of Lua5.1 with only math, string and table + global functions + zos api available.