ESOUI

ESOUI (https://www.esoui.com/forums/index.php)
-   Tutorials & Other Helpful Info (https://www.esoui.com/forums/forumdisplay.php?f=172)
-   -   Update 4.0 (https://www.esoui.com/forums/showthread.php?t=7728)

Letho 04/21/18 05:23 AM

Quote:

Originally Posted by ZOS_ChipHilseberg (Post 34465)
The active skills were changed into single abilities with scaling behavior based on rank. This was to help with updating and maintaining these skills. I'll need to think about what it would mean to target specific ranks of these through APIs. I think it might mean adding rank parameters to a lot of the ability APIs. Which APIs are you using?

This is the best change that has ever been made since I was coding addons, awesome! It will make addon development so much easier for me. There is just one little grain of salt left: Can you add a field or a function that contains info wether the ability is a 'player owned' ability and additonally the base morph, morph a, morph b relations (e.g. 30244 being morph b, it should contain some info on which ability id is morph a and the base morph).

ArtOfShred 04/21/18 06:07 AM

Quote:

Originally Posted by Letho (Post 34486)
This is the best change that has ever been made since I was coding addons, awesome! It will make addon development so much easier for me. There is just one little grain of salt left: Can you add a field or a function that contains info wether the ability is a 'player owned' ability and additonally the base morph, morph a, morph b relations (e.g. 30244 being morph b, it should contain some info on which ability id is morph a and the base morph).

Morphs still have a different ID I believe. Just rank 1-4 for each were compressed into single id's.

Letho 04/21/18 07:01 AM

Quote:

Originally Posted by ArtOfShred (Post 34487)
Morphs still have a different ID I believe. Just rank 1-4 for each were compressed into single id's.

Yep, I understood that, makes sense since there are boss abilities, that do not have morphs ^^

What I meant is, that I'd like to have a field that allows me to link a specific abilityId to it's (base)-morph(s) IF it is morphable (= player owned?).

g4rr3t 04/23/18 04:03 AM

The unification of ability IDs is certainly useful for my application. Makes things much more streamlined only having to register callbacks or monitoring for a quarter of the number of IDs, but I can see how it may introduce a little more work for those who use the unique ranks in more meaningful ways. I'm a fan.

Can confirm that stack IDs (à la Grim Focus) also maintain the Rank I IDs. Haven't tested all ranks for any "gotchas" but at least all the ones I've tested have stacked against the Rank I ID.

Cheers.
G

ZOS_ChipHilseberg 04/23/18 08:16 AM

You can use GetSpecificSkillAbilityInfo to link up the morphs.

Gandalf 04/24/18 10:31 AM

On PTS the handling of buffs(effects) has changed.
The effent EVENT_EFFECT_CHANGED and ESO client BUFF&DEBUFF option don't show:

- RAPID_MANEUVER_ABILITY
- RETREATING_MANEUVER_ABILITY
- CHARGING_MANEUVER_ABILITY

anymore, instead the resulting buffs

- MAJOR_GALLOP
- MAJOR_EVASION

will be shown.

Is the this change on purpose and permanent?

Gandalf 04/24/18 11:04 AM

ESOUIDocumentationP18 2.txt
 
In ESOUIDocumentationP18 2.txt:
Code:

EVENT_ALLIANCE_POINT_UPDATE (*integer* _alliancePoints_, *bool* _playSound_, *integer* _difference_, *[CurrencyChangeReason|#CurrencyChangeReason]* _reason_)
has not changed for update 18.

But with Update 18 the alliance point gain (tick) will be advised when the player may already has moved to another zone.

Therefore:
Can this event be extended with an additional parameter for keep Id of tick?
This would allow to track the source (credit list) of the tick.


.

ZOS_ChipHilseberg 04/25/18 03:55 PM

Quote:

Originally Posted by Gandalf (Post 34525)
On PTS the handling of buffs(effects) has changed.
The effent EVENT_EFFECT_CHANGED and ESO client BUFF&DEBUFF option don't show:

- RAPID_MANEUVER_ABILITY
- RETREATING_MANEUVER_ABILITY
- CHARGING_MANEUVER_ABILITY

anymore, instead the resulting buffs

- MAJOR_GALLOP
- MAJOR_EVASION

will be shown.

Is the this change on purpose and permanent?

Yes, these were unified into specific buff types.

ZOS_ChipHilseberg 04/25/18 04:32 PM

Quote:

Originally Posted by Gandalf (Post 34527)
In ESOUIDocumentationP18 2.txt:
Code:

EVENT_ALLIANCE_POINT_UPDATE (*integer* _alliancePoints_, *bool* _playSound_, *integer* _difference_, *[CurrencyChangeReason|#CurrencyChangeReason]* _reason_)
has not changed for update 18.

But with Update 18 the alliance point gain (tick) will be advised when the player may already has moved to another zone.

Therefore:
Can this event be extended with an additional parameter for keep Id of tick?
This would allow to track the source (credit list) of the tick.


.

Yeah we can do something like that.

Letho 04/26/18 12:55 AM

Quote:

Originally Posted by ZOS_ChipHilseberg (Post 34506)
You can use GetSpecificSkillAbilityInfo to link up the morphs.

I see, thanks! As you said, all player ability ranks have been merged. How about boss abilities? There were some encounters (especially light guy and shadow dude [don't remember their names right now] in vMoL) where some buffs of the same type and name are given to different players using different abilityIDs. Have those use cases' ability ids been merged, too?

Gandalf 04/26/18 08:44 AM

Quote:

Originally Posted by ZOS_ChipHilseberg (Post 34532)
Yeah we can do something like that.

Thanks for the fast response and the clearification, I'm looking forward to see that extension!

Cheers,
Gandalf

sirinsidiator 04/30/18 01:17 PM

I tried to update Circonian's LibNotifications and noticed that NOTIFICATION_TYPE_GIFT is not defined, but is used in notifications_gamepad.lua and notifications_keyboard.lua. Not sure why it doesn't throw a lua error there, but when I copy the table into LibNotifications, it does exactly that:
Code:

user:/AddOns/LibNotification/LibNotification/LibNotification.lua:25: table index is nil
stack traceback:
    user:/AddOns/LibNotification/LibNotification/LibNotification.lua:25: in function '(main chunk)'

@Chip is this entry unused and should be removed, or is the constant just missing? And could you please make these tables global? The lib breaks on almost every update because it relies on the data in these two files. :(

ZOS_ChipHilseberg 04/30/18 01:56 PM

Quote:

Originally Posted by sirinsidiator (Post 34568)
I tried to update Circonian's LibNotifications and noticed that NOTIFICATION_TYPE_GIFT is not defined, but is used in notifications_gamepad.lua and notifications_keyboard.lua. Not sure why it doesn't throw a lua error there, but when I copy the table into LibNotifications, it does exactly that:
Code:

user:/AddOns/LibNotification/LibNotification/LibNotification.lua:25: table index is nil
stack traceback:
    user:/AddOns/LibNotification/LibNotification/LibNotification.lua:25: in function '(main chunk)'

@Chip is this entry unused and should be removed, or is the constant just missing? And could you please make these tables global? The lib breaks on almost every update because it relies on the data in these two files. :(

I'm looking at the latest code and I don't see any references to NOTIFICATION_TYPE_GIFT anywhere. They've all been split into RECEIVED, CLAIMED, and RETURNED variants.

We can make the table globals.

sirinsidiator 04/30/18 02:30 PM

Ok. That explains why I didn't see any errors. I don't have the latest code extracted yet. :o

Gandalf 05/09/18 07:35 AM

Quote:

Originally Posted by ZOS_ChipHilseberg (Post 34532)
Yeah we can do something like that.


Works like a charm, Thank you!


Just one additional question:

Pre Update 18, attack/defense tick have been granted for keep types:
- KEEPTYPE_ARTIFACT_KEEP
- KEEPTYPE_KEEP
- KEEPTYPE_OUTPOST
- KEEPTYPE_RESOURCE
- KEEPTYPE_TOWN

In update 18:
A keep and its resources will been treated as a super structure with a total of 4 credit(reward) list and
the lists will be cleared when the player is defending/attacking in another super structure. Probably when the player earns CURRENCY_CHANGE_REASON_KILL for kills/healing.

What is the handling for the other keep types (without super structure)? Will these credit list cleared as well when the player is active on another keep of the same type? E.g. Moving from one scroll temple to another?

Thanks,
Gandalf

ZOS_ChipHilseberg 05/09/18 11:10 AM

Quote:

Originally Posted by Gandalf (Post 34642)
Works like a charm, Thank you!


Just one additional question:

Pre Update 18, attack/defense tick have been granted for keep types:
- KEEPTYPE_ARTIFACT_KEEP
- KEEPTYPE_KEEP
- KEEPTYPE_OUTPOST
- KEEPTYPE_RESOURCE
- KEEPTYPE_TOWN

In update 18:
A keep and its resources will been treated as a super structure with a total of 4 credit(reward) list and
the lists will be cleared when the player is defending/attacking in another super structure. Probably when the player earns CURRENCY_CHANGE_REASON_KILL for kills/healing.

What is the handling for the other keep types (without super structure)? Will these credit list cleared as well when the player is active on another keep of the same type? E.g. Moving from one scroll temple to another?

Thanks,
Gandalf

Per the programmer responsible, you can have credit on one of each keep type, with the exception of resource keeps where you can have credit on 3 as long as they have the same parent keep.

Baertram 05/10/18 02:38 PM

Just a note about crafting functions which were global and removed now.
Old and removed:
Lua Code:
  1. function ZO_CraftingUtils_IsTraitAppliedToWeapons(traitType)
  2.     local traitCategory = GetItemTraitTypeCategory(traitType)
  3.     return traitCategory == ITEM_TRAIT_TYPE_CATEGORY_WEAPON
  4. end
  5.  
  6. function ZO_CraftingUtils_IsTraitAppliedToArmor(traitType)
  7.     local traitCategory = GetItemTraitTypeCategory(traitType)
  8.     return traitCategory == ITEM_TRAIT_TYPE_CATEGORY_ARMOR
  9. end

Replaced by:
ZO_CraftingUtils_GetSmithingFilterFromTrait(smithingResearchLineTraitInfo)

-> See file
/esoui/ingame/crafting/smithingresearch_shared.lua
-> function ZO_SharedSmithingResearch:Refresh()

e.g. used like this:
local expectedTypeFilter = ZO_CraftingUtils_GetSmithingFilterFromTrait(GetSmithingResearchLineTraitInfo(craftingType, researchLineIndex, 1))

Shinni 05/11/18 04:02 PM

Hey, I just wanted to ask if turning AddOutfitSlotPreviewElementToPreviewCollection private is a permanent change or if it is something temporary as in a past PTS with PreviewCraftItem?


All times are GMT -6. The time now is 11:29 PM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2014 - 2022 MMOUI