Thread Tools Display Modes
05/27/14, 01:27 AM   #1
Vuelhering
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 169
Well, here's a bit of an annoyance.


ZOS added the GetItemArmorType(link) and GetItemWeaponType(link), but that is quite incomplete compared to existing ItemFunctions(bag,slot).

Specifically, there's no way to tell what traits are on an item just using the link.

This matters a lot, because you also cannot call GetItemTrait(bag,slot) on an item in the loot window (e.g.).

So now we need something like GetItemTraitLink(link).

Anyone see a workaround to get trait info just from the info that can be gleaned from a link (or the loot window)?
  Reply With Quote
05/27/14, 09:38 AM   #2
ingeniousclown
AddOn Author - Click to view addons
Join Date: Feb 2014
Posts: 122
Originally Posted by Vuelhering View Post
Well, here's a bit of an annoyance.


ZOS added the GetItemArmorType(link) and GetItemWeaponType(link), but that is quite incomplete compared to existing ItemFunctions(bag,slot).

Specifically, there's no way to tell what traits are on an item just using the link.

This matters a lot, because you also cannot call GetItemTrait(bag,slot) on an item in the loot window (e.g.).

So now we need something like GetItemTraitLink(link).

Anyone see a workaround to get trait info just from the info that can be gleaned from a link (or the loot window)?
I don't think that means that the new functions are incomplete, it just means that the whole item API is just kinda... everywhere. I was pretty surprised when I first saw the announcement of the two new functions, as the new functions using ItemLink to get that info kind of clashes with the rest of the functions that use bagId and slotIndex.

As a result, it is easy to get all the necessary information of an item from the API if it exists in a bagId and slotIndex space. Is the loot window set in some temporary bag for the player, by chance? Like the guild bank? I'm guessing no, but it's worth asking.

I was under the impression that the community (more specifically, Aiiane I believe) had deciphered all the itemlink information, but the new functions almost seem to suggest that the information was in the itemLink the whole time. I kinda wanna research this more, but I don't even know if I'll remember any of this once I get home from work :P

But assuming what I said is true... all relevant information may be in the itemLink as one of the many optional variables... And if so, someone may need to write a library to parse out that information.
  Reply With Quote
05/27/14, 02:51 PM   #3
Vuelhering
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 169
Originally Posted by ingeniousclown View Post
I don't think that means that the new functions are incomplete, it just means that the whole item API is just kinda... everywhere. I was pretty surprised when I first saw the announcement of the two new functions, as the new functions using ItemLink to get that info kind of clashes with the rest of the functions that use bagId and slotIndex.

As a result, it is easy to get all the necessary information of an item from the API if it exists in a bagId and slotIndex space. Is the loot window set in some temporary bag for the player, by chance? Like the guild bank? I'm guessing no, but it's worth asking.

I was under the impression that the community (more specifically, Aiiane I believe) had deciphered all the itemlink information, but the new functions almost seem to suggest that the information was in the itemLink the whole time. I kinda wanna research this more, but I don't even know if I'll remember any of this once I get home from work :P

But assuming what I said is true... all relevant information may be in the itemLink as one of the many optional variables... And if so, someone may need to write a library to parse out that information.
Yeah, i was writing a library, but i think the link info is basically an item index that includes the item/trait into a database (different indices for same item with each trait), and [the link data contains] a bunch of info for the enchantment and style and level and quality. It seems odd that traits aren't there [in the link data instead of the item index], but I couldn't find them. It's possible it's a bit tag across 4 or 5 bits in the item index.

I definitely did a test where I made an item with and without a trait, and the data fields were identical, although iirc the item index was different.

Using a link allows it to work on basically all items since you can always get a link, but you can't always get a bag,slot. So it'll work in chat and loot bags.

Loot bags and even your equipped inventory are different (although you can use bag 0 for that) than bag,slot inventory. The get loot info api calls are highly different, and largely incomplete, compared to the inventory info stuff.

All they need to give us is a way to parse the raw tooltip data, before any addon made changes.

Last edited by Vuelhering : 05/27/14 at 04:37 PM. Reason: clarification on link data
  Reply With Quote
08/17/14, 03:03 PM   #4
Vuelhering
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 169
Originally Posted by Vuelhering View Post
It seems odd that traits aren't there [in the link data instead of the item index], but I couldn't find them. It's possible it's a bit tag across 4 or 5 bits in the item index.

Using a link allows it to work on basically all items since you can always get a link, but you can't always get a bag,slot. So it'll work in chat and loot bags.
Looks like 1.3 may have added all this to links!
  Reply With Quote

ESOUI » Developer Discussions » Lua/XML Help » get weapontype and armortype?


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off