Quantcast [open] FILTER_TYPE chat channel - ESOUI
Thread Tools Display Modes
03/17/18, 07:26 AM   #1
manavortex
 
manavortex's Avatar
AddOn Author - Click to view addons
Join Date: May 2014
Posts: 137
[open] FILTER_TYPE chat channel

Hello Chip,
could we get FILTER_TYPES for the different chat channels? That would make life easier for AddOns that parse chat input.

Thank you.
  Reply With Quote
03/18/18, 01:54 PM   #2
Baertram
 
Baertram's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 1,736
Yes, I definately second this request for several chat related addons which change the channel to speak on automatically.

Filtering Chat channels from npcs etc. Would speed up the events a lot imo.
  Reply With Quote
03/18/18, 02:44 PM   #3
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 1,101
I can see how filters make sense for combat and inventory events performance wise, as they are fired quite often, but chat events? I have never seen more than a handful in any given second? It shouldn't make any noticeable difference when you filter them in Lua compared to C. Still could be nice for completeness sake to have a filter type for them.
__________________
>siri.exe MyAddon
Does your addon work? [y/n] n
There is a typo in there.
  Reply With Quote
03/18/18, 02:50 PM   #4
Dolgubon
 
Dolgubon's Avatar
AddOn Author - Click to view addons
Join Date: Jan 2016
Posts: 310
Originally Posted by sirinsidiator View Post
I can see how filters make sense for combat and inventory events performance wise, as they are fired quite often, but chat events? I have never seen more than a handful in any given second? It shouldn't make any noticeable difference when you filter them in Lua compared to C. Still could be nice for completeness sake to have a filter type for them.
Clearly, you have never been in multiple trade guilds all doing an auction while being in Auridon when zone chat is debating politics.
  Reply With Quote
03/18/18, 02:54 PM   #5
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 1,101
Originally Posted by Dolgubon View Post
Clearly, you have never been in multiple trade guilds all doing an auction while being in Auridon when zone chat is debating politics.
I am in multiple trading guilds, but still wouldn't think about performance implications with that amount of chat messages...
__________________
>siri.exe MyAddon
Does your addon work? [y/n] n
There is a typo in there.
  Reply With Quote
03/18/18, 04:53 PM   #6
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2014
Posts: 1,022
I don't understand your request. There is already filters for chat.

What do you want to do?

And there is nothing about performance. When a lazy dev debugs 10k lines in 1 s, chat don't suffers that much. And I know you all do that.
__________________
Obsessive Compulsive Coder

My little french Guild: Cercle de l'Eveil
  Reply With Quote
03/19/18, 06:51 AM   #7
Baertram
 
Baertram's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 1,736
If there is no impact on performance I'm fine with just checking the event's callback function parameter (e.g. chat_channel_type).
I thought it's nice to do this on the C side if we e.g. do not want to have any of the NPC messages or zone messages within our addon, but just need to check the guild chat e.g.

@Ayantir
Ok, so where are those filters for the chat? Do they work liek the other event filters too?
  Reply With Quote

ESOUI » Developer Discussions » Wish List » [open] FILTER_TYPE chat channel

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off