Overriding default functions

[Bobby Blue]

Hi all,

I'm just trying to write a simple addon that inserts timestamps at the start of every chat message (I know, that's been done before, but I'm just trying to learn, so I thought I'd start with something small).

At this point, I'm trying to override SharedChatContainer:OnChatEvent:

function SharedChatContainer:OnChatEvent(event, formattedEvent, category)
    formattedEvent = GetTimestamp() .. formattedEvent           -- My code
    for i=1, #self.windows do
        if IsChatContainerTabCategoryEnabled(self.id, i, category) then
            self:AddEventMessageToWindow(self.windows[i], formattedEvent, category)
        end
    end
end

But that doesn't seem to work for some reason. The error I am getting is 'expecting function instead of nil', so I've already understood that the function is unable to access the Timestamps table. Why? Is there some way to work around this?

And yes, I do want to call the GetTimestamp() function, because I am formatting the result of ZO_FormatClockTime() before using it.

Thanks for your help and happy new year

[Baertram]

The function names are case sensitive:

* GetTimeStamp()
** _Returns:_ *id64* _timestamp_

You need to write "Stamp" with a capital S then.

Edit
ESOUIDocumentationP12.txt

[Bobby Blue]

Thanks, but I've defined my own GetTimestamp() function, which needs to be in the Timestamps table because I am also loading some saved variables in there.

function Timestamps.GetTimestamp()
    if Timestamps.Vars.TimeUseChannelColour then
        ...
    end
end

[Ayantir]

Plese.. just.. no.

• It has already being done
• Your code can't work right there
• Your code will break other addons potentially
• Hacking ESOUI Code for 1st addon is not good.. keep after after months of learnings.

[Bobby Blue]

Originally Posted by Ayantir Plese.. just.. no. It has already being done Your code can't work right there Your code will break other addons potentially Hacking ESOUI Code for 1st addon is not good.. keep after after months of learnings.

I mean, thanks for the feedback, but I have to say that that wasn't particularly helpful for me as I'm trying to learn about Lua. If you're going to criticise what I am trying to do, I'd appreciate it if you at least explain why so I can learn from it.

I've replied to each of your points in turn:

• It has already been done, but so far I have not found an addon that does just timestamps, which someone might want if they just want simple timestamps without giving their entire chat a makeover.
• Why can't my code work right there? That's what I was asking in the first place. What's the reason behind this not being able to work? I mean, if it straight up just doesn't work, I won't do it, but I want to know why so I can get better at Lua.
• How will it break other addons unless they're doing the exact same thing that I'm trying to do? All I've done is insert a little bit of text in front of the message that's gonna be displayed, all the rest is copy/pasted from the original code.
• Well I have to start somewhere, and this seemed like a simple enough thing to do. What sort of things should I focus on first, in your opinion?

I'm not trying to be aggressive or obnoxious, I just really want to learn, rather than be brushed off just because I'm new to Lua/coding addons.

[Ayantir]

The addon ChatStamp add a date stamp to the chat message.. but also pchat and maybe other addons..

by looking at ChatStamp code I would like to replace

function CS.addChatStamp()
    ...
    
    return chattime
        
end

by your Timestamps.GetTimestamp() code which should return the timestamp.



Your code can't work....
okayyyy now it can work because zos rewrited it because of gamepad chat made at last DLC, but for for 2 years, SharedChatContainer was local.



Your code will break other addons potentially ... because it's chat.. and chat is a UI space where all other addons fights each others. If you rewrite a function, consider another addon perhaps rewrite it also. or use it.. Having to deal when your addon can potentially conflicts wth others on your very first addon.. is not a good thing.



Hacking ESOUI Code for 1st addon is not good.. It's like you wanted to learn C by hacking the Linux Kernel before knowing few concepts that you learn after being a C-Guru for years.

Just do something easier.. or do this .. differently ?


It was just advices of an old coder.

ps:

function SharedChatContainer:OnChatEvent(event, formattedEvent, category)
        formattedEvent = Timestamps.GetTimestamp() .. formattedEvent           -- My code
        for i=1, #self.windows do
            if IsChatContainerTabCategoryEnabled(self.id, i, category) then
                self:AddEventMessageToWindow(self.windows[i], formattedEvent, category)
            end
        end
    end

[Bobby Blue]

Thanks

Had a look at ChatStamp (you were right, pretty much exactly the same as what I'm trying to make), and turns out that what they do is just use LibChat (which I didn't know existed :P) to insert the timestamp.

I think I'll try to finish my addon anyway just for my personal satisfaction, but if there's already an addon that does the exact same thing I may as well just not upload it. Thanks for your help.

[sirinsidiator]

Welcome Bobby Blue!
Don't mind Ayantir. He can be a bit harsh sometimes, but he usually has the best intentions.

As he has said, hooking into the chat is not the easiest topic to start, so I suggest you first read the Getting Started guide on the wiki and do the SimpleNotebook tutorial which explains most basics (the lazy bum author hasn't completed it though).

[Bobby Blue]

Thanks sirinsidiator
No worries, he explained his comments, so I'm quite happy with his response.