OnUpdate not working. D=

[InfiniteShift]

At the moment I'm just fiddling around, trying to set up a basic clock. I'm unsure of what I'm doing wrong here.

tkClock = tkUI.CreateText("tkClock", Guiroot) --CT_LABEL
tkClock:SetAnchor(TOPRIGHT,Guiroot,TOPRIGHT,-10,-5)
tkClock:SetHandler("OnUpdate", function() 
  tkClock:SetText(GetTimeString())
end)

[Sasky]

I think that OnUpdate would fire whenever your text field itself is updated. To have something update the clock periodically, try:

EVENT_MANAGER:RegisterForUpdate("tkClockUpdate", 1000, function()
    tkClock:SetText(GetTimeString())
end))

This will cause it to update text once per second (which is honestly all you really need to do for a clock)

[InfiniteShift]

Hmm I was under the impression that OnUpdate is something that got fired every frame.

[Harven]

Hey,
Your code should work, but make sure that the tkClock is visible (tkClock:SetHidden(false)). OnUpdate will not fire when the control is hidden.

[InfiniteShift]

It's not hidden. I added a few things to make sure.

tkClock = tkUI.CreateText("tkClock", Guiroot) --CT_LABEL
tkClock:SetAnchor(TOPRIGHT,Guiroot,TOPRIGHT,-10,-5)
tkClock:SetText("loaded") --To see if tkClock not hidden
tkClock:SetHidden(false)
tkClock:SetHandler("OnUpdate", function() 
  tkClock:SetText(GetTimeString())
end)

[Seerah]

1. It's GuiRoot, not Guiroot.
2. I don't recall 100%, but you may need to use the OnUpdate on a frame, not just on a label.
3. There was a bug back in beta that I don't think ever got fixed - your frame will not recognize an OnUpdate handler unless the frame was created via XML. (Try Sasky's method instead, or switch to XML - you're giving your frame a global name anyway.)

@Sasky: OnUpdate fires for every update of the UI (every frame draw).

@InfiniteShift: Because of the above, if you have 60 fps, your OnUpdate script will be run 60 times per second. You don't need your clock to be that precise. Use the second return from OnUpdate (or set a delay using the second arg of EVENT_MANAGER:RegisterForUpdate) to create a buffer.

[InfiniteShift]

Originally Posted by Seerah It's GuiRoot, not Guiroot. I don't recall 100%, but you may need to use the OnUpdate on a frame, not just on a label. There was a bug back in beta that I don't think ever got fixed - your frame will not recognize an OnUpdate handler unless the frame was created via XML. (Try Sasky's method instead, or switch to XML - you're giving your frame a global name anyway.) @Sasky: OnUpdate fires for every update of the UI (every frame draw). @InfiniteShift: Because of the above, if you have 60 fps, your OnUpdate script will be run 60 times per second. You don't need your clock to be that precise. Use the second return from OnUpdate (or set a delay using the second arg of EVENT_MANAGER:RegisterForUpdate) to create a buffer.

I was more or less trying to get the OnUpdate script to just work rather than being optimized.
So all frames not created by XML will not work with the OnUpdate handler? I guess that won't really matter with RegisterForUpdate in the event manager. Anyway, thanks.

[Sasky]

Originally Posted by Seerah @Sasky: OnUpdate fires for every update of the UI (every frame draw).

Got it. Never messed with every frame update since it's not really needed for most things.