[outdated] d() before chat is initialized

[sirinsidiator]

Please consider the following change to the chat system, in order to allow debug messages to be shown from before EVENT_PLAYER_ACTIVATED.

function SharedChatSystem:Initialize(control, platformSettings)
    self.cachedMessages = {}
...

function SharedChatSystem:AddMessage(text)
    if IsChatSystemAvailableForCurrentPlatform() then
        if(self.primaryContainer) then
            self.primaryContainer:AddDebugMessage(text)
        else
            self.cachedMessages[#self.cachedMessages + 1] = text
        end
    end
end

local function FlushMessageCache()
    for i = 1, #self.cachedMessages do
        self.primaryContainer:AddDebugMessage(self.cachedMessages[i])
    end
    self.cachedMessages = nil
end
 
local function OnPlayerActivated()
    playerActivated = true
    TryLoadingSettings()
 
    if IsChatSystemAvailableForCurrentPlatform() then
        if(not self.allowMultipleContainers) then
            self:RedockContainersToPrimary()
        end
 
        self:TryNotificationAndMailBursts()
 
        if(self.isAgentChatActive) then
            self.agentChatBurstTimeline:PlayFromStart()
        end
    else
        self.control:SetHidden(true)
    end
    FlushMessageCache()
end

[merlight]

The call to FlushCachedMessages should be in TryLoadSettings (after LoadChatFromSettings) so that it isn't called again. There's no need to call it again as long as primaryContainer exists, plus it will blow because you set the table to nil, and second call will try to iterate it. I'd set it to empty table to be safe.

[sirinsidiator]

Right. Maybe also add a callback/hookpoint when the primary container is ready and the messages have not yet been flushed in order to make it easier for pChat's history restore feature to print the old messages.