Go to Page... |
Compatibility: | Scions of Ithelia (9.3.0) Endless Archive (9.2.5) base-game patch (9.1.5) Necrom (9.0.0) Scribes of Fate (8.3.5) Firesong (8.2.5) Lost Depths (8.1.5) High Isle (8.0.0) |
Updated: | 03/11/24 09:42 AM |
Created: | 04/15/18 10:31 AM |
Monthly downloads: | 1,439 |
Total downloads: | 213,714 |
Favorites: | 102 |
MD5: | |
Categories: | Group, Guild & Friends, Homestead |
File Name |
Version |
Size |
Uploader |
Date |
2.3.15 |
417kB |
BoarGules |
12/29/23 08:40 AM |
|
2.3.14 |
417kB |
BoarGules |
08/21/23 10:33 AM |
|
2.3.13 |
417kB |
BoarGules |
08/07/23 02:03 PM |
|
2.3.10 |
412kB |
BoarGules |
08/22/22 03:02 PM |
Comment Options |
BoarGules |
View Public Profile |
Send a private message to BoarGules |
Send email to BoarGules |
Find More Posts by BoarGules |
Add BoarGules to Your Buddy List |
09/09/18, 03:57 AM | |
Fantastic! Thank you for the update, it's working quite nicely!
|
|
|
RavenMind |
View Public Profile |
Send a private message to RavenMind |
Send email to RavenMind |
Find More Posts by RavenMind |
Add RavenMind to Your Buddy List |
BoarGules |
View Public Profile |
Send a private message to BoarGules |
Send email to BoarGules |
Find More Posts by BoarGules |
Add BoarGules to Your Buddy List |
09/02/18, 01:31 PM | ||
@ ZOS_ChipHilseberg : Yes, I discovered that, but now I know when and how they change, and what to do about it. The bit I was missing was that they get completely reassigned after a guild membership change, but only until the next /reloadui, and which point they go back to mirroring 1..GetNumGuilds().
Thanks for the response.
Last edited by BoarGules : 09/02/18 at 02:10 PM.
|
||
|
BoarGules |
View Public Profile |
Send a private message to BoarGules |
Send email to BoarGules |
Find More Posts by BoarGules |
Add BoarGules to Your Buddy List |
08/23/18, 11:30 PM | |
@ BoarGules: I appreciate you taking the time to read all that! I realize it was a bit long-winded, and debated whether to delete the whole thing. I'm glad now I didn't, since it looks like it elicited a response from ZOS_ChipHilseberg. Hopefully his info will help you with whatever changes you decide to make.
@ ZOS_ChipHilseberg: Thank you very much for taking the time to respond! I believe the information you provided will be useful not only in this situation, but also to other addon authors who come across this thread. |
|
|
RavenMind |
View Public Profile |
Send a private message to RavenMind |
Send email to RavenMind |
Find More Posts by RavenMind |
Add RavenMind to Your Buddy List |
08/23/18, 03:31 PM | |
ZOS Staff!
Forum posts: 551
File comments: 7
Uploads: 0
|
Guild ids are a bit insidious. Whenever a player joins or drops a guild (whenever EVENT_GUILD_DATA_LOADED is sent), all guild ids are invalidated and you have to regrab them using GetGuildId(index). That also means the ids aren't stable so you can't store them. The most stable thing right now is probably the guild name. In the future we'll probably move toward having GetGuildId return a stable id.
|
|
ZOS_ChipHilseberg |
View Public Profile |
Send a private message to ZOS_ChipHilseberg |
Send email to ZOS_ChipHilseberg |
Find More Posts by ZOS_ChipHilseberg |
Add ZOS_ChipHilseberg to Your Buddy List |
08/23/18, 01:51 PM | ||
RavenMind,
Thank you for the friendly, detailed, thoughtful and extremely helpful defect report. I can see one issue straight off, which is that the code thinks guild numbers go from 1 to 5, maybe with gaps. I really wasn't aware they could go from 10 to 14. That in itself will break things, such as the build of the configuration screen (in BuildLAMPanel), and the /guildhall ? command. That assumption about numbering of guilds came straight from ZOS's own code (or so I thought: closer inspection suggests otherwise). So I will have to cast about for a more robust way to enumerate them. I'm glad you managed to solve the problem on your own (especially as you found the defect for me in the process), but I will have to fix this, even if it is now not urgent. If it happened to you it will sooner or later happen to someone else, and that someone else is unlikely to be as resourceful. Regards and thanks again
Last edited by BoarGules : 08/23/18 at 02:05 PM.
|
||
|
BoarGules |
View Public Profile |
Send a private message to BoarGules |
Send email to BoarGules |
Find More Posts by BoarGules |
Add BoarGules to Your Buddy List |
08/22/18, 12:32 AM | |
I'm now receiving a LUA error. I did drop two guilds, re-add one of them, and added a new one. Which changed the ordering of the guilds, if that even matters. Also the Settings menu has nothing in it now. I've reloaded UI, logged out, deleted savedvars, and logged back in, but am still getting the error. Full error indicates it may have a problem with one specific guild, but it may be it only triggers the first error it comes across then stops running the addon? IDK.
I'll try to look at the line myself & see what I can do, but I'm no coder and know nothing about LUA. Error: Code:
user:/AddOns/GuildHallButton/GuildHallButton.lua:503: attempt to index a nil value stack traceback: user:/AddOns/GuildHallButton/GuildHallButton.lua:503: in function 'BuildLAMPanel' user:/AddOns/GuildHallButton/GuildHallButton.lua:628: in function 'BuildLAM' user:/AddOns/GuildHallButton/GuildHallButton.lua:100: in function 'GuildHallButton:Initialize' user:/AddOns/GuildHallButton/GuildHallButton.lua:109: in function 'GuildHallButton.OnAddonLoaded'
Warning: Spoiler
user:/AddOns/GuildHallButton/GuildHallButton.lua:503: attempt to index a nil value
stack traceback: user:/AddOns/GuildHallButton/GuildHallButton.lua:503: in function 'BuildLAMPanel' LUA Code:
LUA Code:
LUA Code:
LUA Code:
Edit: Can't see a problem in the code. /guildhall ? does nothing. Doesn't bring up an "invalid command", as if it were an invalid command, and also doesn't return anything to the chat window. Interestingly trying /guildhall 1 @xxxxx brings up a message at the top-right, stating, "Command /guildhall 1 invalid: you do not have a guild numbered 1". In my Savedvars, (freshly created), I have Guild Halls: 1, 2, 3, 4, 5, 6, 10, 11, & 14. I don't know if that's indicative of anything, but thought I'd provide the info. Thanks! Edit-2: After some digging, I found my guild numbering has been thrown off somehow. Should be guilds 1, 2, 3, 4, 5. In that order, they are now guilds 10, 11, 12, 13, 14. After using "/gh 10 @xxxx" for each guilds, 10-14, the button now works fine. "/guildhall ?" still returns nothing, while mistyping such as /guildhall?, returns "Warning: Invalid chat command '/guildhall?'!" So while there's nothing wrong with the functionality of the button itself, I thought this was an interesting thing to have happen. Incidentally, after I manually set all guildhalls with the slash commands, and reloaded UI to save the variables, the settings menu is now populated. Also, no more LUA errors once manually configured! One more thing, I wanted to thank you for including that .pdf in the archive. Too few authors include ReadMe's or any documentation, so it's really appreciated that you did!! Update (Final, I think.): I logged out & went into the savedvars after having manually set the guildhalls. I renumbered the now-populated guilds 10-14 to 1-5, and deleted the old guilds 1-5. (oddly, guild 1 had been populated now..). Saved & logged in again. No LUA error, the button works on each guild, and I am not getting the correct return with the /guildhall ? command. Yay! I don't know if this is something you still want to look into. My suspicion is that it has to do with me having left 2 guilds, then rejoining 1 and adding another. *shrug* Instead of deleting this whole post, I've decided to leave it up, in-case it might be helpful to others who might have done something similar. Feel free to delete to tidy up the thread if you feel so inclined. Thanks for your time!
Last edited by RavenMind : 08/22/18 at 02:33 AM.
|
|
|
RavenMind |
View Public Profile |
Send a private message to RavenMind |
Send email to RavenMind |
Find More Posts by RavenMind |
Add RavenMind to Your Buddy List |
08/21/18, 04:44 PM | ||
|
||
|
TheYcUtS |
View Public Profile |
Send a private message to TheYcUtS |
Send email to TheYcUtS |
Find More Posts by TheYcUtS |
Add TheYcUtS to Your Buddy List |
08/21/18, 03:44 PM | ||
|
||
|
BoarGules |
View Public Profile |
Send a private message to BoarGules |
Send email to BoarGules |
Find More Posts by BoarGules |
Add BoarGules to Your Buddy List |
08/21/18, 02:40 PM | |||
|
|||
|
TheYcUtS |
View Public Profile |
Send a private message to TheYcUtS |
Send email to TheYcUtS |
Find More Posts by TheYcUtS |
Add TheYcUtS to Your Buddy List |
08/21/18, 02:04 PM | ||
Thanks for reporting this. Working on a fix. I understand from your report that (1) the error is in response to a button press, not a /gh command; (2) you are guild leader (3) the guild hall is not your house. This situation has been tested and was believed to work correctly. How have you configured Settings | Addons? There is already a drop-down list for the owner's name there and the traceback doesn't show that it has been set.
Last edited by BoarGules : 08/21/18 at 02:24 PM.
|
||
|
BoarGules |
View Public Profile |
Send a private message to BoarGules |
Send email to BoarGules |
Find More Posts by BoarGules |
Add BoarGules to Your Buddy List |
08/19/18, 02:12 AM | |
Awesome but
Code:
bad argument #1 to 'string.gsub' (string expected, got boolean) stack traceback: [C]: in function 'string.gsub' user:/AddOns/GuildHallButton/GuildHallButton.lua:307: in function 'GuildHallButton.GoToGuildhall' |caaaaaa<Locals> cmd = "", guild_id = 1, house_specified = false, leader_name = true, guild_name = "My Sweet Moon", house_override = "Earthtear Cavern" </Locals>|r user:/AddOns/GuildHallButton/GuildHallButton.lua:112: in function 'GuildHallButton.OnClicked' |caaaaaa<Locals> self = tbl, button = ud </Locals>|r GoToGuildHallButton_Clicked:2: in function '(main chunk)' |caaaaaa<Locals> self = ud, button = 1, ctrl = false, alt = false, shift = false, command = false </Locals>|r So if we edit JumpToSpecificHouse(leader_name, house_id or house_override) for non gleader name and hall, probably it's work... I mean try this after work.
Last edited by TheYcUtS : 08/19/18 at 09:45 PM.
|
|
|
TheYcUtS |
View Public Profile |
Send a private message to TheYcUtS |
Send email to TheYcUtS |
Find More Posts by TheYcUtS |
Add TheYcUtS to Your Buddy List |
08/18/18, 06:35 PM | |
Thank you for the update! This is one of those "quality of life" addons that I'd hate to go without!
|
|
|
RavenMind |
View Public Profile |
Send a private message to RavenMind |
Send email to RavenMind |
Find More Posts by RavenMind |
Add RavenMind to Your Buddy List |
07/06/18, 09:38 PM | ||
Re: Re: Great Idea ....
|
||
|
RavenMind |
View Public Profile |
Send a private message to RavenMind |
Send email to RavenMind |
Find More Posts by RavenMind |
Add RavenMind to Your Buddy List |