Quantcast
Download
(17 Kb)
Download
Updated: 09/12/19 08:54 AM
Pictures
File Info
Compatibility:
Scalebreaker (5.1.5)
Elsweyr (5.0.5)
Updated:09/12/19 08:54 AM
Created:02/27/19 08:40 AM
Monthly downloads:707
Total downloads:19,440
Favorites:40
MD5:
Bandits Loot Manager  Popular! (More than 5000 hits)
Version: 1.15
by: Hoft [More]
1.15
- Bandits options menu compatibility
- Bursar option fix for ornate shields, added other Bursar quests support

1.14
- Local settings fix

1.13
- Added subscriber bank support

1.12
- API update
- New filters
- New options
- Settings are now combination of account and character (read tooltip in up right corner)

1.11
- Depositing characer bound items fix: Thx to token419
- Added some useless filters: Thx to token419

1.10
- API update
- Menu update
- Move items algorithm improvement

1.9
- Lure filter fix

1.8
- Set items filter fix

1.7
- Unmark as junk fix
- Added additional filters

1.6
- Laundry fix
- Spell fix
- Added filters: Treasure/survey maps, Master writs, Trophy key/runebox fragments.
Archived Files (10)
File Name
Version
Size
Uploader
Date
1.14
17kB
Hoft
08/28/19 01:01 AM
1.13
16kB
Hoft
08/13/19 08:55 PM
1.12
16kB
Hoft
08/08/19 03:24 AM
1.11
14kB
Hoft
06/21/19 10:20 AM
1.10
13kB
Hoft
05/16/19 03:31 AM
1.9
13kB
Hoft
03/26/19 09:22 AM
1.8
13kB
Hoft
03/09/19 04:06 PM
1.7
13kB
Hoft
03/06/19 08:59 AM
1.6
13kB
Hoft
02/28/19 05:31 PM
1.5
13kB
02/27/19 08:40 AM


Post A Reply Comment Options
Unread 06/17/19, 10:16 AM  
dlrgames
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 28
Uploads: 1
Originally Posted by token419
Originally Posted by dlrgames
I don't have the addon set to do anything with any potions, but when visiting the bank the chat log is showing deposits of all Stamina & Magicka pots in the character inventory. It isn't actually moving anything to the bank, so it's just annoying clutter for now.
Are the potions it's showing the "Purple" quality ones that are "Crown" type potions? Usually acquired when leveling up? If so, can you hover your mouse over them and check if it says "Character Bound"?

If not, can you list the potions here, or take a screenshot?

If they are "Character Bound" that will be fixed once Hoft merges in my fixes, if not i'd like to identify them so i can fix that
No, they are just random potions picked up in the world. None are bound. I also have Crown items in inventory and they were not affected.

I'll try to get a list next time.
Report comment to moderator  
Reply With Quote
Unread 06/17/19, 05:15 AM  
token419

Forum posts: 0
File comments: 12
Uploads: 0
Also to summarize what i've fixed, and to group all the community feature requests/bugs into one post:

Fixed Bugs:
  1. There was a bug where when depositing/withdrawing items from the bank some items were being overlooked. This was because ESO actually has 2 banks, one standard bank, and one bank for ESO+ subscribers. I believe this is what Baratox / Jadex ran into when they described items not being pushed/pulled from bank properly in their comments. This will be resolved once my fixes are merged.
  2. There was a bug where "Character Bound" items were attempting to be pushed/pulled from the bank. I believe this is what Dirgames has ran into. This will be resolved once my fixes are merged.

Outstanding Bugs:
  1. Bergur is running into an issue where items are not being stacked when attempting to be added to the bank. There is a system in place currently that attempts to stack an item in the bank, and if the stack size would excede the maximum stack size, it attempts to simply place the item into a free slot. I believe this is what you are running into, where item's are not stacked, because it's trying to allocate a new space, but you do not have any free spaces. I run into a different manifestation of this, where when i do crafting writs, I get say 3 soul gems, and i have 200 in a full stack, it always pulls 3 from my full stack and puts them into the bank, leaving me with 2 stacks in my inventory I'm going to try to tackle this one soon and upgrade the current system, but its lower priority.
  2. Token419 is running into an issue where Unique item's are attempting to be pushed/pulled from the bank, even if the character currently has one in their inventory. This one will be difficult with the current systems, as there is no look ahead currently. I have some ideas on how to tackle this, by creating a shadow bank/inventory and applying the rules there first, then doing the actual moves, but haven't had time to implement. Also there are performance concerns with adding in another set of checks.

Feature Requests:
  1. baratox - Jycs - richo262 - token419: Would like more fine grained control of managing armor. I've briefly spoken to hoft about this, but he doesn't want to complicate the options. I'm going try to discuss this with him further in more detail though and explain some pain points and see if we can come to a resolution.
  2. token419: would like intricate's separated for more fine grain control of pushing/pulling from the bank. Currently they are listed in with filters that are more for junking items than saving, and they sell fast and are great for leveling alts.
  3. fioskal: - stock crafted pots. I agree with hoft's response that there are simply way too cleanly display all the crafted potion types. I would like this as well, to stock spellpower potions on my mag, and damage ones on my stam etc, but from what I can tell, ESO does not simply list the traits as individual entities, they use an equation to display a numerical value for all the traits. For reference I found this post on UESP about Item links, and specifically option 21 which is potion effects: https://en.uesp.net/wiki/Online:Item_Link, if you scroll down you can see how the potion effect value is created. Craftstore may have good insight into how to implement something like this, but from what i gather it wouldn't be visually clean. Perhapse i'll play with it sometime though and see if i can come up with something.
  4. kernkraft-3000: - wants keybind for marking items as junk. This should be somewhat easy to implement if Hoft will agree to it. If Hoft gives the go ahead, i'll try to take a look and see if we can come up with something. I'm still learning ESO stuff so it'll be good practice to have to make a keybind options setting For reference there was an addon called "Junkee" that did this as well as "Destroy" keybinds, since this is a loot manager afterall, and we don't want to be leaving treasure chests with only 1 item in them!!! It makes sense to add those keybinds into an options/keybinds screen.
Last edited by token419 : 06/17/19 at 05:27 AM.
Report comment to moderator  
Reply With Quote
Unread 06/17/19, 04:31 AM  
token419

Forum posts: 0
File comments: 12
Uploads: 0
Originally Posted by dlrgames
I don't have the addon set to do anything with any potions, but when visiting the bank the chat log is showing deposits of all Stamina & Magicka pots in the character inventory. It isn't actually moving anything to the bank, so it's just annoying clutter for now.
Are the potions it's showing the "Purple" quality ones that are "Crown" type potions? Usually acquired when leveling up? If so, can you hover your mouse over them and check if it says "Character Bound"?

If not, can you list the potions here, or take a screenshot?

If they are "Character Bound" that will be fixed once Hoft merges in my fixes, if not i'd like to identify them so i can fix that
Report comment to moderator  
Reply With Quote
Unread 06/16/19, 11:47 AM  
dlrgames
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 28
Uploads: 1
I don't have the addon set to do anything with any potions, but when visiting the bank the chat log is showing deposits of all Stamina & Magicka pots in the character inventory. It isn't actually moving anything to the bank, so it's just annoying clutter for now.
Report comment to moderator  
Reply With Quote
Unread 06/16/19, 04:27 AM  
token419

Forum posts: 0
File comments: 12
Uploads: 0
For anyone watching the thread, I've reached out to Hoft via PM and we've had dialog for a few days.

We now have the source on github and i'm going to be working to fix the issues I've identified.

I have also added in most of the feature requests other's/myself have had on my local copy and Hoft has agreed to accept most of them, so we should see those in the future as well.

The one's we haven't agreed upon, I am going to try to make convincing arguments, but can't guarantee anything. Hoft mainly does not want to clutter the UI which I also agree with, so I am going to see if i can visually present the additions without creating too much visual distraction, while maintaining Bandit's superior functionality.

The future is exciting
Report comment to moderator  
Reply With Quote
Unread 06/13/19, 05:13 PM  
token419

Forum posts: 0
File comments: 12
Uploads: 0
Originally Posted by token419
In the MoveItems function if you change to SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BANK, BAG_SUBSCRIBER_BANK) instead of SHARED_INVENTORY.bagCache[BAG_BANK] it lists the entire bank for ESO+ subscribers instead of just the first 200 items.

The edited line would look like this:
Code:
local BagCache={[BAG_BACKPACK]=SHARED_INVENTORY.bagCache[BAG_BACKPACK],[BAG_BANK]=SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BANK, BAG_SUBSCRIBER_BANK)}
.
This works for iteration of the bank items, however the itemlinks are not populating for all the items, which i belive to be on ZoS's end, which is causing the withdraw of items from the bank to fail since the checks are being made off itemlinks.

I'm still working on a way to implement iterating both banks, but i have to do some trials, so i'll come back and hammer more tomorrow
Report comment to moderator  
Reply With Quote
Unread 06/13/19, 03:05 PM  
token419

Forum posts: 0
File comments: 12
Uploads: 0
Originally Posted by token419
Originally Posted by token419
I ran into somewhat of a bug, the Purple potions that are "Character Bound" are trying to be deposited into the bank when they cannot be. I'm not sure if there is a flag, but if there is you may want to add an exclusion for "Character Bound" potions when trying to add them to the bank.
I was able to fix this by adding a GetItemLinkBindType check to the following line:
Code:
if not data.isJunk and not IsItemLinkStolen(itemLink) and not IsItemLinkCrafted(itemLink) and GetItemLinkBindType(itemLink) ~= BIND_TYPE_ON_PICKUP_BACKPACK then
However after the fix, i am still running into issues where some of my writs and surveys are not being pulled from the bank automatically, i do have a lot on my main crafter. Probably 80-100 of each.

I had assumed previously that it was getting stuck due to the character bound items, but i can validate that is not the case after the fix to ignore character bound items.
I think i found the source of the bug with items not being removed, or partially. I wrote in some debugging logic and found that only 200 slots of the bank were being checked for withdraw.

In the MoveItems function if you change to SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BANK, BAG_SUBSCRIBER_BANK) instead of SHARED_INVENTORY.bagCache[BAG_BANK] it lists the entire bank for ESO+ subscribers instead of just the first 200 items.

The edited line would look like this:
Code:
local BagCache={[BAG_BACKPACK]=SHARED_INVENTORY.bagCache[BAG_BACKPACK],[BAG_BANK]=SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BANK, BAG_SUBSCRIBER_BANK)}
However after correcting this, i am still not getting all my items automatically withdrawn from the bank, still digging to find the source of the bug.
Report comment to moderator  
Reply With Quote
Unread 06/05/19, 04:15 PM  
token419

Forum posts: 0
File comments: 12
Uploads: 0
Originally Posted by token419
I ran into somewhat of a bug, the Purple potions that are "Character Bound" are trying to be deposited into the bank when they cannot be. I'm not sure if there is a flag, but if there is you may want to add an exclusion for "Character Bound" potions when trying to add them to the bank.
I was able to fix this by adding a GetItemLinkBindType check to the following line:
Code:
if not data.isJunk and not IsItemLinkStolen(itemLink) and not IsItemLinkCrafted(itemLink) and GetItemLinkBindType(itemLink) ~= BIND_TYPE_ON_PICKUP_BACKPACK then
However after the fix, i am still running into issues where some of my writs and surveys are not being pulled from the bank automatically, i do have a lot on my main crafter. Probably 80-100 of each.

I had assumed previously that it was getting stuck due to the character bound items, but i can validate that is not the case after the fix to ignore character bound items.
Last edited by token419 : 06/05/19 at 08:31 PM.
Report comment to moderator  
Reply With Quote
Unread 05/25/19, 05:25 AM  
richo262

Forum posts: 0
File comments: 18
Uploads: 0
Originally Posted by token419
Awesome Addon, love all your work!

I ran into somewhat of a bug, the Purple potions that are "Character Bound" are trying to be deposited into the bank when they cannot be. I'm not sure if there is a flag, but if there is you may want to add an exclusion for "Character Bound" potions when trying to add them to the bank.

It creates no gameplay issues when it attempts to add the item, just gives the audio queue that the item cannot be added, and it is listed in the output log as being added.

A few requests possibly (I'd be more than willing to help with a pull request if you have a github or whatnot):
1: in the "Consumables" section, would it be possible to add an option for health potions as well?
2: In the "Recipes" section, would it be possible to separate "Treasure" maps from "Survey" maps?
2a: If you are able to separate, could you add a "Destroy" option for "Treasure" maps, possibly "Survey" maps as well?
3: In the "Items" section, separate "Items with Intricate trait" to be their own line option, and add option to push/pull from bank.
3: In the "Items" section, separate "Set Items" to be their own line option, and add option to push/pull from bank.

Again thanks for your work, love all your addons
2 and 2A is needed sooo badly, I asked for this and I was told to check 'tool tips' and that it was supported, cannot find it though. So far I've just had to rely on manually junking them as I go, but they do not vendor, so when inventory is reaching its limit I check junk and destroy them if any.
Last edited by richo262 : 05/26/19 at 07:45 AM.
Report comment to moderator  
Reply With Quote
Unread 05/23/19, 12:52 AM  
token419

Forum posts: 0
File comments: 12
Uploads: 0
Found another bug, if you have a "Treasure Map" in your inventory that you also have in the bank, the addon attempts to pull the treasure map from the bank, and then ceases to apply the other rules.

Example: I have a "Stormhaven Treasure Map 1" already on my character, and one in the bank. I have it set to also pull "Crafting Style Unknown" and "Recipe Unknown" and it's failing to pull some motifs and recipes that are unknown to that character.
Report comment to moderator  
Reply With Quote
Unread 05/22/19, 04:55 PM  
token419

Forum posts: 0
File comments: 12
Uploads: 0
Awesome Addon, love all your work!

I ran into somewhat of a bug, the Purple potions that are "Character Bound" are trying to be deposited into the bank when they cannot be. I'm not sure if there is a flag, but if there is you may want to add an exclusion for "Character Bound" potions when trying to add them to the bank.

It creates no gameplay issues when it attempts to add the item, just gives the audio queue that the item cannot be added, and it is listed in the output log as being added.

A few requests possibly (I'd be more than willing to help with a pull request if you have a github or whatnot):
1: in the "Consumables" section, would it be possible to add an option for health potions as well?
2: In the "Recipes" section, would it be possible to separate "Treasure" maps from "Survey" maps?
2a: If you are able to separate, could you add a "Destroy" option for "Treasure" maps, possibly "Survey" maps as well?
3: In the "Items" section, separate "Items with Intricate trait" to be their own line option, and add option to push/pull from bank.
3: In the "Items" section, separate "Set Items" to be their own line option, and add option to push/pull from bank.

Again thanks for your work, love all your addons
Report comment to moderator  
Reply With Quote
Unread 05/17/19, 06:27 AM  
richo262

Forum posts: 0
File comments: 18
Uploads: 0
Originally Posted by Hoft
>richo262
Can you just carefully read tooltips?

5. Nirnhoned and jewelry traits are saves.
6. Mark as junk/Unmark as junk are remembers. Each item have unique id. If you want to auto junk all items of specified type then you must mark as junk all of them (treasure maps or paintings, for example).
7. What? How can you import to current character from him self???

All are simple! Just take a time to understand. Detailed log may helps.
No more questions please, just read tooltips.
When you say tooltips, are you referring to the no information on this website? Or the no information presented in minion? Or the mouse over cursor that doesnt say anything about Nirn / Roe?

I can't find any information about treasure maps. It would be ideal for a button to autodestroy rather than having to pick them up, then manually junking each one in the game as you find them. It seems there are so many treasure maps in the game that you'd spend a year manually junking them all as you get them that it would result in it not being as convenient as it could be.
Report comment to moderator  
Reply With Quote
Unread 05/17/19, 02:31 AM  
Hoft
 
Hoft's Avatar
AddOn Author - Click to view AddOns

Forum posts: 16
File comments: 864
Uploads: 11
>richo262
Can you just carefully read tooltips?

5. Nirnhoned and jewelry traits are saves.
6. Mark as junk/Unmark as junk are remembers. Each item have unique id. If you want to auto junk all items of specified type then you must mark as junk all of them (treasure maps or paintings, for example).
7. What? How can you import to current character from him self???

All are simple! Just take a time to understand. Detailed log may helps.
No more questions please, just read tooltips.
Report comment to moderator  
Reply With Quote
Unread 05/16/19, 05:59 PM  
richo262

Forum posts: 0
File comments: 18
Uploads: 0
1) I can somewhat see a system that allows for holding onto Mag or Stam trashpots individually, no HP one. Which is fine, I don't really use them. So if I have it set to keep 150 potion/poisons then mark the rest as junk, it will keep only the one I have set to active under the Consumable tab? I assumed the Consumables tab was simply a menu for moving them between the bank / character. I was unaware it was the method of determining what of the 150 potions you wish to keep in the menu below it, what with the menus being separated. Edit: Nope, that's not it. No way to have mag toons junk hp / stam and stam toons to junk hp / mag.

3) I only have the option to bank or retrieve treasure maps, there is no destroy.

4) I see no specific list of items for provisioning, only destroy all non-purples. I also do not see it state that Gold (Perfect Roe) will be spared.

5) For traits I see either destroy (except jewelry) or bank/retrieve. I see nothing about sparing Nirnhoned traits, nor anything allowing me to add Arcane / Healthy / Robust dust.

6) If there is a memory system, there is no list of excluded items, or on / off button for it. It is somewhat risky to commit an item to destroy memory without a clear way of removing it from the exclusion list.

For 2, 4 and 5, is there intentionally no option for this and the reliance is on the memory system? That's great if it is, it just is not clear. If I junk one treasure map, do all treasure maps get junked going forward or do I have junk each type of treasure map for the memory to learn I want them all destroyed? It would be ideal to have a box to destroy all treasure maps rather than junking them all individually as you come across them.

I'm running version 1.10, most up to date on Minion, in case there is a more up to date version with the functionality you describe.
Last edited by richo262 : 05/26/19 at 09:26 AM.
Report comment to moderator  
Reply With Quote
Unread 05/16/19, 03:35 PM  
Hoft
 
Hoft's Avatar
AddOn Author - Click to view AddOns

Forum posts: 16
File comments: 864
Uploads: 11
Originally Posted by richo262
1,2,3,4,5,6,7
All of this are supported. *facepalm*
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: