Download
(34 Kb)
Download
Updated: 07/12/23 01:15 AM
Pictures
File Info
Compatibility:
Necrom (9.0.0)
Updated:07/12/23 01:15 AM
Created:03/08/21 06:02 AM
Monthly downloads:887
Total downloads:142,856
Favorites:191
MD5:
Categories:Character Advancement, TradeSkill Mods, Miscellaneous, Utility Mods
Jack of all Trades - Automatic CP Respec  Popular! (More than 5000 hits)
Version: 1.2.29
by: CyberOnEso, Kyzeragon

Automatically adjust your green champion bar depending on what you want to achieve

New with V.1.2 Adjust which slot each star gets slotted into.

Crafting
  • Automatically slots Master Gatherer and Plentiful Harvest when you start harvesting a crafting node.
  • Automatically slots Meticulous Disassembly when you start crafting, ensuring you always get optimal refining results!
  • Also works with the new deconstruction assistant.
Looting
  • Automatically slots Treasure Hunter, and Homemaker whenever you are looting the relevant container.
Fishing
  • Slots Reel Technique and Angler's Instincts whenever you start fishing.
Thieving
  • Slots Infamous whenever you interact with a fence, helping you always get the best selling price.
  • Slots Cutpurse's Art whenever you pickpocket someone.
Riding
  • Slots Gifted Rider and War Mount whenever you mount up!
Miscellaneous
  • Slots Professional Upkeep when you talk with a merchant, ensuring you always get your gear repaired for less!
  • Slots rationer whenever you switch quick slot slots!

Optional Features
  • Get a notification whenever any skill you wish to be notified of is slotted
  • Receive a warning message whenever you don't have enough points into a star for it to be automatically slotted
  • Disable automatically slotting any skill you wish
  • Change which slot any stars are slotted into.
  • Slot rationer whenever you port into nBRP.
  • A bunch more intricacies to customize it to your every desire.


Jack of all Trades addon will not respec your champion points, and will not charge you 3000 gold etc.
It will only equip the skills if you have enough points into them already.
It is intended to be a seamless quality of life improvement.

Full German, French, Russian and Spanish translations are available.
V 1.2.29
  • Fixed slotting for thieves troves. Thanks lancerchan!
V.1.2.28
  • Fixed error / interact CP not slotting for Necrom
  • I (@Kyzeragon) will be maintaining the addon to fix issues, so I most likely won't be adding new features unless ZOS adds new green CP
V.1.2.27
  • Added Japaneese translation. Massive thanks to Snorunt361!!
V.1.2.26
  • Fixed bug where Rationer and Liquid Efficency were not slotting in High Isle. Thanks Kyzeragon!
  • Fixed bug where harvesting water plants was not slotting Master Gatherer and Plentiful Harvest when playing in German. Thanks Schrappe!
V.1.2.25
  • Fixed bug where Treasure Hunrter was being slotted when interacting with crafting stations. Thanks Kyzeragon & Caaraamon
V.1.2.24
  • Added support for the deconstruction assistant. Thanks Kyzeragon
  • Improved robustness of the interact key text checking. Thanks to IsJustaGhost
V.1.2.23
  • Added toggle to automatically allocate points into stars, which is disabled by default. Thanks m-ree.
V.1.2.22
  • If you have the points to spare Jack of all Trades will slot the CP Star and all pre-requisite stars that are required to slot the star, whilst spending the minimum amount of points to do so. Real-world application of Dijkstra's algorithm!
  • Improved cooldown code to ensure that the cooldown is not set whilst assigning a start to a slot for the first time.
  • These features may cause issues as they can be kind of complex, if they cause any issues for you please let me know ASAP and I will try to fix it as soon as I can.
V.1.2.21
  • Fixed an issue where warning text would be shown in no- cp environments. Thanks Yoav!
V.1.2.20
  • API bumb to Deadlands
V.1.2.19
  • Major additions to the Spanish Translations! Thank you very much loneloba/ Inval1d for these, they are greatly appreciated.
  • Improved localization by adding more strings to language files.
V.1.2.18
  • Added a setting, which is enabled by default, to automatically slot Rationer when entering nBRP, to make sure you make the most out of your ult pots.
V.1.2.17
  • Fixed a bug where the treasure hunter CP would not get slotted when porting into a dungeon.
V.1.2.16
  • Fixed a bug where warning messages shown as an alert would cause an error. Thanks Yoav!
V.1.2.15
  • Added sustaining shadows to the menu to allow you to select where the skill should be slotted.
V.1.2.14
  • Added optional automatic slotting of Sustaining Shadows. Thank you A_Darklore for the suggestion!
  • Fixed an issue with the German client where the addon sometimes would not realise you had been collecting resources. Thank you Irniben!
  • API bump to Waking Flame
V.1.2.13
  • Fixed an issue where the folder was called JackOfAllTrades-main, this may cause unexpected side effects if it does please redownload it. Thank you Anceane!
V.1.2.12
  • Added a new sub- menu category for harvesting nodes. Thank you Sonwon!
V.1.2.11
  • Improved notifications by allowing users to select whether to show the notification/ warning as a top-right alert instead of in the chat. Thank you Saenic!
  • Added ability to remove the icon from notification if the user wishes.
V.1.2.10
  • API bumb to Blackwood
V.1.2.9
  • Fixed an issue where the Jack of all Trades CP cooldown would not be reset upon changing zones. Which it is. Thank you Kyzeragon!!
V.1.2.8
  • Added option to always post a notification when the CP cooldown ends. Thank you LoneStar2911!
V.1.2.7
  • Added additional French translations provided by Jakez31. Thank you very much!!
V.1.2.6
  • Added additional French translations provided by Jakez31. Thank you very much!!
  • Fixed a bug where "CP Cooldown complete" could show up multiple times. Thank you LoneStar2911!
  • Added localization support for more strings
V.1.2.5
  • Added the option to post a notification to chat when the cooldown is complete if you have disabled 'Automatically slotting stars after the cooldown ends' Thank you LoneStar2911!
  • Updated the menu text
V.1.2.4
  • Added menu option to enable automatically slotting treasure hunter (and homemaker if you have them as a pair) whenever you enter a dungeon. Thank you Cruxa
V.1.2.3
  • Fixed an issue where Gifted Rider and War Mount weren't working as intended. Thank you Provinzheld, FrostByghte and Baertram
V.1.2.2
  • Fixed how checking if you have the required amount of points is calculated. Thanks Baertram!
V.1.2.1
  • Fixed an issue that caused the cooldown to break, thus not allowing any stars to be slotted after an initial change, thanks Kyzeragon!
  • If you are experiencing any issues make sure you are not on V.1.2.0.
V.1.2.0
  • Added a menu option to change which skills will be slotted where.
  • Added riding stars (Gifted Rider and War Mount). These are disabled by default as I don't want to put people on cooldown too often. I still recommend you slot the movement speed passives in slot 1 and 2. But it's your call if you want to use them.
  • Fixed an issue that was causing the cooldown to not start if the CP was triggered by other addons. Thank you Kyzeragon!
V.1.1.19
  • Added a system that will ensure that pairs of passives are slotted correctly even if one is slotted in the intended slot of another.
V.1.1.18
  • Changed the priority of gathering passives to prioritize Plentiful Harvest.
  • I am going to work on a more robust system that will dynamically change the slotting of stars if you have them in the unintended order.
V.1.1.17
  • Will no longer slot Professional Upkeep if your repair cost is 0.
  • Fixed an issue causing notifications to not fully work as intended.
V.1.1.16
  • Gathering stars will no longer be slotted while in Stone Garden, as the gathering passives do not affect 'Gloomspore Agaric'. Thank you Scrofula!
V.1.1.15
  • Added the option to not Liquid Efficiency if the potion that is selected is a trash pot. Thank you Kyzeragon!
V.1.1.14
  • Will no longer slot treasure hunter when unlocking a door to a house, thanks NettleCarrier.
  • Fixed a bug where sometimes treasure hunter and homemaker slotting as a pair wasn't acting as intended. Thank you @DeadSoon!
  • Added more containers where homemaker should be slotted.
V.1.1.13
  • Added the option to disable slotting Meticulous Dissasembly whilst doing writs. Thank you gabbo1928.
V.1.1.12
  • Added the ability to disable automatically slotting queued skills after the cooldown ends. Thank you Cruxa for the suggestion
  • Changed Plentiful Harvest to slot 4 as it is the more important of the two. (Master Gatherer will now be slotted in slot 3)
V.1.1.11
  • Improved the fix substantially, should now only put the user on cooldown when they modify the hotbar.
V.1.1.10
  • Provided a temporary fix for overly aggressive cooldown blocking, if you disable the 'Show alert when attempting to slot CP on cooldown' box in the menu you will be able to use the less aggressive cooldown blocking. Thank you Kyzeragon
V.1.1.9
  • Added Russian translations, thank you Lyniss!
  • Added the option for Treasure Hunter and Homemaker to be slotted as a pair. Thank you Scrofula!
  • Fixed an issue where Liquid Efficiency wasn't being slotted as intended, also added the options for Liquid Efficiency to the menu
V.1.1.8
  • Added liquid efficency. Thank you Lumber!
  • Fixed an issue where CP stars would occasionally be reslotted if you already had them slotted.
  • When you are on CP cooldown a more helpful cooldown text will be shown in the top right, rather than in chat.
V.1.1.7
  • Rationer will not only be slotted when switching to a food/ drink item. Thank you FormlessOne
  • Added more lootables for homemaker to slot with, added the German translations for all homemaker lootables. Thank you @DeadSoon!
  • Gathering stars will not be slotted when looting Psijic Portals anymore. Thank you M-ree!
V.1.1.6
  • Fixed an issue where gathering stars would be slotted when looting corpses on occasion.
V.1.1.5
  • Professional upkeep will no longer be slotted when talking to Nuzhimeh
  • Attempted to fix the bug where notification messages would not be correct. Please let me know if the notification messages are still sometimes incorrect.
V.1.1.4
  • Fixed a bug that caused CP stars to not be correctly slotted
V.1.1.3
  • Added an option to disable homemaker when looting corpses (On by default)
  • Fixed the bug where Rationer would be slotted regardless of if you disabled it.
  • Fixed the bug where the notification would sometimes not post when a skill is slotted
V.1.1.2
  • Added togglable to show/ hide the default ZOS Alert Text when you attempt to slot CP whilst on cooldown
  • Will send a notification when the skill is actually slotted if a skill gets queued to be slotted in X seconds.
  • Fixed spelling issue on the CP cooldown text
V.1.1
  • Rewrote the addon from scratch to allow it to obey the 30-second cooldown on changing CP's
  • The addon will now only slot skills in the 3rd and 4th slot on your champion bar. This allows you to keep slots 1 and 2 the same, I suggest you slot 'Steed's Blessing' and 'Gifted Rider' in slots 1 and 2.
Optional Files (0)


Archived Files (49)
File Name
Version
Size
Uploader
Date
1.2.28
34kB
Kyzeragon
06/11/23 02:18 PM
1.2.27
34kB
CyberOnEso
01/22/23 02:31 PM
1.2.26
30kB
CyberOnEso
06/21/22 04:31 AM
1.2.25
30kB
CyberOnEso
03/30/22 12:26 PM
1.2.24
30kB
CyberOnEso
03/30/22 10:34 AM
1.2.23
30kB
CyberOnEso
12/25/21 02:52 PM
1.2.22
29kB
CyberOnEso
12/24/21 02:21 PM
1.2.21
28kB
CyberOnEso
11/06/21 01:33 PM
1.2.20
28kB
CyberOnEso
10/31/21 03:58 PM
1.2.19
29kB
CyberOnEso
10/23/21 01:55 PM
1.2.18
27kB
CyberOnEso
10/16/21 06:20 PM
1.2.17
27kB
CyberOnEso
09/17/21 07:48 PM
1.2.16
27kB
CyberOnEso
09/09/21 04:37 AM
1.2.15
27kB
CyberOnEso
08/25/21 05:42 AM
1.2.14
27kB
CyberOnEso
08/24/21 04:43 AM
1.2.13
27kB
CyberOnEso
06/19/21 08:52 AM
1.2.12
27kB
CyberOnEso
06/19/21 06:15 AM
1.2.11
26kB
CyberOnEso
06/14/21 05:18 PM
1.2.10
25kB
CyberOnEso
06/01/21 06:46 PM
1.2.9
25kB
CyberOnEso
05/07/21 05:01 AM
1.2.8
25kB
CyberOnEso
04/23/21 06:18 PM
1.2.7
25kB
CyberOnEso
04/18/21 03:22 PM
1.2.6
24kB
CyberOnEso
04/18/21 05:16 AM
1.2.5
23kB
CyberOnEso
04/17/21 10:47 AM
1.2.4
23kB
CyberOnEso
04/10/21 06:22 AM
1.2.3
23kB
CyberOnEso
04/02/21 07:13 AM
1.2.2
23kB
CyberOnEso
03/25/21 06:07 PM
1.2.1
23kB
CyberOnEso
03/23/21 02:13 AM
1.2.0
23kB
CyberOnEso
03/22/21 05:50 PM
1.1.19
21kB
CyberOnEso
03/20/21 06:59 AM
1.1.17
21kB
CyberOnEso
03/19/21 06:11 PM
1.1.16
21kB
CyberOnEso
03/19/21 06:18 AM
1.1.15
21kB
CyberOnEso
03/18/21 07:24 PM
1.1.14
21kB
CyberOnEso
03/18/21 10:27 AM
1.1.13
21kB
CyberOnEso
03/17/21 12:04 PM
1.1.12
21kB
CyberOnEso
03/17/21 10:37 AM
1.1.11
20kB
CyberOnEso
03/17/21 05:48 AM
1.1.10
20kB
CyberOnEso
03/17/21 05:23 AM
1.1.9
20kB
CyberOnEso
03/16/21 10:40 AM
1.1.8
20kB
CyberOnEso
03/15/21 05:54 PM
1.1.7
20kB
CyberOnEso
03/14/21 07:55 AM
1.1.6
19kB
CyberOnEso
03/13/21 03:36 PM
1.1.5
19kB
CyberOnEso
03/12/21 04:49 PM
1.1.4
19kB
CyberOnEso
03/12/21 11:36 AM
1.1.3
19kB
CyberOnEso
03/12/21 10:54 AM
1.1.2
18kB
CyberOnEso
03/11/21 05:13 AM
1.1.1
178kB
CyberOnEso
03/10/21 08:50 AM
1.0.1
362kB
CyberOnEso
03/08/21 09:51 AM
1
362kB
CyberOnEso
03/08/21 06:02 AM


Post A Reply Comment Options
Unread 03/17/21, 12:18 PM  
FormlessOne
 
FormlessOne's Avatar

Forum posts: 1
File comments: 19
Uploads: 0
I have to say, I'm lovin' this add-on. Thanks for taking the time to write & publish this one.
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 12:05 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Originally Posted by gabbo1928
Would it be possible to add an option to NOT slot Meticulous Disassembly when you interact with a crafting table with an active writ quest? I never break down or refine while doing writs, but I do loot containers, pickpocket, and harvest nodes I pass by in the process and I frequently run into issues where I'm on cooldown from having swapped in M.D. when I'm trying to do something else. Thanks!
Hey'a, thank you for the suggestion. I have added this with V.1.1.13. It should be live very soon!
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 11:00 AM  
gabbo1928

Forum posts: 0
File comments: 13
Uploads: 0
Would it be possible to add an option to NOT slot Meticulous Disassembly when you interact with a crafting table with an active writ quest? I never break down or refine while doing writs, but I do loot containers, pickpocket, and harvest nodes I pass by in the process and I frequently run into issues where I'm on cooldown from having swapped in M.D. when I'm trying to do something else. Thanks!
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 10:54 AM  
Cruxa

Forum posts: 0
File comments: 3
Uploads: 0
Re: Re: Hotbar queue

Originally Posted by CyberOnEso
I have implemented all of this with V.1.1.12, there is now an option in the cooldown menu.
V.1.1.12 should be live very soon
Awesome! Thanks a lot for your work and the fast implementation! I'm eagerly awaiting version 12, then this addon should be near perfect (or as perfect as it can be, with the stealth cooldown addition ).
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 10:41 AM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Hotbar queue

Hello, thank you for your suggestions

Originally Posted by Cruxa
Could you please add an additional setting, so that skills that can't be slotted due to being on cooldown are not slotted at all instead of slotted after the cooldown ends? (and thereby change the chat warning from "Homemaker will be slotted in 20 seconds" to "Homemaker can be slotted in 20 seconds").
I have implemented all of this with V.1.1.12, there is now an option in the cooldown menu.
V.1.1.12 should be live very soon

And a less important point: In a previous update, it was preferably slot 4 that was changed, now it is slot 3, even if the option to slot treasure hinter and homemaker as a pair is disabled. Could you change it back to prefer slot 4 when slotting a single skill only? Else I need to change the ordering of master gatherer and plentiful harvest again, so master gatherer is the one to be preferably replaced (and plentiful harvest kept).
I have reversed the order of the gathering stars, this should fix this issue.

If you have any more issues please do let me know.

Many thanks.
Last edited by CyberOnEso : 03/17/21 at 10:42 AM.
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 10:03 AM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Re: Re: Re: Hotbar queue

Originally Posted by Azmodan
Originally Posted by CyberOnEso
It slots when you change to a food/ drink item via the quickslot menu.
Ah, now I understand, thank you. It works via the quickslot menu.
Usually I eat in the inventory, cos it is not so much quickslots and I have them full. ))
Ahh, that's a good point. I will look at seeing if I can add the skill when you eat the food.

My apologies.
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 09:52 AM  
Azmodan

Forum posts: 0
File comments: 33
Uploads: 0
Re: Re: Re: Hotbar queue

Originally Posted by CyberOnEso
It slots when you change to a food/ drink item via the quickslot menu.
Ah, now I understand, thank you. It works via the quickslot menu.
Usually I eat in the inventory, cos it is not so much quickslots and I have them full. ))
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 08:42 AM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Re: Hotbar queue

Originally Posted by Azmodan
Hi,
Very useful addon, thank you.
How rationeer is slotting? I am eating food and it never slots. I have stage 1 in it. English client.
It slots when you change to a food/ drink item via the quickslot menu. This is because slotting the star when you eat the food won't be fast enough to give you the buff (probably).
Ensure that you have autoslotting of the passive enabled in the menu. I will look into it to ensure it is slotting correctly.

Edit: I have checked on my end and it does seem to be slotting correct. Can I ask you to check if you are using the latest update. If the issue persists please do let me know!

Thank you very much
Last edited by CyberOnEso : 03/17/21 at 09:34 AM.
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 08:32 AM  
Azmodan

Forum posts: 0
File comments: 33
Uploads: 0
Re: Hotbar queue

Hi,
Very useful addon, thank you.
How rationeer is slotting? I am eating food and it never slots. I have stage 1 in it. English client.
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 08:08 AM  
Cruxa

Forum posts: 0
File comments: 3
Uploads: 0
Hotbar queue

Could you please add an additional setting, so that skills that can't be slotted due to being on cooldown are not slotted at all instead of slotted after the cooldown ends?

A scenario I frequently encounter: I gather mats and in the meantime also open treasure chests and loot containers. Normally master gatherer and plentiful harvest are slotted. When I encounter a treasure chest with a backpack nearby, I loot the chest (slotting treasure hunter), then the backpack, then go back to mats gathering. What the addon does: When I loot the backpack it tries to slot Homemaker, and then puts it in the queue to be slotted in about 20 seconds. When the cooldown ends, Homemaker is slotted, but in the meantime I'm way past any container and long back to mat farming. Only now it tries to slot plentiful harvets, but that now takes another 30 seconds due to the useless slotting of Homemaker. So please, make it an option to disable queuing of skill slotting (and thereby change the chat warning from "Homemaker will be slotted in 20 seconds" to "Homemaker can be slotted in 20 seconds"). In the current implementation it happens way too frequently (with other skills as well) that a skill is slotted I maybe needed 20 seconds ago, but not anymore. Instead I might need another skill, which takes 30 more seconds to be slotted due to this.

And a less important point: In a previous update, it was preferably slot 4 that was changed, now it is slot 3, even if the option to slot treasure hinter and homemaker as a pair is disabled. Could you change it back to prefer slot 4 when slotting a single skill only? Else I need to change the ordering of master gatherer and plentiful harvest again, so master gatherer is the one to be preferably replaced (and plentiful harvest kept).

Edit: Oh, and btw, slotting homemaker and treasure hunter in a pair is not enough to solve my problem. I want to go back to gathering mats immediately (and not when the previous cooldown is over), so I prefer to keep 3 of the skills slotted, so I at least keep plentiful harvest while being on cooldown due to treasure hunter.
Last edited by Cruxa : 03/17/21 at 08:15 AM.
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 05:50 AM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
With V.1.1.11 the cooldown should function much better. Only putting you on cooldown when you modify you Champion Bar, not your champion points.
And will always allow you to modify your champion point allocation regardless of cooldown.

Thank you very much for letting me know Kyzeragon!
Last edited by CyberOnEso : 03/17/21 at 05:52 AM.
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 05:35 AM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Re: Cooldown when not actually on cooldown

Originally Posted by CyberOnEso
Originally Posted by Kyzeragon
Hi, Jack of all Trades is being too aggressive in blocking CP changes when it thinks the user is on cooldown, when showCooldownError == false. The showCooldownError setting seems to just... not be working correctly, from a user perspective. The text for the setting says "Show alert when attempting to slot CP on cooldown" which suggests to me that it only affects the textual display.

However, the code does this:
Code:
if JackOfAllTrades.isOnCooldown then 
    ZO_Alert(ERROR, SOUNDS.GENERAL_ALERT_ERROR ,"You are on cooldown, please try again in ".. currentCPCooldown .. " seconds.")
    if JackOfAllTrades.savedVariables.showCooldownError then 
        return false
    else
        return true 
    end
end
Which shows the alert anyway, and showCooldownError being false makes the prehook return true. Returning true in ZO_PreHook stops the original function from running. I'm not sure if this is what you intend to happen. It could be argued that actively blocking the purchase request is helpful for the user because it doesn't clear all your pending changes, but if that's what you're trying to avoid, then I would prefer to at least have a setting for toggling that behavior, or have cooldown blocking that's not so aggressive.

There are in fact purchase requests that will NOT be affected by the cooldown, especially if no slottables are even being changed. Jack of all Trades prevents me from using my CP presets that ONLY change the points, not the slottables, more than once every 30 seconds. It even prevents me from saving often while manually allocating CP. This is what I mean:
1. Make sure you have a couple unallocated points available
2. Add a point into a random star
3. Confirm
4. Add a point into a random star
5. Confirm
6. Notice that Jack of all Trades blocks this action, saying that you are on cooldown
7. Disable Jack of all Trades and repeat the steps above. You will see that this sequence is normally allowed, so Jack of all Trades is actually obstructing normal use of the CP system
And of course, all this is with showCooldownError = false.
Hey'a, thank you for letting me know.

I am going to work on getting that fixed ASAP.

Sadly the changes to the CP cooldown (regarding not putting you on cooldown when you only change point allocation) is something that wasn't present in the version that was pushed to live in 6.3.5, but something that was changed with 6.3.6 or 6.3.7. In 6.3.5 reallocating points and not changing your CP hotbar would still put you on cooldown. Since the change is not documented anywhere on ZOS's side I am just guessing into exactly how the cooldown works. As they do not give us access to it.

The pre hook is intended to return true to block the original error message and stop the points from being reallocated.

I will modify the prehook to only return true and the user to only be on cooldown if the user modifies the CP hotbar.

Thank you for letting me know. Though with this change not being documented we are still guessing into exactly how the cooldown works. And I feel I have seen the cooldown go into effect when I wasn't expecting it to, even after 6.3.7.
I have pushed a temporary fix with V.1.1.10. If you disable 'Show alert when attempting to slot CP on cooldown' it will always return false and use the more relaxed cooldown settings. I am currently trying to find a way to get the less restrictive cooldown. And only set the user on cooldown when they change the hotbar.
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 02:12 AM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Cooldown when not actually on cooldown

Originally Posted by Kyzeragon
Hi, Jack of all Trades is being too aggressive in blocking CP changes when it thinks the user is on cooldown, when showCooldownError == false. The showCooldownError setting seems to just... not be working correctly, from a user perspective. The text for the setting says "Show alert when attempting to slot CP on cooldown" which suggests to me that it only affects the textual display.

However, the code does this:
Code:
if JackOfAllTrades.isOnCooldown then 
    ZO_Alert(ERROR, SOUNDS.GENERAL_ALERT_ERROR ,"You are on cooldown, please try again in ".. currentCPCooldown .. " seconds.")
    if JackOfAllTrades.savedVariables.showCooldownError then 
        return false
    else
        return true 
    end
end
Which shows the alert anyway, and showCooldownError being false makes the prehook return true. Returning true in ZO_PreHook stops the original function from running. I'm not sure if this is what you intend to happen. It could be argued that actively blocking the purchase request is helpful for the user because it doesn't clear all your pending changes, but if that's what you're trying to avoid, then I would prefer to at least have a setting for toggling that behavior, or have cooldown blocking that's not so aggressive.

There are in fact purchase requests that will NOT be affected by the cooldown, especially if no slottables are even being changed. Jack of all Trades prevents me from using my CP presets that ONLY change the points, not the slottables, more than once every 30 seconds. It even prevents me from saving often while manually allocating CP. This is what I mean:
1. Make sure you have a couple unallocated points available
2. Add a point into a random star
3. Confirm
4. Add a point into a random star
5. Confirm
6. Notice that Jack of all Trades blocks this action, saying that you are on cooldown
7. Disable Jack of all Trades and repeat the steps above. You will see that this sequence is normally allowed, so Jack of all Trades is actually obstructing normal use of the CP system
And of course, all this is with showCooldownError = false.
Hey'a, thank you for letting me know.

I am going to work on getting that fixed ASAP.

Sadly the changes to the CP cooldown (regarding not putting you on cooldown when you only change point allocation) is something that wasn't present in the version that was pushed to live in 6.3.5, but something that was changed with 6.3.6 or 6.3.7. In 6.3.5 reallocating points and not changing your CP hotbar would still put you on cooldown. Since the change is not documented anywhere on ZOS's side I am just guessing into exactly how the cooldown works. As they do not give us access to it.

The pre hook is intended to return true to block the original error message and stop the points from being reallocated.

I will modify the prehook to only return true and the user to only be on cooldown if the user modifies the CP hotbar.

Thank you for letting me know. Though with this change not being documented we are still guessing into exactly how the cooldown works. And I feel I have seen the cooldown go into effect when I wasn't expecting it to, even after 6.3.7.
Last edited by CyberOnEso : 03/17/21 at 04:57 AM.
Report comment to moderator  
Reply With Quote
Unread 03/17/21, 01:45 AM  
Kyzeragon
 
Kyzeragon's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 268
Uploads: 8
Cooldown when not actually on cooldown

Hi, Jack of all Trades is being too aggressive in blocking CP changes when it thinks the user is on cooldown, when showCooldownError == false. The showCooldownError setting seems to just... not be working correctly, from a user perspective. The text for the setting says "Show alert when attempting to slot CP on cooldown" which suggests to me that it only affects the textual display.

However, the code does this:
Code:
if JackOfAllTrades.isOnCooldown then 
    ZO_Alert(ERROR, SOUNDS.GENERAL_ALERT_ERROR ,"You are on cooldown, please try again in ".. currentCPCooldown .. " seconds.")
    if JackOfAllTrades.savedVariables.showCooldownError then 
        return false
    else
        return true 
    end
end
Which shows the alert anyway, and showCooldownError being false makes the prehook return true. Returning true in ZO_PreHook stops the original function from running. I'm not sure if this is what you intend to happen. It could be argued that actively blocking the purchase request is helpful for the user because it doesn't clear all your pending changes, but if that's what you're trying to avoid, then I would prefer to at least have a setting for toggling that behavior, or have cooldown blocking that's not so aggressive.

There are in fact purchase requests that will NOT be affected by the cooldown, especially if no slottables are even being changed. Jack of all Trades prevents me from using my CP presets that ONLY change the points, not the slottables, more than once every 30 seconds. It even prevents me from saving often while manually allocating CP. This is what I mean:
1. Make sure you have a couple unallocated points available
2. Add a point into a random star
3. Confirm
4. Add a point into a random star
5. Confirm
6. Notice that Jack of all Trades blocks this action, saying that you are on cooldown
7. Disable Jack of all Trades and repeat the steps above. You will see that this sequence is normally allowed, so Jack of all Trades is actually obstructing normal use of the CP system
And of course, all this is with showCooldownError = false.
Report comment to moderator  
Reply With Quote
Unread 03/16/21, 09:20 PM  
satoi

Forum posts: 0
File comments: 7
Uploads: 0
crafting stations in housing

Hi,

your Addon is really indispensable!

Is there a possibility to add disassembly for housing crafting stations in the addon? That would be great.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: