DungeonHistory : Miscellaneous : Elder Scrolls Online AddOns

Changelog for Version 1.1.1

Fixed an issue where an error message would be displayed due to string formatting of dungeon names on non-English ESO clients

Changelog for Version 1.1.0

Added a ComboBox Filter for the ScrollList.
Added Stats (Total Dungeons, Dungeon Counter, Last Counter reset on) to the GUI.
Added a Reset Dungeon Counter Button
Added a EditBox (Notepad) to the GUI.
Added slash command (/dherasealldata) to delete all data stored in the SavedVariables table.
Updated to the API Version 101042

Changelog for Version 1.0.5

Fixed an issue where an Error Message would be displayed if LibAddonMenu-2.0 wasn't installed.

Changelog for Version 1.0.4

Changed the default Date Format of the GUI to d/m/Y.
Added an optional AddOn Settings Menu with LibAddonMenu-2.0.
Added a Setting to the AddOn Menu to toggle the Date Format of the GUI between d/m/Y and m/d/Y.
Added a new slash command (/dhdateformat) to toggle the Date Format between d/m/Y and m/d/Y.

Changelog for Version 1.0.3

Fixed an issue where the AddOn just recorded one Dungeon per session.

Changelog for Version 1.0.0 - 1.0.2

First Release.
Minor bug fixes and cleanup.

Optional Files (0)

Archived Files (1)

File Name	Version	Size	Uploader	Date
DungeonHistory	1.0.5	6kB	oInsideOut	05/27/24 10:17 AM

Comment Options

06/12/24, 11:21 AM

oInsideOut

Forum posts: 0

File comments: 5

Uploads: 1

Originally Posted by crysis992

Originally Posted by oInsideOut

Originally Posted by crysis992

Can't get this to work, every time I finish a random vet dungeon following error pops up:

Code:

user:/AddOns/DungeonHistory/DungeonHistory.lua:131: attempt to index a nil value
stack traceback:
user:/AddOns/DungeonHistory/DungeonHistory.lua:131: in function 'DungeonHistory.StartDungeon'

Hey, thanks for reporting the error.

I assume you are not playing ESO in English, because I was able to reconstruct this error message by changing the language in ESO from English US to German.

The error occurs because ESO adds an article to the front of some dungeon names when translating it into German. By calling the GetUnitZone() function the dungeon name is output with a "translation" suffix of control characters (e.g. ^fd,in). The problem now is that the dungeon names are saved without their definitive article or control character suffix in the SavedVariables file/table but are searched for with the control character suffix.

I will release an update that should fix this issue, however I have only tested it for the German language as it is very time consuming to test it for every other language myself.

I know there are better ways to address this issue which I might implement in the future.

If you still get the error, please let me know and also tell me which language you are playing in.

It's working now, thanks for the fast update.

Any chance to add group members in a future update? Like the Raidificator addon for raids, that shows all group members with their @userid and class icon for that run when hovering over an entry.

Nice, I'm glad to hear.

I was already thinking about adding and tracking more information.
Sounds like a good idea to get some extra information when hovering an entry.
Like last time someone suggested an idea, I'll keep it in mind and eventually add it when I find the time and motivation.

06/12/24, 04:15 AM

crysis992

Forum posts: 2

File comments: 63

Uploads: 0

Originally Posted by oInsideOut

Originally Posted by crysis992

Can't get this to work, every time I finish a random vet dungeon following error pops up:

Code:

user:/AddOns/DungeonHistory/DungeonHistory.lua:131: attempt to index a nil value
stack traceback:
user:/AddOns/DungeonHistory/DungeonHistory.lua:131: in function 'DungeonHistory.StartDungeon'

Hey, thanks for reporting the error.

I assume you are not playing ESO in English, because I was able to reconstruct this error message by changing the language in ESO from English US to German.

The error occurs because ESO adds an article to the front of some dungeon names when translating it into German. By calling the GetUnitZone() function the dungeon name is output with a "translation" suffix of control characters (e.g. ^fd,in). The problem now is that the dungeon names are saved without their definitive article or control character suffix in the SavedVariables file/table but are searched for with the control character suffix.

I will release an update that should fix this issue, however I have only tested it for the German language as it is very time consuming to test it for every other language myself.

I know there are better ways to address this issue which I might implement in the future.

If you still get the error, please let me know and also tell me which language you are playing in.

It's working now, thanks for the fast update.

Any chance to add group members in a future update? Like the Raidificator addon for raids, that shows all group members with their @userid and class icon for that run when hovering over an entry.

06/08/24, 06:08 PM

oInsideOut

Forum posts: 0

File comments: 5

Uploads: 1

Originally Posted by crysis992

Can't get this to work, every time I finish a random vet dungeon following error pops up:

Code:

user:/AddOns/DungeonHistory/DungeonHistory.lua:131: attempt to index a nil value
stack traceback:
user:/AddOns/DungeonHistory/DungeonHistory.lua:131: in function 'DungeonHistory.StartDungeon'

Hey, thanks for reporting the error.

I assume you are not playing ESO in English, because I was able to reconstruct this error message by changing the language in ESO from English US to German.

The error occurs because ESO adds an article to the front of some dungeon names when translating it into German. By calling the GetUnitZone() function the dungeon name is output with a "translation" suffix of control characters (e.g. ^fd,in). The problem now is that the dungeon names are saved without their definitive article or control character suffix in the SavedVariables file/table but are searched for with the control character suffix.

I will release an update that should fix this issue, however I have only tested it for the German language as it is very time consuming to test it for every other language myself.

I know there are better ways to address this issue which I might implement in the future.

If you still get the error, please let me know and also tell me which language you are playing in.

06/08/24, 05:40 AM
crysis992 Forum posts: 2 File comments: 63 Uploads: 0	Can't get this to work, every time I finish a random vet dungeon following error pops up: Code: user:/AddOns/DungeonHistory/DungeonHistory.lua:131: attempt to index a nil value stack traceback: user:/AddOns/DungeonHistory/DungeonHistory.lua:131: in function 'DungeonHistory.StartDungeon'

05/27/24, 07:45 AM

oInsideOut

Forum posts: 0

File comments: 5

Uploads: 1

Re: Awesome!

Originally Posted by ChrisK

Thanks for sharing your Addon, oInsideOut! It's really useful - especially the duration column.

Thank you for the Feedback!
I'm glad that the AddOn is of help to you.

05/27/24, 07:22 AM
ChrisK Forum posts: 0 File comments: 177 Uploads: 0	Awesome! Thanks for sharing your Addon, oInsideOut! It's really useful - especially the duration column.

05/23/24, 12:23 PM

oInsideOut

Forum posts: 0

File comments: 5

Uploads: 1

Originally Posted by Cheshire

Hi, I have an idea, how about adding stats on how many times cleared dungeon? For example, you are farming style mask and already lost count.... and then it finally drops and you want to know how many times you have completed this dungeon

Hey.
Thank you for the suggestion. Actually the purpose and reason I started developing this AddOn is to keep track of how many Dungeons I've completed before I drop a mask.

Sounds like a good idea to add more stats or something like a tracker. I'll keep that in mind and eventually add it when I find the time and motivation.

05/23/24, 10:35 AM
Cheshire Forum posts: 1 File comments: 18 Uploads: 0	Hi, I have an idea, how about adding stats on how many times cleared dungeon? For example, you are farming style mask and already lost count.... and then it finally drops and you want to know how many times you have completed this dungeon

05/21/24, 05:49 AM

oInsideOut

Forum posts: 0

File comments: 5

Uploads: 1

Originally Posted by Baertram

Welcome to ESO addon development.

A hint: All variables you declare in lua are global (accessible by other addons and overwriting existing variables), unless you add a local up in front.
To minimize compatibilty issues and pollution of the global namespace (table _G):

If you create an addon with an UI (like your scrolllist in XML, using variable DungeonHistoryXML as a global container), but you already got a global table (DungeonHistory) you could simply add a sub-table DungeonHistory.XML= {} (adding all variables and UI related functions to that)
instead of defining another 2nd global DungeonHistoryXML.

To speed-up the reference and make it easy to access them in your code you can add a local reference like local DungeonHistoryXML = DungeonHistory.XML at the top, below defining DungeonHistory.XML = {}
This will make your code below (in the same lua file) work the same as of before, only using the local reference, pointing to the global table DungeonHistory.XML (instead of a 2nd global variable DungeonHistoryXML).
-> Only in your XML files you'd need to change DungeonHistoryXML to DungeonHistory.XML as the variable DungeonHistoryXML would be local now, and not global anymore.

It's no "Must do it like that" but a best practice.

First of all thank you for taking the time to glance through my spaghetti code.

That makes a lot of sense. I will adapt my code to your suggestion.

Last edited by oInsideOut : 05/21/24 at 06:28 AM.

05/21/24, 04:57 AM
Baertram Super Moderator Forum posts: 5050 File comments: 6111 Uploads: 78	Welcome to ESO addon development. A hint: All variables you declare in lua are global (accessible by other addons and overwriting existing variables), unless you add a local up in front. To minimize compatibilty issues and pollution of the global namespace (table _G): If you create an addon with an UI (like your scrolllist in XML, using variable DungeonHistoryXML as a global container), but you already got a global table (DungeonHistory) you could simply add a sub-table DungeonHistory.XML= {} (adding all variables and UI related functions to that) instead of defining another 2nd global DungeonHistoryXML. To speed-up the reference and make it easy to access them in your code you can add a local reference like local DungeonHistoryXML = DungeonHistory.XML at the top, below defining DungeonHistory.XML = {} This will make your code below (in the same lua file) work the same as of before, only using the local reference, pointing to the global table DungeonHistory.XML (instead of a 2nd global variable DungeonHistoryXML). -> Only in your XML files you'd need to change DungeonHistoryXML to DungeonHistory.XML as the variable DungeonHistoryXML would be local now, and not global anymore. It's no "Must do it like that" but a best practice. Last edited by Baertram : 05/21/24 at 05:02 AM.

Compatibility:	Gold Road (10.0.0)
Updated:	06/08/24 07:01 PM
Created:	05/21/24 04:32 AM
Monthly downloads:	1,072
Total downloads:	1,077
Favorites:	2
MD5:
Categories:	Miscellaneous, Data Mods, Group, Guild & Friends, Info, Plug-in Bars, UI Media