Download
(5 Kb)
Download
Updated: 11/04/17 08:23 AM
Pictures
File Info
Compatibility:
Clockwork City (3.2)
Updated:11/04/17 08:23 AM
Created:03/06/15 10:21 AM
Monthly downloads:73
Total downloads:50,084
Favorites:92
MD5:
Categories:Discontinued & Outdated, Beta-version AddOns
CritPercent  Popular! (More than 5000 hits)
Version: 4
by: Garkin, Ayantir
Adds percentual crit chance to set bonus description.

Original text:
(2 items) Adds 648 Weapon Critical.

Modified text:
(2 items) Adds 648 (3.09%) Weapon Critical.



This addon also defines new slash command:
/crit <rating>

It will convert given rating to the percentual critical chance for the current character level and CP level


Known bugs:
- If the new description has more lines then original, creator name and flavor text won't be correctly formatted (especially visible with french client)
v4
- API Bump

v3
- API Bump
- Modified few things for being compatible with One Tamriel tooltips

v2
- API Bump (Both compatible with Live & PTS)
- Removed a forgotten debug for french users

v1
- API Bump (Both compatible with Live & PTS)
- Reduced french format of Critical stat in order to have better tooltips

v0.9
- Crit is now displayed on Poisons (not in all cases for now)
- Fixed bug with set items which had their 1st bonus duplicated
- Fixed bug with potions which had their 1st bonus duplicated in case of scaling in one of their bonus
- Fixed bug with worn items which had their 1st bonus duplicated in case of costume / polymorph helmet hidden

v0.8
- API Bump (Both compatible with Live & PTS)

v0.7
- API Bump
- Code little bit modified to handle new features at Craft station

v0.6
- added support for crafting result tooltips

v0.5
- addon now updates tooltip only when needed
- fixed items with flavor text (such as "This necklace was found in the ancient temple of the Scaled Court, Sanctum Ophidia.")

v0.4a
- fixed duplicate line for crafted items

v0.4
- added support for potions and other consumables in bag (quick slot tooltip won't show precentage, as I have no idea how to get item link for item in quick slot)

v0.3
- added support for comparative tooltips
- slightly changed way how set bonus lines are detected, so it should now work with addons which modifies tooltip header lines
- slightly changed new bonus lines layout, so it should work better with french client, however it still does not play nice with crafter name. I will fix it when I find out why I'm getting anchor error when I touch that line.

v0.2
- first public release
- added support for more tooltip methods

v0.1
- first version, more like proof of concept
Optional Files (0)


Archived Files (12)
File Name
Version
Size
Uploader
Date
3
5kB
Ayantir
10/26/16 07:28 PM
2
4kB
Ayantir
09/05/16 08:45 AM
1
4kB
Ayantir
06/30/16 09:54 AM
0.9
4kB
Ayantir
06/11/16 11:31 AM
0.8
4kB
Ayantir
05/12/16 07:49 AM
0.7
4kB
Ayantir
03/07/16 07:03 PM
0.6
4kB
Garkin
03/25/15 07:18 AM
0.5
4kB
Garkin
03/21/15 10:15 AM
0.4a
3kB
Garkin
03/19/15 12:39 PM
0.4
3kB
Garkin
03/18/15 07:55 PM
0.3
3kB
Garkin
03/06/15 11:26 PM
0.2
3kB
Garkin
03/06/15 10:21 AM


Post A Reply Comment Options
Unread 07/03/16, 04:00 PM  
Tonyleila
 
Tonyleila's Avatar
AddOn Author - Click to view AddOns

Forum posts: 288
File comments: 763
Uploads: 7
Will this addon also work with crit resist? Woud be nice!
Report comment to moderator  
Reply With Quote
Unread 06/11/16, 11:34 AM  
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1019
File comments: 1531
Uploads: 31
Should be better, i didn't listed all possibilites (I saw that while being in werewolf, wearing disguises, hat) so for now, you'll have to unnequip item or remove condition if you want a proper tooltip.

For poisons, ZOS judged that the string should be different than on all other labels, so i didn't write the regexp by lazyness. It will come.. at next dlc.
Last edited by Ayantir : 06/11/16 at 11:35 AM.
Report comment to moderator  
Reply With Quote
Unread 06/10/16, 05:34 PM  
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1019
File comments: 1531
Uploads: 31
Thanks, I didn't saw this. I started to fix the cases you mentionned but there are 2 others which will be done tomorrow, it shouldn't be long.
Last edited by Ayantir : 06/10/16 at 05:35 PM.
Report comment to moderator  
Reply With Quote
Unread 06/10/16, 08:36 AM  
code65536
AddOn Author - Click to view AddOns

Forum posts: 21
File comments: 374
Uploads: 40
CritPercent is not compatible with the Dark Brotherhood update. It causes duplicate entries to be shown when viewing items.

Here are some screenshots of item displays before and after CritPercent in Dark Brotherhood:
http://imgur.com/a/2DePB

Notice how the Hunding Armor shows the 2p bonus twice, and the Health and Crit bonuses on the potion display are duplicated as well.
Report comment to moderator  
Reply With Quote
Unread 03/07/16, 07:04 PM  
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1019
File comments: 1531
Uploads: 31
Originally Posted by Bogdan.Kobzar
howdy, having an error occurring with the latest patch.
Also using Harven's Trait and Style version 2.2 (just, updated 5 minutes before my posting this which makes it behave with todays patch).

CritPercent by Garkin, Ayantir version 0.6 (note outdated) is enabled i get the error below.


I am getting the error
Checking type on argument linkStyle failed in GetSmithingPatternResultLink_lua
stack traceback:
[C]: in function 'GetSmithingPatternResultLink'
user:/AddOns/CritPercent/CritPercent.lua:211: in function 'orgFunc'
user:/AddOns/HarvensTraitAndStyle/HarvensTraitAndStyle.lua:338: in function 'HarvensTraitAndStyle_SetPendingSmithingItem'
(tail call): ?
EsoUI/Ingame/Crafting/Keyboard/SmithingCreation_Keyboard.lua:194: in function 'ZO_SmithingCreation:SetupResultTooltip'
EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:895: in function 'ZO_SharedSmithingCreation:UpdateTooltipInternal'
EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:37: in function 'ZO_SharedSmithingCreation:OnUpdate'
EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:32: in function '(anonymous)'
Just retry with the updated version, it should be okay.
I have a lot of addons to update, this one wasn't yet uploaded, it's done now.
Report comment to moderator  
Reply With Quote
Unread 03/07/16, 04:15 PM  
Bogdan.Kobzar

Forum posts: 2
File comments: 43
Uploads: 0
howdy, having an error occurring with the latest patch.
Also using Harven's Trait and Style version 2.2 (just, updated 5 minutes before my posting this which makes it behave with todays patch).

CritPercent by Garkin, Ayantir version 0.6 (note outdated) is enabled i get the error below.


I am getting the error
Checking type on argument linkStyle failed in GetSmithingPatternResultLink_lua
stack traceback:
[C]: in function 'GetSmithingPatternResultLink'
user:/AddOns/CritPercent/CritPercent.lua:211: in function 'orgFunc'
user:/AddOns/HarvensTraitAndStyle/HarvensTraitAndStyle.lua:338: in function 'HarvensTraitAndStyle_SetPendingSmithingItem'
(tail call): ?
EsoUI/Ingame/Crafting/Keyboard/SmithingCreation_Keyboard.lua:194: in function 'ZO_SmithingCreation:SetupResultTooltip'
EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:895: in function 'ZO_SharedSmithingCreation:UpdateTooltipInternal'
EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:37: in function 'ZO_SharedSmithingCreation:OnUpdate'
EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:32: in function '(anonymous)'
Report comment to moderator  
Reply With Quote
Unread 02/16/16, 05:42 PM  
Ayantir
 
Ayantir's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1019
File comments: 1531
Uploads: 31
Thank you. Fixed internally
Report comment to moderator  
Reply With Quote
Unread 02/16/16, 11:45 AM  
Wandamey
Guest

Join Date: Not Yet
Forum posts: 0
File comments: 0
Uploads: 0
Originally Posted by sirinsidiator
I get the following error on pts when I visit a set crafting station:
Code:
Checking type on argument linkStyle failed in GetSmithingPatternResultLink_lua
stack traceback:
	[C]: in function 'GetSmithingPatternResultLink'
	user:/AddOns/CritPercent/CritPercent.lua:211: in function 'SetPendingSmithingItem'
	EsoUI/Ingame/Crafting/Keyboard/SmithingCreation_Keyboard.lua:194: in function 'ZO_SmithingCreation:SetupResultTooltip'
	EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:895: in function 'ZO_SharedSmithingCreation:UpdateTooltipInternal'
	EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:37: in function 'ZO_SharedSmithingCreation:OnUpdate'
	EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:32: in function '(anonymous)'

http://www.esoui.com/forums/showthread.php?t=6075
SetPendingSmithingItem is heriting one extra argument because of the new universal material and screws the hooks.
Report comment to moderator  
Edit/Delete Message Reply With Quote
Unread 02/16/16, 11:32 AM  
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1578
File comments: 1131
Uploads: 41
I get the following error on pts when I visit a set crafting station:
Code:
Checking type on argument linkStyle failed in GetSmithingPatternResultLink_lua
stack traceback:
	[C]: in function 'GetSmithingPatternResultLink'
	user:/AddOns/CritPercent/CritPercent.lua:211: in function 'SetPendingSmithingItem'
	EsoUI/Ingame/Crafting/Keyboard/SmithingCreation_Keyboard.lua:194: in function 'ZO_SmithingCreation:SetupResultTooltip'
	EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:895: in function 'ZO_SharedSmithingCreation:UpdateTooltipInternal'
	EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:37: in function 'ZO_SharedSmithingCreation:OnUpdate'
	EsoUI/Ingame/Crafting/SmithingCreation_Shared.lua:32: in function '(anonymous)'
Report comment to moderator  
Reply With Quote
Unread 09/03/15, 03:03 PM  
Troneon

Forum posts: 0
File comments: 36
Uploads: 0
This addon still ok to use in latest IC update?

Thanks!
Report comment to moderator  
Reply With Quote
Unread 04/21/15, 05:52 AM  
QuadroTony
Banned
 
QuadroTony's Avatar
AddOn Author - Click to view AddOns

Forum posts: 828
File comments: 3866
Uploads: 3
thanks for stat percentage

can you please also make an addon for impenetrable trait percents?
please

and mby merge all 3 addon in one? like "Percentages" (crit+stats+impenetrable)
Report comment to moderator  
Reply With Quote
Unread 04/07/15, 05:03 AM  
Garkin
 
Garkin's Avatar
AddOn Author - Click to view AddOns

Forum posts: 832
File comments: 1097
Uploads: 33
Originally Posted by QuadroTony
Garkin
can you told me - this value also must be shown in %?
and how to calculate this percents for it?
Rating for spell penetration and armor penetration should be the same. The Apprentice mundus stone grants 5% of spell penetration which is for VR14 character 3200 spell penetration rating.

So from this I can guess that formula is:

1% armor penetration = (level + veteran rank) * 10

You character should have armor penetration:

7781 / ((50 + 14) * 10) = 12,1578%


My nightblade (she has equipped bow with sharpened trait):


StatsPercentage-0.1.zip

Warning: Spoiler
Last edited by Garkin : 04/07/15 at 06:48 AM.
Report comment to moderator  
Reply With Quote
Unread 04/07/15, 04:29 AM  
QuadroTony
Banned
 
QuadroTony's Avatar
AddOn Author - Click to view AddOns

Forum posts: 828
File comments: 3866
Uploads: 3
Garkin
can you told me - this value also must be shown in %?
and how to calculate this percents for it?
Report comment to moderator  
Reply With Quote
Unread 04/03/15, 04:45 PM  
QuadroTony
Banned
 
QuadroTony's Avatar
AddOn Author - Click to view AddOns

Forum posts: 828
File comments: 3866
Uploads: 3
youre right
i didnt kow about diff level rating
Report comment to moderator  
Reply With Quote
Unread 04/03/15, 03:42 PM  
Garkin
 
Garkin's Avatar
AddOn Author - Click to view AddOns

Forum posts: 832
File comments: 1097
Uploads: 33
Originally Posted by QuadroTony
on my alts it show wrong value on every item
also chan command show wrong value too

its prob connected with other addons - i ue abother profile of addons on my alts

Are you sure that this value is wrong? Addon uses API function GetCriticalStrikeChance which converts rating to critical chance for your current toon. If you are logged on level 7 toon, critical rating 624 really gives 41.66% critical chance.

crit rating / (2 * (level + veteran rank) * (100 + level + veteran rank) / 100) = crit percent
624 / (2 * (7 + 0) * (100 + 7 + 0) / 100) = 41,6555%
Last edited by Garkin : 04/03/15 at 03:50 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: