Quantcast
Download
(7 Kb)
Download
Updated: 03/20/23 10:54 PM
Pictures
File Info
Compatibility:
Scribes of Fate (8.3.5)
Firesong (8.2.5)
Lost Depths (8.1.5)
High Isle (8.0.0)
Updated:03/20/23 10:54 PM
Created:02/01/23 11:04 AM
Monthly downloads:916
Total downloads:1,325
Favorites:4
MD5:
8.3.5
RidinDirty (Group Tool)  Updated Today!
Version: 2023.3.21
by: sinnereso [More]
"They see me rollin... They be hatin... Neva gonna catch me RidinDirty!!!"

The ULTIMATE group tool with the ability to save & mount a group members multi rider mount if they are in range without even facing or targeting them after combat!!!

BUT WAIT!!! THERES MORE!!! The ability to teleport with effects to them, friends(locally), guild members(locally) or your primary home(inside or outside) after combat as well!!!

Also included FREE OF CHARGE are nameplate font boost, dungeon / battleground / cyrodiil / imperial city auto accept queue, auto bank stacker, auto telvar deposit, auto recharge weapons with gems, AP Log, leave group AND... reloadui functions!!! The catch??? Auto repair at merchants!!! ** CHARGES MAY APPLY **

RidinDirty is specifically aimed at but not limited to small groups, friends and significant others for events, dungeons and questing etc. The features within are targeted at enhancing that playstyles fun, comfort, efficiency and mobility.

*NOTES*
- Teleporting directly to "saved player" requires them to be in group otherwise teleports locally in zone via guilds & friends.
- Auto Bank Stacker only fills existing stacks in bank and does not create new ones. It does not stack foods, drinks, potions, soul gems or tools as they are usually carried items. You can do that manually as u wish.
- Auto Recharge Weapons will use ANY charged gem in inventory but appears to favor crown gems 1st.
- Features a combat queue system for teleporting and multi rider mounting. If your in combat the system will queue up the teleport or mount and play the /ritualcasting emote if unlocked until combat ends and then do it. Can be toggled on or off with the same button.

---------------------------------------------
*INSTRUCTIONS*
- Set keybinds, settings, right click "Save to RidinDirty" on a friend, group or guildmember and GO!!
- ACCOUNT-WIDE SETTINGS
- REQUIRED DEPENDENCIES: LibAddonMenu-2.0, LibCustomMenu
---------------------------------------------

*Credit goes to the one and only MisB!!! My sun.. My moon.. My stars.. and.. inspiration for this addon! BAEBY luvulongtime!
*Special thanks to Baertram and wookiefriseur of ESOUI.COM for ALOT of help getting the saved variables working and several other features.
*Also CrazyDutchGuy and Garkin for some of the code from CDG Bank Stacker for the auto banking
2023.3.21
- Added sounds for many of the previous on screen messages.
- Added sliders in settings menu to adjust the minimum weapon charge before charging and minimum AP to log in chat.*beta* still looking for any issues.

2023/3/20
- Removed a considerable amount of on screen display messages as the default ESO ones in top right corner are enough and less annoying.
- Lowered minimum weapon charge setting and AP logged to chat. Only checks on charge use and load/reload so if you were out of gems for an extended period of time you may need to manually charge or reloadui once you get some. Weapon swap was a good option before 1bar builds but now not much use so I'm lookin at other options still to remedy this without it checking every time you do anything at all.
- Adjusted on screen message entering campaign.

2023.3.19
- Attempting to fix a rare issue during heavy lag where cyrodiil auto queue didn't accept.
- Added onscreen msgs indicating when entering campaign.

2023.3.18
- Final Settings panel tweak
- Tightened up settings panel
- Cleaned up effects toggle code

2023.3.17
- Seperated Auto Bank Stacker and Auto Telvar Deposit into seperate options
- Fixed couple punctuation errors
- Added additional check before disabling on_player_activate between Font Boost and AP Log since they both require it, they now check that the other is off as well before disabling it.
- Fine tuned options panel as best I could with LibAddonMenu and now displays some other useful info.

2023.3.16
- Poilished up some feature descriptions in option menu.
- Fixed saved player not updating in setting window without reloadui.
- REMOVED "SAVE PLAYER" keybinding as it was a redundant feature and saving random people was useless since you had to be at least in group with them to mount or teleport. This change makes LibCustomMenu now required.
- I suggest going into SETTINGS / ADD-ONS and at the bottom hit "clear unused keybinds" after updating. *BE WARNED* this will clear any currently unused keybinds including INACTIVE addons as well so enable all addons with keybinds that matter to you 1st to prevent that.

- REQUIRED DEPENDENCY: LibAddonMenu-2.0, LibCustomMenu.
- UPDATE: Still working on effect button.

2023.3.15 *** MAJOR UPDATE ***
- Fixed auto bank getting all excited and trying to stack from house chests.
- Fixed auto queue not accepting campaign queues.
- ADDED AP Log to chat feature.
- REMOVED all slash commands and upgraded to a real settings menu but came with a saved variable reset. All settings are now in the normal addon settings with the other addons. Still looking for bugs but haven't found any.
- Known issue: Saved Player info and teleport effects button currently dont update after changing without reloadui BUT are working properly, its just not updating the settings window.. Temporarily using an onscreen display message for the teleport effects.
- NEW REQUIRED DEPENCENDY: LibAddonMenu for the new settings menu.

2023.3.14
- Permanantly removed chat window context menu feature as it was not needed.
- Code Optimizations. Increased both load and auto recharge performance.
- Still testing internally AP to Chat feature. Wanting to add it but not wanting to add any more /SLASH commands so I'm at a roadblock with it as it should be a toggleable feature but otherwise its working perfectly so far. I might merge it with autobank & telvar deposit feature but undecided.

2023.3.13
- API bump to update37
- Fixed a chat output bug. Was missing 1 digit on a color table and it stole the letter C from my chat output so those that dont know you "an't teleport while mounted" can still play! =p
- Edited the variable initialization down to 1 line as per Beartrams suggestion which may improve load performance and upset the gods much less! =p
- Testing internally a new very basic AP gained to chat feature.


2023.3.12
- Cleaned up chat messages and preparing for update 37.

2023.3.11
- Added Guild, Group & Friends list "Save to RidinDirty" context menu option via OPTIONAL: LibCustomMenu. TY Votan for the LibCustomMenu upgrades :)
- Temporarily disabled the chat window context menu feature. Depending on your interface settings it may have been saving players character name instead of @NAME. Disabled until I find a workaround to convert them or prevent that.

2023.3.11
- Fixed teleport attempting to use effects and teleport if you were mounted. Now warns you that you are mounted and obviously cannot teleport :)
- Added right click "Save to RidinDirty" chat window context menu to save player for teleport use and optional LibCustomMenu dependency to use it. Continuing to work on guild list, friends list and group list for a future update.

2023.3.10
- Fixed chat output bug when teleporting home. If it hadn't been set yet it was reporting traveling "outside" rather than the game default of "inside" where it was actually going.

2023.2.9
- Added additional weapon recharge check on load/reloadui. In the unlikely event your weapons reach 0 charges it will force a charge check otherwise it only triggers on charge use which could have had a scenario where it wouldn't recharge. For performance and due to the heavy attack build popularity im trying to avoid checking on weapon swaps etc.
- Added informative text when porting to home

2023.3.8
- Fixed double recharge bug. All known bugs fixed.

2023.3.7
- Fixed auto recharge bug. Is working again but trying repair twice with 2h. Fix that in another update.
- Added more descriptive text when porting to saved player ingroup stating the name and location your porting to so its inline with other messages.

2023.3.6
- OK bugs all fixed and fully tested. Moving forward
- Completely revamped the teleport ability. NOW teleports to saved player ONLY if they're in group or to anyone else locally in your current zone from friends list or guilds if your saved player is not in your group. I found this to be the most useful setup and much less accidental ports where u dont want to be.
SUPER useful for events, questing, dragons, harrowstorms etc in group or even solo.
- Some message tweaks. Im still working on a consistent text feedback feel for it and its all complete. :)

2023.3.5
- Reverted back to previous version for the moment.. Was several bugs i need time to work out.

2023.3.6
- Completely revamped the teleport ability. NOW teleports to saved player as before ONLY if they're in group allowing you to play solo because now it can port to friends or guild members locally IN SAME ZONE to bring you to nearest wayshrine if your saved player IS NOT in group. Usefull for events, questing, dragons, harrowstorms etc. Still in beta phase watching for issues.

2023.3.5
- Corrected some chat messages.

2023.3.4
- Added auto bank stacking to auto deposit Telvar function.. It now does both! Fills stacks in bank of anything already in there other than foods, drinks, potions, soul gems, lockpicks and some pvp related items. Thank you CrazyDutchGuy and Garkin for some of the code from an old addon "CDG Bank Stacker" which appears to be freeware to make this possible.
- Added teleport effects and combat queue to teleport to player when they're NOT in group but ARE a friend.
- Fixed a chat output bug and teleport to friend not recognizing them as online.

2023.3.3
- After much thought I have trimmed some of the effects as they didn't quite flow how I'd like and effects aren't the primary focus of this addon.
- Removed: Darkswarm Talisman, Token of Root Sunder and Fetish of Anger effects.
- Moved Ritual Casting effect to the travel/mount queue as an experiment if you have it unlocked. It may or may not stay there depending on how it feels.
- Performance improvements
- Added possibility of teleporting to "saved player" when they're not in group for convenience if they're your "friend" but without teleport effects. Its a group tool so traveling out of group drains all your magic! :)

2023.3.2
- Switched to date format for version.
- Fixed porting from cyro/ic/battlegrounds, now checks if in those zones and doesn't run effects.
- Adjusted some text output coloring for effects toggle so "disabled" is red and you can tell when the cycle has begun to repeat visually.

6.9
- Added Gryphon feather talisman teleport effect. You must have the collectible unlocked to use them.
- Added Ritual Casting EMOTE teleport effect.
- Added Darkswarm Talisman teleport effect.
- Fixed all onscreen and chat messages to be consistent and hopefully final version :)
- slightly increased ouroboros hourglass rotation speed so we dont fall into a trance watching it =p

6.8
- Fixed a settings display bug that would output both "disabled" and "not set" lines if you hadn't set your teleport home setting.
- Adjusted more text output to be short, clean and to the point.

6.7
- Adjusted some text descriptions and colors, mainly [RidinDirty] to a lighter shade everywhere.

6.6
- Added additional recharge weapon check for "IsItemInSlot" to eliminate the possibility of trying to charge non-existent weapons!
- Code optimizations

6.5
- Major code cleanup so all variables are local and can't interfere with other addons.
- Fixed telvar auto deposits showing previous balance after depositing.

6.4
- Added sound to auto recharge weapon and removed text spam as its not critical to know when its done and also avoids any possibility of spam should all yur weapons be broken at the same time.

6.3
- Added auto recharge weapons and /ridindirty_recharge slash command to toggle it on and off. Its still in a BETA phase as it took me 3days to get it working and its untested with dual wield and a few other scenarios. It also may spam chat multiple times repairing multiple items at the same time which should be a very rare occurance that theyre all nearly broken. Report any issue if you encounter any ty :).

6.2
- Added auto telvar deposit setting to settings display. Completely forgot this previously.

6.1
- Added auto deposit telvar into bank and /ridindirty_telvar slash command to toggle it on and off.

5.9
- Code optimizations and cleanup.

5.8
- Added IC auto accept queue function to the auto queue.
- Added or tweaked battleground auto accept queue as an actual feature to the auto queue since it unintentionally was already mostly working.

5.7
- Added cyrodiil auto accept function to auto queue. Now when auto queue is enabled it will auto accept cyrodiil queue's as well. Im reaching a little past just a group function here but its a feature I personally wanted. Working on battleground as well soon.

5.6
- Added mount player auto queue for those semi-rare occasions when your stuck in combat and cant mount them while they're waiting for you.
- Onscreen and chat message cleanup so they all match up better for aesthetics.
- Code optimizations.

5.5
- Added teleport home auto queue like the teleport to player function during combat.
- Fixed auto repair spamming chat with repair costs when interacting with assistant that cannot repair.

5.4
- Added teleport auto queue ANIMATED ICON & LABEL and removed the onscreen text messages. Now you can truely know if it is activated or not at all times. Also added the ability to toggle it on and off while in combat just pressing the same button.. TY guys on ESOUI.COM for the assistance.
- Code optimizations.

5.3
- After much thought I've decided to go with ACCOUNT-WIDE settings so you can swap toons and have same settings already functioning. I apologize but this change will force a saved variable reset and you'll have to redo your settings but never again hopefully and MUCH less between alts :). I may likely do one more reset in the semi-distant future to make sure everyone is on a clean slate.

5.2
- Fixed FontBoost requiring a reloadui and now applies it instantly.
- Cosmetic adjustments and added an auto teleport onscreen activation message so you know when its fired off. Am currently wanting to change that to some kind of hourglass thing while its active once I figure out how to do it, but this helps let you know if its still active or not for now.
- Code optimizations mostly to disable registered events for disabled features.

5.1
- *NEW* Added Font Boost! Slightly increases the nameplate font size for easier reading. Can be enabled/disabled via /ridindirty_fontboost. Currently forcing a reloadui when changing setting. Working still on a more "instant" way still but this works for now.

4.9
- Added onscreen display for auto teleport functions instead of chatbox. *beta*
- Tweaked some chatbox to onscreen messages.

4.8
- Added auto teleport to player after combat if you attempt to teleport during combat.
- Minor cosmetic adjustments.

4.7
- Fixed "is player online" check for porting. ty Baertram and ExoY of esoui.com for the help.

4.5
- Added /ridindirty_home to toggle between teleporting home INSIDE or OUTSIDE - minor cosmetic adjustments.

4.3
- Corrected several bugs with teleport effects being called improperly.. removed playeronline check for the moment untill i can find a workaround to get it working right.

4.2
- Correcting some intermittent port home inside instead of outside bugs.

4.1
- Added token of root sunder effect for those wanting a more druidic feel, tweaked some text formatting and effect timings and updated API version.
- Code optimizations.

3.9
- Added teleport to primary home "outside" function for a quick travel option.

3.8
- Added dragon flight illusion to teleport effects.
- slightly increased delay on effects for slower connections to be safe.

3.7
- Added /ridindirty_status info for the teleport effects feature.

3.6
- Added additional teleport effect "Neramos' Lighting Stick" and /ridindirty_effects slash command to toggle between them and disable effects completely. *** Effects require having the momento unlocked otherwise bypasses and uses normal teleport ***
- Code optimizations.

3.5
- Added teleporting effects using the fetish of anger momento if you have it unlocked for a more eerie feeling :).
- Code optimizations.

3.4
- Corrected some auto queue code issues - Polish - Likely final version for a while.

3.3
- Added auto queue function for the group finder and /ridindirty_queue to toggle on and off.

3.2
- Removed repair cost spam from chat and renamed slash commands to /ridindirty_status to display saved player and auto repair status and /ridindirty_repair to toggle auto repair on and off.
- Code optimizations.

3.1
- Added auto-repairs at merchant with /ridindirty_repair_toggle on/off toggle.

2.3
- Added /ridindirtysaved slash command to display current saved player added chat display of who your actually saving during save operation.

2.1
- Major re-write again & polish but now includes a teleport to saved player(in group) function as well.
**Requires re-saving the player again to update the saved variables file and updating your keybinds**

1.6
- Code optimizations.

1.5
- Removed mounting chat text as it was too much spam. Saving will continue to notify in chat. Also added leave group and reloadui functions

1.4 - Nearly total rewrite and polish but now has 2 keybinds to set/mount user that is independant of character/server and is presistant through reload/relog! Thanks Baertram and wookiefriseur for the help!

1.3
- Code optimizations.

1.2
- Code optimizations.

1.1
- Code optimizations.

1.0 - Original
Archived Files (1)
File Name
Version
Size
Uploader
Date
2023.3.20
7kB
sinnereso
03/20/23 07:32 AM


Post A Reply Comment Options
Unread 03/14/23, 12:07 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4425
File comments: 5516
Uploads: 77
If it works properly I'd recommand it, yes. Filters are always faster and more performant than doing the filtering in the lua code by the callback function via if updateReason == x or bagId == y

Originally Posted by sinnereso
Originally Posted by Baertram
Another hint for your performance:

could i now trim it down to this since the filters are inplace?:

Code:
--addonloaded
EVENT_MANAGER:RegisterForEvent("RidinDirty", EVENT_INVENTORY_SINGLE_SLOT_UPDATE, RidinDirty.InventoryUpdate)
EVENT_MANAGER:AddFilterForEvent("RidinDirty", EVENT_INVENTORY_SINGLE_SLOT_UPDATE, REGISTER_FILTER_INVENTORY_UPDATE_REASON, INVENTORY_UPDATE_REASON_ITEM_CHARGE, REGISTER_FILTER_BAG_ID, BAG_WORN)

--functions
function RidinDirty.InventoryUpdate()
	if not IsUnitDead("player") then
		RidinDirty.AutoRecharge()
	else
		return
	end
end
Im testing this now and appears to be working fine but would u recomend it?
I'm going with it for now.. if you think its bad i welcome imput but otherwise seems to be perfect.
Report comment to moderator  
Reply With Quote
Unread 03/14/23, 09:20 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 77
File comments: 21
Uploads: 1
Originally Posted by Baertram
Another hint for your performance:

could i now trim it down to this since the filters are inplace?:

Code:
--addonloaded
EVENT_MANAGER:RegisterForEvent("RidinDirty", EVENT_INVENTORY_SINGLE_SLOT_UPDATE, RidinDirty.InventoryUpdate)
EVENT_MANAGER:AddFilterForEvent("RidinDirty", EVENT_INVENTORY_SINGLE_SLOT_UPDATE, REGISTER_FILTER_INVENTORY_UPDATE_REASON, INVENTORY_UPDATE_REASON_ITEM_CHARGE, REGISTER_FILTER_BAG_ID, BAG_WORN)

--functions
function RidinDirty.InventoryUpdate()
	if not IsUnitDead("player") then
		RidinDirty.AutoRecharge()
	else
		return
	end
end
Im testing this now and appears to be working fine but would u recomend it?
I'm going with it for now.. if you think its bad i welcome imput but otherwise seems to be perfect.
Last edited by sinnereso : 03/14/23 at 12:04 PM.
Report comment to moderator  
Reply With Quote
Unread 03/14/23, 08:50 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 77
File comments: 21
Uploads: 1
ty ill look into it. I was trying to keep the performance high by only checking on charge use which only happens every few seconds while in combat usually. Ill see what i can do with this.
Last edited by sinnereso : 03/14/23 at 08:50 AM.
Report comment to moderator  
Reply With Quote
Unread 03/14/23, 08:09 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4425
File comments: 5516
Uploads: 77
Another hint for your performance:
EVENT_INVENTORY_SINGLE_SLOT_UPDATE
Events like these fire very often, for different kind of tasks.
e.g. some fire for the durability or item charge value -> your auto recharge check. But they also fire for stack split, item move, etc.

If you only want to have it fire for your addon for some of these cases use event filters to filter the events accordingly to your needs:
https://wiki.esoui.com/AddFilterForEvent
The event EVENT_INVENTORY_SINGLE_SLOT_UPDATE can use e.g. the REGISTER_FILTER_INVENTORY_UPDATE_REASON filter type.
Possible update reasons are:
https://wiki.esoui.com/Globals#InventoryUpdateReason


If you add an eventfilter make sure the name passed in as 1st parameter is the exactly same as used for your normal event, that you want to filter!
e.g.

Lua Code:
  1. local myAddonEventNameInvSingleSlotUpdate = "myAddonNameEventInventorySingleSlotUpdate"
  2. EVENT_MANAGER:RegisterForEvent(myAddonEventNameInvSingleSlotUpdate, EVENT_INVENTORY_SINGLE_SLOT_UPDATE, function() ...... end)
  3. EVENT_MANAGER:FilterForEvent(myAddonEventNameInvSingleSlotUpdate, EVENT_INVENTORY_SINGLE_SLOT_UPDATE, REGISTER_FILTER_INVENTORY_UPDATE_REASON, updateReasonFromTheListLinkedAboveHereWhichYouWanToFilter_forExample_TheDurabilityUpdate_or_TheItemChargeValue)

You could also check for the bagID be BAG_WORN so no items in your inventory will be checked which currently are not equipped.

This will make your addon not listen (and the event for your addon not even fire) for the other non-filtered inventory update reasons.
And this will make your callback function used in the event no need to check for parameter inventoryUpdateReason anymore! As it's prefiltered in C code, before it even hits lua code, already. -> Big performance gain and very needed as ppl run multiple addons at the same time and each addon in combination with vanilla game code slows down the stuff a bit, more and more and more...
Last edited by Baertram : 03/14/23 at 08:12 AM.
Report comment to moderator  
Reply With Quote
Unread 03/13/23, 10:40 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 77
File comments: 21
Uploads: 1
Well.. because im still weak on tables! I only recently figure out what and how this works

If i dont fully understand it then its not going in is my general rule

I expect overtime ill be cleaning stuff up as it makes sense to me because Im the one that has to track down any bugs.

This hasn't been forgotten though from the previous mention of it and is on my todo list.

**EDIT OK added it that way and appears to be working.. ill leave my original stuff commented out for the moment incase of any issues.


Code:
RidinDirty = {
	name = "RidinDirty",
	author = "Michael Cullen(@sinnereso)",
	version = "2023.3.13",
	svName = "RidinDirtyVars",
	svVersion = 2,
}
Last edited by sinnereso : 03/13/23 at 11:06 AM.
Report comment to moderator  
Reply With Quote
Unread 03/12/23, 11:43 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4425
File comments: 5516
Uploads: 77
Code:
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { savedPlayer = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { autoRepair = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { autoRecharge = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { autoBank = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { autoQueue = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { effectId = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { effectDelay = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { travelOutside = nil })
	RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { fontBoost = nil })
aehm WHY? You were already told weeks ago that this is bull****
Just call it ONCE with all that needed default values in 1 table:
RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { savedPlayer = nil, autoRepair= nil, ... })


And if the defalt values are all nil you do not even need to explicitly set them, just use
RidinDirty.savedVariables = ZO_SavedVars:NewAccountWide( RidinDirty.svName, RidinDirty.svVersion, nil, { } )
Report comment to moderator  
Reply With Quote
Unread 03/12/23, 05:13 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 77
File comments: 21
Uploads: 1
I currently have chat window context menu disabled but guild, group and friends list working amazing with optional LibCustomMenu. TY Votan for the upgrades to it.

I may remove the chat window feature since you need to be in group, guild or friends to be able to travel to anyone and in group to mount them anyway making it a nearly useless feature saving total randoms from chat.

I've left the original save reticle target with keybind as a backup leaving LibCustomMenu as optional instead of required. Most wont be changing they're saved player often and likely are playing with significant other. For those that require more hardcore use, LibCustomMenu is available to take it next level
Last edited by sinnereso : 03/12/23 at 05:36 AM.
Report comment to moderator  
Reply With Quote
Unread 02/28/23, 10:47 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 77
File comments: 21
Uploads: 1
Originally Posted by Baertram
Originally Posted by sinnereso
df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
The error messages appear cuz you forgot to add the , between %s" and effectEnabled, and got nothing to do with local or not local
Yes i found that but then realized i had 4 lines for the options anyway so just went with pure text. I'm not an expert on the arrays etc yet so i work with 4 lines for now
Last edited by sinnereso : 02/28/23 at 10:48 AM.
Report comment to moderator  
Reply With Quote
Unread 02/28/23, 10:29 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4425
File comments: 5516
Uploads: 77
Originally Posted by sinnereso
df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
The error messages appear cuz you forgot to add the , between %s" and effectEnabled, and got nothing to do with local or not local
Last edited by Baertram : 02/28/23 at 10:29 AM.
Report comment to moderator  
Reply With Quote
Unread 02/27/23, 01:03 PM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 77
File comments: 21
Uploads: 1
ok got her all fixed up and caught a telvar bank bug in the process.. was displaying previous balance after depositing..

posting..
Report comment to moderator  
Reply With Quote
Unread 02/27/23, 11:41 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 77
File comments: 21
Uploads: 1
Originally Posted by Baertram
Your addon leaks variables to the global namespace and their name is not unique enough, so they might destroy other addons!
Please do a decent variable check ebfore releasing your addons, and add the local in front of them properly!

e.g.
hourglass -> Solution: Add that to RidinDirty.hourglass instead and it will be a least below your 1 global table!
effectEnabled -> Add a local in front and check where it's needed to be used. If more than 1 function need it define it at the top of your file as local. If only the 1 function needs it define it at the top of hat function as local

And your slash commands should be defined in your EVENT_ADD_ON_LOADED callback function first, and not before (makes no sense, in your addon's case, as your addon is not ready before that and your addon's code was not run properly before).
as expected hittin a few issues but only found 1 so far which makes no sense to me. I even reformatted everything so this one is stumping me... getting errors on:

Code:
df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)

in this since changing them to local. its not liking the %s' effectEnabled) portion any longer:

Code:
if effectToggle == nil or effectToggle == "" or effectToggle == 0 then
		df("|c9900FF[RidinDirty]|r Teleport Effects Disabled")
	else
		if effectToggle == 347 then
			local effectEnabled = "Fetish of Anger"
			df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
		end
		if effectToggle == 349 then
			local effectEnabled = "Token of Root Sunder"
			df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
		end
		if effectToggle == 1228 then
			local effectEnabled = "Neramo's Lightning"
			df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
		end
		if effectToggle == 6046 then
			local effectEnabled = "Dragon Flight Illusion"
			df("|c9900FF[RidinDirty]|r Teleport Effect: %s" effectEnabled)
		end
	end
I cant get them any closer to where the variable is being set and theyre not used anywhere else.
Last edited by sinnereso : 02/27/23 at 11:43 AM.
Report comment to moderator  
Reply With Quote
Unread 02/27/23, 10:17 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 77
File comments: 21
Uploads: 1
Originally Posted by Baertram
Your addon leaks variables to the global namespace and their name is not unique enough, so they might destroy other addons!
Please do a decent variable check ebfore releasing your addons, and add the local in front of them properly!

e.g.
hourglass -> Solution: Add that to RidinDirty.hourglass instead and it will be a least below your 1 global table!
effectEnabled -> Add a local in front and check where it's needed to be used. If more than 1 function need it define it at the top of your file as local. If only the 1 function needs it define it at the top of hat function as local

And your slash commands should be defined in your EVENT_ADD_ON_LOADED callback function first, and not before (makes no sense, in your addon's case, as your addon is not ready before that and your addon's code was not run properly before).
Ive been workin on it..

additional isunitdead check on the recharge execute CHECK!!
slash commands moved into onload CHECK!
hourglass converted into RidinDirty.HourGlass.... CHECK

working on all local variables now and done

OK!!! all variables now LOCAL with the exception of:
1. houglass lines are all RidinDirty.HourGlass.. now
2 RidinDirty.savedVariables.xxxxxxxxx = line are not as theyre just saving variables but if needs let me know
3. SetNameplateKeyboardFont(string.format(xxxxxxxx lines are not as well cuz theyre just setting the nameplate font

I think I got everything... one last test and uploading.. if you see anything else i apreciate the advice so noone has any issues.
Last edited by sinnereso : 02/27/23 at 10:46 AM.
Report comment to moderator  
Reply With Quote
Unread 02/27/23, 04:08 AM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 77
File comments: 21
Uploads: 1
Originally Posted by Baertram
Your addon leaks variables to the global namespace and their name is not unique enough, so they might destroy other addons!
Please do a decent variable check ebfore releasing your addons, and add the local in front of them properly!

e.g.
hourglass -> Solution: Add that to RidinDirty.hourglass instead and it will be a least below your 1 global table!
effectEnabled -> Add a local in front and check where it's needed to be used. If more than 1 function need it define it at the top of your file as local. If only the 1 function needs it define it at the top of hat function as local

And your slash commands should be defined in your EVENT_ADD_ON_LOADED callback function first, and not before (makes no sense, in your addon's case, as your addon is not ready before that and your addon's code was not run properly before).
OK thank you. ill get on it after a short break to enjoy it all working before all this breaks it =p
Report comment to moderator  
Reply With Quote
Unread 02/27/23, 03:38 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4425
File comments: 5516
Uploads: 77
Your addon leaks variables to the global namespace and their name is not unique enough, so they might destroy other addons!
Please do a decent variable check ebfore releasing your addons, and add the local in front of them properly!

e.g.
hourglass -> Solution: Add that to RidinDirty.hourglass instead and it will be a least below your 1 global table!
effectEnabled -> Add a local in front and check where it's needed to be used. If more than 1 function need it define it at the top of your file as local. If only the 1 function needs it define it at the top of hat function as local

And your slash commands should be defined in your EVENT_ADD_ON_LOADED callback function first, and not before (makes no sense, in your addon's case, as your addon is not ready before that and your addon's code was not run properly before).
Last edited by Baertram : 02/27/23 at 03:38 AM.
Report comment to moderator  
Reply With Quote
Unread 02/08/23, 06:42 PM  
sinnereso
AddOn Author - Click to view AddOns

Forum posts: 77
File comments: 21
Uploads: 1
Originally Posted by Baertram
Your APIversion in the txt files is old
Code:
## APIVersion: 100034 100036
This will show your addon as outdated.
The current APIversion can be found ingame via function GetAPIVersion() (current live is 101036, current PTS: 101037)
https://wiki.esoui.com/APIVersion

So maybe update that txt file with your next update.
damn didnt catch that.. ty bro..
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: