Download
(4 Kb)
Download
Updated: 03/09/20 10:22 AM
Compatibility:
Ascending Tide (7.3.5)
Deadlands (7.2.5)
Waking Flame (7.1.5)
Blackwood (7.0.5)
Flames of Ambition (6.3.5)
Markarth (6.2.5)
Stonethorn (6.1.5)
Greymoor (6.0.5)
Updated:03/09/20 10:22 AM
Created:07/22/18 02:41 PM
Monthly downloads:1,506
Total downloads:129,911
Favorites:25
MD5:
LibPotionBuff  Popular! (More than 5000 hits)
Version: 3.00
by: Baertram [More]
For Players
This Library is only for use by Add-on Developers.

Attention: Due to API changes and buffId/abilityId changes by ZOs some potions do not use a dedicated buffId (abilityId) anymore which makes it impossible for this library to track the potions properly
Addons cannot fix this, this was a decision done by ZOs. So if your addons do not track the potions properly anymroe it might be because of that (e.g. any other skill used -> buffId is the same as a potion -> character buffs -> checks are done and the adons think a potion was used -> fail!).
This would only be circumventable IF we would have the API to get other information about the potions, but we don't. And tracking the usage of a potion in gamepad and keyboard mode is thing this library is not going to do, to keep timers running (cooldowns of the potions, where we do not get them via API and would need to check the player buffs again to see the cooldown + check champion points + check passive skills earned + worn sets + ... ) and only "assume" the buff is raised from a potion. Even then it would not be 100% clean and working


But if any addon's description/changelog writes "Depends on the dependency/library: LibPotionBuff"
you most probably need to install this library, even if you are no developer of addons
Read more about dependencies/libraries here: https://www.esoui.com/forums/showthread.php?t=9149

For Developers
This Library includes a list of all current potion buffs along with their type (non-crafted, crafted, from crown store).
It includes functions to get information about group member's and/or player potion statuses.


Functions
You need to create an instance of this library via the global variable LibPotionBuff like this:
Lua Code:
  1. local lib = LibPotionBuff
-> This library cannot be used with LibStub anymore!

Optional dependencies:
LibChatMessage
-> Only for debug messages


Use the variable lib to call the following functions then:


Lua Code:
  1. function lib:GetTimeLeftInSeconds(timeInMilliseconds)
  2. Parameter: number timeInMilliseconds - any number in milliseconds
  3. Returns: time in seconds rounded up

Lua Code:
  1. function lib:GetPotionBuffInfos(unitTag)
  2. --Parameter: string unitTag - any unitTag (http://wiki.esoui.com/UnitTag)
  3. -- Returns: boolean isBuffActive, bool isCrafted, bool isFromCrownStore, number abilityId, string buffName, number timeStarted, number timeEnds, textureString iconTexture

Lua Code:
  1. function lib:IsPotionBuffActive(unitTag)
  2. --Parameter: string unitTag - any unitTag (http://wiki.esoui.com/UnitTag)
  3. -- Returns: bool isBuffActive

Lua Code:
  1. function lib:IsPotionBuffActiveAndGetTimeLeft(unitTag)
  2. --Parameter: string unitTag - any unitTag (http://wiki.esoui.com/UnitTag)
  3. -- Returns: bool isBuffActive, number timeLeftInSeconds , number abilityId

Lua Code:
  1. function lib:GetPotionSlotCooldown(chatOutput)
  2.     -- Parameter:   boolean chatOutput - true = output the info to the chat; false = do not show anyhting into the chat
  3.     -- Returns:     number timeLeftInMilliseconds, number buffTotalCooldownInMilliseconds

Lua Code:
  1. function lib:IsAbilityACraftedPotionBuff(abilityId)
  2. --Parameter: integer abilityId - any abilityId (http://esoitem.uesp.net/viewlog.php?record=minedSkills)
  3. -- Returns: nilable:bool IsAbilityACraftedPotionBuff(true) or false if not, or nil if not any potion buff

Lua Code:
  1. function lib:IsAbilityACrownStorePotionBuff(abilityId)
  2. --Parameter: integer abilityId - any abilityId (http://esoitem.uesp.net/viewlog.php?record=minedSkills)
  3. -- Returns: nilable:bool isAbilityACrownStorePotionBuff(true) or false if not, or nil if not any potion buff

Lua Code:
  1. function lib:IsAbilityAPotionBuff(abilityId)
  2. --Parameter: integer abilityId - any abilityId (http://esoitem.uesp.net/viewlog.php?record=minedSkills)
  3. -- Returns: bool isAbilityAnActivePotionBuff(true) or false if not


To register a callback function to the EVENT_EFFECT_CHANGED event for all the potion abilityIds you can use this function:
Lua Code:
  1. function lib:RegisterAbilityIdsFilterOnEventEffectChanged(addonEventNameSpace, callbackFunc, filterType, filterParameter)
  2. --Parameters:   addonEventNameSpace - prefered to insert your addon name. if you want to call this function twice, make sure the second/third/... addonEventNameSpace has another name. Example `addonName.."_01"`, `addonName.."_02"`
  3. --callbackFunc - any global function you want to run when the event is firing
  4. --filterType - choose any filter type from here: http://wiki.esoui.com/AddFilterForEvent
  5. --filterParameter - choose any filter parameter from here: http://wiki.esoui.com/AddFilterForEvent
To unregister your callback function to the EVENT_EFFECT_CHANGED event for all the potion abilityIds you can use this function:
Lua Code:
  1. function lib:UnRegisterAbilityIdsFilterOnEventEffectChanged()

LibPotionBuff sourcecode
https://github.com/Baertram/LibPotionBuff
Version 3.00
-Totally stripped LibStub: Use the global variable LibPotionBuff instead!
-Updated API for Harrowstorm
-Added optional dependency to LibChatMessage
-Changed debug messages


Version 2.00
-Updated API for Elsweyr
-Added ##IsLibrary: true tag to manifest txt
-Added ##AddOnVersion tag to manifest txt
-Made lib work without LibStub. Use global variable LibPotionBuff

1.01
Fixed the wrong library txt file
Added LiBStub dependency

Thanks to "Lakashi" for the fix info about the wrong txt file!
Archived Files (2)
File Name
Version
Size
Uploader
Date
1.01
5kB
Baertram
09/17/18 10:57 AM
1.0
5kB
Baertram
07/22/18 02:41 PM


Post A Reply Comment Options
Unread 10/06/21, 05:38 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4912
File comments: 5990
Uploads: 78
Re: Re: Re: Re: Re: Potion IDs

And he feedback by our ZOs dev contact was already that he cannot really help here as this was done by other guys who made the decisions.
Actually I doubt this will change again *sigh*
And I'm not really interested into trying to find any other working way (I doubt there is any).
So this lib currently is left-over in a non-functional/non-intended way of working -> RIP
As long as noone else wants to invest the tme to find other ways to get the same abilityIds connected to potions by e.g. checking if any potion is currently on cooldown and checking if the buff's timer of potions is always higher (even without passives inmproving the timer length) and taking asumptions that a buffId could be a potion's buffId this way

Originally Posted by Sordrak
Originally Posted by Baertram
hm so e.g. Major brutality's buff id is the same for potion and skills now?
Not sure if always was "split" in the past but I think so. Guess the lib now is useless then, or only semi-helpfull (depending on the usecase).


Originally Posted by Sordrak
Originally Posted by Baertram
Thank you very very much for the work you have put into!
Did not look at all but looks like not all unique buffIds are there anymore to clearly distinguish "all" crafted potions from non-crafted ones. This is odd
I guess I need some time and a queit moment to sort the things out and see if one can keep the different tabes of potion Ids, maybe enhance them a bit for the new invisibility buff Ids. Currently I cannot free my brain to work on this.
I guess it is even worse than i initially thought. It seems like other buffs use the pot buff IDs too...
Seems so. My Netch triggers the same ID as my potion... That was different in the past.
So yes, that sucks :/
Last edited by Baertram : 10/06/21 at 05:41 PM.
Report comment to moderator  
Reply With Quote
Unread 10/06/21, 12:14 PM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
Re: Re: Re: Re: Potion IDs

Originally Posted by Baertram
hm so e.g. Major brutality's buff id is the same for potion and skills now?
Not sure if always was "split" in the past but I think so. Guess the lib now is useless then, or only semi-helpfull (depending on the usecase).


Originally Posted by Sordrak
Originally Posted by Baertram
Thank you very very much for the work you have put into!
Did not look at all but looks like not all unique buffIds are there anymore to clearly distinguish "all" crafted potions from non-crafted ones. This is odd
I guess I need some time and a queit moment to sort the things out and see if one can keep the different tabes of potion Ids, maybe enhance them a bit for the new invisibility buff Ids. Currently I cannot free my brain to work on this.
I guess it is even worse than i initially thought. It seems like other buffs use the pot buff IDs too...
Seems so. My Netch triggers the same ID as my potion... That was different in the past.
So yes, that sucks :/
Report comment to moderator  
Reply With Quote
Unread 09/27/21, 01:29 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4912
File comments: 5990
Uploads: 78
Re: Re: Re: Potion IDs

hm so e.g. Major brutality's buff id is the same for potion and skills now?
Not sure if always was "split" in the past but I think so. Guess the lib now is useless then, or only semi-helpfull (depending on the usecase).


Originally Posted by Sordrak
Originally Posted by Baertram
Thank you very very much for the work you have put into!
Did not look at all but looks like not all unique buffIds are there anymore to clearly distinguish "all" crafted potions from non-crafted ones. This is odd
I guess I need some time and a queit moment to sort the things out and see if one can keep the different tabes of potion Ids, maybe enhance them a bit for the new invisibility buff Ids. Currently I cannot free my brain to work on this.
I guess it is even worse than i initially thought. It seems like other buffs use the pot buff IDs too...
Report comment to moderator  
Reply With Quote
Unread 09/26/21, 08:24 AM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
Re: Re: Potion IDs

Originally Posted by Baertram
Thank you very very much for the work you have put into!
Did not look at all but looks like not all unique buffIds are there anymore to clearly distinguish "all" crafted potions from non-crafted ones. This is odd
I guess I need some time and a queit moment to sort the things out and see if one can keep the different tabes of potion Ids, maybe enhance them a bit for the new invisibility buff Ids. Currently I cannot free my brain to work on this.
I guess it is even worse than i initially thought. It seems like other buffs use the pot buff IDs too...
Report comment to moderator  
Reply With Quote
Unread 09/19/21, 07:32 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4912
File comments: 5990
Uploads: 78
Re: Potion IDs

Thank you very very much for the work you have put into!
Did not look at all but looks like not all unique buffIds are there anymore to clearly distinguish "all" crafted potions from non-crafted ones. This is odd
I guess I need some time and a queit moment to sort the things out and see if one can keep the different tabes of potion Ids, maybe enhance them a bit for the new invisibility buff Ids. Currently I cannot free my brain to work on this.

Originally Posted by Sordrak
I did some crafting today and got some IDs. Unfortunately, I won't be able to get the crown store potion IDs and the IDs of the improved companion potions (i did not really level that companion...).

So here's the list of the potions i have checked.
Alliance War:
Code:
Item: Alliance Battle Draught, Link: |H1:item:71073:307:50:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h
Major Endurance:	61705
Major Brutality:	61665
Major Savagery:		61667
Item: Alliance Health Draught, Link: |H1:item:71071:307:50:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h
Major Fortitude:	61698
Unstoppable:		72930
Invisibility:		136002
Item: Alliance Spell Draught, Link: |H1:item:71072:307:50:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h
Major Intellect:	61707
Major Sorcery:		61687
Major Prophecy:		61689
Normal (w/o companion):
Code:
Item: Essence of Health, Link: |H1:item:27036:307:50:0:0:0:0:0:0:0:0:0:0:0:0:36:0:0:0:0:0|h|h
Major Fortitude:	61698
Item: Essence of Stamina, Link: |H1:item:27038:307:50:0:0:0:0:0:0:0:0:0:0:0:0:36:0:0:0:0:0|h|h
Major Endurance:	61705
Item: Essence of Magicka, Link: |H1:item:27037:307:50:0:0:0:0:0:0:0:0:0:0:0:0:36:0:0:0:0:0|h|h
Major Intellect:	61707
Crafted (Positive Effects):
Code:
Item: Essence of Health, Link: |H1:item:54339:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:8454917|h|h
Major Fortitude:	61698
Major Intellect:	61707
Major Endurance:	61705
Item: Essence of Armor, Link: |H1:item:27042:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:596253|h|h
Physical Resistance Potion:	64564
Minor Protection:	61721
Major Vitality:		61713
Item: Essence of Immovability, Link: |H1:item:27039:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1250563|h|h
Increase Detection:	45236
Major Intellect:	61707
Item: Essence of Speed, Link: |H1:item:27041:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1508639|h|h
Major Expedition:	61736
Major Endurance:	61705
Minor Heroism:		61708
Item: Essence of Weapon Power, Link: |H1:item:44714:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:856325|h|h
Major Brutality:	61665
Major Savagery:		61667
Major Endurance:	61705
Item: Essence of Spell Power, Link: |H1:item:30145:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:724739|h|h
Major Sorcery:		61687
Major Prophecy:		61689
Major Intellect:	61707
Item: Essence of Magicka, Link: |H1:item:54340:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:198425|h|h
Major Intellect:	61707
Spell Resistance Potion: 64562
Minor Protection:	61721
Item: Essence of Invisibility, Link: |H1:item:44715:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1442075|h|h
Invisibility:		45237
Major Fortitude:	61698
Lingering Restore Health: 79705
Item: Essence of Immovability, Link: |H1:item:27039:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1250565|h|h
Increase Detection:	45236
Major Endurance:	61705
Crafted (Negative Effects):
Code:
Item: Essence of Ravage Health, Link: |H1:item:44812:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:132626|h|h
Minor Enervation:	79907
Ravage Health:		46113
Ravage Stamina:		46199
Item: Essence of Ravage Health, Link: |H1:item:44812:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:139264|h|h
Minor Timidity:		140699
Ravage Health:		46113
Item: Essence of Ravage Magicka, Link: |H1:item:44815:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:265216|h|h
Ravage Magicka:		46193
Minor Cowardice:	79867
Item: Essence of Ravage Armor, Link: |H1:item:27040:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:659968|h|h
Physical Resistance Reduction: 46208
Minor Enervation:	79907
Item: Essence of Entrapment, Link: |H1:item:54333:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1311744|h|h
Ravage Magicka:		46193
Item: Essence of Hindering, Link: |H1:item:54335:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1580544|h|h
Hindrance:		46210
Minor Defile:		61726
Item: Essence of Ravage Stamina, Link: |H1:item:44809:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:399374|h|h
Ravage Stamina:		46199
Hindrance:		46210
Minor Maim:		61723
Item: Essence of Uncertainty, Link: |H1:item:54336:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1053184|h|h
Minor Uncertainty:	79895
Minor Enervation:	79907
Item: Essence of Ravage Health, Link: |H1:item:44815:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:264192|h|h
Ravage Magicka:		46193
Spell Resistance Reduction: 46206
Item: Essence of Creeping Ravage Health, Link: |H1:item:77594:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1841664|h|h
Creeping Ravage Health: 79709
Minor Vulnerability:	79717

Two things are a bit odd.
The Invisibility is different on alliance and crafted potions.
Unstoppable does not seem to be given as a buff anymore with crafted potions (only seen on alliance potions).

If we put all these effects in one category (e.g. is potion), the new list would look like this (missing crown store and companion pots):
Code:
local isPotion = {
	--Positive
	[61698] = true, --"Major Fortitude",
	[61707] = true, --"Major Intellect",
	[61705] = true, --"Major Endurance",
	[45236] = true, --"Increase Detection",
	[45237] = true, --"Invisibility", INFO: Still has a different ID on alliance Potions 136002 (wtf?)
	[72930] = true, --"Unstoppable", INFO: Does not exist on crafted Potions anymore (wtf?)

	[61665] = true, --"Major Brutality",
	[61687] = true, --"Major Sorcery",
	[61736] = true, --"Major Expedition",
	[61667] = true, --"Major Savagery",
	[61689] = true, --"Major Prophecy",

	[79705] = true, --"Lingering Restore Health",
	[61721] = true, --"Minor Protection",
	[61713] = true, --"Major Vitality",
	
	[64564] = true, -- "Physical Resistance Potion",
	[64562] = true, -- "Spell Resistance Potion",
	[61708] = true, -- "Minor Heroism",
	
	-- Negative
	[46113] = true, --"Ravage Health",
	[46193] = true, --"Ravage Magicka",
	[46199] = true, --"Ravage Stamina",
	[79867] = true, --"Minor Cowardice",
	[61723] = true, --"Minor Maim",
	[46206] = true, --"Spell Resistance Reduction",
	[46208] = true, --"Physical Resistance Reduction",
	[46210] = true, --"Hindrance",
	
	[79907] = true, -- "Minor Enervation",
	[140699] = true, -- "Minor Timidity",
	[61726] = true, -- "Minor Defile",
	[79895] = true, -- "Minor Uncertainty",
	[79709] = true, -- "Creeping Ravage Health",
	[79717] = true, -- "Minor Vulnerability",
}
Hope this helps.
Report comment to moderator  
Reply With Quote
Unread 09/18/21, 08:53 AM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
Potion IDs

I did some crafting today and got some IDs. Unfortunately, I won't be able to get the crown store potion IDs and the IDs of the improved companion potions (i did not really level that companion...).

So here's the list of the potions i have checked.
Alliance War:
Code:
Item: Alliance Battle Draught, Link: |H1:item:71073:307:50:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h
Major Endurance:	61705
Major Brutality:	61665
Major Savagery:		61667
Item: Alliance Health Draught, Link: |H1:item:71071:307:50:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h
Major Fortitude:	61698
Unstoppable:		72930
Invisibility:		136002
Item: Alliance Spell Draught, Link: |H1:item:71072:307:50:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h
Major Intellect:	61707
Major Sorcery:		61687
Major Prophecy:		61689
Normal (w/o companion):
Code:
Item: Essence of Health, Link: |H1:item:27036:307:50:0:0:0:0:0:0:0:0:0:0:0:0:36:0:0:0:0:0|h|h
Major Fortitude:	61698
Item: Essence of Stamina, Link: |H1:item:27038:307:50:0:0:0:0:0:0:0:0:0:0:0:0:36:0:0:0:0:0|h|h
Major Endurance:	61705
Item: Essence of Magicka, Link: |H1:item:27037:307:50:0:0:0:0:0:0:0:0:0:0:0:0:36:0:0:0:0:0|h|h
Major Intellect:	61707
Crafted (Positive Effects):
Code:
Item: Essence of Health, Link: |H1:item:54339:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:8454917|h|h
Major Fortitude:	61698
Major Intellect:	61707
Major Endurance:	61705
Item: Essence of Armor, Link: |H1:item:27042:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:596253|h|h
Physical Resistance Potion:	64564
Minor Protection:	61721
Major Vitality:		61713
Item: Essence of Immovability, Link: |H1:item:27039:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1250563|h|h
Increase Detection:	45236
Major Intellect:	61707
Item: Essence of Speed, Link: |H1:item:27041:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1508639|h|h
Major Expedition:	61736
Major Endurance:	61705
Minor Heroism:		61708
Item: Essence of Weapon Power, Link: |H1:item:44714:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:856325|h|h
Major Brutality:	61665
Major Savagery:		61667
Major Endurance:	61705
Item: Essence of Spell Power, Link: |H1:item:30145:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:724739|h|h
Major Sorcery:		61687
Major Prophecy:		61689
Major Intellect:	61707
Item: Essence of Magicka, Link: |H1:item:54340:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:198425|h|h
Major Intellect:	61707
Spell Resistance Potion: 64562
Minor Protection:	61721
Item: Essence of Invisibility, Link: |H1:item:44715:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1442075|h|h
Invisibility:		45237
Major Fortitude:	61698
Lingering Restore Health: 79705
Item: Essence of Immovability, Link: |H1:item:27039:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1250565|h|h
Increase Detection:	45236
Major Endurance:	61705
Crafted (Negative Effects):
Code:
Item: Essence of Ravage Health, Link: |H1:item:44812:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:132626|h|h
Minor Enervation:	79907
Ravage Health:		46113
Ravage Stamina:		46199
Item: Essence of Ravage Health, Link: |H1:item:44812:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:139264|h|h
Minor Timidity:		140699
Ravage Health:		46113
Item: Essence of Ravage Magicka, Link: |H1:item:44815:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:265216|h|h
Ravage Magicka:		46193
Minor Cowardice:	79867
Item: Essence of Ravage Armor, Link: |H1:item:27040:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:659968|h|h
Physical Resistance Reduction: 46208
Minor Enervation:	79907
Item: Essence of Entrapment, Link: |H1:item:54333:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1311744|h|h
Ravage Magicka:		46193
Item: Essence of Hindering, Link: |H1:item:54335:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1580544|h|h
Hindrance:		46210
Minor Defile:		61726
Item: Essence of Ravage Stamina, Link: |H1:item:44809:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:399374|h|h
Ravage Stamina:		46199
Hindrance:		46210
Minor Maim:		61723
Item: Essence of Uncertainty, Link: |H1:item:54336:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1053184|h|h
Minor Uncertainty:	79895
Minor Enervation:	79907
Item: Essence of Ravage Health, Link: |H1:item:44815:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:264192|h|h
Ravage Magicka:		46193
Spell Resistance Reduction: 46206
Item: Essence of Creeping Ravage Health, Link: |H1:item:77594:308:50:0:0:0:0:0:0:0:0:0:0:0:0:36:1:0:0:0:1841664|h|h
Creeping Ravage Health: 79709
Minor Vulnerability:	79717

Two things are a bit odd.
The Invisibility is different on alliance and crafted potions.
Unstoppable does not seem to be given as a buff anymore with crafted potions (only seen on alliance potions).

If we put all these effects in one category (e.g. is potion), the new list would look like this (missing crown store and companion pots):
Code:
local isPotion = {
	--Positive
	[61698] = true, --"Major Fortitude",
	[61707] = true, --"Major Intellect",
	[61705] = true, --"Major Endurance",
	[45236] = true, --"Increase Detection",
	[45237] = true, --"Invisibility", INFO: Still has a different ID on alliance Potions 136002 (wtf?)
	[72930] = true, --"Unstoppable", INFO: Does not exist on crafted Potions anymore (wtf?)

	[61665] = true, --"Major Brutality",
	[61687] = true, --"Major Sorcery",
	[61736] = true, --"Major Expedition",
	[61667] = true, --"Major Savagery",
	[61689] = true, --"Major Prophecy",

	[79705] = true, --"Lingering Restore Health",
	[61721] = true, --"Minor Protection",
	[61713] = true, --"Major Vitality",
	
	[64564] = true, -- "Physical Resistance Potion",
	[64562] = true, -- "Spell Resistance Potion",
	[61708] = true, -- "Minor Heroism",
	
	-- Negative
	[46113] = true, --"Ravage Health",
	[46193] = true, --"Ravage Magicka",
	[46199] = true, --"Ravage Stamina",
	[79867] = true, --"Minor Cowardice",
	[61723] = true, --"Minor Maim",
	[46206] = true, --"Spell Resistance Reduction",
	[46208] = true, --"Physical Resistance Reduction",
	[46210] = true, --"Hindrance",
	
	[79907] = true, -- "Minor Enervation",
	[140699] = true, -- "Minor Timidity",
	[61726] = true, -- "Minor Defile",
	[79895] = true, -- "Minor Uncertainty",
	[79709] = true, -- "Creeping Ravage Health",
	[79717] = true, -- "Minor Vulnerability",
}
Hope this helps.
Report comment to moderator  
Reply With Quote
Unread 09/16/21, 03:11 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4912
File comments: 5990
Uploads: 78
Re: Current IDs

Thanks for the update.
Unfortuately I do not have the time to check all buff Ids again and IF ZOs really is not using different Ids for the crafted/-crafted or even crown potions anyore we do not have any chance to distinguish them, correct

If you are able to provide a list of the current abilityIds of all/some potions + the name/itemlink of the potion, this would help a lot to get an overview what really has changed. Else we could also ask ZOsDanBatson if he knows what was changed.

Originally Posted by Sordrak
Hi Baertram

We just had a little chat about the current IDs.
Unfortunately it seems that some or all IDs have changed.

In my short tests, the Major Endurance buff of a crafted potion had the ID 61705.
Unfortunately, a non-crafted (dropped green potion) had the exact same ID for that buff.

I'm not sure if it is still possible to distinguish the source properly now.
Furthermore, AddOns relying on this library may not work properly anymore.

Do you have any suggestions?
If i may provide any help in fixing the issue, let me know.

And thanks for your time.
Report comment to moderator  
Reply With Quote
Unread 09/16/21, 01:31 PM  
Sordrak
 
Sordrak's Avatar
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 355
Uploads: 4
Current IDs

Hi Baertram

We just had a little chat about the current IDs.
Unfortunately it seems that some or all IDs have changed.

In my short tests, the Major Endurance buff of a crafted potion had the ID 61705.
Unfortunately, a non-crafted (dropped green potion) had the exact same ID for that buff.

I'm not sure if it is still possible to distinguish the source properly now.
Furthermore, AddOns relying on this library may not work properly anymore.

Do you have any suggestions?
If i may provide any help in fixing the issue, let me know.

And thanks for your time.
Report comment to moderator  
Reply With Quote
Unread 05/11/19, 09:12 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4912
File comments: 5990
Uploads: 78
LibPotionBuff without LibStub
Use global variable LibPotionBuff instead to call it!

Example:

Lua Code:
  1. local lpb = LibPotionBuff
  2. if lpb == nil and LibStub then lpb = LibStub("LibPotionBuff") end

In your addon's manifest ttx be sure to add LibPotionBuff to the ##DependsOn: entry:

Code:
##DependsOn: LibPotionBuff
And remove LibStub from the DependsOn and OptionalDependsOn as this should be handled in the library's own txt file (if installed as stadnalone and NOT included in your addon zip file) on it's own via LibPotionBuff.txt -> ##DependsOn: LibStub or even not anymore for the new version.

If you have the libraries included into your addon's zip archive you should start to remove them, or be sure to support them properly so either users containing older versions of your addon WITH LibStub libraries are able to use it AND new versions without it as well (as shown above in the example).
Report comment to moderator  
Reply With Quote
Unread 09/17/18, 11:17 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4912
File comments: 5990
Uploads: 78
Thanks Lakashi, quick and good find! Fixed now + added dependency to LibStub properly.
Report comment to moderator  
Reply With Quote
Unread 09/17/18, 10:16 AM  
Lakashi
 
Lakashi's Avatar

Forum posts: 4
File comments: 74
Uploads: 0
In the LibPotionBuff.txt, you have "libs\LibPotionBuff\LibPotionBuff.lua" as the directory and the lua is actually sitting in the root. Same with the LibStub as well, there is no libs directory.

Temporary fix:
Make the LibPotionBuff.txt line 7 and 8 read as:
Code:
LibStub\LibStub.lua
LibPotionBuff.lua
Last edited by Lakashi : 09/17/18 at 10:21 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump:

Support AddOn Development!

You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.