Bandits Loot Manager : Bags, Bank, Inventory : Elder Scrolls Online AddOns

(17 Kb)

Download

Updated: 11/05/22 03:21 AM

Add Favorite

Install Help

Pictures

File Info

Compatibility:	Firesong (8.2.5) High Isle (8.0.0) Greymoor (6.0.5)
Updated:	11/05/22 03:21 AM
Created:	02/27/19 08:40 AM
Monthly downloads:	1,146
Total downloads:	116,611
Favorites:	123
MD5:

Bandits Loot Manager Popular! (More than 5000 hits)

Version: 1.21

by: Hoft [More]

Inventory, bank and loot manager

1.21
- API update

1.20
- API update
- Menu fix

1.18
- Consumable items fix

1.17
- API update
- SavedVars fix

1.16
- API update
- Update for LibAddonMenu-2.0 r31

1.15
- Bandits options menu compatibility
- Bursar option fix for ornate shields, added other Bursar quests support

1.14
- Local settings fix

1.13
- Added subscriber bank support

1.12
- API update
- New filters
- New options
- Settings are now combination of account and character (read tooltip in up right corner)

1.11
- Depositing characer bound items fix: Thx to token419
- Added some useless filters: Thx to token419

1.10
- API update
- Menu update
- Move items algorithm improvement

1.9
- Lure filter fix

1.8
- Set items filter fix

1.7
- Unmark as junk fix
- Added additional filters

1.6
- Laundry fix
- Spell fix
- Added filters: Treasure/survey maps, Master writs, Trophy key/runebox fragments.

Archived Files (15)

File Name	Version	Size	Uploader	Date
Bandits Loot Manager	1.20	17kB	Hoft	06/16/22 12:22 AM
Bandits Loot Manager	1.18	17kB	Hoft	09/22/20 04:01 PM
Bandits Loot Manager	1.17	17kB	Hoft	08/07/20 04:16 AM
Bandits Loot Manager	1.16	17kB	Hoft	06/27/20 06:55 AM
Bandits Loot Manager	1.15	17kB	Hoft	09/12/19 08:54 AM
Bandits Loot Manager	1.14	17kB	Hoft	08/28/19 01:01 AM
Bandits Loot Manager	1.13	16kB	Hoft	08/13/19 08:55 PM
Bandits Loot Manager	1.12	16kB	Hoft	08/08/19 03:24 AM
Bandits Loot Manager	1.11	14kB	Hoft	06/21/19 10:20 AM
Bandits Loot Manager	1.10	13kB	Hoft	05/16/19 03:31 AM
Bandits Loot Manager	1.9	13kB	Hoft	03/26/19 09:22 AM
Bandits Loot Manager	1.8	13kB	Hoft	03/09/19 04:06 PM
Bandits Loot Manager	1.7	13kB	Hoft	03/06/19 08:59 AM
Bandits Loot Manager	1.6	13kB	Hoft	02/28/19 05:31 PM
Bandits Loot Manager	1.5	13kB		02/27/19 08:40 AM

Comment Options

Page 3 of 13

Last »

06/05/19, 04:15 PM

token419

Forum posts: 0

File comments: 12

Uploads: 0

Originally Posted by token419

I ran into somewhat of a bug, the Purple potions that are "Character Bound" are trying to be deposited into the bank when they cannot be. I'm not sure if there is a flag, but if there is you may want to add an exclusion for "Character Bound" potions when trying to add them to the bank.

I was able to fix this by adding a GetItemLinkBindType check to the following line:

Code:

if not data.isJunk and not IsItemLinkStolen(itemLink) and not IsItemLinkCrafted(itemLink) and GetItemLinkBindType(itemLink) ~= BIND_TYPE_ON_PICKUP_BACKPACK then

However after the fix, i am still running into issues where some of my writs and surveys are not being pulled from the bank automatically, i do have a lot on my main crafter. Probably 80-100 of each.

I had assumed previously that it was getting stuck due to the character bound items, but i can validate that is not the case after the fix to ignore character bound items.

Last edited by token419 : 06/05/19 at 08:31 PM.

06/13/19, 03:05 PM

token419

Forum posts: 0

File comments: 12

Uploads: 0

Originally Posted by token419

I was able to fix this by adding a GetItemLinkBindType check to the following line:

Code:

if not data.isJunk and not IsItemLinkStolen(itemLink) and not IsItemLinkCrafted(itemLink) and GetItemLinkBindType(itemLink) ~= BIND_TYPE_ON_PICKUP_BACKPACK then

I think i found the source of the bug with items not being removed, or partially. I wrote in some debugging logic and found that only 200 slots of the bank were being checked for withdraw.

In the MoveItems function if you change to SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BANK, BAG_SUBSCRIBER_BANK) instead of SHARED_INVENTORY.bagCache[BAG_BANK] it lists the entire bank for ESO+ subscribers instead of just the first 200 items.

The edited line would look like this:

Code:

local BagCache={[BAG_BACKPACK]=SHARED_INVENTORY.bagCache[BAG_BACKPACK],[BAG_BANK]=SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BANK, BAG_SUBSCRIBER_BANK)}

However after correcting this, i am still not getting all my items automatically withdrawn from the bank, still digging to find the source of the bug.

06/13/19, 05:13 PM

token419

Forum posts: 0

File comments: 12

Uploads: 0

Originally Posted by token419

In the MoveItems function if you change to SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BANK, BAG_SUBSCRIBER_BANK) instead of SHARED_INVENTORY.bagCache[BAG_BANK] it lists the entire bank for ESO+ subscribers instead of just the first 200 items.

The edited line would look like this:

Code:

local BagCache={[BAG_BACKPACK]=SHARED_INVENTORY.bagCache[BAG_BACKPACK],[BAG_BANK]=SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BANK, BAG_SUBSCRIBER_BANK)}

This works for iteration of the bank items, however the itemlinks are not populating for all the items, which i belive to be on ZoS's end, which is causing the withdraw of items from the bank to fail since the checks are being made off itemlinks.

I'm still working on a way to implement iterating both banks, but i have to do some trials, so i'll come back and hammer more tomorrow

06/16/19, 04:27 AM
token419 Forum posts: 0 File comments: 12 Uploads: 0	For anyone watching the thread, I've reached out to Hoft via PM and we've had dialog for a few days. We now have the source on github and i'm going to be working to fix the issues I've identified. I have also added in most of the feature requests other's/myself have had on my local copy and Hoft has agreed to accept most of them, so we should see those in the future as well. The one's we haven't agreed upon, I am going to try to make convincing arguments, but can't guarantee anything. Hoft mainly does not want to clutter the UI which I also agree with, so I am going to see if i can visually present the additions without creating too much visual distraction, while maintaining Bandit's superior functionality. The future is exciting

06/16/19, 11:47 AM
dlrgames Forum posts: 1 File comments: 43 Uploads: 1	I don't have the addon set to do anything with any potions, but when visiting the bank the chat log is showing deposits of all Stamina & Magicka pots in the character inventory. It isn't actually moving anything to the bank, so it's just annoying clutter for now.

06/17/19, 04:31 AM

token419

Forum posts: 0

File comments: 12

Uploads: 0

Originally Posted by dlrgames

I don't have the addon set to do anything with any potions, but when visiting the bank the chat log is showing deposits of all Stamina & Magicka pots in the character inventory. It isn't actually moving anything to the bank, so it's just annoying clutter for now.

Are the potions it's showing the "Purple" quality ones that are "Crown" type potions? Usually acquired when leveling up? If so, can you hover your mouse over them and check if it says "Character Bound"?

If not, can you list the potions here, or take a screenshot?

If they are "Character Bound" that will be fixed once Hoft merges in my fixes, if not i'd like to identify them so i can fix that

06/17/19, 05:15 AM
token419 Forum posts: 0 File comments: 12 Uploads: 0	Also to summarize what i've fixed, and to group all the community feature requests/bugs into one post: Fixed Bugs: There was a bug where when depositing/withdrawing items from the bank some items were being overlooked. This was because ESO actually has 2 banks, one standard bank, and one bank for ESO+ subscribers. I believe this is what Baratox / Jadex ran into when they described items not being pushed/pulled from bank properly in their comments. This will be resolved once my fixes are merged. There was a bug where "Character Bound" items were attempting to be pushed/pulled from the bank. I believe this is what Dirgames has ran into. This will be resolved once my fixes are merged. Outstanding Bugs: Bergur is running into an issue where items are not being stacked when attempting to be added to the bank. There is a system in place currently that attempts to stack an item in the bank, and if the stack size would excede the maximum stack size, it attempts to simply place the item into a free slot. I believe this is what you are running into, where item's are not stacked, because it's trying to allocate a new space, but you do not have any free spaces. I run into a different manifestation of this, where when i do crafting writs, I get say 3 soul gems, and i have 200 in a full stack, it always pulls 3 from my full stack and puts them into the bank, leaving me with 2 stacks in my inventory I'm going to try to tackle this one soon and upgrade the current system, but its lower priority. Token419 is running into an issue where Unique item's are attempting to be pushed/pulled from the bank, even if the character currently has one in their inventory. This one will be difficult with the current systems, as there is no look ahead currently. I have some ideas on how to tackle this, by creating a shadow bank/inventory and applying the rules there first, then doing the actual moves, but haven't had time to implement. Also there are performance concerns with adding in another set of checks. Feature Requests: baratox - Jycs - richo262 - token419: Would like more fine grained control of managing armor. I've briefly spoken to hoft about this, but he doesn't want to complicate the options. I'm going try to discuss this with him further in more detail though and explain some pain points and see if we can come to a resolution. token419: would like intricate's separated for more fine grain control of pushing/pulling from the bank. Currently they are listed in with filters that are more for junking items than saving, and they sell fast and are great for leveling alts. fioskal: - stock crafted pots. I agree with hoft's response that there are simply way too cleanly display all the crafted potion types. I would like this as well, to stock spellpower potions on my mag, and damage ones on my stam etc, but from what I can tell, ESO does not simply list the traits as individual entities, they use an equation to display a numerical value for all the traits. For reference I found this post on UESP about Item links, and specifically option 21 which is potion effects: https://en.uesp.net/wiki/Online:Item_Link, if you scroll down you can see how the potion effect value is created. Craftstore may have good insight into how to implement something like this, but from what i gather it wouldn't be visually clean. Perhapse i'll play with it sometime though and see if i can come up with something. kernkraft-3000: - wants keybind for marking items as junk. This should be somewhat easy to implement if Hoft will agree to it. If Hoft gives the go ahead, i'll try to take a look and see if we can come up with something. I'm still learning ESO stuff so it'll be good practice to have to make a keybind options setting For reference there was an addon called "Junkee" that did this as well as "Destroy" keybinds, since this is a loot manager afterall, and we don't want to be leaving treasure chests with only 1 item in them!!! It makes sense to add those keybinds into an options/keybinds screen. Last edited by token419 : 06/17/19 at 05:27 AM.

06/17/19, 10:16 AM

dlrgames

Forum posts: 1

File comments: 43

Uploads: 1

Originally Posted by token419

Originally Posted by dlrgames

No, they are just random potions picked up in the world. None are bound. I also have Crown items in inventory and they were not affected.

I'll try to get a list next time.

06/17/19, 10:23 AM
dlrgames Forum posts: 1 File comments: 43 Uploads: 1	Empty Soul Gems moved to bank Found another off behavior - I have the addon set to keep 100 Soul Gems in character inventory with push/pull to bank active. I didn't choose to do anything with empty Soul Gems, but they are all getting grabbed and put into the bank.

06/17/19, 02:22 PM
dlrgames Forum posts: 1 File comments: 43 Uploads: 1	Update on odd deposits OK, just visited my banker & here's what happened: Withdrawn Soul Gem x1 - correct activity Deposited Soul Gem (empty) x1 - wrong, I don't have anything set for empty Soul Gems The following were logged in the chat window, but did not actually happen: Deposited Potion of Magicka x17 Deposited Draught of Magicka x22 Deposited Solution of Magicka x30 Deposited Philter of Magicka x6 Deposited Potion of Stamina x19 Deposited Draught of Stamina x11 Deposited Solution of Stamina x50 Character had Crown potions and crafted potions in its inventory that were not touched

06/17/19, 04:44 PM

token419

Forum posts: 0

File comments: 12

Uploads: 0

Re: Update on odd deposits

Originally Posted by dlrgames

OK, just visited my banker & here's what happened:
The following were logged in the chat window, but did not actually happen:
Deposited Potion of Magicka x17
Deposited Draught of Magicka x22
Deposited Solution of Magicka x30
Deposited Philter of Magicka x6
Deposited Potion of Stamina x19
Deposited Draught of Stamina x11
Deposited Solution of Stamina x50

Interesting, I've seen that a lot on my private copy while i was fixing the bank section for ESO+ subscribers, but it shouldn't be related to the ESO+ bank since the current public version has no knowledge of the ESO+ bank.

If you get another free moment, can you do a few things for me:

Are you an ESO+ Subscriber?
Is your bank currently full? (excluding stackable items)
Open your bank repeatedly, does it show the same messages?
If so, pick one potion from the list, lets say "Solution of Stamina" and give the count that the addon is messaging, and what size the stack in your bank is.

I'm wondering if its related to the stacking logic where maybe your bank is full and it's flagged the item's to get stacked, it can't properly stack since the combination of potions in your inventory + the stack size in the bank is larger than the item's max stack size (100) for trash pots.

Last edited by token419 : 06/17/19 at 04:46 PM.

06/17/19, 06:05 PM

dlrgames

Forum posts: 1

File comments: 43

Uploads: 1

Re: Re: Update on odd deposits

Originally Posted by token419

If you get another free moment, can you do a few things for me:

Are you an ESO+ Subscriber?
Is your bank currently full? (excluding stackable items)
Open your bank repeatedly, does it show the same messages?
If so, pick one potion from the list, lets say "Solution of Stamina" and give the count that the addon is messaging, and what size the stack in your bank is.

1 - yes, I have ESO+
2 - the same behavior occurs whether the bank id full or not
3 - yes
4 - I don't have any of the potions in the bank. The addon acts like it is depositing them, but it doesn't. I can try putting some in the bank and see if the deposit actually occurs.

UPDATE:
I put one of the Magicka pots in the bank to see if it would stack them. No change, chat log says they are being deposited, but nothing is moved.

Last edited by dlrgames : 06/17/19 at 09:01 PM.

06/18/19, 11:35 AM
dlrgames Forum posts: 1 File comments: 43 Uploads: 1	Another one ... Another behavior I just found. I visited the bank and the addon moved all the Grand Repair Kits out of the character inventory to the bank. I don't have the addon set to do anything with repair kits. I took some out of the bank and put them back in the character inventory, the next time I visited the bank it did nothing. Last edited by dlrgames : 06/18/19 at 11:37 AM.

06/19/19, 12:47 PM

Archamus

Forum posts: 0

File comments: 24

Uploads: 0

Re: Another one ...

Originally Posted by dlrgames

Another behavior I just found. I visited the bank and the addon moved all the Grand Repair Kits out of the character inventory to the bank. I don't have the addon set to do anything with repair kits.
I took some out of the bank and put them back in the character inventory, the next time I visited the bank it did nothing.

And I just found that mine refuses to move grand repair kits at all. It's also not moving my lockpicks at all. I was having some other issues with other things last night, but I unhelpfully didn't take notes.

06/19/19, 03:22 PM

Hoft

Forum posts: 17

File comments: 1713

Uploads: 12

Re: Empty Soul Gems moved to bank

Originally Posted by dlrgames

I have the addon set to keep 100 Soul Gems in character inventory with push/pull to bank active. I didn't choose to do anything with empty Soul Gems, but they are all getting grabbed and put into the bank.

Originally Posted by dlrgames

I visited the bank and the addon moved all the Grand Repair Kits out of the character inventory to the bank. I don't have the addon set to do anything with repair kits.

It is not documented function. If you check "push to bank" box in consumables section then all "disabled" consumables will be deposited.

Page 3 of 13

Last »

Report this File