Download
(25 Kb)
Download
Updated: 06/13/22 05:04 AM
Patch for:
LibTreasure.
Compatibility:
High Isle (8.0.0)
Updated:06/13/22 05:04 AM
Created:06/13/22 05:04 AM
Monthly downloads:37
Total downloads:2,733
Favorites:1
MD5:
LibTreasure-HighIsle
Version: 2
by: pesakm [More]
Added treasure maps for High Isle
Post A Reply Comment Options
Unread 06/13/22, 12:24 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 652
Uploads: 2
Originally Posted by Baertram
As requested by the dev of the original lib I'll remove this patch now and move it to the outdated section.
As he asked to please report the missing data at the original library and wait for an update instead of creating patches directly.
Thanks for your understanding.

@Gamer1986Pan If you guys do not want someone to create patches please disable the patch possibilities at the addon/library settings!
done thx for the heads up.
Report comment to moderator  
Reply With Quote
Unread 06/13/22, 12:21 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4973
File comments: 6038
Uploads: 78
As requested by the dev of the original lib I'll remove this patch now and move it to the outdated section.
As he asked to please report the missing data at the original library and wait for an update instead of creating patches directly.
Thanks for your understanding.

@Gamer1986Pan If you guys do not want someone to create patches please disable the patch possibilities at the addon/library settings!
Report comment to moderator  
Reply With Quote
Unread 06/13/22, 12:18 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4973
File comments: 6038
Uploads: 78
Originally Posted by NeuroticPixels
I’m confused….
Is this a patch to be used WITH the original LibTreasure?
Or is this meant to replace LibTreasure?
"Patches" are nothing else than added files or replacements for addons. And libraries = normal addons too, in terms of "addons".
So optional files at any addon which state to be a patch will just add files or replace files of existing addons.

The bad side is:
If they "just add files" Minion will do the same as with normal addons and download the zip file, delete the original addon's folder in total and then extract the patch files. If the patch only contains 1 file of 10 it will break the addon that way so no matter if the patches only change 1 file in code they should simply include ALL files of the total addon in the zip file so that manually extracting or Minion dl and extract work properl and do not break any addon.

In this case here this patch was a changed file of LibTreasure and was replacing that library to add the new data for the treasure maps.

@pesakm Thanks.
It does not matter if ppl do not find the files, the files have to relate to the correct parent file please. I do not want to start cross-references here as THIS clearly is more confusing as referencing the correct file where the patch belongs to (and you just "think it might be confusing because ppl do not understand where the data resists" > change the addon description then to tell ppl where the data comes from or teach them by other ressources, but do not try to solve this with something like this please). A patch of addon1 cannot be applied to addon2! It will break addon2.
And it Minion 4 comes some day it will check for e.g. patches and show them related to their parent. In your case it woudl show this patch here of LibTreasure to be a patch of LostTreasure making users download it and break the addon as the folder "LostTreasure" is deleted by Minion and simply LibTreasure would be downloaded and reinstalled via your patch. That totally makes no sense and just currently is not breaking anything as Minion 3is not doing this yet.
But also manual searches and clicks at the library would never show this patch and ppl would never find it properly regardless what you think "is easier for them to find it". Ppl looking in the right spot would never see it, and ppl looking in the wrong spot would wonder or get educated wrong how it works
Last edited by Baertram : 06/13/22 at 12:19 PM.
Report comment to moderator  
Reply With Quote
Unread 06/13/22, 11:22 AM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 652
Uploads: 2
@Baertram, this can be deleted, i already was in contact with the original author Scootworks to update it, but was only missing "{ 0.4597, 0.6066, "treasuremap_highisle_06", 187676 }, -- High Isle Treasure Map VI" because no finder so far did post the bug report from the miner where it belongs for this map.

Next time please only post the bug reports so we can update the lib on time - thx for your understanding and the missing map.
Last edited by Gamer1986PAN : 06/13/22 at 11:28 AM.
Report comment to moderator  
Reply With Quote
Unread 06/13/22, 10:54 AM  
NeuroticPixels
Addon Addict
 
NeuroticPixels's Avatar
Premium Member

Forum posts: 211
File comments: 869
Uploads: 0
I’m confused….
Is this a patch to be used WITH the original LibTreasure?
Or is this meant to replace LibTreasure?
Report comment to moderator  
Reply With Quote
Unread 06/13/22, 10:36 AM  
pesakm
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 30
Uploads: 9
If I uploaded it as optional patch to the LibTreasure, no one would probably find it at all (probably very few people nows that map data is in that librarary).

But OK, next time I upload it to the LibTreasure and put a link to the Lost Treasure forum.

Originally Posted by Baertram
If you release a patch or optional addon for another addon please link it to the correct SAME addon/library and not any other!
LibTreasure HighIsle -> LibTreasure (and not patch to "LostTreasure" which is a totally different addon which only uses LibTreasure as a dependency).

I've fixed that.
Thank you
Report comment to moderator  
Reply With Quote
Unread 06/13/22, 08:10 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4973
File comments: 6038
Uploads: 78
If you release a patch or optional addon for another addon please link it to the correct SAME addon/library and not any other!
LibTreasure HighIsle -> LibTreasure (and not patch to "LostTreasure" which is a totally different addon which only uses LibTreasure as a dependency).

I've fixed that.
Thank you
Last edited by Baertram : 06/13/22 at 08:11 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: