Download
(36 Kb)
Download
Updated: 04/23/24 12:48 AM
Compatibility:
Gold Road (10.0.0)
Scions of Ithelia (9.3.0)
Updated:04/23/24 12:48 AM
Created:01/21/20 03:40 PM
Monthly downloads:37,619
Total downloads:3,940,350
Favorites:626
MD5:
10.0.0
LibCombat  Popular! (More than 5000 hits)
Version: 73
by: Solinur [More]
DEpendency

The following library is optional:

Description

Please note that the library is not complete yet, so some of the API could still change.

This library is providing the data collection for Combat Metrics.
However I tried to make it in such a way it can be used for other addons which may only need parts of the data.
Additionally it can provide human readable combat log lines, which are arranged so they should be translatable.
I tried to optimize the code to impact the performance as little as possible.

For useage instructions and feedback please have a look at the github repository: https://github.com/Solinur/LibCombat

Solinur (EU)
73
  • Added support for some Update 42 changes. (Thx to Anthonysc)

72
  • Fixed an error due to removed constants

71
  • Fixed tracking of Pulsar. (Thx to isiiimode for reporting)
  • Minor Fixes

70
  • Fixed tracking of several Arcanist abilities (incl. Fulminating Rune) when main resource is Stamina (Thx to Helix and brdalert for reporting this).

69
  • Reverted some code that was not ready for publishing

68
  • Added Support for weaving tracking of Arkanist Skill Lines
  • Fixed and improved tracking of resources.

67
  • Added support for Force of Nature (by popular request)

66
  • Fixed an issue where Z'en stacks could go higher than 5.
  • Fixed an issue where each stack of Relequen would add a Z'en stack.

65
  • Removed some unnecessary debug messages (Thx to DakJaniels for reporting this)
  • Added "damageOutTotal" entry to the table provided with the LIBCOMBAT_EVENT_FIGHTRECAP callback.

64
  • Added a fix for an issue that caused a Lua error on rare occasions. (Thx to ithildae for the report)

63
  • Added support for tracking stacks of Z'en and the spell and weapon damage buff of seething fury.
  • Slight changes for tracking of special buffs to include stacks (via Combat Events).

62
  • Removed obsolete code
  • API Bump to Firesong (100036)

61
  • Adjusted crit damage bonus from Backstabber to new value. (Thx to Complicative for the hint)

60
  • Fixed an issue where ability costs were not attributed properly. (Thx to Hypno for reporting)

59
  • Added compatibility with High Isle (API 101034).

58
  • Fixed issue with skill activation tracking of Meteor and its morphs. (thx to Skinny Cheeks for reporting the issue)

57
  • Fixed some issues with skill activation tracking. (thx to Skinny Cheeks and virtus753 for reporting the issue)

56
  • Added tracking of glacial presence passive and the (hidden) chilled debuff to allow tracking of the respective critical damage bonus.
  • Removed some legacy code

55
  • Added number of stacks to buff events in combat log
  • Removed Grim Focus tracking as it is no longer needed

54
  • Fix an issue where incoming critical hits were not properly shown in logs (Thx to shira for reporting this).

53
  • Added workaround for Grim Focus, to correctly calculate its contribution to the critical damage bonus stat. (thx to master_vanargand for pointing this out)
  • Added missing license file.

52
  • Another fix to finally make it work for all ESO supported languages (and hopefully all others too)

51
  • Fixed parsing of strings to determine the critical damage bonus by shadow mundus for russian language.

50
  • Reworked critical damage tracking to use the advanced stats info from ZOS (including adjustments like backstabber to keep it consistent with how it was shown up until now).

49
  • Updated the crit bonus value for Khajits
  • Added the crit bonus tracking for dual wield and 2H-Axes
  • Added detection of trial dummies
  • Updated tracking of penetration value from Alkosh, set it to 3000 instead
  • Remove a spammy debug message

48
  • Fixed an issue where Backstabber was included to the critical damage bonus even when not slotted

47
  • Fixed an issue where stat update events were too spammy.

46
  • Disabled advanced stats tracking, since it causes major performance issues. Gotta investigate before returning them.

45
  • Fixed an issue with resource tracking.

44
  • Added tracking for new CP system and advanced stats.
  • API Bump to Flames of Ambition (100034)

43
  • Fixed an issue where crystal frag casts were not properly reported

42
  • Fixed an issue that could lead to inconsistent DPS numbers for a fight.

41
  • Fixed an issue where damage to shields was not properly counted.
  • Fixed an issue where resource values where sometimes missing in death recaps.

40
  • Fixed Major Force value since it was still set to 15% (Thx to @Wrath of Innos)

39
  • Fixed an issue where heals would fail to be recorded.
  • Removed some debug spam

38
  • Changed the way damage versus absorbing shields is handled. The shield event will be shown as usual but sent with the Heal callbacks. The combat event for damage callback will now send the normal event with the proper action result and contain the shielded fraction in the overflow field.
  • Adjusted handling of shields in combat log string creation
  • Added workaround for Minor Magickasteal
  • Added some adjustments to skill timing after ZOS changed something again to fix LA weaving

37
  • Removed skill timing events firing when out of combat

36
  • Reworked skill timing to fix several issues. Now also the input registration and queue activation will trigger a callback
  • Added some code that might help in cases where combat end is not properly detected.

35
  • Fixed penetration values for TFS. While the penetration API function is not doing what it should either (its not tracking stacks higher than 1 at all), the wrong value was my fault. Should work fine now, I hope.

34
  • Reverted critical damage bonus calculation to the previous method (but with fixed values), since the ZOS tooltip hast turned out to be inaccurate.
  • Bug: Physical penetration values are not working correctly when TFS is involved. The underlying API function is bugged and applies the old increase of 860 pen for every stack higher or equal than two. I will fix this if possible, but it will require some work.

33
  • Corrected the calculation for critical damage values to mind the new values from shadow mundus. It will now extract the value from the same tooltip which you can see in the character window, instead of using a hard coded base value and the extracted bonus from divine pieces.
  • Some small fixes and changes for future use.

32
  • API Bump to Stonethorn (100032)
  • Added special tracking for the new Alkosh penetration debuff
  • Small fixes

31
  • Put back tracking of skill timings for Necro Siphon since it is back on GCD
  • Removed tracking of skill timing for Blood Frenzy and it's morphs, since they are off the GCD
  • Fixed an issue where a lua error would appear if an old version of libdebuglogger was installed

30
  • Fixed some issues with skill timing events. (Thx @ wraith1515 for reporting)

29
  • Fixed version number

28
  • Fixed a lua error that could happen when leaving Battleground or Cyrodil in some cases

27
  • Reworked event registration functions (e.g. lib:RegisterForCombatEvent). The behaviour and syntax now matches event registration of the ESO API (EVENT_MANAGER:RegisterForEvent). The old functions are still supported but may be removed in the future.
  • LibCombat:RegisterCallbackType(callbacktype, callback, name) --> LibCombat:RegisterForCombatEvent(name, callbacktype, callback), returns: isRegistered
  • LibCombat:UnregisterCallbackType(callbacktype, callback, name) --> LibCombat:UnregisterForCombatEvent(name, callbacktype), returns: isUnregistered
  • LibCombat:RegisterAllLogCallbacks(callback, name) --> LibCombat:RegisterForLogableCombatEvents(name, callback)
  • LibCombat now optionally depends on libdebuglogger. It is set up to handle all debug output and also saves them for later review. When it is not installed no debug output will be shown.
  • Small fixes and performance improvements.
  • Added new events for performance (ping, fps).
  • Added field skillDelay to LIBCOMBAT_EVENT_SKILL_TIMINGS events.
  • Changed boss assignment to not just check if unit is a boss on unit initialization but all the time.
  • Consolidated the preliminary event LIBCOMBAT_EVENT_RESURRECTION into LIBCOMBAT_EVENT_DEATH. This one is still work in progress.

26
  • Fixed an issue that prevented display names (@Names) to be added to unit info.

25
  • Updated ability IDs used in a couple of places, since ZOS seemed to have removed a few.

24
  • initial release as standalone library
  • fixed formatting issue in log for stats
  • fixed issue with crit damage values when buff is only refreshed but not applied completely new
Archived Files (49)
File Name
Version
Size
Uploader
Date
72
36kB
Solinur
03/11/24 12:39 PM
71
36kB
Solinur
12/14/23 02:07 PM
70
35kB
Solinur
06/21/23 04:06 PM
69
35kB
Solinur
06/04/23 04:15 PM
68
35kB
Solinur
06/04/23 04:07 PM
67
34kB
Solinur
05/15/23 04:18 PM
66
33kB
Solinur
03/15/23 05:09 PM
65
33kB
Solinur
03/11/23 03:45 AM
64
38kB
Solinur
12/28/22 01:28 PM
63
38kB
Solinur
12/19/22 03:10 PM
62
37kB
Solinur
11/09/22 04:55 PM
61
31kB
Solinur
06/12/22 03:16 PM
60
31kB
Solinur
06/10/22 02:04 PM
59
32kB
Solinur
06/03/22 03:12 PM
58
31kB
Solinur
02/12/22 06:38 AM
57
31kB
Solinur
01/18/22 05:37 PM
56
32kB
Solinur
12/28/21 10:41 AM
55
32kB
Solinur
11/05/21 01:30 PM
54
32kB
Solinur
07/05/21 04:06 PM
53
32kB
Solinur
06/15/21 03:58 PM
52
28kB
Solinur
06/11/21 05:07 PM
51
28kB
Solinur
06/11/21 04:48 PM
50
28kB
Solinur
06/09/21 01:50 PM
49
29kB
Solinur
04/17/21 04:01 PM
48
29kB
Solinur
03/15/21 05:56 PM
47
29kB
Solinur
03/08/21 04:28 PM
46
29kB
Solinur
03/08/21 02:37 PM
45
29kB
Solinur
03/06/21 07:43 AM
44
29kB
Solinur
03/04/21 05:52 PM
43
28kB
Solinur
01/30/21 07:04 AM
42
28kB
Solinur
12/25/20 02:52 PM
41
28kB
Solinur
12/13/20 03:13 PM
40
28kB
Solinur
12/04/20 03:38 PM
39
28kB
Solinur
12/04/20 02:07 PM
38
28kB
Solinur
12/02/20 05:19 PM
37
27kB
Solinur
10/20/20 03:45 PM
36
27kB
Solinur
10/13/20 04:18 PM
35
26kB
Solinur
09/20/20 11:35 AM
34
26kB
Solinur
09/20/20 04:41 AM
33
26kB
Solinur
09/17/20 11:55 AM
32
26kB
Solinur
08/24/20 02:11 AM
31
26kB
Solinur
06/09/20 03:15 PM
30
26kB
decay2
05/23/20 02:53 PM
29
26kB
decay2
05/19/20 04:50 PM
28
26kB
decay2
05/18/20 03:28 PM
27
26kB
decay2
05/17/20 02:25 PM
26
22kB
decay2
03/22/20 10:06 AM
25
22kB
decay2
02/25/20 04:11 PM
24
22kB
decay2
01/21/20 03:40 PM


Post A Reply Comment Options
Unread 06/18/24, 02:55 PM  
Solinur
AddOn Author - Click to view AddOns

Forum posts: 78
File comments: 721
Uploads: 8
Re: Re: Re: Re: Re: Re: Re: Re: Re: Libcombat causing crash

Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
i can load in with all of my other addons just fine. i can load in with combat metrics and combatmetricsfightdata enabled and libcombat disabled, but the addon doesnt work. as soon as i try enabling libcombat and loading in/reloadui, the game crashes. i have uninstalled both combat metrics and libcombat and reinstalled, and it still causes the same crash. everything worked fine before the gold road update.
I haven't heard of something like this yet, so it shouldn't be a general issue. Also recent code changes should not cause this in any way. My guess is, that the saved variables got corrupted (Antivirus is often a candidate because of interfering with the save process). So please try backing up the saved variables for combat metrics and remove them temporarily while trying to load the addon. Make sure you are logged out while doing anything with the files, otherwise any changes have no effect.
I backed up and deleted the saved variables for combat metrics, logged into the game, turned libcombat, combatmetricsfightdata, and combat metrics on. when loading into my character the same crash happens. i am not sure what to do at this point, i have even done a clean install of the game and still get the same crash. libcombat seems to be the only thing that causes the crash.
Hmm, I'll try to think about what can be done. It's already unusual that addons crash the game, but that it happens in such a way is even weirder. Due to the crash any debugging is also very limited. Have you tried with just LibCombat enabled?
just turned off all of my addons and logged into my character, loaded up just fine. turned on libcombat and reloaded my ui and crashed.
This just gets weirder and weirder. LibCombat on its own dowsn't ahve any SavedVariables (that could corrupt) and most of its functions are not active until another addon (such as Combat Metrics) sets up listeners.

If you are up to investigating further lets try a few things:

First: check that line 16 in LibCombat.lua (located in LibCombat folder in AddOns) shows: `lib.version = 73`
Then comment out the last line by adding "--" in front, that means line 4186 should be `-- Initialize()` --> Check if you char loads with only LibCombat enabled.
If this works we can try to troubleshoot the Initialization function. Remove the "--" added in the previous step and insert ` if true then return end`into line 4156. This terminates the function early. Now you can move this line downwards in steps, (for example that it is placed after line 4168, where the active bar is read) so that more and more of the Initialize function is allowed to run.
Perhaps this way one can find out what exactly causes the issue.
changed lines and tried loading in with only libcombat enabled and got the same crash. the version did read 73.
Which language are you playing in? Which operating system? Steam?
English, windows 10, and yes through steam.
Nothing unusual here.

I asked a bit around and for now the only idea is to gather more information.
So could you try to install https://www.esoui.com/downloads/info...bugLogger.html
Load into ESO without addons enabled and then try to do it with LibCombat enabled?

The addon will gather a bunch of info I can look trough, more details on what it gathers are on the addon page.
After you did that and the game crashed, could you send me the file? Via email at [email protected] or via discord: "solinur". You can also upload it to https://sir.insidi.at/or/logviewer/ (thats the page of the author of libdebuglogger) and create a link to send to me.
Report comment to moderator  
Reply With Quote
Unread 06/18/24, 01:49 PM  
Frostyx24

Forum posts: 0
File comments: 5
Uploads: 0
Re: Re: Re: Re: Re: Re: Re: Re: Libcombat causing crash

Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
i can load in with all of my other addons just fine. i can load in with combat metrics and combatmetricsfightdata enabled and libcombat disabled, but the addon doesnt work. as soon as i try enabling libcombat and loading in/reloadui, the game crashes. i have uninstalled both combat metrics and libcombat and reinstalled, and it still causes the same crash. everything worked fine before the gold road update.
I haven't heard of something like this yet, so it shouldn't be a general issue. Also recent code changes should not cause this in any way. My guess is, that the saved variables got corrupted (Antivirus is often a candidate because of interfering with the save process). So please try backing up the saved variables for combat metrics and remove them temporarily while trying to load the addon. Make sure you are logged out while doing anything with the files, otherwise any changes have no effect.
I backed up and deleted the saved variables for combat metrics, logged into the game, turned libcombat, combatmetricsfightdata, and combat metrics on. when loading into my character the same crash happens. i am not sure what to do at this point, i have even done a clean install of the game and still get the same crash. libcombat seems to be the only thing that causes the crash.
Hmm, I'll try to think about what can be done. It's already unusual that addons crash the game, but that it happens in such a way is even weirder. Due to the crash any debugging is also very limited. Have you tried with just LibCombat enabled?
just turned off all of my addons and logged into my character, loaded up just fine. turned on libcombat and reloaded my ui and crashed.
This just gets weirder and weirder. LibCombat on its own dowsn't ahve any SavedVariables (that could corrupt) and most of its functions are not active until another addon (such as Combat Metrics) sets up listeners.

If you are up to investigating further lets try a few things:

First: check that line 16 in LibCombat.lua (located in LibCombat folder in AddOns) shows: `lib.version = 73`
Then comment out the last line by adding "--" in front, that means line 4186 should be `-- Initialize()` --> Check if you char loads with only LibCombat enabled.
If this works we can try to troubleshoot the Initialization function. Remove the "--" added in the previous step and insert ` if true then return end`into line 4156. This terminates the function early. Now you can move this line downwards in steps, (for example that it is placed after line 4168, where the active bar is read) so that more and more of the Initialize function is allowed to run.
Perhaps this way one can find out what exactly causes the issue.
changed lines and tried loading in with only libcombat enabled and got the same crash. the version did read 73.
Which language are you playing in? Which operating system? Steam?
English, windows 10, and yes through steam.
Report comment to moderator  
Reply With Quote
Unread 06/18/24, 12:54 PM  
Solinur
AddOn Author - Click to view AddOns

Forum posts: 78
File comments: 721
Uploads: 8
Re: Re: Re: Re: Re: Re: Re: Libcombat causing crash

Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
i can load in with all of my other addons just fine. i can load in with combat metrics and combatmetricsfightdata enabled and libcombat disabled, but the addon doesnt work. as soon as i try enabling libcombat and loading in/reloadui, the game crashes. i have uninstalled both combat metrics and libcombat and reinstalled, and it still causes the same crash. everything worked fine before the gold road update.
I haven't heard of something like this yet, so it shouldn't be a general issue. Also recent code changes should not cause this in any way. My guess is, that the saved variables got corrupted (Antivirus is often a candidate because of interfering with the save process). So please try backing up the saved variables for combat metrics and remove them temporarily while trying to load the addon. Make sure you are logged out while doing anything with the files, otherwise any changes have no effect.
I backed up and deleted the saved variables for combat metrics, logged into the game, turned libcombat, combatmetricsfightdata, and combat metrics on. when loading into my character the same crash happens. i am not sure what to do at this point, i have even done a clean install of the game and still get the same crash. libcombat seems to be the only thing that causes the crash.
Hmm, I'll try to think about what can be done. It's already unusual that addons crash the game, but that it happens in such a way is even weirder. Due to the crash any debugging is also very limited. Have you tried with just LibCombat enabled?
just turned off all of my addons and logged into my character, loaded up just fine. turned on libcombat and reloaded my ui and crashed.
This just gets weirder and weirder. LibCombat on its own dowsn't ahve any SavedVariables (that could corrupt) and most of its functions are not active until another addon (such as Combat Metrics) sets up listeners.

If you are up to investigating further lets try a few things:

First: check that line 16 in LibCombat.lua (located in LibCombat folder in AddOns) shows: `lib.version = 73`
Then comment out the last line by adding "--" in front, that means line 4186 should be `-- Initialize()` --> Check if you char loads with only LibCombat enabled.
If this works we can try to troubleshoot the Initialization function. Remove the "--" added in the previous step and insert ` if true then return end`into line 4156. This terminates the function early. Now you can move this line downwards in steps, (for example that it is placed after line 4168, where the active bar is read) so that more and more of the Initialize function is allowed to run.
Perhaps this way one can find out what exactly causes the issue.
changed lines and tried loading in with only libcombat enabled and got the same crash. the version did read 73.
Which language are you playing in? Which operating system? Steam?
Report comment to moderator  
Reply With Quote
Unread 06/18/24, 09:17 AM  
Frostyx24

Forum posts: 0
File comments: 5
Uploads: 0
Re: Re: Re: Re: Re: Re: Libcombat causing crash

Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
i can load in with all of my other addons just fine. i can load in with combat metrics and combatmetricsfightdata enabled and libcombat disabled, but the addon doesnt work. as soon as i try enabling libcombat and loading in/reloadui, the game crashes. i have uninstalled both combat metrics and libcombat and reinstalled, and it still causes the same crash. everything worked fine before the gold road update.
I haven't heard of something like this yet, so it shouldn't be a general issue. Also recent code changes should not cause this in any way. My guess is, that the saved variables got corrupted (Antivirus is often a candidate because of interfering with the save process). So please try backing up the saved variables for combat metrics and remove them temporarily while trying to load the addon. Make sure you are logged out while doing anything with the files, otherwise any changes have no effect.
I backed up and deleted the saved variables for combat metrics, logged into the game, turned libcombat, combatmetricsfightdata, and combat metrics on. when loading into my character the same crash happens. i am not sure what to do at this point, i have even done a clean install of the game and still get the same crash. libcombat seems to be the only thing that causes the crash.
Hmm, I'll try to think about what can be done. It's already unusual that addons crash the game, but that it happens in such a way is even weirder. Due to the crash any debugging is also very limited. Have you tried with just LibCombat enabled?
just turned off all of my addons and logged into my character, loaded up just fine. turned on libcombat and reloaded my ui and crashed.
This just gets weirder and weirder. LibCombat on its own dowsn't ahve any SavedVariables (that could corrupt) and most of its functions are not active until another addon (such as Combat Metrics) sets up listeners.

If you are up to investigating further lets try a few things:

First: check that line 16 in LibCombat.lua (located in LibCombat folder in AddOns) shows: `lib.version = 73`
Then comment out the last line by adding "--" in front, that means line 4186 should be `-- Initialize()` --> Check if you char loads with only LibCombat enabled.
If this works we can try to troubleshoot the Initialization function. Remove the "--" added in the previous step and insert ` if true then return end`into line 4156. This terminates the function early. Now you can move this line downwards in steps, (for example that it is placed after line 4168, where the active bar is read) so that more and more of the Initialize function is allowed to run.
Perhaps this way one can find out what exactly causes the issue.
changed lines and tried loading in with only libcombat enabled and got the same crash. the version did read 73.
Last edited by Frostyx24 : 06/18/24 at 09:19 AM.
Report comment to moderator  
Reply With Quote
Unread 06/18/24, 08:29 AM  
Solinur
AddOn Author - Click to view AddOns

Forum posts: 78
File comments: 721
Uploads: 8
Re: Re: Re: Re: Re: Libcombat causing crash

Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
i can load in with all of my other addons just fine. i can load in with combat metrics and combatmetricsfightdata enabled and libcombat disabled, but the addon doesnt work. as soon as i try enabling libcombat and loading in/reloadui, the game crashes. i have uninstalled both combat metrics and libcombat and reinstalled, and it still causes the same crash. everything worked fine before the gold road update.
I haven't heard of something like this yet, so it shouldn't be a general issue. Also recent code changes should not cause this in any way. My guess is, that the saved variables got corrupted (Antivirus is often a candidate because of interfering with the save process). So please try backing up the saved variables for combat metrics and remove them temporarily while trying to load the addon. Make sure you are logged out while doing anything with the files, otherwise any changes have no effect.
I backed up and deleted the saved variables for combat metrics, logged into the game, turned libcombat, combatmetricsfightdata, and combat metrics on. when loading into my character the same crash happens. i am not sure what to do at this point, i have even done a clean install of the game and still get the same crash. libcombat seems to be the only thing that causes the crash.
Hmm, I'll try to think about what can be done. It's already unusual that addons crash the game, but that it happens in such a way is even weirder. Due to the crash any debugging is also very limited. Have you tried with just LibCombat enabled?
just turned off all of my addons and logged into my character, loaded up just fine. turned on libcombat and reloaded my ui and crashed.
This just gets weirder and weirder. LibCombat on its own dowsn't ahve any SavedVariables (that could corrupt) and most of its functions are not active until another addon (such as Combat Metrics) sets up listeners.

If you are up to investigating further lets try a few things:

First: check that line 16 in LibCombat.lua (located in LibCombat folder in AddOns) shows: `lib.version = 73`
Then comment out the last line by adding "--" in front, that means line 4186 should be `-- Initialize()` --> Check if you char loads with only LibCombat enabled.
If this works we can try to troubleshoot the Initialization function. Remove the "--" added in the previous step and insert ` if true then return end`into line 4156. This terminates the function early. Now you can move this line downwards in steps, (for example that it is placed after line 4168, where the active bar is read) so that more and more of the Initialize function is allowed to run.
Perhaps this way one can find out what exactly causes the issue.
Report comment to moderator  
Reply With Quote
Unread 06/18/24, 06:39 AM  
Frostyx24

Forum posts: 0
File comments: 5
Uploads: 0
Re: Re: Re: Re: Libcombat causing crash

Originally Posted by Solinur
Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
i can load in with all of my other addons just fine. i can load in with combat metrics and combatmetricsfightdata enabled and libcombat disabled, but the addon doesnt work. as soon as i try enabling libcombat and loading in/reloadui, the game crashes. i have uninstalled both combat metrics and libcombat and reinstalled, and it still causes the same crash. everything worked fine before the gold road update.
I haven't heard of something like this yet, so it shouldn't be a general issue. Also recent code changes should not cause this in any way. My guess is, that the saved variables got corrupted (Antivirus is often a candidate because of interfering with the save process). So please try backing up the saved variables for combat metrics and remove them temporarily while trying to load the addon. Make sure you are logged out while doing anything with the files, otherwise any changes have no effect.
I backed up and deleted the saved variables for combat metrics, logged into the game, turned libcombat, combatmetricsfightdata, and combat metrics on. when loading into my character the same crash happens. i am not sure what to do at this point, i have even done a clean install of the game and still get the same crash. libcombat seems to be the only thing that causes the crash.
Hmm, I'll try to think about what can be done. It's already unusual that addons crash the game, but that it happens in such a way is even weirder. Due to the crash any debugging is also very limited. Have you tried with just LibCombat enabled?
just turned off all of my addons and logged into my character, loaded up just fine. turned on libcombat and reloaded my ui and crashed.
Report comment to moderator  
Reply With Quote
Unread 06/17/24, 04:37 PM  
Solinur
AddOn Author - Click to view AddOns

Forum posts: 78
File comments: 721
Uploads: 8
Re: Re: Re: Libcombat causing crash

Originally Posted by Frostyx24
Originally Posted by Solinur
Originally Posted by Frostyx24
i can load in with all of my other addons just fine. i can load in with combat metrics and combatmetricsfightdata enabled and libcombat disabled, but the addon doesnt work. as soon as i try enabling libcombat and loading in/reloadui, the game crashes. i have uninstalled both combat metrics and libcombat and reinstalled, and it still causes the same crash. everything worked fine before the gold road update.
I haven't heard of something like this yet, so it shouldn't be a general issue. Also recent code changes should not cause this in any way. My guess is, that the saved variables got corrupted (Antivirus is often a candidate because of interfering with the save process). So please try backing up the saved variables for combat metrics and remove them temporarily while trying to load the addon. Make sure you are logged out while doing anything with the files, otherwise any changes have no effect.
I backed up and deleted the saved variables for combat metrics, logged into the game, turned libcombat, combatmetricsfightdata, and combat metrics on. when loading into my character the same crash happens. i am not sure what to do at this point, i have even done a clean install of the game and still get the same crash. libcombat seems to be the only thing that causes the crash.
Hmm, I'll try to think about what can be done. It's already unusual that addons crash the game, but that it happens in such a way is even weirder. Due to the crash any debugging is also very limited. Have you tried with just LibCombat enabled?
Report comment to moderator  
Reply With Quote
Unread 06/17/24, 11:45 AM  
Frostyx24

Forum posts: 0
File comments: 5
Uploads: 0
Re: Re: Libcombat causing crash

Originally Posted by Solinur
Originally Posted by Frostyx24
i can load in with all of my other addons just fine. i can load in with combat metrics and combatmetricsfightdata enabled and libcombat disabled, but the addon doesnt work. as soon as i try enabling libcombat and loading in/reloadui, the game crashes. i have uninstalled both combat metrics and libcombat and reinstalled, and it still causes the same crash. everything worked fine before the gold road update.
I haven't heard of something like this yet, so it shouldn't be a general issue. Also recent code changes should not cause this in any way. My guess is, that the saved variables got corrupted (Antivirus is often a candidate because of interfering with the save process). So please try backing up the saved variables for combat metrics and remove them temporarily while trying to load the addon. Make sure you are logged out while doing anything with the files, otherwise any changes have no effect.
I backed up and deleted the saved variables for combat metrics, logged into the game, turned libcombat, combatmetricsfightdata, and combat metrics on. when loading into my character the same crash happens. i am not sure what to do at this point, i have even done a clean install of the game and still get the same crash. libcombat seems to be the only thing that causes the crash.
Report comment to moderator  
Reply With Quote
Unread 06/16/24, 10:48 PM  
Solinur
AddOn Author - Click to view AddOns

Forum posts: 78
File comments: 721
Uploads: 8
Re: Libcombat causing crash

Originally Posted by Frostyx24
i can load in with all of my other addons just fine. i can load in with combat metrics and combatmetricsfightdata enabled and libcombat disabled, but the addon doesnt work. as soon as i try enabling libcombat and loading in/reloadui, the game crashes. i have uninstalled both combat metrics and libcombat and reinstalled, and it still causes the same crash. everything worked fine before the gold road update.
I haven't heard of something like this yet, so it shouldn't be a general issue. Also recent code changes should not cause this in any way. My guess is, that the saved variables got corrupted (Antivirus is often a candidate because of interfering with the save process). So please try backing up the saved variables for combat metrics and remove them temporarily while trying to load the addon. Make sure you are logged out while doing anything with the files, otherwise any changes have no effect.
Report comment to moderator  
Reply With Quote
Unread 06/16/24, 10:42 PM  
Solinur
AddOn Author - Click to view AddOns

Forum posts: 78
File comments: 721
Uploads: 8
Re: 4CE731B2

Originally Posted by Toastymouse
I keep receiving this code 4CE731B2,

user:/AddOns/LibCombat/LibCombat.lua:2506: table index is nil
stack traceback:
user:/AddOns/LibCombat/LibCombat.lua:2506: in function '(main chunk)'
I'm puzzled by this one, since the line that throws the error shouldn't do that. The only reason I can come up with is that something got corrupted during install. Please try reinstalling the addon.
Report comment to moderator  
Reply With Quote
Unread 06/16/24, 06:08 PM  
Frostyx24

Forum posts: 0
File comments: 5
Uploads: 0
Libcombat causing crash

i can load in with all of my other addons just fine. i can load in with combat metrics and combatmetricsfightdata enabled and libcombat disabled, but the addon doesnt work. as soon as i try enabling libcombat and loading in/reloadui, the game crashes. i have uninstalled both combat metrics and libcombat and reinstalled, and it still causes the same crash. everything worked fine before the gold road update.
Last edited by Frostyx24 : 06/16/24 at 06:10 PM.
Report comment to moderator  
Reply With Quote
Unread 06/11/24, 06:18 AM  
Toastymouse

Forum posts: 1
File comments: 4
Uploads: 0
4CE731B2

I keep receiving this code 4CE731B2,

user:/AddOns/LibCombat/LibCombat.lua:2506: table index is nil
stack traceback:
user:/AddOns/LibCombat/LibCombat.lua:2506: in function '(main chunk)'
Report comment to moderator  
Reply With Quote
Unread 04/21/24, 11:56 AM  
Solinur
AddOn Author - Click to view AddOns

Forum posts: 78
File comments: 721
Uploads: 8
Originally Posted by Anthonysc
Hey Solinur,

I don't know if you've noticed, but LibCombat will need a small fix for compatibility with the new skills created by the Scribing system. The issue being that
Code:
GetSlotBoundId
is returning special "craftedAbilityIds" for Scribed skills instead of regular abilityIds, and this causes downstream issues with functions like
Code:
GetAbilityName
which only recognize regular abilityIds.

To fix this, I've been replacing
Code:
GetSlotBoundId
across my code with a new custom function
Code:
GetSlotBoundAbilityId
Code:
function GetSlotBoundAbilityId(index, bar)
	local id = GetSlotBoundId(index, bar)
	local actionType = GetSlotType(index, bar)
	
	if actionType == ACTION_TYPE_CRAFTED_ABILITY then
		id = GetAbilityIdForCraftedAbilityId(id)
	end

	return id
end
I thought it might be useful to offer you this for use in LibCombat.
Considering how widely
Code:
GetSlotBoundId
is used, having a drop-in replacement in a widely used library might be helpful for a lot of people.
Hey Anthonysc, thanks for the hint. I already noticed the Code changes in the ESO lua source, so I figured something like this would be needed. I just didn't get around to it yet.
Also thanks for offering a shortcut for me :>, I'll use it with a reference to you in a comment
Report comment to moderator  
Reply With Quote
Unread 04/21/24, 12:15 AM  
Anthonysc
AddOn Author - Click to view AddOns

Forum posts: 10
File comments: 119
Uploads: 2
Hey Solinur,

I don't know if you've noticed, but LibCombat will need a small fix for compatibility with the new skills created by the Scribing system. The issue being that
Code:
GetSlotBoundId
is returning special "craftedAbilityIds" for Scribed skills instead of regular abilityIds, and this causes downstream issues with functions like
Code:
GetAbilityName
which only recognize regular abilityIds.

To fix this, I've been replacing
Code:
GetSlotBoundId
across my code with a new custom function
Code:
GetSlotBoundAbilityId
Code:
function GetSlotBoundAbilityId(index, bar)
	local id = GetSlotBoundId(index, bar)
	local actionType = GetSlotType(index, bar)
	
	if actionType == ACTION_TYPE_CRAFTED_ABILITY then
		id = GetAbilityIdForCraftedAbilityId(id)
	end

	return id
end
I thought it might be useful to offer you this for use in LibCombat.
Considering how widely
Code:
GetSlotBoundId
is used, having a drop-in replacement in a widely used library might be helpful for a lot of people.
Last edited by Anthonysc : 04/21/24 at 12:16 AM.
Report comment to moderator  
Reply With Quote
Unread 03/13/24, 09:29 PM  
Nacedah

Forum posts: 0
File comments: 2
Uploads: 0
Re: Re: Version 72?

Originally Posted by Solinur
Originally Posted by Nacedah
I am getting the same error message about the Libcombat. From the change log, it sounds like you updated, but I'm not seeing version 72 to download? Thanks for the great add-on by the way!
I just checked to be sure but I can download v72 just fine.
Yes, sorry, operator error. Thanks!
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: