Download
(18 Kb)
Download
Updated: 04/21/24 06:29 AM
Pictures
File Info
Compatibility:
Scions of Ithelia (9.3.0)
Endless Archive (9.2.5)
Updated:04/21/24 06:29 AM
Created:04/24/14 05:05 PM
Monthly downloads:2,758
Total downloads:194,742
Favorites:402
MD5:
9.3.0
Harven's Custom Map Pins (Markers)  Updated less than 3 days ago!  Popular! (More than 5000 hits)
Version: 3.2.4
by: Harven, votan
DependenciesVersion 3.1 is a major update! Please backup your SavedVariable.

Description
This addon allows you to place your own markers anywhere on the map. You can place them by typing a command in the chat window or by pressing 'x' key (default) when the map is open. Then a dialog window will appear that allows you to enter the marker description. You can delete and edit markers in the map window by pressing left mouse button on a marker and selecting corresponding item from context menu. There is also an option to share a pin with other players who have this addon installed. Select the "Share" option from the context menu and some text will paste to the chat window entry field. Don't change that text! Just choose a suitable channel and press enter. Requests that arrive at zone, say and yell channels are ignored.

Commands
- /custompin - will place a marker at your position,
- /importpins - will import pins stored in the ["import"] section of the HarvensCustomMapPins.lua file. Read below for more details. (Still available, but out-dated)

How to add your own pin textures
- Create your 64x64px pin texture (must be .dds format - there is a Gimp plugin which can export to this format),
- Copy texture file to the addon folder (the one with "pinflag.dds" file) - (Optionally you can create a new folder within AddOns folder, lets say "MyCustomIcons" and put texture file there),
- Edit Icons.lua file and add your texture filename at the end (take notice how other filenames look like),
- type /reloadui in the chat window - that's it.

How to use colours
When entering pins description you can use colour markers. To start some color simply write |cRRGGBB where RR is a red compoment in hex, GG - green component and BB - blue component. To end the colour, write |r. Look at the third screenshot for exapmple.

Import/Export pins
Beggining from version 1.5 all custom pins are account wide (the same pins will be visible to all your characters). To import your pins from other characters just login to the game with those characters. The pins will be imported automatically.

Share pins
Clicking on a pin, there is an menu entry "Share". It will create a chat link. You can send it to any channel or copy the selection to the clipboard and store it outside of ESO.
Everyone, having this addon installed as well, can click on that link and gets a dialog to confirm the pin.
The dialog will tell you whether the pin is new or would replace an existing one.

Donations (for versions up to 2.1)
If you like my work you can make me happy by sending some in-game gold/items to @theharven on EU server (but please, no lockpicks ), eventually you can help me pay my monthly subscription by donating some money.

[Edit 09.31.2015]
Since monthly subscription is no longer required to play the game I decided to transfer all future dontations to charity. There is a polish site where you can chose a person you would like to support (mostly children) https://www.siepomaga.pl/. I will be anonymously transfering your donations there, to a person of my choosing and then I will post a link in The Great Donor Hall so you will know who gets your money I would love to help this people so I hope this doesn't discourages you from donating.

version 3.2.4:
- If description is empty the predefined name is used as tool-tip text instead. Thanks to @Tarulia.
- Added some icons. Thanks to @Neverlands.

version 3.2.3:
- Fixed issue with new dialog layout behavior.

version 3.2.2:
- Add icons to legend.

version 3.2.1: Added dependency to LibMapPins-1.0 for scrollbars in the map pin filter menu.

version 3.2.0:
-Allow to turn off sub-filters.

version 3.1.0:
- Major update! Please backup your SavedVariable.
- Rewritten a lot of code.
- New dependency: LibChatMeassge.
- Optional async pin rendering.
- New pin share via custom item link.
- Sub pin filter to hide selective predefines. (New predefines need reload ui)

Version 2.10 features:
- Removed LibStub,
- Removed embedded LibHarvensAddonsSettings, please download it separately,
- API version changed to 100030.

Version 2.9 features:
- Fixed libHarvensAddonSettings library,
- API version changed to 100024

Version 2.8d features:
- LibStub updated to the latest version,
- API version changed to 100020

Version 2.8c features:
- API version changed to 100019

Version 2.8b features:
- API version changed to 100018

Version 2.8a features:
- API version changed to 100017

Version 2.8 features:
- API version changed to 100016,
- Updated LHAS, thanks Votan :)

Version 2.7f features:
- API version changed to 100015, see below ;)

Version 2.7e features:
- API version changed to 100014, yeah, I know Votan ;)

Version 2.7d features:
- API version changed to 100013

Version 2.7b features:
- Added validation of data passed to callback functions to avoid UI Errors caused by addons misusing these callbacks.

Version 2.7a features:
- Fixed (hopefully) UI error.

Version 2.7 features:
- Added player contributed pin icon: loot by Alp - thanks again!,
- Fixed HarvensCustomMapPins:FindPinOnCurrentMap.

Version 2.6 features:
- Added player contributed pin icon: feather by Alp - thanks!,
- Added API functions to access custom pins:
* function HarvensCustomMapPins:GetPin(pinTag)
* function HarvensCustomMapPins:GetCurrentMapPins()
* function HarvensCustomMapPins:AddPinToCurrentMap(x, y, description, icon, color)
* function HarvensCustomMapPins:FindPinOnCurrentMap(x, y, radius)

Version 2.5 features:
- API version changed to 100012,
- Added support for multiple floors of the same map (hopefully ;)),
- New version of LibHarvensAddonSettings - thanks to Votan :)
- Changed the way pins are colored (internals),
- Changed the way pins are stored in saved variables file

Version 2.4 features:
- API version changed to 100011,
- Fixed version of LibHarvensAddonSettings,
- The legend can now be moved around freely

Version 2.3a features:
- API version changed to 100010,
- New version of LibHarvensAddonSettings (thanks to Garkin).

Version 2.3 features:
- Added options menu with two options:
* pin size,
* pin draw level.

Version 2.2a features:
- API version changed to 100009.

Version 2.2 features:
- Added more stock icons:
-- Normal resolution:
--- guildkiosk,
--- dyestation,
-- Low resolution (these look somewhat ugly, but...):
--- arcanist,
--- magister,
--- generalgoods,
--- cookingstation,
--- mediumarmor,
--- lightarmor,
--- heavyarmor,
--- armorsmith,
--- weaponsmith,
--- armorsmithingstation,
--- weaponsmithingstation,
--- bagvendor,
--- woodworker_new,
--- woodworker,
--- swords,
--- provisioner,
--- banker,

Version 2.1 features:
- API version changed to 100008.

Version 2.0a features:
- Some quickfix :) (left "-" character in wrong place)

Version 2.0 features:
- Pin icon and colour are shared via "Share" option.

Version 1.9b features:
- Added new icons:
* Stock "smithy" and "caravan",
* Doors - used in Harven's House Hunter
- When selecting predefined style, the icon select control will no longer make annoying noise.

Version 1.9a features:
- Added fish bite and fish icons.

Version 1.9 features:
- New custom made create/edit dialog (no longer using ZOS default),
- Added Advanced Options to the pin creation/editing dialog, you can now:
* select an icon,
* select a color,
* apply predefined style (icon and color)
* define new predefined style (icon and color)
- Changed edit control to multiline edit control (so now you can create multiline descriptions),
- Predefined styles are displayed next to the map as a Legend,
- Slightly decreased pins size

Version 1.8a features:
- Removed "Share via Link" pin menu option because with the new API you can not insert custom links into the chat entry field :/
- API version changed to 100007.

Version 1.8 features:
- All new pins will be created with color of the previous pin,
- Added "Share via Link" pin menu option. It will paste a link into the chat entry field. The link can be clicked by other users of this addon, then the acceptance dialog will appear.
- Added "/importpins" command which allows you to import pins stored in the ["import"] section of your HarvensCustomMapPins.lua SavedVariable file.
- Changed pin sharing informations, so now you can share a pin between different clients - en, de, fr (using map index, zone index and poi index instead of map name),
- Fixed display of map name in the acceptance dialog,
- Made some pin description validation so it will not break your HarvensCustomMapPins.lua file.

Version 1.7 features:
- Added an option to change individual pin's colours,

Version 1.6a features:
- API version changed.

Version 1.6 features:
- Fixed chat channel filtering when sending a pin request - thanks gamegenius86!

Version 1.5 features:
- Slightly increased clickable pin area,
- Made custom pins account wide,

Version 1.4 features:
- You can now share your pins with anyone who is using this addon!
- The request window can be placed anywhere

Version 1.3 features:
- Added addon description in addons menu,
- Changed the way of placing a pin in the wold map (again :o) from shift+lmb to 'x' key (default). Actual binding can be seen on the bottom bar (called keybind strip).

Version 1.2 bugfixes:
- Sometimes custom pins were messing other map markers,
- Fixed LMB behavior when two (or more) pins were close to each other.

Version 1.1 features:
- Changed pin icon,
- Pins can be placed on the map by pressing SHIFT+LMB instead of "F" key,
- Pins descriptions now support colours
Optional Files (0)


Archived Files (42)
File Name
Version
Size
Uploader
Date
3.2.3
18kB
votan
03/16/23 12:22 PM
3.2.2
18kB
votan
01/22/23 07:04 AM
3.2.1
18kB
votan
11/12/22 09:32 AM
3.2.0
18kB
votan
04/30/22 04:41 AM
3.1.0
18kB
votan
02/06/22 07:23 AM
2.10
18kB
Harven
03/29/20 02:34 PM
2.9
25kB
Harven
08/15/18 04:19 PM
2.8d
25kB
Harven
08/14/17 03:08 PM
2.8c
23kB
Harven
05/23/17 12:45 PM
2.8b
23kB
Harven
02/12/17 08:50 AM
2.8a
25kB
Harven
10/05/16 02:22 PM
2.8
25kB
Harven
08/01/16 02:56 PM
2.7f
27kB
Harven
06/02/16 02:11 PM
2.7e
25kB
Harven
03/07/16 04:31 PM
2.7d
25kB
Harven
11/02/15 09:14 AM
2.7b
25kB
Harven
10/06/15 08:42 AM
2.7a
25kB
Harven
10/02/15 03:54 AM
2.7
25kB
Harven
09/07/15 03:54 PM
2.6
24kB
Harven
09/06/15 08:23 AM
2.5
21kB
Harven
09/02/15 05:07 PM
2.4
20kB
Harven
03/04/15 10:25 AM
2.3a
20kB
Harven
11/04/14 01:57 PM
2.3
20kB
Harven
09/26/14 08:31 AM
2.2a
13kB
Harven
09/16/14 05:40 PM
2.2
13kB
Harven
08/08/14 06:32 AM
2.1
13kB
Harven
08/05/14 03:01 PM
2.0a
13kB
Harven
07/22/14 12:20 PM
2.0
13kB
Harven
07/22/14 12:16 PM
1.9b
13kB
Harven
07/15/14 04:28 PM
1.9a
11kB
Harven
07/03/14 01:06 PM
1.9
10kB
Harven
07/02/14 04:24 PM
1.8a
7kB
Harven
06/25/14 04:03 PM
1.8
7kB
Harven
06/17/14 04:12 PM
1.7
6kB
Harven
06/04/14 01:36 PM
1.6a
5kB
Harven
05/23/14 12:58 PM
1.6
5kB
Harven
05/20/14 04:48 PM
1.5
5kB
Harven
05/18/14 12:48 PM
1.4
5kB
Harven
05/03/14 02:45 PM
1.3
3kB
Harven
04/28/14 03:19 PM
1.2
3kB
Harven
04/26/14 06:18 PM
1.1
3kB
Harven
04/26/14 08:04 AM
1.0
2kB
04/24/14 05:05 PM


Post A Reply Comment Options
Unread 03/27/22, 04:19 PM  
Neverlands
 
Neverlands's Avatar

Forum posts: 7
File comments: 571
Uploads: 0
Thanks for the update!

Originally Posted by votan
version 3.1:
- Sub pin filter to hide selective predefines.
Would it be possible to add an option to hide the sub pin filters? I have a very long pin list and with the new filters I have to scroll alot.
Report comment to moderator  
Reply With Quote
Unread 03/16/22, 11:19 AM  
Leia

Forum posts: 0
File comments: 48
Uploads: 0
Originally Posted by votan
Sorry for the delayed response. [...]

Can you show me how your SavedVar looks like?

Sorry for the delay but the new update got in the way.

First, thanks for the advice about the browser. I used a different one and that got me the old version which seems to clash with the new update, so I'm back to your rewrite.
Your advice on that helped too, but somehow I still seem to do something wrong.

Currently, my SavedVar is your default version. Below is a very small part of what I tried to use and which upon login is changed back to the default version.

What am I missing? Any help is appreciated.

Warning: Spoiler
Report comment to moderator  
Reply With Quote
Unread 03/14/22, 09:07 AM  
votan
 
votan's Avatar
AddOn Author - Click to view AddOns

Forum posts: 577
File comments: 1671
Uploads: 40
Originally Posted by Leia
Hi there,

need some help, please.
Today I finally updated my addons with Minion. Unfortunately, I found out that ingame I now didn't have any of my map pins any longer.
So I went to check on the addon website here only to find out that there's been a major rewrite which apparently messed with the old lua file.

What I tried so far to get my pins back:

1. Simply replacing the new lua file with my backup file didn't work. As the addon doesn't seem to be able to read it.

2. Trying to copy and paste all my pins into the new lua file didn't work either as I couldn't find a corresponding "$Accountwide" section in the rewrite.

3. Trying to re-install the previous 2.10 version didn't work either since the unpacked Zip file also contained only the new 3.1 version.

So, could someone please explain to me how to get all my pins back?

Thanks
Sorry for the delayed response.

To 3.: That must be a browser cache problem. I download the older version and it is definitive not 3.1.

hmm. I'm quite sure there is a data migration done.

There $AccountWide does not exist anymore. Right.
This belongs to HarvensCustomMapPins_Data. You should copy it there instead.
It should look like this:
Code:
HarvensCustomMapPins_Data =
{
    ["artmapseastmarchdirefrostkeepsummitbasedds"] = 
    {
...
The map names are without any "_0".

Can you show me how your SavedVar looks like?
Report comment to moderator  
Reply With Quote
Unread 03/01/22, 10:14 AM  
Leia

Forum posts: 0
File comments: 48
Uploads: 0
Hi there,

need some help, please.
Today I finally updated my addons with Minion. Unfortunately, I found out that ingame I now didn't have any of my map pins any longer.
So I went to check on the addon website here only to find out that there's been a major rewrite which apparently messed with the old lua file.

What I tried so far to get my pins back:

1. Simply replacing the new lua file with my backup file didn't work. As the addon doesn't seem to be able to read it.

2. Trying to copy and paste all my pins into the new lua file didn't work either as I couldn't find a corresponding "$Accountwide" section in the rewrite.

3. Trying to re-install the previous 2.10 version didn't work either since the unpacked Zip file also contained only the new 3.1 version.

So, could someone please explain to me how to get all my pins back?

Thanks
Report comment to moderator  
Reply With Quote
Unread 02/06/22, 11:19 AM  
Maxxermax
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 74
Uploads: 2
Re: Re: How Do You Share a Pin/Marker?

Originally Posted by votan
Originally Posted by Darth Cuffer
Late to the party...

A friend and I recently installed this Addon and we love the ability to add custom pins, but when we try to share them with the team via Group chat, nothing happens.

Are we doing it right? How does one share one of their pins with a group, or does this feature not work?

Thanks!
You are not doing something wrong. The way it was implemented caused trouble, so I disabled it. You are the first asking for it since. I can try to re-enable it, but no promise.

And welcome to the party
I also miss the function to share the Pins with my friends..
Thanks for your work!

/edit: Uh, oh .. you already implement pin share again "- New pin share via custom item link."
.. so what are you guys talking about
Last edited by Maxxermax : 02/07/22 at 11:19 AM.
Report comment to moderator  
Reply With Quote
Unread 01/29/22, 02:38 AM  
votan
 
votan's Avatar
AddOn Author - Click to view AddOns

Forum posts: 577
File comments: 1671
Uploads: 40
Originally Posted by Necropsi
hey, anybody knows how to bring up the legend from third screenshot? thank you
As ZOS is claiming more and more for themselves and to keep space for other addons, the legend is part of the built-in legend now. On the right, the second from left. Right at the bottom.

/edit: Sorry. Was talking about my rewritten version.
Last edited by votan : 02/06/22 at 07:03 AM.
Report comment to moderator  
Reply With Quote
Unread 01/29/22, 02:33 AM  
votan
 
votan's Avatar
AddOn Author - Click to view AddOns

Forum posts: 577
File comments: 1671
Uploads: 40
Re: How Do You Share a Pin/Marker?

Originally Posted by Darth Cuffer
Late to the party...

A friend and I recently installed this Addon and we love the ability to add custom pins, but when we try to share them with the team via Group chat, nothing happens.

Are we doing it right? How does one share one of their pins with a group, or does this feature not work?

Thanks!
You are not doing something wrong. The way it was implemented caused trouble, so I disabled it. You are the first asking for it since. I can try to re-enable it, but no promise.

And welcome to the party
Report comment to moderator  
Reply With Quote
Unread 01/25/22, 10:54 AM  
Darth Cuffer

Forum posts: 0
File comments: 1
Uploads: 0
How Do You Share a Pin/Marker?

Late to the party...

A friend and I recently installed this Addon and we love the ability to add custom pins, but when we try to share them with the team via Group chat, nothing happens.

Are we doing it right? How does one share one of their pins with a group, or does this feature not work?

Thanks!
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 04:13 PM  
Necropsi

Forum posts: 1
File comments: 48
Uploads: 0
hey, anybody knows how to bring up the legend from third screenshot? thank you
Report comment to moderator  
Reply With Quote
Unread 08/08/20, 07:27 PM  
Berun

Forum posts: 0
File comments: 7
Uploads: 0
Import not working properly

There's a bug in the code for importing the new format pins. Trying to run /importpins indicates the function is trying to read a nil value. The error is in the code near line 448.

Code:
if not self.sv.pins[k][cfloor][key] then
	self.sv.pins[k][cfloor][key] = {
		map = v.map,
		description = v.description,
		x = v.x,
		y = v.y,
		color = {
			v.color[1],
			v.color[2],
			v.color[3],
			v.color[4],
		},
		icon = v.icon
	}
else
	CHAT_SYSTEM:AddMessage("A pin is already present at that location: "..pinData.x..", "..pinData.y.." "..pinData.description)
end
All the v.* variables should be pinData.* (as used in the CHAT_SYSTEM line).

There should probably be some error checking like there is for the old format and a message if pins are malformed. The 'Import Complete" should probably also state that "Malformed pins were deleted."

I'd really like a way to have a single set of pins for all accounts (not just all characters within an account) so I don't need to keep importing pins back and forth.
Last edited by Berun : 08/08/20 at 07:36 PM.
Report comment to moderator  
Reply With Quote
Unread 03/18/20, 10:47 AM  
MoonPile

Forum posts: 1
File comments: 24
Uploads: 0
No longer updating?

Hi,
I love this addon, especially for the daily fetch quests: it's so helpful to be able to mark quest items like tea leaves (if you know what I mean) instead of hunting for them anew each time.

Unfortunately as of the latest ESO updates, this addon no longer works properly (for me).

When you click on a custom marker its name box should pop up, but now the box is really small and doesn't show the name or the marker menu. The lack of name doesn't bother me, but this bug makes it impossible to delete markers.

Looks like Harven came back in 2019 but the last update was in 2018, so I've uninstalled for now and I wonder if anyone has found a good replacement?
Report comment to moderator  
Reply With Quote
Unread 02/26/20, 03:57 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4971
File comments: 6038
Uploads: 78
Nope, Im not using the addon anymore and thus got no folder.
But it's easy if you follow these easy steps:

1. Logout of the game!
2. Just delete the folder "libs" inside "elder scrolls online/live/AddOns/HarvensCustomMapPins"
3. Change the file elder scrolls online/live/AddOns/HarvensCustomMapPins/HarvensCustomMapPins.txt to (copy & paste the whole file content and replace it):

Code:
; This Add-on is not created by, affiliated with or sponsored by ZeniMax
; Media Inc. or its affiliates. The Elder Scrolls® and related logos are
; registered trademarks or trademarks of ZeniMax Media Inc. in the United
; States and/or other countries. All rights reserved.

; Fish icon source: http://www.visualpharm.com/
; Door icon source: http://game-icons.net/lorc/originals/wooden-door.html

## Title: Harven's Custom Map Pins
## APIVersion: 100030
## SavedVariables: HarvensCustomMapPins_SavedVariables
## Description: This addon allows you to place custom pins on the map. To place a pin at your position type |c00ff00/custompin|r in the chat window. To place a pin when the world map window is open, press |c00ff00'x'|r key (default).
## DependsOn: LibHarvensAddonSettings

Icons.lua
MapPinEditDialog.lua
HarvensCustomMapPins.lua
HarvensCustomMapPins.xml
4. Download and install this library as standalone version (into your elder scrolls online/live/AddOns folder): Harven's Addon Settings
5. Edit the file elder scrolls online/live/AddOns/HarvensCustomMapPins/HarvensCustomMapPins.lua with a text editor.
Search for: function HarvensCustomMapPins:SetupOptions()
Delete the line (below the line function HarvensCustomMapPins:SetupOptions()):
[code]local LibHarvensAddonSettings = LibStub("LibHarvensAddonSettings-1.0")[code]
Add these lines instead at the same position (directly below function HarvensCustomMapPins:SetupOptions())
Code:
local LibHarvensAddonSettings = LibHarvensAddonSettings
    if not LibHarvensAddonSettings and LibStub then LibHarvensAddonSettings = LibStub("LibHarvensAddonSettings-1.0", false) end
    if not LibHarvensAddonSettings then d("[HarvensCustomMapPins]Library LibHarvensAddonSettings-1.0 is missing!") return end
Save the file.
6. Reloadui ingame and it should work again.


About the other addon: No please contact the author of the addon in the addon comments.
I don#t have the time to take over and fix another whole addon, sorry.
Report comment to moderator  
Reply With Quote
Unread 02/25/20, 06:22 PM  
BackToTheGrave

Forum posts: 0
File comments: 2
Uploads: 0
Originally Posted by Baertram
Hey Harven

could you PLEASE update the addon and remove the embedded "hardcoded" old libraries of LibHarvensAddonSettings
as it throws errors and destroys the complete UI

Just add the library with it's own txt file please, and remove LibStub hardcoded, use it's txt file as well please!
And add ## DependsOn: LibHarvensAddonSettings to your txt file.

For now I fixed this locally but this will get other users in trouble as well. All libraries are updated and working but some addons still use embedded and harcoded libraries with incompatible old code, older than 2 years now.

At best it would be to not even include the newest copy of the library but install them standalone and add this to your addon's txt file:
## DependsOn: LibHarvensAddonSettings>=10704


Remove:
Librraies subfolder "libs".
If you include the libraries then do not load them from the txt file of your addon "hardcoded" anymore please!" Just include them with their own txt file so the addon manager will load the newest version autoamtically. LibStub will be obsolete one day.

New txt file:
Code:
; This Add-on is not created by, affiliated with or sponsored by ZeniMax
; Media Inc. or its affiliates. The Elder Scrolls? and related logos are
; registered trademarks or trademarks of ZeniMax Media Inc. in the United
; States and/or other countries. All rights reserved.

; Fish icon source: http://www.visualpharm.com/
; Door icon source: http://game-icons.net/lorc/originals/wooden-door.html

## Title: Harven's Custom Map Pins
## APIVersion: 100029 100030
## Version: 3.0
## AddOnVersion: 0300
## SavedVariables: HarvensCustomMapPins_SavedVariables
## Description: This addon allows you to place custom pins on the map. To place a pin at your position type |c00ff00/custompin|r in the chat window. To place a pin when the world map window is open, press |c00ff00'x'|r key (default).
## DependsOn: LibHarvensAddonSettings>=10704

Icons.lua
MapPinEditDialog.lua
HarvensCustomMapPins.lua
HarvensCustomMapPins.xml
Changed addon lua file:
functions HarvensCustomMapPins:SetupOptions
-> Change variable LibHarvensAddonSettings (capital L) to
libHarvensAddonSettings with lower l.
Load the library via it's global variable LibHarvensAddonSettings first, and if this fails use LibStub to load it (if LibStub is given).

Lua Code:
  1. function HarvensCustomMapPins:SetupOptions()
  2.     local libHarvensAddonSettings = LibHarvensAddonSettings
  3.     if not libHarvensAddonSettings and LibStub then libHarvensAddonSettings = LibStub("LibHarvensAddonSettings-1.0", false) end
  4.     if not libHarvensAddonSettings then d("[HarvensCustomMapPins]Library LibHarvensAddonSettings-1.0 is missing!") return end
  5.  
  6. ...
I'm really bad with the whole naming files and what not and was wondering if you could please send me your folder with the fix instead. I'm also having errors with Waypointit if you have the time to look into that for me. Thank you!
Report comment to moderator  
Reply With Quote
Unread 12/23/19, 03:07 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4971
File comments: 6038
Uploads: 78
Hey Harven

could you PLEASE update the addon and remove the embedded "hardcoded" old libraries of LibHarvensAddonSettings
as it throws errors and destroys the complete UI

Just add the library with it's own txt file please, and remove LibStub hardcoded, use it's txt file as well please!
And add ## DependsOn: LibHarvensAddonSettings to your txt file.

For now I fixed this locally but this will get other users in trouble as well. All libraries are updated and working but some addons still use embedded and harcoded libraries with incompatible old code, older than 2 years now.

At best it would be to not even include the newest copy of the library but install them standalone and add this to your addon's txt file:
## DependsOn: LibHarvensAddonSettings>=10704


Remove:
Librraies subfolder "libs".
If you include the libraries then do not load them from the txt file of your addon "hardcoded" anymore please!" Just include them with their own txt file so the addon manager will load the newest version autoamtically. LibStub will be obsolete one day.

New txt file:
Code:
; This Add-on is not created by, affiliated with or sponsored by ZeniMax
; Media Inc. or its affiliates. The Elder Scrolls? and related logos are
; registered trademarks or trademarks of ZeniMax Media Inc. in the United
; States and/or other countries. All rights reserved.

; Fish icon source: http://www.visualpharm.com/
; Door icon source: http://game-icons.net/lorc/originals/wooden-door.html

## Title: Harven's Custom Map Pins
## APIVersion: 100029 100030
## Version: 3.0
## AddOnVersion: 0300
## SavedVariables: HarvensCustomMapPins_SavedVariables
## Description: This addon allows you to place custom pins on the map. To place a pin at your position type |c00ff00/custompin|r in the chat window. To place a pin when the world map window is open, press |c00ff00'x'|r key (default).
## DependsOn: LibHarvensAddonSettings>=10704

Icons.lua
MapPinEditDialog.lua
HarvensCustomMapPins.lua
HarvensCustomMapPins.xml
Changed addon lua file:
functions HarvensCustomMapPins:SetupOptions
-> Change variable LibHarvensAddonSettings (capital L) to
libHarvensAddonSettings with lower l.
Load the library via it's global variable LibHarvensAddonSettings first, and if this fails use LibStub to load it (if LibStub is given).

Lua Code:
  1. function HarvensCustomMapPins:SetupOptions()
  2.     local libHarvensAddonSettings = LibHarvensAddonSettings
  3.     if not libHarvensAddonSettings and LibStub then libHarvensAddonSettings = LibStub("LibHarvensAddonSettings-1.0", false) end
  4.     if not libHarvensAddonSettings then d("[HarvensCustomMapPins]Library LibHarvensAddonSettings-1.0 is missing!") return end
  5.  
  6. ...
Last edited by Baertram : 12/23/19 at 03:19 PM.
Report comment to moderator  
Reply With Quote
Unread 10/03/19, 08:40 PM  
AegonVI
 
AegonVI's Avatar

Forum posts: 0
File comments: 43
Uploads: 0
Please update this beautiful addon.
Thank you.

Warning: Spoiler
Last edited by AegonVI : 10/03/19 at 08:50 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: