LibCombat : Libraries : Elder Scrolls Online AddOns

(35 Kb)

Download

Updated: 06/21/23 04:06 PM

Add Favorite

Install Help

Compatibility:	Necrom (9.0.0)
Updated:	06/21/23 04:06 PM
Created:	01/21/20 03:40 PM
Monthly downloads:	18,832
Total downloads:	3,526,431
Favorites:	585
MD5:

LibCombat

Version: 70

by: Solinur [More]

DEpendency

The following library is optional:

LibDebugLogger (Allows debugging, minimum required version 2.0.0)

Description

Please note that the library is not complete yet, so some of the API could still change.

This library is providing the data collection for Combat Metrics.
However I tried to make it in such a way it can be used for other addons which may only need parts of the data.
Additionally it can provide human readable combat log lines, which are arranged so they should be translatable.
I tried to optimize the code to impact the performance as little as possible.

For useage instructions and feedback please have a look at the github repository: https://github.com/Solinur/LibCombat

Solinur (EU)

Fixed tracking of several Arcanist abilities (incl. Fulminating Rune) when main resource is Stamina (Thx to Helix and brdalert for reporting this).

Reverted some code that was not ready for publishing

Added Support for weaving tracking of Arkanist Skill Lines
Fixed and improved tracking of resources.

Added support for Force of Nature (by popular request)

Fixed an issue where Z'en stacks could go higher than 5.
Fixed an issue where each stack of Relequen would add a Z'en stack.

Removed some unnecessary debug messages (Thx to DakJaniels for reporting this)
Added "damageOutTotal" entry to the table provided with the LIBCOMBAT_EVENT_FIGHTRECAP callback.

Added a fix for an issue that caused a Lua error on rare occasions. (Thx to ithildae for the report)

Added support for tracking stacks of Z'en and the spell and weapon damage buff of seething fury.
Slight changes for tracking of special buffs to include stacks (via Combat Events).

Removed obsolete code
API Bump to Firesong (100036)

Adjusted crit damage bonus from Backstabber to new value. (Thx to Complicative for the hint)

Fixed an issue where ability costs were not attributed properly. (Thx to Hypno for reporting)

Added compatibility with High Isle (API 101034).

Fixed issue with skill activation tracking of Meteor and its morphs. (thx to Skinny Cheeks for reporting the issue)

Fixed some issues with skill activation tracking. (thx to Skinny Cheeks and virtus753 for reporting the issue)

Added tracking of glacial presence passive and the (hidden) chilled debuff to allow tracking of the respective critical damage bonus.
Removed some legacy code

Added number of stacks to buff events in combat log
Removed Grim Focus tracking as it is no longer needed

Fix an issue where incoming critical hits were not properly shown in logs (Thx to shira for reporting this).

Added workaround for Grim Focus, to correctly calculate its contribution to the critical damage bonus stat. (thx to master_vanargand for pointing this out)
Added missing license file.

Another fix to finally make it work for all ESO supported languages (and hopefully all others too)

Fixed parsing of strings to determine the critical damage bonus by shadow mundus for russian language.

Reworked critical damage tracking to use the advanced stats info from ZOS (including adjustments like backstabber to keep it consistent with how it was shown up until now).

Updated the crit bonus value for Khajits
Added the crit bonus tracking for dual wield and 2H-Axes
Added detection of trial dummies
Updated tracking of penetration value from Alkosh, set it to 3000 instead
Remove a spammy debug message

Fixed an issue where Backstabber was included to the critical damage bonus even when not slotted

Fixed an issue where stat update events were too spammy.

Disabled advanced stats tracking, since it causes major performance issues. Gotta investigate before returning them.

Fixed an issue with resource tracking.

Added tracking for new CP system and advanced stats.
API Bump to Flames of Ambition (100034)

Fixed an issue where crystal frag casts were not properly reported

Fixed an issue that could lead to inconsistent DPS numbers for a fight.

Fixed an issue where damage to shields was not properly counted.
Fixed an issue where resource values where sometimes missing in death recaps.

Fixed Major Force value since it was still set to 15% (Thx to @Wrath of Innos)

Fixed an issue where heals would fail to be recorded.
Removed some debug spam

Changed the way damage versus absorbing shields is handled. The shield event will be shown as usual but sent with the Heal callbacks. The combat event for damage callback will now send the normal event with the proper action result and contain the shielded fraction in the overflow field.
Adjusted handling of shields in combat log string creation
Added workaround for Minor Magickasteal
Added some adjustments to skill timing after ZOS changed something again to fix LA weaving

Removed skill timing events firing when out of combat

Reworked skill timing to fix several issues. Now also the input registration and queue activation will trigger a callback
Added some code that might help in cases where combat end is not properly detected.

Fixed penetration values for TFS. While the penetration API function is not doing what it should either (its not tracking stacks higher than 1 at all), the wrong value was my fault. Should work fine now, I hope.

Reverted critical damage bonus calculation to the previous method (but with fixed values), since the ZOS tooltip hast turned out to be inaccurate.
Bug: Physical penetration values are not working correctly when TFS is involved. The underlying API function is bugged and applies the old increase of 860 pen for every stack higher or equal than two. I will fix this if possible, but it will require some work.

Corrected the calculation for critical damage values to mind the new values from shadow mundus. It will now extract the value from the same tooltip which you can see in the character window, instead of using a hard coded base value and the extracted bonus from divine pieces.
Some small fixes and changes for future use.

API Bump to Stonethorn (100032)
Added special tracking for the new Alkosh penetration debuff
Small fixes

Put back tracking of skill timings for Necro Siphon since it is back on GCD
Removed tracking of skill timing for Blood Frenzy and it's morphs, since they are off the GCD
Fixed an issue where a lua error would appear if an old version of libdebuglogger was installed

Fixed some issues with skill timing events. (Thx @ wraith1515 for reporting)

Fixed version number

Fixed a lua error that could happen when leaving Battleground or Cyrodil in some cases

Reworked event registration functions (e.g. lib:RegisterForCombatEvent). The behaviour and syntax now matches event registration of the ESO API (EVENT_MANAGER:RegisterForEvent). The old functions are still supported but may be removed in the future.
LibCombat:RegisterCallbackType(callbacktype, callback, name) --> LibCombat:RegisterForCombatEvent(name, callbacktype, callback), returns: isRegistered
LibCombat:UnregisterCallbackType(callbacktype, callback, name) --> LibCombat:UnregisterForCombatEvent(name, callbacktype), returns: isUnregistered
LibCombat:RegisterAllLogCallbacks(callback, name) --> LibCombat:RegisterForLogableCombatEvents(name, callback)
LibCombat now optionally depends on libdebuglogger. It is set up to handle all debug output and also saves them for later review. When it is not installed no debug output will be shown.
Small fixes and performance improvements.
Added new events for performance (ping, fps).
Added field skillDelay to LIBCOMBAT_EVENT_SKILL_TIMINGS events.
Changed boss assignment to not just check if unit is a boss on unit initialization but all the time.
Consolidated the preliminary event LIBCOMBAT_EVENT_RESURRECTION into LIBCOMBAT_EVENT_DEATH. This one is still work in progress.

Fixed an issue that prevented display names (@Names) to be added to unit info.

Updated ability IDs used in a couple of places, since ZOS seemed to have removed a few.

initial release as standalone library
fixed formatting issue in log for stats
fixed issue with crit damage values when buff is only refreshed but not applied completely new

Archived Files (46)

File Name	Version	Size	Uploader	Date
LibCombat	69	35kB	Solinur	06/04/23 04:15 PM
LibCombat	68	35kB	Solinur	06/04/23 04:07 PM
LibCombat	67	34kB	Solinur	05/15/23 04:18 PM
LibCombat	66	33kB	Solinur	03/15/23 05:09 PM
LibCombat	65	33kB	Solinur	03/11/23 03:45 AM
LibCombat	64	38kB	Solinur	12/28/22 01:28 PM
LibCombat	63	38kB	Solinur	12/19/22 03:10 PM
LibCombat	62	37kB	Solinur	11/09/22 04:55 PM
LibCombat	61	31kB	Solinur	06/12/22 03:16 PM
LibCombat	60	31kB	Solinur	06/10/22 02:04 PM
LibCombat	59	32kB	Solinur	06/03/22 03:12 PM
LibCombat	58	31kB	Solinur	02/12/22 06:38 AM
LibCombat	57	31kB	Solinur	01/18/22 05:37 PM
LibCombat	56	32kB	Solinur	12/28/21 10:41 AM
LibCombat	55	32kB	Solinur	11/05/21 01:30 PM
LibCombat	54	32kB	Solinur	07/05/21 04:06 PM
LibCombat	53	32kB	Solinur	06/15/21 03:58 PM
LibCombat	52	28kB	Solinur	06/11/21 05:07 PM
LibCombat	51	28kB	Solinur	06/11/21 04:48 PM
LibCombat	50	28kB	Solinur	06/09/21 01:50 PM
LibCombat	49	29kB	Solinur	04/17/21 04:01 PM
LibCombat	48	29kB	Solinur	03/15/21 05:56 PM
LibCombat	47	29kB	Solinur	03/08/21 04:28 PM
LibCombat	46	29kB	Solinur	03/08/21 02:37 PM
LibCombat	45	29kB	Solinur	03/06/21 07:43 AM
LibCombat	44	29kB	Solinur	03/04/21 05:52 PM
LibCombat	43	28kB	Solinur	01/30/21 07:04 AM
LibCombat	42	28kB	Solinur	12/25/20 02:52 PM
LibCombat	41	28kB	Solinur	12/13/20 03:13 PM
LibCombat	40	28kB	Solinur	12/04/20 03:38 PM
LibCombat	39	28kB	Solinur	12/04/20 02:07 PM
LibCombat	38	28kB	Solinur	12/02/20 05:19 PM
LibCombat	37	27kB	Solinur	10/20/20 03:45 PM
LibCombat	36	27kB	Solinur	10/13/20 04:18 PM
LibCombat	35	26kB	Solinur	09/20/20 11:35 AM
LibCombat	34	26kB	Solinur	09/20/20 04:41 AM
LibCombat	33	26kB	Solinur	09/17/20 11:55 AM
LibCombat	32	26kB	Solinur	08/24/20 02:11 AM
LibCombat	31	26kB	Solinur	06/09/20 03:15 PM
LibCombat	30	26kB	decay2	05/23/20 02:53 PM
LibCombat	29	26kB	decay2	05/19/20 04:50 PM
LibCombat	28	26kB	decay2	05/18/20 03:28 PM
LibCombat	27	26kB	decay2	05/17/20 02:25 PM
LibCombat	26	22kB	decay2	03/22/20 10:06 AM
LibCombat	25	22kB	decay2	02/25/20 04:11 PM
LibCombat	24	22kB	decay2	01/21/20 03:40 PM

Comment Options

Page 1 of 2

03/11/23, 03:30 AM

Solinur

Forum posts: 78

File comments: 693

Uploads: 8

Re: zen

Originally Posted by DakJaniels

11, 8469929, 27, 126597, 1, 2, 5, 1, 244
|rstack traceback:
user:/AddOns/LibDebugLogger/LogHandler.lua:201: in function 'Log'
|caaaaaa<Locals> level = "W", config = [table:1]{originalTag = "LibCombat/other", enabled = T, tag = "LibCombat/other"}, handled = T, message = "11, 8469929, 27, 126597, 1, 2,...", shouldLogTraces = T </Locals>|r
(tail call): ?
user:/AddOns/LibCombat/LibCombat.lua:62: in function 'Print'
|caaaaaa<Locals> category = "other", level = "W", logger = [table:1] </Locals>|r
user:/AddOns/LibCombat/LibCombat.lua:576: in function 'UnitHandler:UpdateZenData'
|caaaaaa<Locals> self = [table:2]{starttime = 8455084, name = "The Endling", isFriendly = F, dpsend = 8469586, dpsstart = 8455084, damageOutTotal = 188687, endtime = 8469929, bossId = 1, unitId = 27, unitType = 0, unitTag = "boss1", stacksOfZen = 5, groupDamageOut = 0}, callbackKeys = "LibCombat11", eventid = 11, timems = 8469929, unitId = 27, abilityId = 126597, changeType = 1, effectType = 2, _ = 1, sourceType = 1, effectSlot = 244, abilityType = 5, isActive = T, stacks = 5 </Locals>|r
user:/AddOns/LibCombat/LibCombat.lua:1874: in function 'BuffEventHandler'
|caaaaaa<Locals> isspecial = F, groupeffect = 0, _ = 131157, changeType = 1, effectSlot = 244, _ = "Touch of Z'en", unitTag = "reticleover", _ = 8469.919921875, endTime = 8489.919921875, stackCount = 0, _ = "/esoui/art/icons/ability_heale...", _ = "", effectType = 2, abilityType = 5, _ = 0, unitName = "The Endling^n", unitId = 27, abilityId = 126597, sourceType = 1, timems = 8469929 </Locals>|r
user:/AddOns/LibCombat/LibCombat.lua:1881: in function 'onEffectChanged'

Seems I forgot to remove some debug message.

Last edited by Solinur : 03/11/23 at 03:30 AM.

03/10/23, 09:52 PM
DakJaniels Forum posts: 14 File comments: 90 Uploads: 1	zen 11, 8469929, 27, 126597, 1, 2, 5, 1, 244 \|rstack traceback: user:/AddOns/LibDebugLogger/LogHandler.lua:201: in function 'Log' \|caaaaaa<Locals> level = "W", config = [table:1]{originalTag = "LibCombat/other", enabled = T, tag = "LibCombat/other"}, handled = T, message = "11, 8469929, 27, 126597, 1, 2,...", shouldLogTraces = T </Locals>\|r (tail call): ? user:/AddOns/LibCombat/LibCombat.lua:62: in function 'Print' \|caaaaaa<Locals> category = "other", level = "W", logger = [table:1] </Locals>\|r user:/AddOns/LibCombat/LibCombat.lua:576: in function 'UnitHandler:UpdateZenData' \|caaaaaa<Locals> self = [table:2]{starttime = 8455084, name = "The Endling", isFriendly = F, dpsend = 8469586, dpsstart = 8455084, damageOutTotal = 188687, endtime = 8469929, bossId = 1, unitId = 27, unitType = 0, unitTag = "boss1", stacksOfZen = 5, groupDamageOut = 0}, callbackKeys = "LibCombat11", eventid = 11, timems = 8469929, unitId = 27, abilityId = 126597, changeType = 1, effectType = 2, _ = 1, sourceType = 1, effectSlot = 244, abilityType = 5, isActive = T, stacks = 5 </Locals>\|r user:/AddOns/LibCombat/LibCombat.lua:1874: in function 'BuffEventHandler' \|caaaaaa<Locals> isspecial = F, groupeffect = 0, _ = 131157, changeType = 1, effectSlot = 244, _ = "Touch of Z'en", unitTag = "reticleover", _ = 8469.919921875, endTime = 8489.919921875, stackCount = 0, _ = "/esoui/art/icons/ability_heale...", _ = "", effectType = 2, abilityType = 5, _ = 0, unitName = "The Endling^n", unitId = 27, abilityId = 126597, sourceType = 1, timems = 8469929 </Locals>\|r user:/AddOns/LibCombat/LibCombat.lua:1881: in function 'onEffectChanged'

01/01/23, 10:49 AM

vgabor

Forum posts: 1

File comments: 52

Uploads: 0

Originally Posted by Solinur

Originally Posted by vgabor

Code:

2022-12-29T13:10:07.800+01:00 |cff0000Lua Error: user:/AddOns/LibCombat/LibCombat.lua:1939: operator / is not supported for nil / number
stack traceback:
user:/AddOns/LibCombat/LibCombat.lua:1939: in function 'SpecialBuffEventHandler'
<Locals> isdebuff = F, _ = 131108, result = 2240, _ = F, _ = "", _ = 0, _ = 0, _ = "", sourceType = 0, unitName = "", targetType = 0, hitValue = 3, _ = 0, damageType = 1, _ = T, _ = 0, unitId = 66363, abilityId = 122729, now = 504.894876519, stackCount = 3 </Locals>
user:/AddOns/LibCombat/LibCombat.lua:1948: in function 'onSpecialBuffEvent'|r

It's happening when there's a duel going on nearby.

I assume this is the issue in version 63, that should be fixed with the upload from yesterday. The line of the error it refers to is empty now.
Let me know if this also occurs in the current version (64).

Yeah it was happening on 63. I haven't had this error since I updated to 64, although hard to say definitively that it is fixed as it was only occurring occasionally when there was a duel going on nearby...

12/29/22, 08:10 AM

Solinur

Forum posts: 78

File comments: 693

Uploads: 8

Originally Posted by vgabor

Code:

2022-12-29T13:10:07.800+01:00 |cff0000Lua Error: user:/AddOns/LibCombat/LibCombat.lua:1939: operator / is not supported for nil / number
stack traceback:
user:/AddOns/LibCombat/LibCombat.lua:1939: in function 'SpecialBuffEventHandler'
<Locals> isdebuff = F, _ = 131108, result = 2240, _ = F, _ = "", _ = 0, _ = 0, _ = "", sourceType = 0, unitName = "", targetType = 0, hitValue = 3, _ = 0, damageType = 1, _ = T, _ = 0, unitId = 66363, abilityId = 122729, now = 504.894876519, stackCount = 3 </Locals>
user:/AddOns/LibCombat/LibCombat.lua:1948: in function 'onSpecialBuffEvent'|r

It's happening when there's a duel going on nearby.

Last edited by Solinur : 12/29/22 at 08:10 AM.

12/29/22, 06:13 AM

vgabor

Forum posts: 1

File comments: 52

Uploads: 0

Code:

2022-12-29T13:10:07.800+01:00 |cff0000Lua Error: user:/AddOns/LibCombat/LibCombat.lua:1939: operator / is not supported for nil / number
stack traceback:
user:/AddOns/LibCombat/LibCombat.lua:1939: in function 'SpecialBuffEventHandler'
<Locals> isdebuff = F, _ = 131108, result = 2240, _ = F, _ = "", _ = 0, _ = 0, _ = "", sourceType = 0, unitName = "", targetType = 0, hitValue = 3, _ = 0, damageType = 1, _ = T, _ = 0, unitId = 66363, abilityId = 122729, now = 504.894876519, stackCount = 3 </Locals>
user:/AddOns/LibCombat/LibCombat.lua:1948: in function 'onSpecialBuffEvent'|r

It's happening when there's a duel going on nearby.

04/29/22, 04:58 PM

Solinur

Forum posts: 78

File comments: 693

Uploads: 8

Originally Posted by Baertram

Attention for quickslot related or weapon bar / action button related addons
PTS API101034 High Isle chapter
All kind of GetSlot* functions for the action- and quickslots have changed their parameters and need a 2nd parameter HOTBAR_CATEGORY_* now to detect the correct abilityId, itemLink, etc.

e.g. GetSlotBoundId(slotNr, HOTBAR_CATEGORY_*) where the hotbar category of the default quickslots would be HOTBAR_CATEGORY_QUICKSLOT_WHEEL and the one for weapon bar 1 would be HOTBAR_CATEGORY_PRIMARY
GetSlotTexure, GetSlotItemLink, GetSlotName, ...

As the parameter HOTBARCategory was "inserted" as 2nd param (if the current 2nd, 3rd, etc params could be nil after the 1st) it might be that your functions have wrong parameters passed in now, so check you code please! Else your passed in variables at param 2 might be a number and define any of the HOTBAR_CATEGORY_* constants "by accident" so that the functions work but provide wrong results!

Also important:
The variable ACTION_BAR_FIRST_UTILITY_BAR_SLOT is not existing anymore.
The quickslots actionBar slot is 1 now and not 8 (ACTION_BAR_UTILITY_BAR_SIZE) anymore as it seems!

Thanks for the headsup, Baertram

.
I'm still in the middle of the work to update my addons for that patch... There is quite a bit that needs to be taken care of.

04/29/22, 04:55 PM
Baertram Super Moderator Forum posts: 4691 File comments: 5754 Uploads: 77	Attention for quickslot related or weapon bar / action button related addons PTS API101034 High Isle chapter All kind of GetSlot* functions for the action- and quickslots have changed their parameters and need a 2nd parameter HOTBAR_CATEGORY_* now to detect the correct abilityId, itemLink, etc. e.g. GetSlotBoundId(slotNr, HOTBAR_CATEGORY_) where the hotbar category of the default quickslots would be HOTBAR_CATEGORY_QUICKSLOT_WHEEL and the one for weapon bar 1 would be HOTBAR_CATEGORY_PRIMARY GetSlotTexure, GetSlotItemLink, GetSlotName, ... As the parameter HOTBARCategory was "inserted" as 2nd param (if the current 2nd, 3rd, etc params could be nil after the 1st) it might be that your functions have wrong parameters passed in now, so check you code please! Else your passed in variables at param 2 might be a number and define any of the HOTBAR_CATEGORY_ constants "by accident" so that the functions work but provide wrong results! Also important: The variable ACTION_BAR_FIRST_UTILITY_BAR_SLOT is not existing anymore. The quickslots actionBar slot is 1 now and not 8 (ACTION_BAR_UTILITY_BAR_SIZE) anymore as it seems!

06/12/21, 03:32 AM
singer39 Forum posts: 0 File comments: 6 Uploads: 0	All is well now. Thank you

06/11/21, 04:54 PM

Solinur

Forum posts: 78

File comments: 693

Uploads: 8

Originally Posted by singer39

It's russian language

Originally Posted by CHESTE_R

I faced the error spam attack in the same way. Using the mundus shadow, spam occurs, if you change the stone to a thief, then everything is fine. Russian language

Originally Posted by Yavandiel

The same..
Shadow stone.
Cause this spam atack I can't do anything when caught by npc while stealing..

Sorry for the trouble. This was exclusive to russian so I didn't encounter it myself. I just uploaded an update, which I hope fixes those issues.

Last edited by Solinur : 06/11/21 at 04:54 PM.

06/11/21, 03:04 PM
Solinur Forum posts: 78 File comments: 693 Uploads: 8	I'm on it, but fixing russian text parsing is challenging, since it uses a weird technical implementation.

06/11/21, 01:01 PM

Yavandiel

Forum posts: 0

File comments: 18

Uploads: 1

Re: spamattack

Originally Posted by CHESTE_R

I faced the error spam attack in the same way. Using the mundus shadow, spam occurs, if you change the stone to a thief, then everything is fine. Russian language

The same..
Shadow stone.
Cause this spam atack I can't do anything when caught by npc while stealing..

06/11/21, 07:20 AM
CHESTE_R Forum posts: 0 File comments: 1 Uploads: 0	spamattack I faced the error spam attack in the same way. Using the mundus shadow, spam occurs, if you change the stone to a thief, then everything is fine. Russian language Last edited by CHESTE_R : 06/11/21 at 07:35 AM.

06/11/21, 05:31 AM

singer39

Forum posts: 0

File comments: 6

Uploads: 0

Originally Posted by Solinur

Sorry, which language are you playing?

It's russian language

06/11/21, 02:12 AM

Solinur

Forum posts: 78

File comments: 693

Uploads: 8

Originally Posted by singer39

With last update i got spam attack

Heeelp mee

Sorry, which language are you playing?

Last edited by Solinur : 06/11/21 at 02:12 AM.

06/10/21, 11:48 AM
singer39 Forum posts: 0 File comments: 6 Uploads: 0	With last update i got spam attack Heeelp mee Last edited by singer39 : 06/10/21 at 11:48 AM.

Page 1 of 2

Report this File