Download
(16 Kb)
Download
Updated: 11/01/22 02:41 PM
Pictures
File Info
Compatibility:
Firesong (8.2.5)
Updated:11/01/22 02:41 PM
Created:04/16/14 09:03 PM
Monthly downloads:232
Total downloads:59,258
Favorites:150
MD5:
JunkBuster  Popular! (More than 5000 hits)
Version: 1.91
by: ADH, Atoom
Now compatible with 8.2.0 Firesong!

This addon provides a rule-based system to put items in your junk bag or destroy them

Unlike the other automatic junking addons, JunkBuster allows you to filter items by any combination of the following criteria:
  • Name
  • Item Type
  • (Specialized) Item Type
  • Equipment slot
  • Weapon/Armor type
  • Level
  • Price
  • Quality
  • Trait
  • Actor type (Player or Companion)
  • Item is crafted or not
  • Item is stolen or not
  • Item has a set bonus or not
  • Recipee is known or not

For example, you can set it to only junk the ingredients you loot that have 0g price value, or the normal quality (white) stolen treasures (but not the green ones).

Other Features:
  • The addon can automatically sell junked items to a merchant (not stolen items) or a fence (stolen items) when visiting them
  • You can add exemption rules that save and unjunk any special item that you want skipped by junkBuster
  • You can add rules to DESTROY items upon looting
    Warning: Be very careful with the destroy option. Destroyed items CAN NOT be returned.

The screenshots show some sample rules that I use when playing.
There is an extended logging option available which provides the info for every looted item in the chatbox so you can fine-tune or make new junking rules.

Planned future additions:
  • Allow <=, >=, == selections for item quality
  • Add support for FCO Item Saver
  • Allow addon to apply rules to (guild) bank too?
v1.91
* Updated API version for game patch 8.2.0

v1.90
* Updated API version for game patch 8.1.5

v1.89
* Updated API version for game patch 8.0.0

v1.88
* Fixed bug affecting rule creation with specialised item type filter
* Updated API version for game/pts version 7.3.5

v1.87
* Fixed bug in matching item names in rules
* Updated API version for game patch 7.2.5

v1.86
* Updated API version for game patch 7.1.5, fixed removed API constants

v1.85
* New filters:
-- Actor type (Player or Companion)
-- Is recipe known (or not)
* Updated API version for game patch 7.0.5 Blackwood and added new item trait and collectible types from the new release

v1.84
* Made additional item types available for rules
-- Crown Item
-- Crown Repair
-- Dye Stamp
-- Master Writ
-- Recall Stone
-- Tabard

v1.83
* Updated API version for game patch 6.3.5

v1.82
* Updated API version for game patch 6.2.5

v1.81
* Updated API version for game patch 6.1.5
* Overhauled chat messages made by this addon
* Removed leftover usage of a LibStub function
* Small bug fixes

v1.80
* Added possibility to customize the order rules are evaluated
-> This required some changes to the way rules are handled from now on
--- Newly added keep rules are inserted at position 1 of the list
--- Newly added junk or destroy rules are added at the bottom of the list
--- Previously created rules and their order should be preserved on updating to this version of the addon
---> Check your rules after updating!
* Added filter for specialized type for item types that have those
* Reorganized settings page layout

v1.79
* Updated API version for game patch 6.0.5

v1.78
* Updated API version for game patch 5.3.4
* Added new item type "Group repair" (or however its called ingame, I'm open for better names)

v1.77
* Updated API version for game patch 5.2.5
* Removed local LibAddonMenu files from the addon and changed it to depend on a external instance of the lib
* Compressed the space taken by some controls in the settings menu
* Added a new Config field "Max. junk sales" where it is possible to configure the maximum amount of items simultaneously sold by the auto junk sell function. If you occasionally get kicked back to the login screen on selling junk you can try lowering this number

v1.76:
* Fixed bug that could display rules twice in the settings menu

v1.75:
* Updated API version for game patch 5.1.5

v1.74:
* Updated API version for game patch 5.0.5
* Updated LAM to 2.0r29
* Added new Itemtype "Currency Container"

v1.73:
* Updated API version for game patch 4.3

v1.72:
* Updated API version for game patch 4.2

v1.71:
* Updated API version for game patch 4.1

v1.70:
* Reworked structure of saved character settings (now based on unique character id instead of the characters displayed name)
* Added a seperate account wide settings profile which can be switched on/off for each character seperately. On first time switching it on after installing/upgrading it will import the current characters settings.

v1.63:
* Fixed displaying of wrong message when one of the "Do Save/Destroy/Junk" settings is disabled
* If a item fits a save, destroy or junk rule which is disabled, addon will now check if one of the other rules apply instead
* Reduced maximum number of items sold at once by the auto junk sale to 89 in hope to avoid triggering zos' action spam protection

v1.62:
* Updated API version for game patch 4.0
* Updated LAM to 2.0r26

v1.61:
* Updated API version for game patch 3.3

v1.60:
* new Filters:
Filter Weapons by Weapon type (Sword, Axe,...)
Filter Armor by Armor Type (Light, Medium, Heavy, Clothing/No Armor)
* Removed a useless lone "0 items sold for 0g" message
* A little more realigning of rule creation controls

v1.52:
* Reworked item level filter to include CP levels
* Realigned the controls in the create rule section to save some vertical space
* Updated LAM to 2.0r25

v1.51:
* Updated API version for game patch 3.2

v1.50:
* New Filters:
Filter equipable items (weapons and armor) by their slot (Head, chest, one handed, ...)
Filter items by them having a set bonus or not
* Stolen junk is now sold sorted by price instead of quality at a fence
* Updated, sorted and corrected item types for rules. Tell me if a item type that you need / were using is missing
* Dollar signs for item prices changed to small g (gold)

v1.40:
* Added option to automatically sell junk when visiting a merchant (non stolen junk) or fence (stolen junk)
* Added option to filter for stolen or not stolen items
* Added option to add crafted items to rules
* You can now open the settings panel by typing /jb into the chat
* Corrected some trait and item quality names
* Item qualityies except Normal now colored in their respective colors in the rules display
* Grouped the on/off settings a bit

v1.31:
* Provisional fix for the rules display in the settings panel disappearing

v1.3:
* Updated for HotR / API 100020
* Changed Settings Pannel from LAM-1.0 to LAM-2.0r24
* Items crafted by a player are currently ignored (will not be junked or deleted)
* Many small fixes and improvements
- Disabled junk Trial run (never worked for me, may be fixed and reenabled in the future)
- Disabled Filter by crafting type (never found a use for this filter, tell me if you want it back)

v1.21:
* Update to new API version
* Removed a couple of item types that were obsolete

v1.2:
* Updated API version
* Changed the way rules are stored (thanks Alisu@)
* Rulesets can individually be turned on or off
* Laid the foundation for autobanking framework

v1.12: Added minimum level and price options

v1.11: Fixed a bug in item trait comparison. Thanks alisu!

v1.1:
* Several bug fixes
* Added rules to save and unjunk items
* Added rules to destroy items

v1.02: Added 'No Traits' option as per requests

v1.01: Made reporting in chat box to appear the same style as the rules in settings box.
Optional Files (0)


Archived Files (32)
File Name
Version
Size
Uploader
Date
1.90
15kB
Atoom
08/24/22 05:00 PM
1.89
15kB
Atoom
05/27/22 04:31 AM
1.88
15kB
Atoom
02/23/22 10:43 AM
1.87
15kB
Atoom
10/25/21 04:09 AM
1.86
15kB
Atoom
08/23/21 10:12 AM
1.85
15kB
Atoom
06/01/21 12:26 PM
1.84
14kB
Atoom
05/04/21 01:02 PM
1.83
14kB
Atoom
03/08/21 10:32 AM
1.82
14kB
Atoom
11/04/20 11:29 AM
1.81
14kB
Atoom
09/12/20 02:47 PM
1.80
14kB
Atoom
06/01/20 04:20 PM
1.79
12kB
Atoom
05/27/20 10:59 AM
1.78
12kB
Atoom
02/24/20 01:26 PM
1.77
12kB
Atoom
10/24/19 12:47 PM
1.76
57kB
Atoom
08/18/19 03:48 PM
1.75
57kB
Atoom
08/12/19 09:57 AM
1.74
57kB
Atoom
05/20/19 01:22 PM
1.73
55kB
Atoom
02/26/19 01:38 PM
1.72
55kB
Atoom
10/23/18 04:31 PM
1.71
55kB
Atoom
08/15/18 07:32 AM
1.70
55kB
Atoom
07/07/18 11:26 AM
1.63
54kB
Atoom
05/24/18 04:09 PM
1.62
54kB
Atoom
05/23/18 12:10 PM
1.61
53kB
Atoom
02/13/18 04:03 PM
1.60
53kB
Atoom
11/01/17 10:02 AM
1.52
52kB
Atoom
10/26/17 08:42 AM
1.51
52kB
Atoom
10/23/17 11:34 AM
1.50
52kB
Atoom
09/09/17 11:36 AM
1.40
51kB
Atoom
09/04/17 01:50 PM
1.31
50kB
Atoom
09/01/17 10:30 AM
1.3
50kB
Atoom
08/23/17 01:58 PM
1.21
12kB
ADH
06/25/14 07:19 PM


Post A Reply Comment Options
Unread 04/18/14, 06:37 PM  
Kabushiki

Forum posts: 2
File comments: 51
Uploads: 0
This is constantly junking my provisioning mats even without any filter that applies to them. But I wanted to be sure so I removed all filters except for Weapon Ornate, Armor Ornate and Jewelery Ornate and it is still junking mats like Oat Mash!
Report comment to moderator  
Reply With Quote
Unread 04/19/14, 02:28 AM  
Vantor
 
Vantor's Avatar

Forum posts: 0
File comments: 58
Uploads: 0
Originally Posted by Kabushiki
This is constantly junking my provisioning mats even without any filter that applies to them. But I wanted to be sure so I removed all filters except for Weapon Ornate, Armor Ornate and Jewelery Ornate and it is still junking mats like Oat Mash!
Yep same for me, I've disabled it until a further patch. If the filters manage to work properly it'll be the perfect loot mod for me.
Report comment to moderator  
Reply With Quote
Unread 04/19/14, 04:48 AM  
Alisu
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 35
Uploads: 4
I found one problem with food items though it doesn't yet solve anything. The game API offers two functions for asking itemType, "GetItemCraftingInfo" and "GetItemType", you use the first one but it seems it always returns type 0 if the item is not crafting ingredient. I solved this by placing

Lua Code:
  1. if type == 0 then
  2.   type = GetItemType(bagId, slotId)
  3. end

in the utils file on line 11, between the original information queries and return. With this though the game seems to class awfully many items as trophies, returning 5 as their type. My conclusion, the games item typing is in the same state as many aspects in the game yet, somewhat fubar..

edit: sight, it seems the type 5 is equal for type 0 in that it can't be taken reliably. this far everything which is not crafting ingredient, with my addition to the type query, has returned type 5, trophy...


Edit 2: darn, used wrong variable name for slotId in my example and now I'm not in place where I can further test it. I fixed it in the code example but can't test if things start to report correct types for them with it. What I do know the original code only seems to report correct type for crafting ingredients.
Last edited by Alisu : 04/19/14 at 09:43 AM.
Report comment to moderator  
Reply With Quote
Unread 04/19/14, 04:10 PM  
ADH
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 16
Uploads: 1
I've uploaded a new version with some bugfixes and rules for saving and destroying items. Let me know if this fixes your problems



Alisu: Actually, that did inspire me to make a change with that. I think this fixes a bunch of problems we were having
Report comment to moderator  
Reply With Quote
Unread 04/19/14, 05:52 PM  
Vantor
 
Vantor's Avatar

Forum posts: 0
File comments: 58
Uploads: 0
Ornate junking is still not working for me :/
I've put the appropriate filters and nothing happens
Last edited by Vantor : 04/19/14 at 05:52 PM.
Report comment to moderator  
Reply With Quote
Unread 04/19/14, 07:06 PM  
ADH
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 16
Uploads: 1
Originally Posted by Vantor
Ornate junking is still not working for me :/
I've put the appropriate filters and nothing happens
Well, if you want me to do something about it, you gotta provide some more info.
What does your item say it is in the sample run of items (bottom of settings page)?
What rule did you make?
Does the item log line match the description of your rule and it still does nothing?
Report comment to moderator  
Reply With Quote
Unread 04/20/14, 03:11 AM  
McGuffin

Forum posts: 5
File comments: 35
Uploads: 0
Hi, thx for this little tool: its seems a lot promising, but does this addon works in other language than English?
It works with some filter and doesnt for some other...

for example:
destroy lure cost 0, works
junk any blacksmith weapon/armor (white) doesnt work
Last edited by McGuffin : 04/20/14 at 03:51 AM.
Report comment to moderator  
Reply With Quote
Unread 04/20/14, 04:26 AM  
Alisu
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 35
Uploads: 4
Originally Posted by McGuffin
Hi, thx for this little tool: its seems a lot promising, but does this addon works in other language than English?
It works with some filter and doesnt for some other...

for example:
destroy lure cost 0, works
junk any blacksmith weapon/armor (white) doesnt work
All comparison, except name based of course, is based on integer codes so I'd assume the problem is not language related at least. How have you set up the rule? The craft name should only be relevant for craft ingredients (if I recall right). Defining something to be both "blacksmithing" and "weapon" thus wouldn't match anything.

Edit: it seems to me Inventory.lua might have a typo on line 70 where "item.type" should be "item.trait", I'm not sure if this can cause your problem but as far as I see from code might need to be fixed anyway. I'm yet with no change to test that either (cursed Easter holiday :P)
Last edited by Alisu : 04/20/14 at 05:08 AM.
Report comment to moderator  
Reply With Quote
Unread 04/20/14, 05:11 AM  
Alisu
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 35
Uploads: 4
Originally Posted by ADH
Originally Posted by Vantor
Ornate junking is still not working for me :/
I've put the appropriate filters and nothing happens
Well, if you want me to do something about it, you gotta provide some more info.
What does your item say it is in the sample run of items (bottom of settings page)?
What rule did you make?
Does the item log line match the description of your rule and it still does nothing?
Hmm, actually mentioned this in my other post, the line 70 is now
Lua Code:
  1. if (rule.trait >= 0) and (item.type ~= rule.trait) then return false end

That is, you're comparing items type against trait rule. That propably causes all trait related filtering problems.
Report comment to moderator  
Reply With Quote
Unread 04/20/14, 05:46 AM  
McGuffin

Forum posts: 5
File comments: 35
Uploads: 0
Originally Posted by Alisu

All comparison, except name based of course, is based on integer codes so I'd assume the problem is not language related at least. How have you set up the rule? The craft name should only be relevant for craft ingredients (if I recall right). Defining something to be both "blacksmithing" and "weapon" thus wouldn't match anything.
ah ok...
so i guess the issue is on my end .
I made a filter that junk item_type: Weapon - crafting_type: blacksmith - quality: normal
so this cant work since blacksmith only matches "ore" or "regent"?

is there a way to set that kind of rules?
Last edited by McGuffin : 04/20/14 at 05:47 AM.
Report comment to moderator  
Reply With Quote
Unread 04/20/14, 07:36 AM  
Alisu
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 35
Uploads: 4
Originally Posted by McGuffin
Originally Posted by Alisu

All comparison, except name based of course, is based on integer codes so I'd assume the problem is not language related at least. How have you set up the rule? The craft name should only be relevant for craft ingredients (if I recall right). Defining something to be both "blacksmithing" and "weapon" thus wouldn't match anything.
ah ok...
so i guess the issue is on my end .
I made a filter that junk item_type: Weapon - crafting_type: blacksmith - quality: normal
so this cant work since blacksmith only matches "ore" or "regent"?

is there a way to set that kind of rules?
If you want to set separate rule based on if it's a weapon made by blacksmith, or woodworker, the closest idea I can come up with is to set separate rule for every weapon type. However, currently this addon doesn't offer way to do it since the games item information querying functions don't offer simple way to query it, except.

The event used gets itemSoundCategory and that supposedly is enough to separate between different weapon/armor types so it can be used to gather this info. This is something the addon author would have to add himself but it should be somewhat straightforward to do.
Report comment to moderator  
Reply With Quote
Unread 04/20/14, 10:32 AM  
Vantor
 
Vantor's Avatar

Forum posts: 0
File comments: 58
Uploads: 0
Originally Posted by ADH
Originally Posted by Vantor
Ornate junking is still not working for me :/
I've put the appropriate filters and nothing happens
Well, if you want me to do something about it, you gotta provide some more info.
What does your item say it is in the sample run of items (bottom of settings page)?
What rule did you make?
Does the item log line match the description of your rule and it still does nothing?
Nope the item log line doesn't match. All the matching lines work fine.

e.g. Junk any Normal quality Weapon with trait Weapon Ornate.
respectively for armor and all normal jewels. None of them work.
I happen to have a normal ornate belt on me and it registers as Looting and not as junked.

In the beginning i thought it didn't work cause i had only selected the respective trait, without selecting item type, but it didn't work even after i put the types in the rule.
Last edited by Vantor : 04/20/14 at 10:34 AM.
Report comment to moderator  
Reply With Quote
Unread 04/20/14, 10:42 AM  
Alisu
AddOn Author - Click to view AddOns

Forum posts: 3
File comments: 35
Uploads: 4
Originally Posted by Vantor
Originally Posted by ADH
Originally Posted by Vantor
Ornate junking is still not working for me :/
I've put the appropriate filters and nothing happens
Well, if you want me to do something about it, you gotta provide some more info.
What does your item say it is in the sample run of items (bottom of settings page)?
What rule did you make?
Does the item log line match the description of your rule and it still does nothing?
Nope the item log line doesn't match. All the matching lines work fine.

e.g. Junk any Normal quality Weapon with trait Weapon Ornate.
respectively for armor and all normal jewels. None of them work.
I happen to have a normal ornate belt on me and it registers as Looting and not as junked.

In the beginning i thought it didn't work cause i had only selected the respective trait, without selecting item type, but it didn't work even after i put the types in the rule.
Fix the typo in jbInventory.lua, on line 70 change the "item.type" to "item.trait" and see if that fixes the problem.
Report comment to moderator  
Reply With Quote
Unread 04/20/14, 12:32 PM  
McGuffin

Forum posts: 5
File comments: 35
Uploads: 0
Originally Posted by Alisu
Fix the typo in jbInventory.lua, on line 70 change the "item.type" to "item.trait" and see if that fixes the problem.
I can confirm it's working with that fix.
Report comment to moderator  
Reply With Quote
Unread 04/20/14, 12:52 PM  
ADH
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 16
Uploads: 1
Oh wow, that was a copy-paste fail on my behalf

Thanks a lot Alisu. Just submitted the fixed version. Should get approved soon

Edit: it's up
Last edited by ADH : 04/20/14 at 12:58 PM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: