Quantcast
Download
(13 Kb)
Download
Updated: 10/30/19 05:21 PM
Pictures
File Info
Compatibility:
Dragonhold (5.2.5)
Scalebreaker (5.1.5)
Elsweyr (5.0.5)
Updated:10/30/19 05:21 PM
Created:07/04/17 05:45 PM
Monthly downloads:143
Total downloads:13,326
Favorites:23
MD5:
5.2.5
Where's My Guild Hall  Popular! (More than 5000 hits)
Version: 2.2.1
by: Shadowfen [More]
Depends on the following (separately installed) libraries: LibSFUtils, LibAddonMenu

Shows the available "guild halls" for your guild on the guild home screen.

It allows you to set for each of your guilds individually if you want to assume that the guild master owns a guild hall, and/or if you want the addon to look for the "Guild Hall List" (GHL) addon marker characters "<GH" or the phrase "Guild Hall" in the guild member notes.

If you turn on Guild Master Owner, then the guild master will always be listed first in the guild halls list on the Guild home page. The guild master will then be followed by any guild members that have the GHL marker or "Guild Hall" marker in their guild member notes (if you have turned on Guild Hall List compatibility mode).

This addon conflicts with Guild Hall List - primarily because we try to use the exact same spot on the Guild page for our guild hall lists.

I wrote this addon because sirinsidiator's excellent Guild Hall List addon did not assume that the guild master owned the guild hall - instead, it required the guild hall owner to put the "<GH" marker in their member notes. Unfortunately, the guild hall owners for my guilds did not wish to add the "<GH" marker so that I could use the addon. Sirinsidiator did not wish to add guild masters as owners to his addon because in his guilds, some of the guild hall owners were not the guild masters. So, this addon was born...
2.2.1
  • Fix version to prevent being listed as "Out of Date".

2.2
  • Fixed the code to scan for guild hall markers in the guild roster when you change guilds on the Guild page. (reported by MycroftJr)

2.1.3
  • API Bump

2.1.2
  • Adjusted the location of the Guild Hall listing on the guild page so that it appears below the new "View Bid" button.
  • API bump.

2.1.1
  • Fixed problem with the addon not saving its settings properly (reported by Rhyono).

2.1
  • Fixed errors that occurred when people were removed from guilds or changed ranks.

2.0
  • Rewrite to fix problems from the Zenimax change from guild indexes (1-5) to real guild IDs for certain functions.
  • Change localization string tables to work with LibSFUtils.LoadLanguage()

1.6
  • Fix settings page after library changes with Elsweyr.

1.5
  • Use LibAddonMenu-2.0 directly instead of through LibStub. LibAddonMenu-2.0 and LibSFUtil both still need to be installed separately.
  • API Bump

1.4
  • API Bump

1.3
  • Removed all embedded libraries. You must now install LibSFUtils, and LibAddonMenu separately in order for WheresMyGuildHall to work.
  • Added help display when you /wmgh in chat to display the various things you can do in chat for this addon.
  • Converted to use the saved variables functions from LibSFUtils.
  • Updated to use LibSFUtils version 12.

1.2.1
  • API Bump

1.2
  • Updated LibSFUtils to version 10.
  • Fix the saved indexes of the guilds when you drop out of one of your guilds.

1.1.15
  • API Bump

1.1.14
  • API Bump
  • Upgraded LibSFUtils to version 8.

1.1.13
  • Russian translations provided courtesy of alexesprit.

1.1.12
  • Fix the Guild Member Note Change error message.
I still occasionally see errors when someone else's guild membership changes (I assume), but a /reloadui will fix it - and maybe one day I'll figure out the problem...

1.1.11
  • Correct an error in a debug message.
  • Fix usage of debug messages to have them start as turned off.

1.1.10
  • Modify matching the saved guild settings to active guilds.

1.1.9
  • Experimenting with guild id representations.

1.1.8
  • Fixed a new problem with defining a non-existent guild entry in my internal tables.

1.1.7
  • Changes to Active Guild scan code to determine which guilds you belong to. This time it is based on the assumption that the Zenimax guild table is a sparse array and may have nil entries (whereas before I thought that it was a simple contiguous list). The change should not affect anyone that the addon already works for, and may fix it for those who are having problems.

1.1.6
  • Changes to Active Guild scan code to determine which guilds you belong to.
  • Added a toggle debug messages slash command "/wmgh.debug" to display some debug messages in chat while loading active guilds. Since that is normally done before the chat window is available - you must /wmgh.debug and then /wmgh.init (which explicitly runs the loadActiveGuilds function). To turn off debug messages, /wmgh.debug again.

1.1.5
  • API bump.
  • Upgraded LibSFUtils to version 6.

1.1.4
  • Rewrote code where Where's My Guildhall would see an "attempt to index nil value" error when a guild note was changed in one of your guilds. If any of you see this error again, please let me know.
  • Changes to the WheresMyGuild settings for the current guild will now automatically update in the Guild page instead of requiring to to look at another guild and then come back to the guild that you just changed the settings for.
  • Changes that you make to your guild notes (to add or remove a guild hall marker) will now automatically be updated on the Guild Home page.
  • Upgraded LibAddonMenu to r25.

1.1.3
  • Theoretically fixed an error where Where's My Guildhall would see an "attempt to index nil value" error when a guild note was changed in one of your guilds. If any of you see this error again, please let me know.

1.1.2
  • Modified the settings saves so that it distinguishes which megaserver you are currently on. This change will require everyone to redo their settings so they can be saved properly for the megaserver(s) that they play on, but it allows people to play on multiple megaservers without getting the savedvariables corrupted.

1.1.1
  • Revised the settings text so the important part doesn't get cut off.

1.1.0
  • Added a new marker style for guild notes. Now you can choose to have it look for the words "Guild Hall" (with exactly that capitalization) in the guild notes. This is turned off by default.
  • Fixed the guild hall list so that people are only listed once on it even if they are the Guild Master and have "<GHL" and "Guild Hall" in their personal notes. Previously, they would have been listed multiple times.

1.0.4
  • Fixed problem with loading the saved variables.
  • Fixed problem with displaying guild halls for the very first guild before data was loaded.
  • Fixed lua error that was occurring when the guild MOTD was getting changed.

1.0.3
  • Bump up the API version.
  • Upgraded LibAddonMenu to 2.0_r24.

1.0.2
  • Reworked how the guild settings were rematched to the player's active guilds.
  • Reworked the processing to do only as much as absolutely necessary at a time in order to increase performance.
  • Created a library to put my commonly used functions in so they can be available to all of my addons.

1.0.1
  • Fixed some problems where the guild hall lists just went away.
  • Fixed problem where sometimes the guild halls listed were for a different guild than the one currently on the Guild Home page.

1.0
  • Works with Morrowind
  • Initial release by Shadowfen
Optional Files (1)
File Name
Version
Size
Author
Date
Type
2.1.3
13kB
08/31/19 01:47 PM
Patch


Archived Files (34)
File Name
Version
Size
Uploader
Date
2.2
13kB
Shadowfen
10/25/19 05:17 PM
2.1.3
13kB
Shadowfen
10/20/19 05:09 PM
2.1.2
13kB
Shadowfen
08/15/19 11:36 PM
2.1.1
12kB
Shadowfen
06/15/19 09:31 PM
2.1
12kB
Shadowfen
06/03/19 09:54 PM
2.0
12kB
Shadowfen
05/31/19 02:06 PM
1.6
12kB
Shadowfen
05/21/19 03:01 PM
1.5
12kB
Shadowfen
05/02/19 11:13 PM
1.4
12kB
Shadowfen
02/25/19 10:09 PM
1.3
12kB
Shadowfen
12/31/18 02:05 PM
1.2.1
60kB
Shadowfen
10/21/18 11:29 AM
1.2
60kB
Shadowfen
08/29/18 05:50 PM
1.1.15
59kB
Shadowfen
08/13/18 05:58 PM
1.1.14
59kB
Shadowfen
05/20/18 02:52 PM
1.1.13
59kB
Shadowfen
03/04/18 03:57 PM
1.1.12
58kB
Shadowfen
01/17/18 10:38 PM
1.1.12
58kB
Shadowfen
01/15/18 08:54 PM
1.1.10
58kB
Shadowfen
01/15/18 02:05 PM
1.1.10
58kB
Shadowfen
01/15/18 01:28 PM
1.1.9
58kB
Shadowfen
01/13/18 08:38 PM
1.1.8
58kB
Shadowfen
01/13/18 11:12 AM
1.1.7
58kB
Shadowfen
01/12/18 11:48 PM
1.1.6
58kB
Shadowfen
01/11/18 09:31 PM
1.1.5
58kB
Shadowfen
01/08/18 10:51 PM
1.1.4
57kB
Shadowfen
11/26/17 09:39 PM
1.1.3
58kB
Shadowfen
11/17/17 12:27 AM
1.1.2
58kB
Shadowfen
10/14/17 05:34 PM
1.1.2
58kB
Shadowfen
10/09/17 03:17 PM
1.1.0
58kB
Shadowfen
10/05/17 06:58 PM
1.0.4
57kB
Shadowfen
08/26/17 10:46 PM
1.0.3
57kB
Shadowfen
08/15/17 07:13 PM
1.0.2
55kB
Shadowfen
07/11/17 07:20 PM
1.0.1
53kB
Shadowfen
07/06/17 08:30 PM
1.0.1
53kB
Shadowfen
07/04/17 05:45 PM


Post A Reply Comment Options
Unread 10/25/19, 05:31 PM  
Shadowfen
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 279
Uploads: 10
Re: Still only works for 1st guild

Originally Posted by MycroftJr
If you won't make the other changes I've recommended, please at least put
Lua Code:
  1. for i=1,WMGH.numGuilds do
  2.     local gid = GetGuildId(i)
  3.     WMGH.DoRescan(gid)
  4.     WMGH.DoDisplay(gid)
  5. end
at the end of onPlayerActivated(). Without it, only the 1st guild is ever scanned for member notes.
With version 2.2 (released today) I have fixed that problem - only not with the code that you've provided.
I very much appreciate the help, and your suggestion pointed me to the actual problem in the code, but you suggestion had two potential problems with it:
  1. It puts a lot of delay into your initial load screen on character login. While it runs rapidly enough for a small guild, if people belong to multiple 400+ member guilds then the lag becomes unacceptable. On general principle, when you take the chance of potentially inspecting large amounts of data, it is better practice to inspect only the minimum set of the data that you really need at the time that you do the inspection. The roster for guild 3 for instance only really needs to be read and examined if you go to the guild page for guild 3 - otherwise it was just wasted seconds.
  2. It does not update, if another guild note marker is placed in one of the guild rosters after you log in. You have to /reloadui in order to get the new guild house designated by a new marker. Once again it wastes seconds that I could have spent learning how to play better.
Report comment to moderator  
Reply With Quote
Unread 10/21/19, 08:42 PM  
MycroftJr
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 11
Uploads: 1
Still only works for 1st guild

If you won't make the other changes I've recommended, please at least put
Lua Code:
  1. for i=1,WMGH.numGuilds do
  2.     local gid = GetGuildId(i)
  3.     WMGH.DoRescan(gid)
  4.     WMGH.DoDisplay(gid)
  5. end
at the end of onPlayerActivated(). Without it, only the 1st guild is ever scanned for member notes.
Last edited by MycroftJr : 10/21/19 at 08:45 PM.
Report comment to moderator  
Reply With Quote
Unread 10/20/19, 03:41 PM  
Shadowfen
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 279
Uploads: 10
Originally Posted by SteveCampsOut
Getting errors from this addon today after a few other addons have been updated. Possible conflicts from LibMainMenu?
I was not able to get new errors from updating today's addons (and WMGH does not use LibMainMenu).

Can you give me any more info?
Last edited by Shadowfen : 10/20/19 at 04:30 PM.
Report comment to moderator  
Reply With Quote
Unread 10/20/19, 12:26 AM  
SteveCampsOut
 
SteveCampsOut's Avatar

Forum posts: 25
File comments: 318
Uploads: 0
Getting errors from this addon today after a few other addons have been updated. Possible conflicts from LibMainMenu?
Report comment to moderator  
Reply With Quote
Unread 08/22/19, 11:55 PM  
MycroftJr
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 11
Uploads: 1
Re: Bugs?

Originally Posted by MycroftJr
Not sure if my copy of the addon was bad, but it wasn't working very well so I debugged it. Here are my conclusions:
1. function WMGH.DoDisplay() should be function WMGH.DoDisplay(guildId), and the single WMGH.DoDisplay() with no parameter in ScanGuildForHalls should be WMGH.DoDisplay(current_guild).
2. getAllMarkerHalls is only called by WMGH.ScanGuild, which is only called by DoRescan. But DoRescan is only called for guild 1, in onPlayerActivated. Calling it in a loop there for every guild fixed it for me
3. There was at least one reference to WMGH.numberGuilds, which I think should either be WMGH.numGuilds or WMGH.saved.numberGuilds?

Apologies if these are old bugs, but hopefully this saves you some time.
These bugs were still present in the newest update, which prevented it from working entirely for my 3rd guild.
Report comment to moderator  
Reply With Quote
Unread 06/23/19, 11:10 PM  
MycroftJr
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 11
Uploads: 1
Bugs?

Not sure if my copy of the addon was bad, but it wasn't working very well so I debugged it. Here are my conclusions:
1. function WMGH.DoDisplay() should be function WMGH.DoDisplay(guildId), and the single WMGH.DoDisplay() with no parameter in ScanGuildForHalls should be WMGH.DoDisplay(current_guild).
2. getAllMarkerHalls is only called by WMGH.ScanGuild, which is only called by DoRescan. But DoRescan is only called for guild 1, in onPlayerActivated. Calling it in a loop there for every guild fixed it for me
3. There was at least one reference to WMGH.numberGuilds, which I think should either be WMGH.numGuilds or WMGH.saved.numberGuilds?

Apologies if these are old bugs, but hopefully this saves you some time.
Last edited by MycroftJr : 06/23/19 at 11:23 PM.
Report comment to moderator  
Reply With Quote
Unread 06/15/19, 07:03 PM  
Shadowfen
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 279
Uploads: 10
Originally Posted by Rhyono
The individual guild settings don't work for me. They don't seem to save at all.
I will look into it.


Editted:

Fixed in version 1.2.1.
Last edited by Shadowfen : 06/15/19 at 10:00 PM.
Report comment to moderator  
Reply With Quote
Unread 06/15/19, 10:32 AM  
Rhyono
AddOn Author - Click to view AddOns

Forum posts: 561
File comments: 1116
Uploads: 19
The individual guild settings don't work for me. They don't seem to save at all.
Report comment to moderator  
Reply With Quote
Unread 06/07/19, 10:27 PM  
Shadowfen
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 279
Uploads: 10
Originally Posted by yoco007
Hi! I get this error
You probably need to download (or activate) the LibAddonMenu-2.0 addon that this addon depends on.
Report comment to moderator  
Reply With Quote
Unread 06/07/19, 05:26 AM  
yoco007

Forum posts: 3
File comments: 43
Uploads: 0
Hi! I get this error
user:/AddOns/WheresMyGuildHall/Settings.lua:110: attempt to index a nil value
stack traceback:
user:/AddOns/WheresMyGuildHall/Settings.lua:110: in function 'WMGH.RegisterSettings'
|caaaaaa<Locals> guilds = tbl </Locals>|r
user:/AddOns/WheresMyGuildHall/WheresMyGuildHall.lua:565: in function 'onPlayerActivated'
Report comment to moderator  
Reply With Quote
Unread 05/28/19, 04:16 AM  
Shadowfen
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 279
Uploads: 10
Originally Posted by SteveCampsOut
Originally Posted by Shadowfen
Originally Posted by SteveCampsOut
Well there's a new addon out there called Essential Housing Tools that starting today is using a string of characters in people's guild roster notes that totally spazm's out Where's My Guild Hall's <GHL feature!
I'm not sure what I can actually do about that.
The <GHL detection can be turned off to avoid conflict with Essential Housing Tools as necessary.
I get errors now when trying to turn that on or off with the latest update.
I'm looking into that. Thanks.
Last edited by Shadowfen : 05/28/19 at 04:17 AM.
Report comment to moderator  
Reply With Quote
Unread 05/28/19, 03:55 AM  
SteveCampsOut
 
SteveCampsOut's Avatar

Forum posts: 25
File comments: 318
Uploads: 0
Originally Posted by Shadowfen
Originally Posted by SteveCampsOut
Well there's a new addon out there called Essential Housing Tools that starting today is using a string of characters in people's guild roster notes that totally spazm's out Where's My Guild Hall's <GHL feature!
I'm not sure what I can actually do about that.
The <GHL detection can be turned off to avoid conflict with Essential Housing Tools as necessary.
I get errors now when trying to turn that on or off with the latest update.
Report comment to moderator  
Reply With Quote
Unread 04/07/19, 09:26 PM  
Shadowfen
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 279
Uploads: 10
Originally Posted by SteveCampsOut
Well there's a new addon out there called Essential Housing Tools that starting today is using a string of characters in people's guild roster notes that totally spazm's out Where's My Guild Hall's <GHL feature!
I'm not sure what I can actually do about that.
The <GHL detection can be turned off to avoid conflict with Essential Housing Tools as necessary.
Report comment to moderator  
Reply With Quote
Unread 04/01/19, 06:26 PM  
SteveCampsOut
 
SteveCampsOut's Avatar

Forum posts: 25
File comments: 318
Uploads: 0
Well there's a new addon out there called Essential Housing Tools that starting today is using a string of characters in people's guild roster notes that totally spazm's out Where's My Guild Hall's <GHL feature!
Last edited by SteveCampsOut : 04/01/19 at 06:31 PM.
Report comment to moderator  
Reply With Quote
Unread 11/12/18, 01:18 AM  
Shadowfen
AddOn Author - Click to view AddOns

Forum posts: 39
File comments: 279
Uploads: 10
Originally Posted by SteveCampsOut
I can't access the settings on this addon anymore. It's also not showing guild halls and buttons when I first open the guild page. I have to switch guilds for them to show up.
I'll look into it.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: