Quantcast
Download
(85 Kb)
Download
Updated: 02/07/19 10:53 AM
Pictures
File Info
Compatibility:
Murkmire (4.2)
Updated:02/07/19 10:53 AM
Created:08/09/18 07:47 PM
Monthly downloads:522
Total downloads:1,082
Favorites:5
MD5:
4.2
Advanced Junk Filters
Version: 1.7
by: eromelcm [More]


Addons like Dustman are fantastic, but don't offer a deep level of control over exactly what, and under what conditions things get marked as junk. Advanced Junk Filters aims to give you that control. To see what is possible, take a look at the documentation
  • Define your own custom junk filters.
  • Set the order that your filters are applied.
  • Automatically sell junk at vendors.
Future plans:
  • Character specific filters.
  • A way to view an item's type information to remove any guessing.
1.7
- Added option to toggle auto sell
- Added "hasSet" to usable functions

1.6
- Added "id" to usable functions

1.4
- /filternow fixed
- Code cleanup

1.3
- Fixed "ftype" bug not working as intended
- Can now use numbers for "type", "stype", "ftype", "trait", "weapontype", and "armortype"
- Updated documentation

1.2
- Fixed a bug where "ftype" would only check the first filter type of an item. An item can have multiple filter types

1.1
- Fixed quality function not working right when comparing
- Updated documentation with accurate type information

1.0
- Update for Murkmire.
- Added "isKnown" to usable functions

0.8
- Updated for Wolfhunter.
- Added "craftRank" to usable functions
Optional Files (0)


Post A Reply Comment Options
Unread 02/07/19, 11:11 AM  
eromelcm
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 5
Uploads: 2
Re: More options

Originally Posted by SimplyArmin
BTW would be nice to select if you want to auto sell or not. For me I like to see my junk again before selling just in case.
Done. Added option in 1.7
Report comment to moderator  
Reply With Quote
Unread 02/07/19, 08:30 AM  
SimplyArmin

Forum posts: 0
File comments: 16
Uploads: 0
More options

Thanks for the explanation. I'll gonna try that out for sure. BTW would be nice to select if you want to auto sell or not. For me I like to see my junk again before selling just in case.
I just commented the lines in the addon for now.

Greets
Last edited by SimplyArmin : 02/07/19 at 08:30 AM.
Report comment to moderator  
Reply With Quote
Unread 01/28/19, 02:13 AM  
eromelcm
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 5
Uploads: 2
Re: Need a bit of help :D

Originally Posted by SimplyArmin
Hi,
very big fan of ur addon.
currently am struggling a bit, and im trying to learn how to make filters properly.
When you have a more complex filter like you have, it's a good idea to separate out your "and" and "or" statements with parens like this:

Lua Code:
  1. (... and ...) or (... and ...)

But in your case, I would break it up into separate filters:

Filter 1: Junk jewelry that has no set.

Lua Code:
  1. ftype('Jewelry') and set('None')

Filter 2: Junk jewelry that has no trait or is ornate.

Lua Code:
  1. ftype('Jewelry') and trait('None', 'Ornate')

Filter 3: Junk jewelry worse than blue quality that is not intricate and not crafted.

Lua Code:
  1. ftype('Jewelry') and quality() < 3
  2. and not trait('Intricate')
  3. and not isCrafted()

As for names,
Originally Posted by SimplyArmin
Also would like to know if someone knows how to handle jewelery like Exemplary Swift Neck.
The "name" function looks at the full name of an item, not just a part of the name. So if the item name is " Exemplary Swift Necklace", just using "Exemplary" will not match because that's not the item's name, just one word in the name. I might in the future add a way to match on just part of a name, but it would be a separate function. For now just do:

Lua Code:
  1. name('Exemplary Swift Necklace')
Last edited by eromelcm : 01/28/19 at 02:14 AM.
Report comment to moderator  
Reply With Quote
Unread 01/26/19, 06:50 AM  
SimplyArmin

Forum posts: 0
File comments: 16
Uploads: 0
Need a bit of help :D

Hi,
very big fan of ur addon.
currently am struggling a bit, and im trying to learn how to make filters properly.
Actually im trying to filter out jewelery which looks like this:
Code:
ftype('Jewelry') and set('None')
or
ftype('Jewelry') and trait('None', 'Ornate')
or
ftype('Jewelry') and quality() >= 2
and not
trait('Intricate')
and not
isCrafted()
the fiilter works well except the quality part... How can i tell my filter to sort out items with a quality equal or lower then green.
Also would like to know if someone knows how to handle jewelery like Exemplary Swift Neck.
I tried out with
Code:
and not name('Exemplary')
which didnt work.
And last quetion is do you think i somehow can improve my code?
Thanks
Report comment to moderator  
Reply With Quote
Unread 01/20/19, 10:53 AM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1904
File comments: 2089
Uploads: 52
Originally Posted by jubalfh
+1; actually I think that this might have a potential to finally replace both FCOIS and Inventory Manager with something less clunky and more powerful.
Clunky I've never read this complaint from your side in my addon's comments nor via PM.
Sometimes it will just be enough to "ask" or "tell" what your concers or ideas are, instead of talking bad about other addons in addon comments.

btw: FCOIS is not meant to do your inventory management for you. It was build to "save your items", and not to define junkfilters.

@eromelcm
If you want to support FCOIS saved items within your addon have a look at the file FCOIS_API.lua. I think the function
Code:
FCOIS.IsMarked
would be enough to check for marker icons on an item -> This item is protected against junk then.
Last edited by Baertram : 01/20/19 at 10:56 AM.
Report comment to moderator  
Reply With Quote
Unread 01/18/19, 04:39 PM  
Marazota

Forum posts: 93
File comments: 825
Uploads: 0
eventually smthing highly customizable as Circonian JunkIt?
Last edited by Marazota : 01/19/19 at 12:03 PM.
Report comment to moderator  
Reply With Quote
Unread 08/11/18, 08:58 AM  
jubalfh
 
jubalfh's Avatar

Forum posts: 0
File comments: 3
Uploads: 0
Originally Posted by SlippyCheeze
Nice. Any thought of supporting FCO ItemSaver marks as an output, or side-effect? I'd love to be able to mark as junk with that, but also mark into my guild bank, etc.
+1; actually I think that this might have a potential to finally replace both FCOIS and Inventory Manager with something less clunky and more powerful.

A quick question: OP, have you looked at AutoInventory? It would be extremely rad, if the functions and queries for both plugins had the same syntax. Perhaps it would be feasible to carve out a common library out of both?
Report comment to moderator  
Reply With Quote
Unread 08/09/18, 08:02 PM  
SlippyCheeze
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 234
Uploads: 1
Nice. Any thought of supporting FCO ItemSaver marks as an output, or side-effect? I'd love to be able to mark as junk with that, but also mark into my guild bank, etc.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: