Quantcast
Download
(914 Kb)
Download
Updated: 10/27/18 09:00 AM
Pictures
File Info
Compatibility:
Murkmire (4.2)
Wolfhunter (4.1)
Summerset (4.0)
Updated:10/27/18 09:00 AM
Created:09/11/18 09:42 AM
Monthly downloads:68
Total downloads:611
Favorites:8
MD5:
4.2
Rulebased Inventory
Version: 1.4.2
by: TaxTalis [More]
YOU ARE USING THIS ADDON AT YOUR OWN RISK!
I will not be hold responsible for any damage or inconvenience this addon might cause for any reason.
This said, I have tested this addon on my main account for quite some time and try to do everything I can to make your experience with this addon as good and as safe as possible.

The main documentation is located at the addon's folder, there are all possible terms and functions for rules noted and it is quite impossible to go without it.
I admit, this is not an addon for everyone. There is no interface defining the rules for you by clicking buttons, you have to insert them by text.
A wrongly defined (but valid) rule may cause severe damage when fencing, destroying or deconstructing as the items will never return after such an action was taken.

Needed libraries
  • LibStub
  • LibAsync
  • LibAddonMenu-2.0
  • LibCustomMenu
Supported addons
  • FCOIS
  • CraftStore
  • AutoCategory
  • Master Merchant
  • Tamriel Trade Centre


About Rulebased Inventory
After installing it, it does nothing. It’s simple as that.
You have to define rules for different tasks which then are executed automatically.
Tasks to define rules for are:
  • Move from Backpack to Bank (starts when opening the Bank UI)
  • Move from Bank to Backpack (starts when opening the Bank UI)
  • Sell at Store and Fence (starts when opening the Store or Fence UI)
  • Launder (starts when opening the Fence UI)
  • Junk (is checked continuously (“on update”) for each item on the backpack)
  • Destroy (is checked continuously (“on update”) for each item on the backpack)
  • Deconstruct (starts when opening the deconstruct tab of an Crafting Station UI)
  • Notification (is checked continuously (“on update”) for each new item)
Currencies and Homebank are not supported. Please see features in development.



Key Features
  • take actions on specific amounts of an item, not only on a whole stack (e.g. keep only 100 lockpicks in inventory)
  • check if your current character is the first one of a defined list in need of an item for research or a recipe to learn (so you can "hand down" a recipe if your main crafter doesn't need it to your secondary and further) (CraftStore needed)
  • save profiles and load them on multiple characters
  • a notification will include pricing from MM and TTC, count of vouchers for masterwrits and the count you have in backpack, bank and craftbag
  • ...


Features and fixes in development
  • event-based deconstruct
  • event-based refine
  • Homebank
  • Guildbank
Example rules "MasterCrafter"
Bag-To-Bank (Exclude Bank-To-Bag is on)
Lua Code:
  1. NOT (JUNKED) AND NOT FCOISMARKER("LOCK") AND
  2. ((tool)
  3. or (soulgem)
  4. or (survey)
  5. or (masterwrit)
  6. or (treasuremap)
  7. or (intricate)
  8. or (recipe)
  9. or (((armor) or (weapon)) and not crafted)
  10. or ((item_enchanting) and not (crafted))
  11. or (item_jewelry))
Transfer all lockpicks (tools), soulgems, surveys, masterwrits, treasuremaps, intricate items, recipes, non-crafted equipment and glyphs and all jewelry to the bank as long as they are not marked as "Locked" via FCOIS.
Except items which would be transferred from bank to backpack!

Bank-To-Bag (Exclude off, otherwise rules are blocking themselves)
lua Code:
  1. NOT FCOISMARKER("LOCK") AND
  2. (((itemnamematch("lockpick") or ((soulgem) and (fine)) or ((tool) and level == 50)) and countbackpack < 50)
  3. or (learnlist("Caelean", "Seika Kitamura",  "Gilvalar Merohin") and ((recipe_drink) or (recipe_food)))
  4. or (learnlist("Caelean", "Seika Kitamura", "Gilvalar Merohin") and not ((recipe_drink) or (recipe_food)))
  5. or (masterwrit)
  6. or (treasuremap and itemname("XXX"))
  7. or (survey)
  8. or (item_jewelry)
  9. or (item_clothier)
  10. or (item_blacksmithing)
  11. or (item_woodworking)
  12. or (item_enchanting)
  13. )
This will transfer lockpicks and soulgems to the backpack until there are 50 of each or no more available in bank. Furthermore all types of Masterwrits, recipes this character is first of the list needing it (here: different lists for food/drink and other recipes though they list is - for now - the same), glyphs, armor, weapons and jewelry will be transferred as long as they are not marked as "Locked" via FCOIS. All these items will be excluded from the previous task as the exclude-switch there is active. This only means for example soulgems and lockpicks ABOVE 50 in backpack will be transferred to bank.

Junk
Lua Code:
  1. NOT FCOISMARKER("LOCK") AND
  2. (
  3. (trash)
  4. or (junk)
  5. or (treasure)
  6. or (ornate)
  7. or (monstertrophy)
  8. or (((potion) or (poison) or (drink) or (food)) and not ((crafted) or itemnamematch("crown", "gold")) and (cp < 150 or (normal)) and not (itemname("Essence of Health", "Essence of Stamina", "Essence of Magicka")))
  9. or ((((weapon) or (armor) or (item_enchanting)) and (cp < 150 or quality <= normal)) and not ((crafted) or (intricate) or (item_jewelry)))
  10. )
This will junk any trash, treasure, ornate items, potions (includes poisons), drinks and food which are not crafted, do not have "crown" or "gold" in their name and are below cp 150 or of normal or lower quality. Further all items of the lowest quality (named "junk") (like rotten food) and all weapon, armor and glyps which are not crafted, lower than cp 150 or lower or equal to normal quality and neither intricate nor jewelry items are junked. Again except the item is marked as with "lock" via FCOIS.

Destroy
Lua Code:
  1. (stolen) and (tool)

Will destroy all stolen lockpicks (and other stolen items of type tool, if there are any)
Needed libraries
  • LibStub
  • LibAsync
  • LibAddonMenu-2.0
  • LibCustomMenu

Cumulative change log for version 1.4.2
  • fixed usage of AutoCategory function

Cumulative change log for version 1.4.1
  • added general option for a message when starting a task
  • added support for AutoCategory
  • added function: autocategory("category1",...)
  • fixed multiple bugs which occurred on a full bag
  • fixed test of deconstruct
  • fixed test of notification not using an unsaved rule
  • fixed an issue where in bagCache the count of an item would not be updated

Cumulative change log for version 1.2.2
  • added filters for events to not listen to unnecessary ones
  • rewrite of action- and event-queue
  • rewrite of action execution
  • rewrite of bagCache and generation of actions from task
  • rewrites for integration of LibAsync to reduce runtime per frame for less lag
  • API bump for Murkmire

Cumulative change log for version 0.10.1
  • dropped library because of instability: LibLoadedAddons
  • functions fcoismarker and fcoismarkermatch now support the custom names for fcois markers
  • safe rule switch for deconstruct now has the tooltip it deserves
  • events (junk/notification/destroy) now only are accepted when items were added to the bag to reduce lag
  • fixed notification to try to notify about already again empty slots (like loot containers directly extracted by other addons)
  • optimized events (junk/notification/destroy) to only create a cache of the whole bag if necessary to further reduce lag

Cumulative change log for version 0.8.0
  • tasks are only executed if a rule was defined
  • output now shows intricate and ornate symbols
  • added itemdata: fcoisismarked (replaces fcoislocked)
  • added itemdata: fcoismarker
  • added function: fcoismarker
  • added function: fcoismarkermatch

Cumulative change log for version 0.6.1
  • fixed variables leaking into global namespace (thanks Votan!)
  • added German translation
  • added itemdata: tags
  • added function: itemtag
  • added function: itemtagmatch
  • added itemdata: reagenttraits
  • added function: reagenttrait
  • added function: reagenttraitmatch
  • minimum delay and timeout lowered

-Version 0.4.2 was initial release-
Archived Files (6)
File Name
Version
Size
Uploader
Date
1.4.1
914kB
TaxTalis
10/26/18 02:36 PM
1.2.2
911kB
TaxTalis
10/12/18 01:27 PM
0.10.1
910kB
TaxTalis
09/26/18 12:27 PM
0.8.0
911kB
TaxTalis
09/16/18 01:58 PM
0.6.1
909kB
TaxTalis
09/15/18 07:08 AM
0.4.2
903kB
TaxTalis
09/11/18 10:06 AM


Post A Reply Comment Options
Unread 11/05/18, 04:16 PM  
TaxTalis
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 55
Uploads: 1
Oh, don't worry, I merely copied it to not rewrite it on mobile (which I commented from) rather than pointing out you should have known that already!
Please be very patient for the next update, the next few month might be tough and I do not know when I will have time to spare to code again. Game will be first before addon for now, so I don't loose the fun in this.

Originally Posted by SlippyCheeze
Originally Posted by TaxTalis
Originally Posted by SlippyCheeze
I don't seem to be able to auto-sell anything that has an FCOIS ItemSaver mark on it at a regular merchant.

When I run a test, it works as expected, and lists the items. When I visit the merchant, however, it doesn't sell them, silently. Looks like it maybe skips over them?
Stated a few messages before:
Originally Posted by TaxTalis
I have to inform about another issue I am sort of aware of regarding FCOIS: there is an option to "disable" the protection for e.g. deconstruction for a marker when at a specific station. Though I am not totally sure how this works and if this is an issue as I never used this, there might be a problem because RbI collects the information about protections without checking for a station dependency. It so might happen that an marked item even if deconstructable by hand, is not deconstrucatble via RbI. If this is the case please notify me and I will look deeper into this.
I will look into this.

In Extension: FCOIS protections are applied on lowest possible base so are not dependent on rules.
Thus if a protection for the item exist for this action it indeed is skipped.
“Station” also refers to shop.
I'm sorry that I missed the earlier statement. That sounds like the root cause of the issue.

FCOIS itself has an option to disable or enable selling things based on marks, and it also has an option to permit it in certain circumstances, which I have enabled. So, it doesn't block manual selling.

I'm not sure how that is intended to be handled with the API. Thanks for noting that, and I'll absolutely hang out and wait until it is figured out, or whatever.
Report comment to moderator  
Reply With Quote
Unread 11/02/18, 03:01 PM  
SlippyCheeze
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 234
Uploads: 1
Originally Posted by TaxTalis
Originally Posted by SlippyCheeze
I don't seem to be able to auto-sell anything that has an FCOIS ItemSaver mark on it at a regular merchant.

When I run a test, it works as expected, and lists the items. When I visit the merchant, however, it doesn't sell them, silently. Looks like it maybe skips over them?
Stated a few messages before:
Originally Posted by TaxTalis
I have to inform about another issue I am sort of aware of regarding FCOIS: there is an option to "disable" the protection for e.g. deconstruction for a marker when at a specific station. Though I am not totally sure how this works and if this is an issue as I never used this, there might be a problem because RbI collects the information about protections without checking for a station dependency. It so might happen that an marked item even if deconstructable by hand, is not deconstrucatble via RbI. If this is the case please notify me and I will look deeper into this.
I will look into this.

In Extension: FCOIS protections are applied on lowest possible base so are not dependent on rules.
Thus if a protection for the item exist for this action it indeed is skipped.
“Station” also refers to shop.
I'm sorry that I missed the earlier statement. That sounds like the root cause of the issue.

FCOIS itself has an option to disable or enable selling things based on marks, and it also has an option to permit it in certain circumstances, which I have enabled. So, it doesn't block manual selling.

I'm not sure how that is intended to be handled with the API. Thanks for noting that, and I'll absolutely hang out and wait until it is figured out, or whatever.
Report comment to moderator  
Reply With Quote
Unread 11/02/18, 04:51 AM  
TaxTalis
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 55
Uploads: 1
Originally Posted by SlippyCheeze
I don't seem to be able to auto-sell anything that has an FCOIS ItemSaver mark on it at a regular merchant.

When I run a test, it works as expected, and lists the items. When I visit the merchant, however, it doesn't sell them, silently. Looks like it maybe skips over them?
Stated a few messages before:
Originally Posted by TaxTalis
I have to inform about another issue I am sort of aware of regarding FCOIS: there is an option to "disable" the protection for e.g. deconstruction for a marker when at a specific station. Though I am not totally sure how this works and if this is an issue as I never used this, there might be a problem because RbI collects the information about protections without checking for a station dependency. It so might happen that an marked item even if deconstructable by hand, is not deconstrucatble via RbI. If this is the case please notify me and I will look deeper into this.
I will look into this.

In Extension: FCOIS protections are applied on lowest possible base so are not dependent on rules.
Thus if a protection for the item exist for this action it indeed is skipped.
“Station” also refers to shop.
Last edited by TaxTalis : 11/02/18 at 04:55 AM.
Report comment to moderator  
Reply With Quote
Unread 11/01/18, 07:48 PM  
SlippyCheeze
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 234
Uploads: 1
I don't seem to be able to auto-sell anything that has an FCOIS ItemSaver mark on it at a regular merchant.

When I run a test, it works as expected, and lists the items. When I visit the merchant, however, it doesn't sell them, silently. Looks like it maybe skips over them?
Report comment to moderator  
Reply With Quote
Unread 10/29/18, 05:37 AM  
TaxTalis
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 55
Uploads: 1
Could just look in code, there is an error, but this doesn’t break it but only call it more often then necessary.
But a -feature- I use might cause destroy to not destroy a whole stack: to be more sure a slot did not move or a different item was put there in between actions, only event-actions may do an actual destroy. This works for threshold if the stack needed to be split, as then there will be an event. But if there just needs to be a whole stack to be destroyed then the addon can’t get it done as there was no event, only a task. I will see how to solve this, but will not test or code anything during this events as I want to have some playtime for now and destroy is a delicate thing and needs massive testing.

Originally Posted by SlippyCheeze
Originally Posted by TaxTalis
I am not sure if I understand. If threshold is enabled the whole bag is checked on ... well... every occasion an bagupdate is coming in. So what is missing for you? Or did this functionality break with the major update to 1.x.x?

Originally Posted by SlippyCheeze
wishlist: apply the "destruction" rule first to the new item, and then repeatedly to everything in inventory, until we are below the threshold.

right now, if I pick up a non-destruction item while my inventory is full enough, it simply fills.
Oh. Uh, huh. I'm not sure. It seemed only to destroy the item that was just collected. Perhaps I was confused.
Last edited by TaxTalis : 10/29/18 at 05:52 AM.
Report comment to moderator  
Reply With Quote
Unread 10/28/18, 11:12 AM  
SlippyCheeze
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 234
Uploads: 1
Originally Posted by TaxTalis
I am not sure if I understand. If threshold is enabled the whole bag is checked on ... well... every occasion an bagupdate is coming in. So what is missing for you? Or did this functionality break with the major update to 1.x.x?

Originally Posted by SlippyCheeze
wishlist: apply the "destruction" rule first to the new item, and then repeatedly to everything in inventory, until we are below the threshold.

right now, if I pick up a non-destruction item while my inventory is full enough, it simply fills.
Oh. Uh, huh. I'm not sure. It seemed only to destroy the item that was just collected. Perhaps I was confused.
Report comment to moderator  
Reply With Quote
Unread 10/28/18, 10:06 AM  
TaxTalis
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 55
Uploads: 1
I am not sure if I understand. If threshold is enabled the whole bag is checked on ... well... every occasion an bagupdate is coming in. So what is missing for you? Or did this functionality break with the major update to 1.x.x?

Originally Posted by SlippyCheeze
wishlist: apply the "destruction" rule first to the new item, and then repeatedly to everything in inventory, until we are below the threshold.

right now, if I pick up a non-destruction item while my inventory is full enough, it simply fills.
Last edited by TaxTalis : 10/28/18 at 11:04 AM.
Report comment to moderator  
Reply With Quote
Unread 10/28/18, 09:13 AM  
SlippyCheeze
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 234
Uploads: 1
wishlist: apply the "destruction" rule first to the new item, and then repeatedly to everything in inventory, until we are below the threshold.

right now, if I pick up a non-destruction item while my inventory is full enough, it simply fills.
Report comment to moderator  
Reply With Quote
Unread 10/27/18, 01:19 PM  
TaxTalis
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 55
Uploads: 1
Ok, I will investigate this, thanks!

Originally Posted by Chivana
It lags for a few seconds, when I get an item (loot or mail) and MM is loaded - even when there is no rule at all.

Code:
                ["userSettings"] = 
                {
                    ["BankToBag"] = 
                    {
                        ["excludeOtherRule"] = false,
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["timeout"] = 1000,
                        ["output"] = true,
                        ["delay"] = 300,
                    },
                    ["General"] = 
                    {
                        ["profile"] = "",
                        ["summary"] = false,
                        ["useFCOIS"] = false,
                        ["contextMenu"] = false,
                        ["printCompiledRule"] = false,
                        ["output"] = true,
                        ["taskStartMessage"] = true,
                    },
                    ["Deconstruct"] = 
                    {
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["delay"] = 1500,
                        ["timeout"] = 400,
                        ["output"] = true,
                        ["safeRule"] = true,
                    },
                    ["UnJunk"] = 
                    {
                        ["delay"] = 200,
                        ["output"] = false,
                        ["summary"] = false,
                        ["timeout"] = 0,
                    },
                    ["Destroy"] = 
                    {
                        ["delay"] = 300,
                        ["safeRule"] = true,
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["timeout"] = 100,
                        ["treshold"] = true,
                        ["output"] = true,
                        ["thresholdcount"] = 5,
                    },
                    ["Sell"] = 
                    {
                        ["summary"] = true,
                        ["rulestring"] = "",
                        ["delay"] = 300,
                        ["timeout"] = 100,
                        ["output"] = true,
                        ["safeRule"] = true,
                    },
                    ["Notify"] = 
                    {
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["timeout"] = 0,
                        ["output"] = true,
                        ["delay"] = 0,
                    },
                    ["Launder"] = 
                    {
                        ["summary"] = true,
                        ["rulestring"] = "",
                        ["delay"] = 300,
                        ["timeout"] = 100,
                        ["output"] = true,
                        ["safeRule"] = false,
                    },
                    ["Junk"] = 
                    {
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["timeout"] = 0,
                        ["output"] = true,
                        ["delay"] = 300,
                    },
                    ["BagToBank"] = 
                    {
                        ["excludeOtherRule"] = false,
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["timeout"] = 1000,
                        ["output"] = true,
                        ["delay"] = 300,
                    },
                },
                ["version"] = 1,
                ["$LastCharacterName"] = "Chivana",
Report comment to moderator  
Reply With Quote
Unread 10/27/18, 07:34 AM  
Chivana

Forum posts: 0
File comments: 20
Uploads: 0
It lags for a few seconds, when I get an item (loot or mail) and MM is loaded - even when there is no rule at all.

Code:
                ["userSettings"] = 
                {
                    ["BankToBag"] = 
                    {
                        ["excludeOtherRule"] = false,
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["timeout"] = 1000,
                        ["output"] = true,
                        ["delay"] = 300,
                    },
                    ["General"] = 
                    {
                        ["profile"] = "",
                        ["summary"] = false,
                        ["useFCOIS"] = false,
                        ["contextMenu"] = false,
                        ["printCompiledRule"] = false,
                        ["output"] = true,
                        ["taskStartMessage"] = true,
                    },
                    ["Deconstruct"] = 
                    {
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["delay"] = 1500,
                        ["timeout"] = 400,
                        ["output"] = true,
                        ["safeRule"] = true,
                    },
                    ["UnJunk"] = 
                    {
                        ["delay"] = 200,
                        ["output"] = false,
                        ["summary"] = false,
                        ["timeout"] = 0,
                    },
                    ["Destroy"] = 
                    {
                        ["delay"] = 300,
                        ["safeRule"] = true,
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["timeout"] = 100,
                        ["treshold"] = true,
                        ["output"] = true,
                        ["thresholdcount"] = 5,
                    },
                    ["Sell"] = 
                    {
                        ["summary"] = true,
                        ["rulestring"] = "",
                        ["delay"] = 300,
                        ["timeout"] = 100,
                        ["output"] = true,
                        ["safeRule"] = true,
                    },
                    ["Notify"] = 
                    {
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["timeout"] = 0,
                        ["output"] = true,
                        ["delay"] = 0,
                    },
                    ["Launder"] = 
                    {
                        ["summary"] = true,
                        ["rulestring"] = "",
                        ["delay"] = 300,
                        ["timeout"] = 100,
                        ["output"] = true,
                        ["safeRule"] = false,
                    },
                    ["Junk"] = 
                    {
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["timeout"] = 0,
                        ["output"] = true,
                        ["delay"] = 300,
                    },
                    ["BagToBank"] = 
                    {
                        ["excludeOtherRule"] = false,
                        ["summary"] = false,
                        ["rulestring"] = "",
                        ["timeout"] = 1000,
                        ["output"] = true,
                        ["delay"] = 300,
                    },
                },
                ["version"] = 1,
                ["$LastCharacterName"] = "Chivana",
Report comment to moderator  
Reply With Quote
Unread 10/27/18, 02:04 AM  
TaxTalis
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 55
Uploads: 1
Re: Not solved

The addon is not fully optimized simply because I am doing this in my free time, just for fun, and haven't found time to write a complete parser to check on what data to collect and which don't. That's why I am always collecting all the data. You are totally right, that would be a good way.
But for now, because one could put a rule in notify messaging about an item worth above 10k for example, MM is consulted. And again yes, this seems to be a problem for machines slower than for example my own. Hardware may compensate "bad programming" as you call it. I still would refer to it as "it was a way to save some time to still play ESO". I understand your frustration, no one likes to have lag, but I can't provide a fix for that now. I am still working on optimizations though, please be patient. Thank you.


Wait, maybe we are talking about different things here.
Do you have no rule defined for neither Destroy, Junk nor Notify?
Because if no rules for neither are defined no action is executed on loot and thus no data for the bagCache is collected.

Originally Posted by Chivana
Thank you for the start message!

Lag on loot ist still there though. I am really gratefull for this addon, because it helps me to easily store items in my mules. But honestly... Why the hell is RbI checking MM prices on loot when only Bag-To-Bank is defined? RbI should check the rules and don't do anything further if there is no rule concerning fresh loot. And this is not about slow machine, it's bad programming, simple as that.

Originally Posted by TaxTalis
MM lags at initialization at my client too.
When I recall yes, executing an task while MM still initializes does increase this lag. Still, that’s the only occurrence I am aware of at my client. A wilde guess is MM too is using async and they somehow interfere or the load in a frame then just gets to high as there are two addons trying async calls.
RbI still retrieves values from MM on loot to check for pricing, so sure with MM disabled it would not be able to and when enabled MM too needs to run code to determine the pricing for an item just looted because RbI requests this.
Thanks for testing I’ll look into this.

Originally Posted by Chivana
I disabled all other addons and then re-enabled them one by one: No lag at all - until I enabled Master Merchant.
MM and RbI together = lag on loot, even with all other addons disabled.
MM or RbI alone = no problem.
MM also stutters a bit while initializing though. I wonder what it's doing on loot...
So the lag I encounter might be caused by MM, but it happens only when RbI is enabled.
Last edited by TaxTalis : 10/27/18 at 02:39 AM.
Report comment to moderator  
Reply With Quote
Unread 10/27/18, 01:32 AM  
Chivana

Forum posts: 0
File comments: 20
Uploads: 0
Not solved

Thank you for the start message!

Lag on loot ist still there though. I am really gratefull for this addon, because it helps me to easily store items in my mules. But honestly... Why the hell is RbI checking MM prices on loot when only Bag-To-Bank is defined? RbI should check the rules and don't do anything further if there is no rule concerning fresh loot. And this is not about slow machine, it's bad programming, simple as that.

Originally Posted by TaxTalis
MM lags at initialization at my client too.
When I recall yes, executing an task while MM still initializes does increase this lag. Still, that’s the only occurrence I am aware of at my client. A wilde guess is MM too is using async and they somehow interfere or the load in a frame then just gets to high as there are two addons trying async calls.
RbI still retrieves values from MM on loot to check for pricing, so sure with MM disabled it would not be able to and when enabled MM too needs to run code to determine the pricing for an item just looted because RbI requests this.
Thanks for testing I’ll look into this.

Originally Posted by Chivana
I disabled all other addons and then re-enabled them one by one: No lag at all - until I enabled Master Merchant.
MM and RbI together = lag on loot, even with all other addons disabled.
MM or RbI alone = no problem.
MM also stutters a bit while initializing though. I wonder what it's doing on loot...
So the lag I encounter might be caused by MM, but it happens only when RbI is enabled.
Last edited by Chivana : 10/27/18 at 01:37 AM.
Report comment to moderator  
Reply With Quote
Unread 10/27/18, 01:21 AM  
TaxTalis
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 55
Uploads: 1
There are some CurrencyManagers out there, this will not be part of RbI, sorry.

And for me, notify does message me about new things getting into CraftBag, just checked when doing the daily writs. The received Rosin was detected correctly even when it went straight to CraftBag. Please check again, maybe it was just a one-time event miss?

Originally Posted by SlippyCheeze
Wishlist, I know, but it'd be great to have currency handling in this.

Also, it looks like at least notify doesn't report things going into the ESO+ crafting bag. Didn't test others.
Last edited by TaxTalis : 10/27/18 at 01:22 AM.
Report comment to moderator  
Reply With Quote
Unread 10/26/18, 05:35 PM  
SlippyCheeze
AddOn Author - Click to view AddOns

Forum posts: 52
File comments: 234
Uploads: 1
Wishlist, I know, but it'd be great to have currency handling in this.

Also, it looks like at least notify doesn't report things going into the ESO+ crafting bag. Didn't test others.
Report comment to moderator  
Reply With Quote
Unread 10/26/18, 12:29 AM  
TaxTalis
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 55
Uploads: 1
Re: Re: Re: Re: fcoismarker in 1.2.2 and (intricate)

In terms of raw execution time (when items are moved and so on) the new version really is slower.
This is due to a more even spread of computation across frames which I hoped would reduce lag on slower machines, which in combination with MM sadly is not the case.
The old version calculated all actions before execution, the new version calculates this on the go, thus checking slots which are not to move in between two slots which are to move looks like a huge delay between these both.

Originally Posted by anachronicPanda
Originally Posted by TaxTalis
Please enable the RbI context menu entry and use it on an item having the marker you want to use. Then in the printed text in chat look for the list of fcoismarker and check if the names appear and if they are written correctly. With this you can also determine the name for the default construction marker, if it was applied to the item you hit the context menu switch for.
I use the dynamic marker 1 for writ items and called it "Writ", this works finde for me and your rule seems to be fine as well.
Ok I will update to latest version and let you know how it goes. Also thanks to the person who posted the Deconstruct code

Update: Ok, looks like it's working now, though a tad slower than the older version. Anyways I'll keep playing around with it. Thanks!
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: