Quantcast
Download
(4 Kb)
Download
Updated: 09/25/21 05:21 AM
Pictures
File Info
Compatibility:
Waking Flame (7.1.5)
Blackwood (7.0.5)
Flames of Ambition (6.3.5)
Markarth (6.2.5)
Stonethorn (6.1.5)
Greymoor (6.0.5)
Updated:09/25/21 05:21 AM
Created:04/07/21 04:24 AM
Monthly downloads:198
Total downloads:1,015
Favorites:6
MD5:
Categories:ToolTip, Utility Mods
7.1.5
Custom Item Notes
Version: 1.1
by: Alianym [More]
Welcome to Custom Item Notes!

Created after a request to add notes to items. You can view/update these with the new context menu item "Edit Note" (text is localized). This is a relatively simple implementation that I may expand if anyone has other requests/thoughts/comments on how it could be improved but my aim for this initial release was to keep it fairly simple. Usage should hopefully be pretty straightforward, (see below).

To edit (add/remove) a note from an item:
Code:
Open context menu (right-click on Keyboard+Mouse) and select "Edit Note", then SAVE to update the note.
I can add a command to remove all CINs (custom item notes) at once if the desire is there, but for now it's a 1:1 add/remove.

Each note is tied to an item ID and the notes are currently stored account-wide per megaserver.

Required Libraries:
LibCustomMenu
v1.1
  • Removed the "Notes" header in the notes display – This has the result that notes will now scale to the size of the text (re: HowellQagan)

v1.0a
  • Fixed up the implementation from v1.0 (skipped over the wiki page too quickly the first time!)

v1.0
  • Added an icon to items in the inventory with notes (thanks ziplock9000 for prompting this, and thanks to whoever did the ESOUI wiki page with a PreHook/PostHook example of just this use-case)

v0.99f
  • Fixing compatibility issues, Part 2 (Thanks OneSkyGod for helping me reproduce and isolate the issue, and Baertram for helping me apply a fix)

v0.99e
  • Fixing compatibility issues

v0.99d
  • Fixing the bug, Round 2

v0.99c
  • Recreated the tooltip on mouse-over (hopefully the initial issue is fixed this time)
  • Added some multi-language support (thanks Baertram)

v0.99b
  • Updated a terribly generic global to be less generic

v0.99a
  • Updated functionality to mimic guild/friend notes (no more /commands)
  • Any notes you've created should carry over to this new system
Archived Files (8)
File Name
Version
Size
Uploader
Date
1.0a
4kB
Alianym
07/09/21 06:53 AM
0.99f
3kB
Alianym
04/15/21 05:46 AM
0.99e
3kB
Alianym
04/10/21 10:05 PM
0.99d
3kB
Alianym
04/09/21 09:36 AM
0.99c
3kB
Alianym
04/09/21 04:39 AM
0.99b
2kB
Alianym
04/08/21 02:01 AM
0.99a
2kB
Alianym
04/07/21 08:39 PM
0.99
1kB
Alianym
04/07/21 04:24 AM


Post A Reply Comment Options
Unread 09/26/21, 11:00 AM  
HowellQagan
 
HowellQagan's Avatar

Forum posts: 9
File comments: 361
Uploads: 0
Originally Posted by Alianym
Hey there!

Glad the AddOn helps!

I'll take a look into it and see what I can do.
Thank you <3
__________________
Yep, I'm goddamn annoying.
Report comment to moderator  
Reply With Quote
Unread 09/23/21, 08:20 PM  
Alianym
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 75
Uploads: 8
Originally Posted by HowellQagan
Great addon, just what I was looking for. Thank you.

Not sure how formatting elements works in LUA but from a UX perspective I would suggest setting the size of notes with a max width value and otherwise use only as much space as necessary for the note (with a comfortable padding around the text of course). For example, the new Leyawiin Reward Coffers have the same name but different ID for wb and delve quest rewards (as they contain different things) and I just added the note "delve" and "wb" to them but it still generates the same width note as with a longer note.

Also FYI if anyone was wondering, max length for notes is 254 characters.
Hey there!

Glad the AddOn helps!

I'll take a look into it and see what I can do.
Report comment to moderator  
Reply With Quote
Unread 09/21/21, 01:35 PM  
HowellQagan
 
HowellQagan's Avatar

Forum posts: 9
File comments: 361
Uploads: 0
Great addon, just what I was looking for. Thank you.

Not sure how formatting elements works in LUA but from a UX perspective I would suggest setting the size of notes with a max width value and otherwise use only as much space as necessary for the note (with a comfortable padding around the text of course). For example, the new Leyawiin Reward Coffers have the same name but different ID for wb and delve quest rewards (as they contain different things) and I just added the note "delve" and "wb" to them but it still generates the same width note as with a longer note.

Also FYI if anyone was wondering, max length for notes is 254 characters.
__________________
Yep, I'm goddamn annoying.
Report comment to moderator  
Reply With Quote
Unread 07/09/21, 10:46 PM  
Alianym
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 75
Uploads: 8
Originally Posted by Baertram
You are welcome, that's what the Wiki is there for

But why didn't you use the SecurePostHook from the example?
Because I was too excited seeing a solution and might've just figured; "this works, I'll go with that!" Really that's on me for not reading the whole page more thoroughly, but thanks for updating the page anyway.

Fixed it up with the latest update.
Report comment to moderator  
Reply With Quote
Unread 07/09/21, 11:21 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 3716
File comments: 4530
Uploads: 68
and thanks to whoever did the ESOUI wiki page with a PreHook/PostHook example of just this use-case
You are welcome, that's what the Wiki is there for

But why didn't you use the SecurePostHook from the example?
Your code overwrites the original setup function and is basically the same, where the SecurePosthook should assure it will "append" your code to the end of the original code calls, done in ZOs secure way.

I've changed the Wiki to explain that better now so the SecurePostHook will be prefered, if working.
https://wiki.esoui.com/How_to_run_your_code_before/after_functions_(PreHook/PostHook)
Last edited by Baertram : 07/09/21 at 11:30 AM.
Report comment to moderator  
Reply With Quote
Unread 06/29/21, 06:04 AM  
Alianym
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 75
Uploads: 8
Originally Posted by ziplock9000
Please add an icon to items with notes.
Hey there,

I like the idea, so I'll put it on the To-Do list. Don't know how soon I'll get to it unfortunately though, my outside-ESO life has been... hectic to say the least recently. Which is why it took five days to reply when normally I'm checking my comments more often. :P In any event, it's a good idea so I'll look into it.
Report comment to moderator  
Reply With Quote
Unread 06/24/21, 06:53 AM  
ziplock9000

Forum posts: 0
File comments: 19
Uploads: 0
Please add an icon to items with notes.
Report comment to moderator  
Reply With Quote
Unread 04/11/21, 04:48 AM  
crysis992

Forum posts: 2
File comments: 53
Uploads: 0
The latest version fixed the keybind issues, thank you
Report comment to moderator  
Reply With Quote
Unread 04/10/21, 10:53 PM  
Alianym
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 75
Uploads: 8
Alright, let's see how this latest upload goes. It fixed it on my end (thanks for the detail on conflicting AddOns – helped me narrow down the issue (I hope)). As ever, let me know if any errors come up still.

Working on a fix for the issue you're coming across, ksorah. I think I've got it, just want to see about one last test.
Last edited by Alianym : 04/11/21 at 01:47 AM.
Report comment to moderator  
Reply With Quote
Unread 04/10/21, 03:29 PM  
crysis992

Forum posts: 2
File comments: 53
Uploads: 0
Another note, it's not just opening the event boxes, it happens on every item. I can't even use buff food or learn recipes/motifs via the keybind

Edit:
As soon as I enable any addon that adds a entry on the right click menu, it stops working.
When I disable Tamriel Trade Centre, Arkadius Trade Tools and PersonalAssistant it works.
As soon as I enable any of the addons that add something to the context menu, it breaks the hotkey.
Last edited by crysis992 : 04/10/21 at 03:34 PM.
Report comment to moderator  
Reply With Quote
Unread 04/10/21, 11:27 AM  
Alianym
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 75
Uploads: 8
Originally Posted by crysis992
No, doesn't happen with only these two installed.
But as soon as I enable my other addons and your addon it stops working.
Once I disable your addon but leave all other addons enabled it works fine.

I've just enabled PersonalAssistant and your addon, it stopped working. Once i disabled your addon it worked fine to open containers in my inventory.

It must be something in your addon that breaks this :/
Thank you for narrowing down the conflict for me! Much appreciated and should definitely help with debugging. I can't take a look right now, but will definitely investigate later today.
Report comment to moderator  
Reply With Quote
Unread 04/10/21, 11:01 AM  
crysis992

Forum posts: 2
File comments: 53
Uploads: 0
Originally Posted by Alianym
I have no idea how this would be my AddOn causing it, the only option I can think of is if it's some weird conflict but still that function doesn't even get a mention in my code. Have you tried to see if the bug happens when you have only Custom Item Notes and LibCustomMenu installed?
No, doesn't happen with only these two installed.
But as soon as I enable my other addons and your addon it stops working.
Once I disable your addon but leave all other addons enabled it works fine.

I've just enabled PersonalAssistant and your addon, it stopped working. Once i disabled your addon it worked fine to open containers in my inventory.

It must be something in your addon that breaks this :/
Report comment to moderator  
Reply With Quote
Unread 04/10/21, 09:50 AM  
Alianym
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 75
Uploads: 8
Originally Posted by crysis992
I'm still unable to open containers with this addon enabled. Getting following error when trying to open a container with the keybind.

Code:
EsoUI/Ingame/Inventory/InventorySlot.lua:1110: function expected instead of nil
stack traceback:
EsoUI/Ingame/Inventory/InventorySlot.lua:1110: in function 'TryUseItem'
EsoUI/Ingame/Inventory/InventorySlot.lua:1344: in function 'INDEX_ACTION_CALLBACK'
EsoUI/Ingame/Inventory/InventorySlotActions.lua:96: in function 'ZO_InventorySlotActions:DoPrimaryAction'
EsoUI/Ingame/Inventory/ItemSlotActionController.lua:30: in function 'callback'
EsoUI/Libraries/ZO_KeybindStrip/ZO_KeybindStrip.lua:679: in function 'ZO_KeybindStrip:TryHandlingKeybindDown'
(tail call): ?
(tail call): ?
Hey there,

Thanks for the error message, but it's kind of weird because at InventorySlot.lua:1110 is:
Code:
1105    local function TryUseItem(inventorySlot)
1106        local bag, index = ZO_Inventory_GetBagAndIndex(inventorySlot)
1107        local usable, onlyFromActionSlot = IsItemUsable(bag, index)
1108        if usable and not onlyFromActionSlot then
1109            ClearCursor()
1110            UseItem(bag, index)
1111            return true
1112        end
1112    end
And that's a base ZOS function I don't even touch, (and would definitely risk breaking things if I did).
Code:
UseItem *protected* (*[Bag|#Bag]* _bagId_, *integer* _slotIndex_)
I have no idea how this would be my AddOn causing it, the only option I can think of is if it's some weird conflict but still that function doesn't even get a mention in my code. Have you tried to see if the bug happens when you have only Custom Item Notes and LibCustomMenu installed?
Report comment to moderator  
Reply With Quote
Unread 04/10/21, 08:36 AM  
crysis992

Forum posts: 2
File comments: 53
Uploads: 0
I'm still unable to open containers with this addon enabled. Getting following error when trying to open a container with the keybind.

Code:
EsoUI/Ingame/Inventory/InventorySlot.lua:1110: function expected instead of nil
stack traceback:
EsoUI/Ingame/Inventory/InventorySlot.lua:1110: in function 'TryUseItem'
EsoUI/Ingame/Inventory/InventorySlot.lua:1344: in function 'INDEX_ACTION_CALLBACK'
EsoUI/Ingame/Inventory/InventorySlotActions.lua:96: in function 'ZO_InventorySlotActions:DoPrimaryAction'
EsoUI/Ingame/Inventory/ItemSlotActionController.lua:30: in function 'callback'
EsoUI/Libraries/ZO_KeybindStrip/ZO_KeybindStrip.lua:679: in function 'ZO_KeybindStrip:TryHandlingKeybindDown'
(tail call): ?
(tail call): ?
Report comment to moderator  
Reply With Quote
Unread 04/09/21, 10:13 AM  
Alianym
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 75
Uploads: 8
Originally Posted by Baertram
Never happens to me /irony off
The life of an AddOn author!

Originally Posted by Baertram
Could also be the side effect of other addons!
I'd always ask the error reporters to proof it throws the error with ONLY this addon + needed libs enabled as well, else it's there work to check what other of theire addons enabled casues this in combination (as you cannot know these addons + have them installed + got the same settings like the reporter does).

Sounds harsh but simply is the way to be able to rebuild and find a fix. We all learned this in several field tries

About the invSlot: Weird. They should have the same structure.
Happy to be corrected about invSlot, but that’s definitely how it looked to me, even in the ESOUI source.

Yeah I was thinking about that just afterwards.

So questions for users encountering bugs;
  • how long until the error showed up?
  • did it error on your first container?
  • keyboard + mouse or Gamepad?
  • did you try with only Custom Item Notes and LibCustomMenu active?
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: