| Results: 213Comments by: merlight |
| File: LibMsgWin07/31/15 |
 As per request ;)
## ReverseDepend...
Posted By: merlight
As per request ;)
## ReverseDependsOn: merUndefinedGlobalsCatcher
|
| File: Mer Band-Aid ZO-UI Fixes07/31/15 |
|
can you made it compatible/displaye...
Posted By: merlight
can you made it compatible/displayed at minimap addons too? or it must be done on the other side (Fyrakin minimap), that still displaying wrong coordinates
That would have to be done in the minimap add-on, as it needs to shift the map coordinates as well. My fix only shifts pins (player arrow, dungeon exit, etc.).
|
| File: Mer Band-Aid ZO-UI Fixes07/31/15 |
|
Yea I know, I had to put on a helme...
Posted By: merlight
Yea I know, I had to put on a helmet as I was hitting walls all the time while measuring it :( But no, coords were enough, let ZOS fix the map itself. Actually I'm fine maps not being perfect. Especially maps of underground rogue areas that the authorities would like to earth up.
|
| File: Mer Torchbug07/29/15 |
|
Sorry, not my call. I only work on...
Posted By: merlight
Sorry, not my call. I only work on add-ons I use, or have other special interest in. MM is out of that scope.
|
| File: Mer Torchbug07/29/15 |
|
it will be very nice if you pointin...
Posted By: merlight
it will be very nice if you pointing me out how with this addon delete choose item's date from Master Merchants database
right now i need to edit saved variables by hands =(
I already told you in Zgoo comments that I don't use MM. And if you can't delete it with Zgoo or the trick Garkin posted there, you won't be able to delete...
|
| File: Auto Mail Return (Mailbox Daemon)07/22/15 |
|
Re: Re: Re: Re: Unable to open the first mail at top of the list
Posted By: merlight
Still looking at why exactly, but I think its timing related which would explain why it only happens sometimes :confused:.
Will update with more info or a fix when I have something :)
I had the same problem a year+ ago when writing an add-on that scanned mailbox for specific messages. IIRC it had something to do with either req...
|
| File: LibFilters-2.007/17/15 |
|
If you think that cost isn't low en...
Posted By: merlight
If you think that cost isn't low enough, here's another possible optimization without changing the API.
Just tried the previous timing with 260k calls - was about 500-700ms. With this once-per-frame optimization, it's around 80-120ms! That's 0.5us per call... not much to be gained by the added parameter. Well unless I'm timing it...
|
| File: LibFilters-2.007/17/15 |
|
So I was curious how costly Request...
Posted By: merlight
So I was curious how costly RequestInventoryUpdate actually is. For me 13000 calls took between 27 to 63 milliseconds.
code used for timing
local fakeFilters = {}
local filterTypeToUpdaterName = {
= "BACKPACK",
= "BANK",
= "GUILD_BANK",
= "BACKPACK",
= "DECONSTRUCTION",
= "BACKPACK",
= "...
|
| File: Advanced Filters07/17/15 |
|
I do understand the need for the Re...
Posted By: merlight
I do understand the need for the RequestInventoryUpdate, IMO I think the two functionalities should just be separated completely, registering/unregistering a filter should have nothing to do with updates. Addons should be forced to call a RequestInventoryUpdate anytime they want an update, it should be up to them to track that. But I...
|
| File: Advanced Filters07/17/15 |
|
Re: Re: Re: Advanced Filters and FCO Item Server - Error
Posted By: merlight
Could this change may slow down the character login time or is it just my feeling that it takes a little bit longer?
It's probably just your feeling :) Technically it depends on the (essentially random) order in which ESO loads these, but it's loading 200 thousand lines of Lua code on startup, and libFilters.lua is only 300 lines,...
|
| File: Advanced Filters07/17/15 |
|
Re: Advanced Filters and FCO Item Server - Error
Posted By: merlight
After updating Advanced Filters to v0.8.1.2 i get this error message for FCO item Saver:
I suspect strange inter-actions between the addons Advanced Filters and FCO Item Saver. Please check & help!
Try opening AddOns/AdvancedFilters/lib/libFilters/libFilters.lua in a text editor and changing the first line to:
local MAJO...
|
| File: Advanced Filters07/17/15 |
|
I did leave in the deferred update....
Posted By: merlight
I did leave in the deferred update. It is still delayed in case multiple addons call for an update. I just altered the AF code so that it does not even request updates that aren't even necessary.
Oh, sorry, I should've read the code before assuming that by forced you mean immediate :D So it basically combines 2) with 1) from my earl...
|
| File: LibFilters-2.007/17/15 |
|
libFilters:RequestInventoryUpdate s...
Posted By: merlight
libFilters:RequestInventoryUpdate should be re-exposed. http://www.esoui.com/downloads/info630-FCOItemSaver.html#comments is using it.
Now I finally remembered why it's really good having it exposed. You can register a filter once, but have the filter function check some toggles that by themselves don't need to re-register the fil...
|
| File: Advanced Filters07/16/15 |
|
edit: the new version of AF should...
Posted By: merlight
edit: the new version of AF should only be registering for the filterType currently in use via libFilters:GetCurrentLAF(inventoryType) so a filter change would produce 6 registration changes rather than a bunch
Isn't that how it was originally was? :D
Btw, I don't have a use case, but back then I though exposing RequestInventoryU...
|
| File: Advanced Filters07/16/15 |
|
Thats why i would expect zo_callLa...
Posted By: merlight
Thats why i would expect zo_callLater (blablafunc, 0) and blablafunc() behave exactly the same but they don't.
blablafunc is actually delayed with a callLater of 0 ms. So i wonder if it's next frame + ms timer instead of just the ms timer or if it's something else (like waiting that all the other stuff running is over)
I wouldn'...
|
| File: Advanced Filters07/16/15 |
|
15ms is close enough and is a nice...
Posted By: merlight
15ms is close enough and is a nice "divisible by 5" which gives me warmer fuzzies than 17ms, which is prime and... ick.
Whaaat?! :eek: Prime numbers are cooool! :cool: Except seventeen. I hate seventeen. :mad:
edit: I suggested 10ms because that's the default minimum frame time set in UserSettings.txt
|
| File: Mer Character Sheet07/16/15 |
|
Is your research timer list showing...
Posted By: merlight
Is your research timer list showing the research timers of the current character or is it showing ALL charcter's research timers (or is it cappable to show all characters)?
Added a toggle (at the right edge of the RESEARCH header) to show all characters' research. You will have to log each one so that the add-on can scan and sav...
|
| File: Advanced Filters07/16/15 |
|
Do you think there is something bet...
Posted By: merlight
Do you think there is something better that can be done in libFilters? Or is this just something to live with (the ZOS hackery with faking things and whatnot)?
IIRC when I wrote that RequestInventoryUpdate function, I was pondering these options:
1) Anticipate that there might be more update requests in rapid succession, and simp...
|
| File: Advanced Filters07/15/15 |
|
Maybe when it attempts the "PickupI...
Posted By: merlight
Maybe when it attempts the "PickupInventoryItem" the
PLAYER_INVENTORY:UpdateList(INVENTORY_BACKPACK)
which was called by your code is still running and somehow triggers the error.
It can't "still be running", it all happens in one thread. But otherwise you're right. I tried increasing the delay to ridiculous 2000ms, and here's w...
|
| File: LibAddonMenu-2.007/04/15 |
|
Hey merlight, thanks for the sugges...
Posted By: merlight
Hey merlight, thanks for the suggestion. I think I follow you, but I'm not sure. Could I get a more complete minimum working example?
I forgot about the "OnEffectivelyShown" hook... I was trying to use "OnShow" but that is reserved for LAM itself so it breaks the menu.
OnShow is not what you want to handle anyway, because it only...
|
| File: LibAddonMenu-2.007/04/15 |
|
Perhaps there is already an easy wa...
Posted By: merlight
Perhaps there is already an easy way to achieve what I want to do, but it is not documented and the solution I have developed is pretty clumsy. Please let me know if you have any questions or feedback.
You can simply set a handler (or ZO_PreHookHandler to be future-proof) on your panel control for OnEffectivelyShown / OnEffectivel...
|
| File: FCO ItemSaver07/01/15 |
|
Is this always not working for you?...
Posted By: merlight
Is this always not working for you? Maybe it depends on the settings then somehow.
Sorry, was totally my fault. I had this add-on installed since when we were debugging filters, and recently "updated" from that ancient version by just replacing existing files. Which means all new files were missing :o
Now it works as advertis...
|
| File: FCO ItemSaver06/29/15 |
|
Does the confirmation dialog before...
Posted By: merlight
Does the confirmation dialog before equipping a BoE item work for you? I've just tried equipping a new ring I got and nothing happened (edit: no dialog appears and the ring stays in my bag). Dragging to the equipment slot / hitting 'E' / choosing 'Equip' from the context menu... no response at all. There's no error message. Not even...
|
| File: Sous Chef - Provisioning Helper (Recipe helper/search)06/26/15 |
|
For VR1+ food recipes, SousChef sho...
Posted By: merlight
For VR1+ food recipes, SousChef shows "Creates a Level 50 ..." in tooltip. I changed that to show veteran rank with the ugly V icon used e.g. in material tooltips; and also changed text color so only the level/rank is white. Here're my diffs:
SousChef/Common.lua:
diff -ru autoupdate/unpacked/SousChef/Common.lua modified/SousChe...
|
| File: Mer Quickslot Filters06/10/15 |
|
thanks for great addon! one thing...
Posted By: merlight
thanks for great addon! one thing
can you disable displaying quick slot items in quick slot menu if this items belonged to junk tab?:o
will be nice
I currently don't play nor work on addons. Try adding a check to function qsShouldAddItemToList, hope it works:
local function qsShouldAddItemToList(self, itemData)
if not zo...
|
AddOn Sites
© 2014 - 2022 MMOUI