ESOUI - [fixed] Achievements Points Count Bug

ESOUI (https://www.esoui.com/forums/index.php)

- Bug Reports (https://www.esoui.com/forums/forumdisplay.php?f=187)

- - [fixed] Achievements Points Count Bug (https://www.esoui.com/forums/showthread.php?t=7272)

[fixed] Achievements Points Count Bug

Hi @Chip,

I found a prio 1 bug :D
The achievements sub-category progress-bar of "General" does not show the sub-category points, but the summary points.

As you can see, the sub-category progress-bar should be at zero.

And this should correct it:

Lua Code:

do
    local orgGetCategoryInfoFromData = ACHIEVEMENTS.GetCategoryInfoFromData
    function ACHIEVEMENTS.GetCategoryInfoFromData(self, data, parentData)
        if not data.isFakedSubcategory and parentData then
            return orgGetCategoryInfoFromData(self, data, parentData)
        else
            local numSubCategories, numAchievements, earnedPoints, totalPoints, hidesPoints = select(2, self:GetCategoryInfo(data.categoryIndex))
            if parentData then
                for index = 1, numSubCategories do
                    local subEarned, subTotal = select(3, self:GetSubCategoryInfo(parentData.categoryIndex, index))
                    earnedPoints, totalPoints = earnedPoints - subEarned, totalPoints - subTotal
                end
            end
            return numAchievements, earnedPoints, totalPoints, hidesPoints
        end
    end
end

Hmm, is there more to this? When switching between categories my progress bar is updating correctly.

All this of course without any addon:

As you can see the progress bar of the PvP summary is the same as the progressbar of PvP General.
But the PvP General progressbar is expected to be zero, because the only 80 points shown in the summary belong to Alliance War.

Whatever.

It is such a small issue nobody realized since ... ever. At least this was what I wanted to say with "prio 1 bug" with a smiley. If you did not understand it that way: Excuse me.:(

Looks like we were able to reproduce it.

Quote:

Originally Posted by ZOS_ChipHilseberg (Post 32222)

Looks like we were able to reproduce it.

Thanks @Chip.

I already took a look into the issue and may save you time.
The problem is distributed across two source files. At the end the code for the summary and the code for the sub-category are calling the same function: self:GetCategoryInfo(categoryIndex)
To get the correct values for what you call yourself a faked sub-category=General, is to substract all real sub-category values from the summary values.
Like this:

Lua Code:

do
    local orgGetCategoryInfoFromData = ACHIEVEMENTS.GetCategoryInfoFromData
    function ACHIEVEMENTS.GetCategoryInfoFromData(self, data, parentData)
        if not data.isFakedSubcategory and parentData then
            return orgGetCategoryInfoFromData(self, data, parentData)
        else
            local numSubCategories, numAchievements, earnedPoints, totalPoints, hidesPoints = select(2, self:GetCategoryInfo(data.categoryIndex))
            if parentData then
                for index = 1, numSubCategories do
                    local subEarned, subTotal = select(3, self:GetSubCategoryInfo(parentData.categoryIndex, index))
                    earnedPoints, totalPoints = earnedPoints - subEarned, totalPoints - subTotal
                end
            end
            return numAchievements, earnedPoints, totalPoints, hidesPoints
        end
    end
end

Quote:

Originally Posted by ZOS_ChipHilseberg (Post 32263)

It has been fixed.

Awesome :banana: