[open] Search Box Bug
I have found 2 more bugs in the searchBox game code and added them to this post.
BUG 1 If you unequip an item by double clicking on it in the character window (or right clicking and selected unequip) everything works fine. But when you double click an item to equip it & you already have an item equiped in that equip slot, they just swap slots and the searchData does not get updated and still has the cached searchData for the old item. Steps to Reproduce:
Example:
Fix: It looks like you need to clear the searchData.cache & set searchData.cached to false when the slots are updated with a different item, something like: Lua Code:
BUG 2 I'm not sure when this broke, but the search box does NOT work in the guild bank. The virtual control that is inherited by all inventory search boxes comes from this control: Lua Code:
which calls: Lua Code:
But it only updates the backpack or bank. Lua Code:
Fix: It should be Lua Code:
BUG 3 In inventory.lua, when the "guildbank" scene is registered for the "StateChange" callback it Ends the search for the wrong searchBox. Which means the searchBox for the guild bank does not get cleared properly. Lua Code:
For anyone interested I have added a fix for the two new bugs I found to my SearchBox Bug Fix addon, you can find it here: SearchBox Bug Fix V3.0 |
Does this fix it for you? For me it does.
Lua Code:
|
Although the equipType would be the same since both items go in the same equip slot the itemStyles might not be the same, so that really needs to be updated also. You could just nil out the cache & set cached = false, like I did in my example above, but if you want to fix the cache instead of nilling it out the itemStyle needs to be updated as well:
Lua Code:
Nilling it out would probably be the best solution though. Whenever a search is started it checks to see if data is cached and if its not it grabs that data on its own. That way it would only have to mess with those calls to update the cache if a search is being run instead of every time they don't match in the OnSlotUpdate. |
Quote:
Nethertheless, if a small code snippet like that would fix it, it maybe something for Mer Band-Aid ZO-UI Fixes |
Quote:
Lua Code:
and thought it said: Lua Code:
|
2 MORE SearchBox Bugs
I have found 2 more bugs in the inventory searchBoxes.
I have edited the original post to reflect all three bugs (scroll up to first post to read). |
I have a question regarding bug #1 fix. You set .cached to false if .rawName doesn't match. Is that condition sufficient? I mean, I noticed the search also includes item style, e.g. "breton" finds all items in Breton style. Hopefully I can find a pair of identically named items in different styles to test. Just wanted to ask how much "wrong" it would be to clear the .cached flag unconditionally.
|
One more question: I can't find the fix to #1 in FilterIt. Has it been fixed by ZOS already?
|
Quote:
|
Quote:
(untested) Probably the easiest way I can think of to fix that would be to copy the itemInstanceId and check it instead to see if its changed: Lua Code:
|
Quote:
|
there is a ticket # 200415-001514
|
All times are GMT -6. The time now is 12:30 AM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2014 - 2022 MMOUI