ESOUI

ESOUI (https://www.esoui.com/forums/index.php)
-   Wish List (https://www.esoui.com/forums/forumdisplay.php?f=177)
-   -   [rejected] update addoncompatibilityaliases.lua (item styles) (https://www.esoui.com/forums/showthread.php?t=7585)

manavortex 01/23/18 09:21 AM

[rejected] update addoncompatibilityaliases.lua (item styles)
 
While it's great to have all those neatly in one file, a few are missing:

60 -> Clockwork
61 -> Bloodforge
62 -> Dreadhorn
63 -> Unused
64 -> Unused
65 -> Apostle
66 -> Ebonshadow


Thanks!

Ayantir 01/24/18 12:46 PM

It's working as intended

ITEM_STYLE_SOMETHING was an ItemStyle constant

Now we use styleIndex values. (the old styleItemIndex).

sirinsidiator 01/24/18 01:48 PM

Exactly. Those constants have been deprecated and should no longer be used. Adding new ones now would go against that change. Not sure what Chip will say, but I consider this request rejected. ;)

ZOS_ChipHilseberg 01/24/18 04:20 PM

I agree with what has been said here.

manavortex 01/25/18 03:06 AM

Then kill the deprecated things? :D

sirinsidiator 01/25/18 04:18 AM

That would kill old addons that have not been updated for the new system yet. But I do agree that at some point the stuff in the compatibility layer should be removed.

manavortex 01/25/18 05:19 AM

fighting the urge to re-name the thread to [open] break out-dated AddOns by purging compatibility layer now... :D


All times are GMT -6. The time now is 11:44 PM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2014 - 2022 MMOUI