Assert KeybindStrip Bug
 

I was trying to track down a bug someone posted that I thought could possibly be caused by JunkIt, but now I'm not so sure. I found this bug that I am able to reproduce every try without any addons running.






So I prehooked the AddKeybindButton to see what it was doing, which button was causing the error (which button was failing to be removed):





It changes everytime, its not always the same button. Here it looks like its trying to add a keybind for UI_SHORTCUT_TERTIARY, but it already exists:



From reports it was very random, although I did managed to figure out a way to reproduce it.
WITHOUT ANY ADDONS: I was able to reproduce this every time with the following method:


The stack traceback for the error I reproduced is not the same as the reports I saw, but I think its the same problem. There is probably just more than one way to reproduce it.
Reports:



Since I can reproduce a very similar error (just a different stack traceback) without any addons I'm guessing its the same bug in the game. Before I waste any more time looking into this I thought I'de ask, what do you think?

Tried to reproduce it, but it does not happen every time for me and it only works when I end up on equipment, does not seem to occur with crafting mats and others.
Most reliable way to get the error was when I press the inventory key and mail key in quick succession while moving the mouse between items.

I got few assertions also when switching between I > Mail and Craft > Mail also but I was not able to determine if it was me or the game itself, due to strong reworks on my addons too and my newbieness in Keybindings :(

(Happens very randomly, maybe when i'm too quick).

Yeah moving the mouse around different items that have different kebyindStrip buttons like: Use, Repair, Equip, Enchant, exc... when you open or change inventory windows makes it "try" to add/remove the buttons to fast & it seems like it can't keep up.

Tried your steps on the PTS with and without any add-ons and got the error several times, not always but often.
Still had more "luck" reproducing it my way.

OT: why the hell does this forum insist on showing embedded video when I want to post a link to youtube? :mad:

Ah, I didn't see that post. Good to know its not just me.

Another one, This happens at the bank.

2015-02-22T21:08:09.011-05:00 |cff0000Lua Error: assertion failed
stack traceback:
[C]: in function 'assert'
EsoUI/Libraries/ZO_KeybindStrip/ZO_KeybindStrip.lua:97: in function 'ZO_KeybindStrip:AddKeybindButton'
EsoUI/Libraries/ZO_KeybindStrip/ZO_KeybindStrip.lua:205: in function 'ZO_KeybindStrip:AddKeybindButtonGroup'
EsoUI/Libraries/ZO_MenuBar/ZO_SceneFragmentBar.lua:86: in function 'callback'
EsoUI/Libraries/ZO_MenuBar/ZO_MenuBar.lua:256: in function 'MenuBarButton:Release'
EsoUI/Libraries/ZO_MenuBar/ZO_MenuBar.lua:471: in function 'MenuBar:SelectDescriptor'
(tail call): ?
EsoUI/Libraries/ZO_MenuBar/ZO_SceneFragmentBar.lua:17: in function 'ZO_SceneFragmentBar:SelectFragment'
EsoUI/Ingame/Inventory/Inventory.lua:1409: in function 'callback'
EsoUI/Libraries/Utility/ZO_CallbackObject.lua:86: in function 'ZO_CallbackObject:FireCallbacks'|r

This sounds like it could be a bug in the game code. I'll take a shot a reproing it here.

It is a bug with mail. I have a fix in the works.

Are you sure it is only a mail thing?
From the other thread that merlight linked:
I just did that on the PTS and got this:

And it also sometimes happened if you used the keybinding "E" repetitively fast after another to move items from your inventory to a bank/to a guild bank, if I remember right.

Glad to hear it!

Keybind assert bugs?
 

I have seen this bug too, in other places than just the mail. It seems to be a problem with the keybindings not getting the "OnHide" commands or something like that. I ran into that problem with adding keybinds to the Keybind Strip. If, say I mouseOver the control in the guild Roster and my keybind pops up to add a name to my Address Book, If i close the roster or move to a different menu, the mouse technically doesn't "exit" the control, right? So the keybind is NOT removed. They remain until the keybind is refreshed by another menu.

The assert is triggered in cases where we're adding an action to the keybind strip when another action with that same bind already exists on there. There are a multitude of things that can lead to this situation including overlapping binds in a window, failing to remove binds on a window closing, etc. The particular instance I was able to repro involved mousing over an item in the mail send inventory after the window hiding. I was not able to repro the guild store issue.

We appreciate it!!
 

Nice job though Chip!! Thanks for the hard work!!

Here is an example of a bug I had today with Keybindings.
So okay, I should check in roomba if there is already an existing keybind, but, this bug triggered at bank, and the keybind was about a lockpicking UI i just triggered before by opening a chest.

(please note that between opening a chest and opening bank, i also opened the guildroster).

Attachment 557

If I check zgoo and descriptor , it's my 2 roomba buttons declared here, but on the UI it's the lockpick one.
And If i leave bank and speak back to the npc, the keybind remains here

PS: I was about to handle this kind of problem with


Maybe there's a better way?

What's the status of "the fix", I get this error when I am in the mail window and click "reply" to a mail, results in the ui error popping up and when dismissed leaved a blank mail screen, happens on all of them therefore I cannot reply to any mail.

it's fixed since few patchs, check your addons.

You are correct, the current issue is being caused by wykkydsMailBox.