ESOUI - Unnamed outfits have empty string as name

ESOUI (https://www.esoui.com/forums/index.php)

- Lua/XML Help (https://www.esoui.com/forums/forumdisplay.php?f=175)

- - Unnamed outfits have empty string as name (https://www.esoui.com/forums/showthread.php?t=9898)

Unnamed outfits have empty string as name

Hey there!

I'm working on my wardrobe manager mod, and any outfit that has been recently unlocked has an empty string for its name even though its label is "Outfit N." This breaks my code and prevents my LAM dropdowns from populating correctly.

I tried implementing a fix that renamed any unnamed outfits to the label (Outfit N) which got the job done, but the first time that code runs it throws the error listed below. Also below is the relevant code and a link to the project on Github.

Full code

Lua Code:

function LWM:Initialize()
    LWM.vars = ZO_SavedVars:NewCharacterIdSettings("LWMVars", LWM.variableVersion, nil, LWM.default, GetWorldName())
 
    self.inCombat = IsUnitInCombat("player")
    self.inStealth = GetUnitStealthState("player")
 
    for i=1,GetNumUnlockedOutfits() do
        name = GetOutfitName(0, i)
        -- TODO: This throws an error the first time it runs, fix it
        if name == '' then
            RenameOutfit(0, i, "Outfit " .. tostring(i))
        end
        self.allOutfits[i + OUTFIT_OFFSET] = name
    end
    ...
end

Error:

Code:

user:/AddOns/LeonardosWardrobeManager/LeonardosWardrobeManager.lua:112: attempt to index a nil value

stack traceback:

user:/AddOns/LeonardosWardrobeManager/LeonardosWardrobeManager.lua:112: in function 'LeonardosWardrobeManager.OnOutfitRenamed'

|caaaaaa<Locals> event = 131661, response = 0, index = 0 </Locals>|r

Line 112 is an end?
Please update the error message to your current github code lines so one sees where exactly it errors!

btw PLEASE do not use the constant values like 0 for the actor category BUT use the given constants!
They might change and your code should always use constants like BAG_BAGPACK instead of 1 and GAMEPLAY_ACTOR_CATEGORY_* instead of 0 or 1!
That's why constants were created :-)

Edit:
If the line here is the errror: if name == '' then

You check for name == string but name will be nil in that case you have described.
So you need to add a nil check like this:

if not name or name == '' then

or more simple
name = GetOutfitName(GAMEPLAY_ACTOR_CATGORY_PLAYER, i) or ''
the or '' will react and add an empty string if GetOutfitName returns nil

or just another notation
name = GetOutfitName(GAMEPLAY_ACTOR_CATGORY_PLAYER, i)
if not name then name = '' end

or

name = name or '' --the same as above

Thanks so much for your help, I got it all working!!

Quote:

Originally Posted by Baertram (Post 44661)