ESOUI - Update 5.3

ESOUI (https://www.esoui.com/forums/index.php)

- Tutorials & Other Helpful Info (https://www.esoui.com/forums/forumdisplay.php?f=172)

- - Update 5.3 (https://www.esoui.com/forums/showthread.php?t=8919)

sirinsidiator

01/20/20 12:00 PM

Update 5.3

1 Attachment(s)

The next update "Harrowstorm" is now available on the PTS.

New API Version: 100030 :banana:

PTS Dev Guild
We have created guilds on the EU and NA server for all addon developers, which get copied over during the PTS cycle for a new update, so we can test guild related things, ask for help with testing or just chat. If you need an invite, ask here or over on our Gitter channel. You are also free to join them on the live servers so you don't always have to be reinvited when the PTS is wiped.

Links

I'll edit the OP with more useful information as you post it and add the links as they become available.

Baertram

01/20/20 07:20 PM

Chat related

Removed function in patch 5.3.:
CHAT_SYSTEM:CreateChannelData()

New function to use: There seems to be no explizit function for this anymore.
The old function was building the self.switchLookup = {} table of the chat system which now can be done by:
self.channelData = ZO_ChatSystem_GetChannelInfo()
self.switchLookup = ZO_ChatSystem_GetChannelSwitchLookupTable()

-> File: https://github.com/esoui/esoui/blob/...m/chatdata.lua

Changed control names:
Chat tab - Old name:
ZO_ChatWindowTabTemplate1

Chat tab - New name:
GuiRootKeyboard1 ... n
Probably GuiRootGamepad1 ... n in Gamepad mode

Not sure if this was an intended change by ZOs though. Reported it to Chip.
Update: Communicated the wrong control names to ZOs and ZOs will fix this.

Context menu related
Function IsMenuVisisble (including typo) was renamed to IsMenuVisible() correctly now!

sirinsidiator

01/22/20 06:51 AM

The following entry has been added to the addon compatibility alias and may explain what's going on with the chat system:

Lua Code:

-- CHAT_SYSTEM refactor
-- Many of the internals/method calls have changed in chat system to support multiple chat systems at once.
-- This will preserve compatibility with addons that add messages to chat using CHAT_SYSTEM:AddMessage(), but more complex chat addons may need rewrites.
CHAT_SYSTEM = KEYBOARD_CHAT_SYSTEM
function CHAT_SYSTEM:AddMessage(messageText)
    return CHAT_ROUTER:AddSystemMessage(messageText)
end

Baertram

01/29/20 04:22 AM

Chat related, formatting of messages
The ZO_ChatSystem_AddEventHandler function will still register functions for the Formatters but these functions are currently not run at all.
So messages which are sent or are incoming will currently not be formatted by addons, if they are using this function.
And if you try to achieve it by other means you definately will get in trouble because you need to override stuff and other addons will fail to work properly together, so pleae do NOT do so!

There seems to be some bug in ZOs code (or this is on purpose? I don't hope so).

Shadowfen

01/29/20 10:28 PM

Chat related: LibChatMessage FYI

There does seem to be a new problem that trips up LibChatMessage in that it attempts to register an eventFormatter with the eventId "LibChatMessage". This causes an error because the eventId field is now required to be a number.

Was testing code re-initializing the registered events from the ChatEventFormatters table.

LibDebugLogger outputs:

Code:

Checking type on argument event failed in ScriptEventManagerRegisterForEventLua

|rstack traceback:

[C]: in function 'RegisterForEvent'

user:/AddOns/rChat/ZOS_Rewrite-5.3.lua:517: in function 'CHAT_ROUTER:AddEventFormatter'

    (This is simply a copy of ZO_ChatRouter:AddEventFormatter() with debug added so I can watch what is going on.)

EsoUI/Ingame/ChatSystem/ChatHandlers.lua:268: in function 'ZO_ChatSystem_AddEventHandler'

Debug outputs:

Code:

        [106] = "Bad eventId type: LibChatMessage",

        [107] = "ZO_ChatRouter:AddEventFormatter: eventCode=LibChatMessage",

        [108] = "ZO_ChatRouter:AddEventFormatter: registering OnChatEvent",

However, ensuring that this error does not occur does not help our inability to get event handlers executed.

sirinsidiator

02/24/20 09:03 AM

Regarding the addon chat formatters no longer working, I have added a workaround in LibChatMessage.
Instead of using ZO_ChatSystem_AddEventHandler you will have to add your formatter to the table returned by ZO_ChatSystem_GetEventHandlers. Then you can simply set LibChatMessage.formatRegularChat to true anywhere before EVENT_PLAYER_ACTIVATED (or inside the event handler for it) and the library will take care of the rest.
Just be aware that this will disable the new taskbar flash feature for incoming whispers while the game is not focused.

Baertram

02/24/20 05:23 PM

And beware that this will overwrite the given chosen chat handler so it will skip the other addon's handlers.

Sordrak

02/26/20 04:15 PM

Quote:

Originally Posted by Baertram (Post 40097)

I can't find anything in the API patch notes about these changes. Did you get any additional information about this anywhere (is it a bug?)?

Baertram

02/27/20 03:40 AM

No, no natch potes, just findings during tests on PTS... Seems to be a bug then.
Afaik it's not intended and ZOs was informed and is working on something.

All times are GMT -6. The time now is 06:49 PM.