ESOUI - My copyright : Provision RF & fork Provinatus

Hi,

I am here to speak of the fork "Provinatus" of Provision TeamFormation, today in this post, I only ask question without action for now.

I was agreed on beginning to add functionnality (because I don't have even system) but now I'm not because I made event system.(I was less agree for refactoring without performance gain and I never say "yes, you can" for that).

Provinatus only add "Pointer" and made "refactoring" of my code. Ok. But the functionnality can add in my Event system.

I admit that the main problem for me, it was the players download provinatus without provision TeamFormation but I want to my work reward by the number of download. It's the only reward for me, see my work liked.

06/15/18 I sent :

Quote:

Originally Posted by Provision

Quote:

Originally Posted by AlbinoPython

Quote:

Originally Posted by Provision

Is it possible to make Provinatus like mod/dependance of TeamFormation ? Not like competitor ?

I made event, it is a first try :

Code:

CALLBACK_MANAGER:FireCallbacks("TEAMFORMATION_SetHiddenCalled", bool)

CALLBACK_MANAGER:FireCallbacks("TEAMFORMATION_MakeIcon", index)

CALLBACK_MANAGER:FireCallbacks("TEAMFORMATION_UpdateIcon", index, unitTag, sameZone, isDead, isInCombat)

-- You can get element with : ProvTF.UI.Player[index]

Branch : https://github.com/GuimDev/Provision...10-fire-events

Issue #10 : https://github.com/GuimDev/Provision...ment-397659059

You code will be like that :

Code:

local function Provinatus_UpdateIcon(index, unitTag, sameZone, isDead, isInCombat)

        local name = GetUnitName(unitTag)

        local isMe = (name == GetUnitName("player"))

        if isMe then

                ProvTF.UI.Player[index].Icon:SetColor(0, 1, 0)

        end

end

 

CALLBACK_MANAGER:RegisterCallback("TEAMFORMATION_UpdateIcon", Provinatus_UpdateIcon)

Today I sent him :

Quote:

Originally Posted by Provision

Hi,

I don't understand why you want copy/paste my Addon if it is just to change arrow on the center of the screen and remove settings. It's easy to do refactoring when you have not take many time to make it of 0 but now I'm not agree with that.

I ask you to use my event system. We have two addons to do one thing. The addon which update more in month will be the more used that original, it's not normal. Make refactoring update is cheating.

Prov.