Originally Posted by haggen
Another thing that bothers me is: if you check the sort function for comparing rows in a scroll list, it accepts a flag in the sort keys options called "isNumeric" to know when to compare numeric values. But, in esoui\ingame\mail\mailinbox_shared.lua it reads "numeric" (without the prefix 'is'). I think it's misspelled but since I never took the time to look for other instances I never reported. Well, I am now. :P
|
It's probably misspelled, but in this case it also doesn't matter. ZO_TableOrderingFunction checks "isNumeric" and converts the argument tonumber; but since those two "numeric" arguments in mailbox already are numbers, "isNumeric" isn't needed there.
Originally Posted by haggen
I was reading the link you mentioned. I notice now that there are bugs everywhere around SORT_ORDER_UP and SORT_ORDER_DOWN, and I think it's because they're booleans. Wouldn't it be better if they used 0 and 1?
|
Maybe, but then inversion (order = not order) would have to be rewritten (order = 1 - order), not only in ZO code, but also in add-ons. Better just fix the bad uses
