View Single Post
03/11/19, 08:14 AM   #11
merlight
AddOn Author - Click to view addons
Join Date: Jul 2014
Posts: 671
Originally Posted by sirinsidiator View Post
I've made an update for Medic which includes a fix for this problem and uploaded it to dropbox (as it is untested). Let me know if it works and I'll upload it to ESOUI later.
Thanks, works for me.


Originally Posted by Baertram View Post
Unofficial analysis from a developer:


There needs to be a fix incoming from ZOs or maybe any fix from addon devs which will unofficially fix the rokens tuff until ZOs will do
I'd like to add that -- besides the broken call to class instead of instance -- the initialization of that instance is kinda evil; and extremely weird, as it doesn't follow the same pattern that dozens of singletons in ZOS code do.

This is wrong (although it's syntactically correct and does exactly what the author wanted):
Lua Code:
  1. function ZO_SkillsDataManager:New(...)
  2.     SKILLS_DATA_MANAGER = ZO_CallbackObject.New(self)
  3.     SKILLS_DATA_MANAGER:Initialize(...)
  4.     return SKILLS_DATA_MANAGER
  5. end
  6.  
  7. ZO_SkillsDataManager:New()


edit: I was curious whether this was the only occurrence where Class:New() is called and the return value discarded. Nope:
Warning: Spoiler

Last edited by merlight : 03/11/19 at 08:30 AM.
  Reply With Quote