[circonian]

I have found 2 more bugs in the searchBox game code and added them to this post.

BUG 1
If you unequip an item by double clicking on it in the character window (or right clicking and selected unequip) everything works fine.

But when you double click an item to equip it & you already have an item equiped in that equip slot, they just swap slots and the searchData does not get updated and still has the cached searchData for the old item.

Steps to Reproduce:

1. Log in or /reloadui to clear searchData.cache for all slots
2. Do a search in the search box so that it will cache search data in to each slot.searchData.cache
3. Double click on an item to equip it AND you must already have an item equipped in that slot so they swap slots !!
4. The item that was unequipped was placed in the inventory slot of the item you equipped & it still contains the old searchData.cache.
5. Try to search for the name of the item you EQUIPPED (yes its not in your inventory you equipped it, but) it will display the item that was UNEQUIPPED in the search results...because it has the searchData.cache for the old item.

Example:

• I "HAD" the "Ironthread Jerkin" equipped
• I double clicked on the "Robe of the Magic Furnace" (now it is equipped)
• Then I /zgoo'd the row control for the "Ironthread Jerkin" that got unequipped.
• We can see the slot data shows the "Ironthread Jerkin", but the searchData still has the cached data for the "Robe of the Magic Furnace"
• When I search for "Robe of the Magic Furnace" the "Ironthread Jerkin" appears

Fix:
It looks like you need to clear the searchData.cache & set searchData.cached to false when the slots are updated with a different item, something like:

function ZO_SharedInventoryManager:CreateOrUpdateSlotData(existingSlotData, bagId, slotIndex, isNewItem)
    ...
    if not wasSameItemInSlotBefore then
        slot.itemType = GetItemType(bagId, slotIndex)
        slot.uniqueId = GetItemUniqueId(bagId, slotIndex)
        
        --------------------------------------
        -- Add these to clear the old cache --
        --------------------------------------
        local searchData = slot.searchData
        
        if searchData.cached then
            searchData.cache = nil
            searchData.cached = false
        end
        --------------------------------------
        --------------------------------------
    end
    
    ...
end

BUG 2
I'm not sure when this broke, but the search box does NOT work in the guild bank.

The virtual control that is inherited by all inventory search boxes comes from this control:

<EditBox name="ZO_InventorySearchBox" font="ZoFontWinT1" inherits="ZO_DefaultEdit ZO_EditDefaultText" virtual="true">
   ...
    <OnTextChanged>
        ZO_EditDefaultText_OnTextChanged(self)
        ZO_PlayerInventory_OnSearchTextChanged(self)
    </OnTextChanged>
    ...

which calls:

ZO_PlayerInventory_OnSearchTextChanged(self)

But it only updates the backpack or bank.

function ZO_PlayerInventory_OnSearchTextChanged(editBox)
    if(editBox == ZO_PlayerInventorySearchBox) then
        PlayerInventory:UpdateList(PlayerInventory.selectedTabType)
    else
        PlayerInventory:UpdateList(INVENTORY_BANK)
    end
end

Fix: It should be

function ZO_PlayerInventory_OnSearchTextChanged(editBox)
    if(editBox == ZO_PlayerInventorySearchBox) then
        PlayerInventory:UpdateList(PlayerInventory.selectedTabType)
    elseif (editBox == ZO_PlayerBankSearchBox) then
        PlayerInventory:UpdateList(INVENTORY_BANK)
    else
        PlayerInventory:UpdateList(INVENTORY_GUILD_BANK)
    end
end

BUG 3
In inventory.lua, when the "guildbank" scene is registered for the "StateChange" callback it Ends the search for the wrong searchBox. Which means the searchBox for the guild bank does not get cleared properly.

local guildBankScene = ZO_InteractScene:New("guildBank", SCENE_MANAGER, GUILD_BANKING_INTERACTION)
guildBankScene:RegisterCallback("StateChange",  function(oldState, newState)
    if(newState == SCENE_SHOWING) then
        self:RefreshMoney(GetCurrentMoney())
        self:RefreshAlliancePoints(GetAlliancePoints())
        guildBankFragmentBar:SelectFragment(SI_BANK_WITHDRAW)
        ZO_SharedInventory_SelectAccessibleGuildBank(self.lastSuccessfulGuildBankId)
    elseif(newState == SCENE_HIDDEN) then
        guildBankFragmentBar:Clear()
        ZO_InventorySlot_RemoveMouseOverKeybinds()
        
        --============================================================--
        -- This line is incorrect. 
        --ZO_PlayerInventory_EndSearch(ZO_PlayerBankSearchBox)
        -- It should be:
        ZO_PlayerInventory_EndSearch(ZO_GuildBankSearchBox)
        --============================================================--
    end
end)

For anyone interested I have added a fix for the two new bugs I found to my SearchBox Bug Fix addon, you can find it here: SearchBox Bug Fix V3.0