[Xrystal]

Hmm,

Still not working for me ..

1. Made sure ZO_WorldMap functions used _G[pinType]
2. Made sure pinType was prefixed with something to make it unique
3. Draw Callback function now uses pinManager parameter and cycles through the pinData table and calls pinManager:CreatePin with the data it holds, and removes the RefreshCustomPins function so it doesn't get into that loop ( yes it has happened before, had to crash out a few times ).
4. Set Resize Callback function to nil for the time being
5. Pin Layout table now just has texture, level and size values
6. Added tooltip value to tag/key table to use in the tooltip part of the AddCustomPin function.

Obviously something else is missing in my code somewhere or in the wrong place.

Don't think I missed anything, and did find a few bits of code with the wrong name that clearly isn't being used at present and didn't pick up on it. Here's the updated code with the above changes, minus the code that has been commented out. From your explanation I thought these changes would resolve it but there must be something else. I have tried both MapName and GetUnitZone functions as they sometimes return different values, just in case that was the reason.

My understanding of the functionality is as follows:

1. Subclass an appropriate object ( I have tried both ZO_WorldMapPins and ZO_Object )
2. New the subclassed variable into the usable variable
3. Initialise the pin types including a callback function,texture,tooltip etc and a call to the customised AddCustomPin function to add your data via ZO_WorldMap_AddCustomPin
4. Callback function to cycle through the pin data and create the individual pins at the stored location using the pin manager passed to the function whenever the map is redrawn
5. While still in the initialisation stage initialise the equivalent filters use your customised SetCustomPinEnabled and RefreshCustomPins functions to enable and refresh your pins using the ZO_WorldMap_RefreshCustomPinsOfType(_G[pinType]) and ZO_WorldMap_SetCustomPinEnabled(_G[pinType]) functions.
6. Not got as far as seeing how the RemovePins function works to know where that fits in.

Did I miss anything out ? I hate it when something so apparently simple causes me no end of problems. Especially when I took this week off in the hopes of getting this fixed and catching up with the levelling by actually playing.

-- Values used often so created variables for them
local addonName = "XrysMapPins"
local addonVersion = "1.0.0"
local addonPrefix = "XMP"
 
-- References to System and Manager objects
local ChatMsg = CHAT_SYSTEM
local EventMgr = EVENT_MANAGER
local WindowMgr = WINDOW_MANAGER
 
--------------------------------------------------------------
local TradeSkillNames = {}
local TradeSkills = {}
 
local function InitTradeSkillInfo()
    local skillType,skillIndex = GetCraftingSkillLineIndices(CRAFTING_TYPE_ALCHEMY)
    local skillName,skillRank  = GetSkillLineInfo(skillType, skillIndex) 
    local abilityName,abilityIcon = GetSkillAbilityInfo(skillType, skillIndex, 1) 
    TradeSkills[CRAFTING_TYPE_ALCHEMY] = { Name = skillName, Icon = abilityIcon }
  
    skillType,skillIndex = GetCraftingSkillLineIndices(CRAFTING_TYPE_BLACKSMITHING)
    skillName,skillRank  = GetSkillLineInfo(skillType, skillIndex) 
    abilityName,abilityIcon = GetSkillAbilityInfo(skillType, skillIndex, 1) 
    TradeSkills[CRAFTING_TYPE_BLACKSMITHING] =  { Name = skillName, Icon = abilityIcon }
 
 
    skillType,skillIndex = GetCraftingSkillLineIndices(CRAFTING_TYPE_CLOTHIER)
    skillName,skillRank  = GetSkillLineInfo(skillType, skillIndex) 
    abilityName,abilityIcon = GetSkillAbilityInfo(skillType, skillIndex, 1) 
    TradeSkills[CRAFTING_TYPE_CLOTHIER] =   { Name = skillName, Icon = abilityIcon }
 
    skillType,skillIndex = GetCraftingSkillLineIndices(CRAFTING_TYPE_ENCHANTING)
    skillName,skillRank  = GetSkillLineInfo(skillType, skillIndex) 
    abilityName,abilityIcon = GetSkillAbilityInfo(skillType, skillIndex, 1) 
    TradeSkills[CRAFTING_TYPE_ENCHANTING] =     { Name = skillName, Icon = abilityIcon }
  
    skillType,skillIndex = GetCraftingSkillLineIndices(CRAFTING_TYPE_PROVISIONING)
    skillName,skillRank  = GetSkillLineInfo(skillType, skillIndex) 
    abilityName,abilityIcon = GetSkillAbilityInfo(skillType, skillIndex, 1) 
    TradeSkills[CRAFTING_TYPE_PROVISIONING] =   { Name = skillName, Icon = abilityIcon }
    
    skillType,skillIndex = GetCraftingSkillLineIndices(CRAFTING_TYPE_WOODWORKING)
    skillName,skillRank  = GetSkillLineInfo(skillType, skillIndex) 
    abilityName,abilityIcon = GetSkillAbilityInfo(skillType, skillIndex, 1) 
    TradeSkills[CRAFTING_TYPE_WOODWORKING] =    { Name = skillName, Icon = abilityIcon }
 
    for i,v in ipairs(TradeSkills) do
        table.insert(TradeSkillNames,v.Name)
    end
end
--------------------------------------------------------------
 
--------------------------------------------------------------
local CustomMapPins = ZO_WorldMapPins:Subclass()
 
function CustomMapPins:New(...)
    local pinObject = ZO_WorldMapPins.New(self)
    pinObject:Initialise(...)
    return pinObject
end
 
function CustomMapPins:Initialise(...)
 
    --Default Values
    self.Type = addonPrefix.."_Unspecified"
    self.Name = "Unspecified"
    self.TradeSkill = CRAFTING_TYPE_INVALID
    self.ItemType = ITEMTYPE_NONE
    self.Icon = "EsoUI/Art/MapPins/hostile_pin.dds"
    self.Size = 16
    self.Level = 20
 
    -- Useful data
    self.Info = {}
 
    -- Pin Data
    self.Data = {}
 
    -- Layout Data
    self.Layout = { level = self.Level, texture = self.Icon, size = self.Size } 
end
 
function CustomMapPins:List(...)
    local pinType, pinZone = ...
    ChatMsg:AddMessage("Pin Data currently available for type "..pinType.." in zone "..pinZone)
    if not self.Data[pinType] then return end
    if not self.Data[pinType][pinZone] then return end
    for i,v in pairs(self.Data[pinType][pinZone]) do
        ChatMsg:AddMessage(v.zone.." "..tostring(v.x)..", "..tostring(v.y))
    end
end
 
function CustomMapPins:CreatePin(...)
    local pinType, pinKey, pinZone, pinX, pinY, pinRadius = ...
    self.Data[pinType] = self.Data[pinType] or {}
    self.Data[pinType][pinZone] = self.Data[pinType][pinZone] or {}
    table.insert(self.Data[pinType][pinZone],{ 
        ["key"] = pinKey, 
        ["zone"] = pinZone, 
        ["x"] = pinX, 
        ["y"] = pinY, 
        ["radius"] = pinRadius 
    })
end
 
 
function CustomMapPins:AddCustomPin(...)
    local pinType, drawCallback, resizeCallback, pinLayout, pinTooltipCreator, pinID = ...
 
    self.Info[pinID] = self.Info[pinID] or {}
    table.insert(self.Info[pinID], {
        ["Type"] = pinType,
        ["Name"] = TradeSkills[pinID].Name,
        ["Icon"] = TradeSkills[pinID].Icon
        })
 
    ZO_WorldMap_AddCustomPin(pinType, drawCallback, resizeCallback, pinLayout, pinTooltipCreator)
 
    WORLD_MAP_FILTERS.pvePanel:AddPinFilterCheckBox(5, function() self:RefreshCustomPins(pinType) end)      
    WORLD_MAP_FILTERS.pvePanel.lastControl.label:SetText(GetString("SI_MAPFILTER",5).." ("..TradeSkills[pinID].Name..")")
    WORLD_MAP_FILTERS.pvePanel.lastControl:SetState(1)
    self:SetCustomPinEnabled( pinType, true )
    self:RefreshCustomPins(pinType)
end
 
function CustomMapPins:RemovePins(...)
    local pinType = ...
    self.Data[pinType] = {}
    self:RefreshCustomPins(pinType)
end
 
function CustomMapPins:RefreshCustomPins(pinType)
    ZO_WorldMap_RefreshCustomPinsOfType(_G[pinType])
end
 
function CustomMapPins:SetCustomPinEnabled(pinType)
    ZO_WorldMap_SetCustomPinEnabled(_G[pinType])
end
 
function CustomMapPins:IsCustomPinEnabled(pinType)
    return ZO_WorldMap_IsCustomPinEnabled(_G[pinType])
end
 
function CustomMapPins:IsPinGroupShown(pinType)
    return ZO_WorldMap_IsPinGroupShown(_G[pinType]) 
end
 
local XMPins = CustomMapPins:New()
--------------------------------------------------------------
 
-----------------------------------------------------------------------
local function CreateTopLevelWindow(name)
    local tlw = WindowMgr:CreateTopLevelWindow(name)
    tlw:SetMovable(true)
    tlw:SetMouseEnabled(true)
    tlw:SetDimensions(200,100)
    tlw:SetAnchor(CENTER)
 
    tlw.BackGround = WindowMgr:CreateControlFromVirtual(nil,tlw,"ZO_DefaultBackdrop")
    tlw.BackGround:SetAnchorFill(tlw)
    tlw.BackGround:SetAlpha(0.8)
    tlw.BackGround:SetHidden(false)
 
    return tlw
end
 
local function CreateDropDown(name,parent,data,selected,callback)
    local combo = WindowMgr:CreateControlFromVirtual(parent:GetName()..name,parent,"ZO_StatsDropdownRow")
    combo:SetAnchor(CENTER)
    combo:SetResizeToFitDescendents(true)
 
    combo.selected = combo.name
 
    combo.dropdown = combo.dropdown
    combo.dropdown:SetFont("ZoFontBookScroll")
    if selected then combo.dropdown:SetSelectedItem(selected) end
 
    combo.dropdown.SetSelectedIndex = function(self,value)
        self.SelectedIndex = nil
        for i = 1,#data do
            if data[i] == value then
                self.SelectedIndex = i
                break
            end
        end
    end
 
    combo.dropdown.GetSelectedIndex = function(self)
        return self.SelectedIndex
    end
 
    combo.dropdown.OnSelect = function(self,value)
        self:SetSelectedItem(value)
        self:SetSelectedIndex(value)
        if callback then callback(value) end
    end
 
    for i = 1,#data do
        local entry = combo.dropdown:CreateItemEntry(data[i],combo.dropdown.OnSelect)
        combo.dropdown:AddItem(entry)
    end
 
    combo.GetSelectedInfo = function(self)
        return self.dropdown:GetSelectedItem(),self.dropdown:GetSelectedIndex()
    end
 
    combo:SetHidden(false)
    return combo
end
 
local function CreateButton(name,parent,text,callback)
    local button = WindowMgr:CreateControlFromVirtual(parent:GetName()..name,parent,"ZO_DefaultButton")
    button:SetAnchor(BOTTOMLEFT)
    button:SetHandler("OnClicked",
        function(self) 
            if callback then callback() end
        end)
    button:SetHidden(false)
    return button
end
 
local function InitUI()
    local testTLW = CreateTopLevelWindow("XrysMapPins_TLW")
    testTLW:SetDimensions(200,400)
 
    local MapPinCombo = CreateDropDown("MapPinTypes",testTLW,TradeSkillNames,nil,function(value) end)
    MapPinCombo:SetDimensions(150,50)
    MapPinCombo:SetAnchor(TOP)
 
    local PinTexture = WindowMgr:CreateControl(nil,testTLW,CT_TEXTURE)
    PinTexture:SetDimensions(200,200)
    PinTexture:SetAnchor(CENTER)
    PinTexture:SetHidden(false)
 
    local PutMapPinButton = CreateButton("MapPinButton",testTLW,nil, function(value) 
        local pinType,pinID = MapPinCombo:GetSelectedInfo() 
        pinType = addonPrefix.."_"..pinType
        PinTexture:SetTexture(TradeSkills[pinID].Icon)
        SetMapToPlayerLocation()
        local pinZone = GetMapName()
        local pinX,pinY,pinHeading = GetMapPlayerPosition("player")     
        local pinTooltip = TradeSkills[pinID].Name
        local pinTag = { ["id"] = pinID, ["type"] = pinType, ["zone"] = pinZone, ["x"] = pinX, ["y"] = pinY, ["tooltip"] = pinTooltip } 
        XMPins:CreatePin(pinType, pinTag, pinZone, pinX, pinY, nil)
        XMPins:RefreshCustomPins(pinType)
        XMPins:List(pinType,pinZone)
    end )
    PutMapPinButton:SetAnchor(BOTTOM)
    PutMapPinButton:SetDimensions(50,50)
end
------------------------------------------------------------------------
 
local function InitPinTypes()
    for i,v in ipairs(TradeSkills) do
        local pinType = addonPrefix.."_"..v.Name 
        local pinID = i
        local drawCallback = function(pinManager) 
            SetMapToPlayerLocation()
            local pinZone = GetMapName()
            local harvestData = self.Data[pinType][pinZone]
            for i,v in pairs(harvestData) do
                pinManager:CreatePin(_G[pinType], v.key, v.zone, v.x, v.y, v.radius)
            end
        end
        local resizeCallback = nil --function(width,height) XMPins:RefreshCustomPins(pinType) end       
        local pinLayoutData = {}
        for i,v in pairs(XMPins.Layout) do
            pinLayoutData[i] = v
        end
        pinLayoutData.texture = TradeSkills[pinID].Icon
        local pinTooltipCreator = { creator = function(pin) InformationTooltip:AddLine(pin.key.tooltip) end, tooltip = InformationTooltip }
        XMPins:AddCustomPin(pinType,drawCallback,resizeCallback,pinLayoutData,pinTooltipCreator,pinID) 
    end 
end
 
local function PlayerActivated(eventID)
    EventMgr:UnregisterForEvent(addonName,eventID)
    ChatMsg:AddMessage(string.format("%s %s Loaded",addonName,addonVersion))
    InitTradeSkillInfo()
    InitUI()
    InitPinTypes()
end
 
-- Our Addon is loaded so we can start work
local function AddOnLoaded(eventID,addon)
    if addon ~= addonName then return end
    EventMgr:UnregisterForEvent(addonName,eventID)
    EventMgr:RegisterForEvent( addonName ,EVENT_PLAYER_ACTIVATED , PlayerActivated )
end
 
-- Track addons loading
EventMgr:RegisterForEvent( addonName ,EVENT_ADD_ON_LOADED , AddOnLoaded )