Thread: 2.3 Update
View Single Post
02/13/16, 03:16 PM   #39
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 1,578
The function ZO_WorldMap_GetMapTitle is leaking the variable title into global namespace (worldmap.lua:5185).
Lua Code:
  1. function ZO_WorldMap_GetMapTitle()
  2.     local titleText
  3.     local mapName = GetMapName()
  4.     local dungeonDifficulty = ZO_WorldMap_GetMapDungeonDifficulty()
  5.     if dungeonDifficulty == DUNGEON_DIFFICULTY_NONE then
  6.         title = zo_strformat(SI_WINDOW_TITLE_WORLD_MAP, mapName)
  7.     else
  8.         title = zo_strformat(SI_WINDOW_TITLE_WORLD_MAP_WITH_DUNGEON_DIFFICULTY, mapName, GetString("SI_DUNGEONDIFFICULTY", dungeonDifficulty))
  9.     end
  10.     return title
  11. end
Should have been titleText instead.
  Reply With Quote