View Single Post
05/15/17, 04:38 PM   #13
Kyoma
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 125
Originally Posted by Letho View Post
Yes, that is a problem. I tested it shortly after the release of homestead and as far as I remember unitSourceId is ALWAYS void, even if the player is the source, be it inside CYRO or outside, be it in pve or pvp.
I see what you mean though and totally agree: source and target information should be included in ALL appropriate events - I would go further again and request another field: the globald unit id, sending the unique ressource identifier that the native code uses for each instance of an object. (*dreaming of a good server architecture to withstand the pressure* lol)


EVENT_EFFECT_CHANGED does not provide enough information for calculating dps. They could have blanked damage/hit notifications for EVENT_COMBAT_EVENT, but events related to buffs/debuffs gained, fading, refreshed provided by either EFFECT_CHANGED or COMBAT_EVENT do not harm anybody.

I am just saying I dont understand why they don't use better filters for unwanted actions or addons resulting from events...
Originally Posted by ZOS_ChipHilseberg View Post
Looking at the current code I'm seeing:

Targets Player/Pet or from Player/Pet

Full information.

Doesn't target Player/Pet and isn't from Player/Pet

You get limited information. This hides the ability name, icon, damage type, source name, source unit id, source type, target name, target type, and...not target unit id apparently...maybe that should be gone too. The exception to this case is in Cyrodiil and BGs where you get limited information about DIED, DIED_XP, and KILLING_BLOW results ONLY. This is because the mere presence of a COMBAT_EVENT can be used to detect the presence of other players in the area.
Please dont remove targetUnitId outside Cyro/PvP!
  Reply With Quote